| *** Sphericus has joined #openstack-powervm | 00:41 | |
| Sphericus | Hi | 00:42 |
|---|---|---|
| *** kjw3 has joined #openstack-powervm | 00:48 | |
| *** kjw3 has quit IRC | 01:05 | |
| *** esberglu has quit IRC | 01:07 | |
| *** esberglu has joined #openstack-powervm | 01:10 | |
| *** esberglu has quit IRC | 01:10 | |
| *** seroyer has joined #openstack-powervm | 01:56 | |
| *** thorst has quit IRC | 01:58 | |
| *** seroyer has quit IRC | 02:13 | |
| *** thorst has joined #openstack-powervm | 02:21 | |
| *** thorst has quit IRC | 02:23 | |
| *** thorst has joined #openstack-powervm | 03:24 | |
| *** thorst has quit IRC | 03:28 | |
| *** thorst has joined #openstack-powervm | 04:00 | |
| *** thorst has quit IRC | 04:03 | |
| *** thorst has joined #openstack-powervm | 05:04 | |
| *** thorst has quit IRC | 05:19 | |
| *** edmondsw has joined #openstack-powervm | 05:20 | |
| *** edmondsw has quit IRC | 05:25 | |
| *** Sphericus has quit IRC | 05:38 | |
| *** thorst has joined #openstack-powervm | 06:16 | |
| *** thorst has quit IRC | 06:20 | |
| *** thorst has joined #openstack-powervm | 07:17 | |
| *** thorst has quit IRC | 07:21 | |
| *** thorst has joined #openstack-powervm | 08:18 | |
| *** thorst has quit IRC | 08:22 | |
| *** k0da has joined #openstack-powervm | 08:31 | |
| *** edmondsw has joined #openstack-powervm | 08:57 | |
| *** edmondsw has quit IRC | 09:01 | |
| *** openstackgerrit has quit IRC | 09:03 | |
| *** thorst has joined #openstack-powervm | 09:18 | |
| *** thorst has quit IRC | 09:23 | |
| *** thorst has joined #openstack-powervm | 09:40 | |
| *** thorst has quit IRC | 09:44 | |
| *** thorst has joined #openstack-powervm | 10:40 | |
| *** thorst has quit IRC | 10:45 | |
| *** thorst has joined #openstack-powervm | 11:41 | |
| *** thorst has quit IRC | 11:46 | |
| *** smatzek_ has joined #openstack-powervm | 11:55 | |
| *** seroyer has joined #openstack-powervm | 12:26 | |
| *** thorst has joined #openstack-powervm | 12:33 | |
| *** seroyer has quit IRC | 12:46 | |
| *** seroyer has joined #openstack-powervm | 12:47 | |
| *** seroyer has quit IRC | 12:48 | |
| *** jpasqualetto has joined #openstack-powervm | 12:55 | |
| *** seroyer has joined #openstack-powervm | 13:07 | |
| *** efried has quit IRC | 13:08 | |
| *** edmondsw has joined #openstack-powervm | 13:14 | |
| *** kylek3h has quit IRC | 13:15 | |
| *** efried has joined #openstack-powervm | 13:18 | |
| *** dwayne has quit IRC | 13:26 | |
| *** jpasqualetto has quit IRC | 13:29 | |
| *** jpasqualetto has joined #openstack-powervm | 13:46 | |
| *** apearson has joined #openstack-powervm | 13:59 | |
| *** jpasqualetto has quit IRC | 13:59 | |
| *** kylek3h has joined #openstack-powervm | 14:01 | |
| *** tblakes has joined #openstack-powervm | 14:01 | |
| *** esberglu has joined #openstack-powervm | 14:07 | |
| thorst | tfw you quadruple your storage capacity :-) | 14:08 |
| *** mdrabe has joined #openstack-powervm | 14:09 | |
| *** tjakobs has joined #openstack-powervm | 14:10 | |
| *** jpasqualetto has joined #openstack-powervm | 14:12 | |
| *** seroyer has quit IRC | 14:16 | |
| *** tblakes has quit IRC | 14:32 | |
| thorst | esberglu efried: did we figure out anything with the flak8 and CI? In openstack-nova, it looks like it also impacted the intel CI | 14:33 |
| *** smatzek_ has quit IRC | 14:36 | |
| *** mdrabe has quit IRC | 14:38 | |
| *** mdrabe has joined #openstack-powervm | 14:38 | |
| *** seroyer has joined #openstack-powervm | 14:44 | |
| esberglu | thorst: Not that I know of. I'm still trying to get newton/ocata CI working | 14:47 |
| *** tblakes has joined #openstack-powervm | 14:59 | |
| *** smatzek_ has joined #openstack-powervm | 14:59 | |
| *** tjakobs has quit IRC | 15:11 | |
| *** dwayne has joined #openstack-powervm | 15:22 | |
| thorst | what's up with those/ | 15:23 |
| esberglu | setuptools keeps breaking stuff | 15:29 |
| esberglu | https://review.openstack.org/#/c/437880/ | 15:29 |
| esberglu | https://review.openstack.org/#/c/443099/ | 15:29 |
| esberglu | It will be fixed once those 2 get in | 15:30 |
| thorst | ugh, are you patching into the CI then to overcome? | 15:30 |
| *** tjakobs has joined #openstack-powervm | 15:30 | |
| thorst | efried: any reviews you want me to prioritize today? | 15:33 |
| esberglu | I haven't yet. I can if you want, but it will require an image rebuild, then probably another image rebuild after the changes merge | 15:33 |
| thorst | is there another option? Or if you think they'll merge soon, we could just wait it out. | 15:34 |
| esberglu | I'm hoping they merge soon. Pretty trivial changes, just excluding certain setuptools versions | 15:40 |
| esberglu | There's currently only 1 change out on those branches | 15:42 |
| esberglu | For the *-powervm projects | 15:42 |
| *** mdrabe has quit IRC | 15:43 | |
| esberglu | which is the only thing waiting for the merge will block | 15:43 |
| *** tjakobs has quit IRC | 15:51 | |
| efried | thorst Sorry, not sure why notifications aren't popping up all the time here. I figured out the flake8 thing. Will try to get it resolved today. | 15:52 |
| efried | https://review.openstack.org/#/c/435575/ is what broke us. | 15:52 |
| *** mdrabe has joined #openstack-powervm | 15:52 | |
| efried | thorst Review-wise, it would be good if you could take a first pass at https://review.openstack.org/#/c/443189/ | 15:53 |
| efried | I might want to spend some time trying to figure out how to reduce the LOC count there. | 15:53 |
| efried | I already pared a bunch out by ripping out the base disk adapter. | 15:53 |
| efried | And I still need to add more UT. | 15:53 |
| thorst | k. I'm looking over one from taylor quick then I'll get to that | 15:58 |
| *** gaperez has joined #openstack-powervm | 16:14 | |
| *** gaperez has quit IRC | 16:14 | |
| thorst | efried: damn...that is a large patch | 16:16 |
| *** jpasqualetto has quit IRC | 16:17 | |
| *** k0da has quit IRC | 16:31 | |
| thorst | efried adreznec esberglu: Should we W+1 these? https://review.openstack.org/#/c/439809/ https://review.openstack.org/#/c/439805/ | 16:32 |
| thorst | is there a reason not to? | 16:32 |
| *** jpasqualetto has joined #openstack-powervm | 16:34 | |
| adreznec | thorst: Not that I'm aware of | 16:35 |
| thorst | efried did +2 | 16:35 |
| thorst | so I guess just waiting for esberglu to say it won't make his life awful | 16:35 |
| esberglu | Why would it make my life awful? | 16:36 |
| thorst | don't think it would | 16:36 |
| esberglu | W+1 | 16:36 |
| thorst | but you're battling CI, a world where anything can go wrong :-) | 16:36 |
| esberglu | can and eventually will | 16:37 |
| thorst | adreznec: do we know if the pypowervm version stuff is being worked still? | 16:37 |
| adreznec | thorst: Was going to ping Julio about that later today | 16:38 |
| thorst | alright. | 16:38 |
| *** tjakobs has joined #openstack-powervm | 16:39 | |
| *** openstackgerrit has joined #openstack-powervm | 16:42 | |
| openstackgerrit | Merged openstack/networking-powervm master: Bump to match latest global requirements https://review.openstack.org/439805 | 16:42 |
| openstackgerrit | Merged openstack/ceilometer-powervm master: Bump to match latest global requirements https://review.openstack.org/439809 | 16:45 |
| efried | esberglu Does the CI env have nvls with dual VIOS where each VIOS is on a separate SSP? | 16:55 |
| esberglu | No everything CI is single vios | 16:55 |
| efried | k | 16:55 |
| efried | thorst - The base disk adapter is already not in the SSP change set. | 16:58 |
| efried | So I'm confused about your comment. | 16:59 |
| thorst | efried: I'm saying make two change sets...one with it | 16:59 |
| thorst | can we get half the code into the base disk adapter | 16:59 |
| thorst | or no? | 16:59 |
| efried | Oh, I gotcha. The first change wouldn't do anything. | 16:59 |
| efried | But... not really any savings by doing that. | 17:00 |
| thorst | well, so I think the core team was OK if we said 'here's the disk patch series' | 17:00 |
| thorst | after the third patch, it'll work. | 17:00 |
| efried | Yeah, I understand. | 17:00 |
| thorst | so was trying to figure out a sensible way to decompose into that... | 17:00 |
| efried | Yeah. I'll take a look at it. Try to get it under 500LOC per change set. | 17:00 |
| efried | Though there's really not an awful lot of code in here. A bunch of docstrings/comments. A bunch of UT. | 17:01 |
| *** jpasqualetto has quit IRC | 17:03 | |
| thorst | efried: yep... | 17:07 |
| *** efried has quit IRC | 17:13 | |
| *** jpasqualetto has joined #openstack-powervm | 17:16 | |
| *** efried has joined #openstack-powervm | 17:21 | |
| efried | thorst So I'm gonna rebase all the change sets. | 17:25 |
| efried | I suspect I'm going to need to do that in order to get this flake8 thing resolved. | 17:25 |
| esberglu | Fun | 17:27 |
| efried | thorst adreznec - Any reason I need to bump the pypowervm req in nova/requirements.txt? | 17:29 |
| efried | No functional difference between .4 and .4.1; leaving it as .4 would work with the new g-r because it's >= | 17:30 |
| adreznec | efried: no, I don't think | 17:32 |
| adreznec | so | 17:32 |
| adreznec | they should eventually get the new req from a g-r sync | 17:32 |
| openstackgerrit | Drew Thorstensen (thorst) proposed openstack/nova-powervm master: Switch to qcow handler https://review.openstack.org/443246 | 17:35 |
| thorst | efried adreznec seroyer: ^^ | 17:35 |
| *** kjw3 has joined #openstack-powervm | 17:36 | |
| efried | thorst Hey, btw, mriedem gave me a bit of grief yesterday for our use of TaskFlow. | 17:43 |
| efried | I had been under the impression that it was The OpenStack Way. | 17:43 |
| efried | But when he expressed surprise that we were using it, I went and checked. There's nothing else in the nova project that uses it. | 17:43 |
| efried | So - where did that come from? | 17:44 |
| thorst | from OpenStack was my understanding. There was a desire from various projects around the Atlanta summit (way way back) to use task flow for things...especially when things go wrong | 17:48 |
| thorst | there was a push to use it, but the issue was always "we have so much code, how to go back and reimplment" | 17:48 |
| thorst | and also, when you just have a bug to fix, you don't want to go back and resolve all the things | 17:49 |
| thorst | but since we were writing code from scratch...and we've done this rodeo before...I wanted to use it | 17:49 |
| thorst | and I am so freaking thankful we did. Yeah, it adds a layer, but when sh!t goes wrong...it gets cleaned up right. | 17:49 |
| thorst | we had a lot of arguments way back then about the complexity it added...which is legit...but its really reduced the defects. | 17:51 |
| *** apearson has quit IRC | 17:56 | |
| *** smatzek_ has quit IRC | 17:59 | |
| *** apearson has joined #openstack-powervm | 18:00 | |
| efried | thorst May be worth having that conversation with mriedem. | 18:11 |
| efried | Was he around at the Atlanta summit? | 18:11 |
| efried | Or was he, like, twelve at the time? | 18:11 |
| *** smatzek_ has joined #openstack-powervm | 18:20 | |
| thorst | lol, I don't know if he was there | 18:20 |
| thorst | I'll chat with him | 18:21 |
| thorst | otp with a user though, so I'll ping him when I get off the call | 18:22 |
| openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm master: Add support for file-backed ephemeral disk https://review.openstack.org/437584 | 18:25 |
| *** apearson has quit IRC | 18:32 | |
| *** apearson has joined #openstack-powervm | 18:39 | |
| thorst | efried: if you get a chance...I'd like to push this through today: https://review.openstack.org/#/c/443246/ | 19:36 |
| thorst | removes the need for a patch that the PowerVC team is carrying. | 19:36 |
| *** k0da has joined #openstack-powervm | 19:42 | |
| *** dwayne has quit IRC | 20:02 | |
| *** apearson has quit IRC | 20:26 | |
| *** apearson has joined #openstack-powervm | 20:28 | |
| efried | thorst +2 - but I thought the REST layer was going to switch to this by default? | 20:47 |
| thorst | no, REST was not going to change | 20:47 |
| thorst | openstack was to change | 20:47 |
| adreznec | I was actually just looking at that patch thorst | 20:48 |
| adreznec | Are we intending to basically only support the qcow handler for now and patch in a configopt for other handlers in the future? | 20:49 |
| thorst | adreznec: I'm not sold that we need other handlers in the future...I was operating under assumption that openstack would really only need one type | 20:51 |
| thorst | though, I could be sold that maybe the cinder connector (ex. gpfs.py or nfs.py) should choose which handler to use? | 20:51 |
| adreznec | thorst: is the hope that we could autodetect based on filetype or something? | 20:51 |
| thorst | not really, I guess I just don't want to have to figure it out per type...just seems like excess configuration. | 20:52 |
| thorst | do we need multiple types? | 20:52 |
| adreznec | I mean that works for things like qcow vs raw, but makes things like ceph ephemeral fuzzy | 20:52 |
| adreznec | Depends on where we go I suppose | 20:52 |
| thorst | so this is the qcow handler, not the qcow file type...right? | 20:52 |
| adreznec | Not for just qcow vs raw | 20:52 |
| adreznec | Yes | 20:52 |
| adreznec | But down the road if we want to support other ephemeral types | 20:52 |
| thorst | so maybe we cross that bridge when we get to it? Other connectors needing different types? | 20:53 |
| adreznec | Right | 20:53 |
| thorst | well, and its not just ephemeral...my change is for cinder | 20:53 |
| thorst | tjakobs is for nova ephemeral | 20:53 |
| adreznec | Right sorry, was looking at his patch now and mixed up wording :P | 20:53 |
| thorst | so I don't think its fair to ask the administrator what 'handler' do you want to use | 20:54 |
| adreznec | I think that's fair | 20:54 |
| thorst | I think its fair to say 'are you using gpfs, nfs, or ceph (or whatevs)' | 20:54 |
| thorst | and then pick the handler based off that | 20:54 |
| adreznec | Right | 20:54 |
| thorst | even for tjakobs change...I think maybe we need an enumeration there...even though right now we're just bundling it all as 'fileio' | 20:55 |
| thorst | adreznec: if you look through the cinder volume drivers now...do you see any that shouldn't be qcow2? | 20:55 |
| adreznec | thorst: not for file-backed volumes | 20:57 |
| adreznec | I mean other volume types like iSCSI won't be of course, but they're just block | 20:57 |
| *** dwayne has joined #openstack-powervm | 20:57 | |
| thorst | right...that's completely different | 21:00 |
| thorst | so I think for tjakobs change, I don't think I want 'fileio' to show up as a disk type | 21:00 |
| openstackgerrit | Merged openstack/nova-powervm master: Switch to qcow handler https://review.openstack.org/443246 | 21:00 |
| thorst | I think it should be local_file... | 21:01 |
| thorst | make the option something that an admin can understand. Because fileio indicates 'anything that is a file'...which isn't necessarily true? | 21:01 |
| thorst | what use cases are we targeting for his change set? Local files, NFS? | 21:02 |
| tjakobs | so you want the nova.conf option to be "local_file" instead of "fileio"? | 21:06 |
| tjakobs | I've also only tested the patch on local files | 21:06 |
| adreznec | thorst: do we actually care what the backing storage the files sit on is in that case? | 21:08 |
| adreznec | I mean putting in on some parts would certainly have a performance penalty | 21:08 |
| thorst | adreznec: I thought you said it would/could? :-) | 21:08 |
| adreznec | But if Linux has it mounted as a filesystem you can put stuff on... | 21:09 |
| thorst | so, maybe we name it something to just indicate a standard filesystem | 21:09 |
| adreznec | It would if we're using a specialized handler | 21:09 |
| thorst | maybe just 'filesystem' | 21:09 |
| adreznec | Like Ceph | 21:09 |
| adreznec | That has tighter coupling with the backing devices | 21:09 |
| adreznec | But if we're just slapping a file down and mapping it | 21:10 |
| * adreznec shrugs | 21:10 | |
| adreznec | Should all look the same | 21:10 |
| thorst | so I guess instead of fileio...we go with filesystem? | 21:11 |
| thorst | or just file | 21:11 |
| adreznec | Yeah | 21:11 |
| thorst | tjakobs: your call on which. | 21:11 |
| tjakobs | ok, i'll toss that in the next update I do | 21:12 |
| efried | tjakobs thorst apearson adreznec - Does the FileIO object need to be PUT to the REST server? | 21:15 |
| thorst | the file itself? no. The path to the file | 21:15 |
| efried | So I'm looking at tjakobs change set, and seeing that we're doing all of these ops directly on the file system. I would have thought, for the sake of API consistency, that the REST API should be doing those ops instead, and the community code should be going through that. | 21:16 |
| thorst | hmm...no, I'm not so sure | 21:18 |
| thorst | we've done the whole stream a file from NL to REST before | 21:18 |
| thorst | so there is precedent having things on NL. | 21:18 |
| thorst | cfg drive for instance? | 21:18 |
| thorst | streaming through rest would be a lot of overhead, and I'm not sold its consistent | 21:19 |
| adreznec | yeah efried I was just looking at his changeset too | 21:24 |
| *** apearson has quit IRC | 21:24 | |
| efried | thorst Even when we do the image upload "directly", it's to a path retrieved from the REST API. | 21:25 |
| thorst | yeah, but I think the whole idea of fileio isn't that we stream the file through rest...just that we point rest to it. | 21:26 |
| thorst | we probably should confer with apearson, but I think that's the design intention. | 21:26 |
| adreznec | Calling things like qemu-img directly(ish) through the nova utils is again breaking that model | 21:26 |
| efried | Realistically, we would still be composing that path from CONF.instances_path etc. - but doing that once and then asking the REST API for that path subsequently for ops like the upload. | 21:26 |
| efried | I'm more concerned with stuff like creating, deleting, and resizing the file on the file system. | 21:26 |
| thorst | I guess I'd have the concern if we were talking volumes...but there was a line drawn between volumes and files to me. | 21:28 |
| thorst | where basically you just tell REST the file...and you do whatevs to it (ex. cinder driver can clone it) | 21:28 |
| thorst | I need to relocate to house a little early today | 21:30 |
| thorst | back in a bit | 21:30 |
| *** thorst has quit IRC | 21:30 | |
| *** thorst has joined #openstack-powervm | 21:31 | |
| *** smatzek_ has quit IRC | 21:31 | |
| *** thorst has quit IRC | 21:35 | |
| *** apearson has joined #openstack-powervm | 21:42 | |
| *** thorst has joined #openstack-powervm | 21:50 | |
| *** kjw3 has quit IRC | 22:20 | |
| *** edmondsw has quit IRC | 22:20 | |
| *** edmondsw has joined #openstack-powervm | 22:23 | |
| *** edmondsw has quit IRC | 22:28 | |
| efried | esberglu Seeing quite a lot more in-tree CI failures recently. | 22:29 |
| efried | Do you know what that's about? | 22:29 |
| esberglu | Looking at it right now | 22:29 |
| esberglu | Remember those rebuild server tests that were hitting us before? | 22:29 |
| esberglu | They seemed to stop for a while, but they are hitting us again now | 22:30 |
| efried | yeah | 22:30 |
| efried | Actually right now this is the only one I care about that's gotten a failure: https://review.openstack.org/#/c/391288/ | 22:31 |
| esberglu | There were 3 rebuild tests that were failing. We disabled the rebuild from error because it seemed to just be taking too long | 22:32 |
| esberglu | And then I didn't see the other two (the ones hitting us now) for a while, so I thought they were a side effect from the 1st one | 22:33 |
| efried | thorst adreznec esberglu - Need re-+1s on rebased-and-slightly-updated change sets: https://review.openstack.org/438598 https://review.openstack.org/438729 https://review.openstack.org/391288 | 22:34 |
| *** dwayne has quit IRC | 22:44 | |
| *** tblakes has quit IRC | 22:47 | |
| *** esberglu has quit IRC | 22:51 | |
| *** esberglu has joined #openstack-powervm | 22:52 | |
| *** thorst has quit IRC | 22:54 | |
| *** thorst has joined #openstack-powervm | 22:55 | |
| *** esberglu has quit IRC | 22:56 | |
| *** mdrabe has quit IRC | 22:56 | |
| *** edmondsw has joined #openstack-powervm | 22:57 | |
| *** thorst has quit IRC | 22:59 | |
| *** edmondsw has quit IRC | 23:01 | |
| *** tjakobs has quit IRC | 23:09 | |
| *** kylek3h has quit IRC | 23:11 | |
| *** tblakes has joined #openstack-powervm | 23:12 | |
| *** thorst has joined #openstack-powervm | 23:20 | |
| *** tblakes has quit IRC | 23:24 | |
| *** thorst has quit IRC | 23:24 | |
| *** jpasqualetto has quit IRC | 23:25 | |
| *** seroyer has quit IRC | 23:35 | |
| *** jpasqualetto has joined #openstack-powervm | 23:41 | |
| *** jpasqualetto has quit IRC | 23:42 | |
| *** apearson has quit IRC | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!