| *** mdrabe has quit IRC | 00:29 | |
| *** apearson_ has quit IRC | 00:48 | |
| *** esberglu has joined #openstack-powervm | 01:06 | |
| *** tjakobs has joined #openstack-powervm | 01:07 | |
| *** thorst_ has quit IRC | 01:07 | |
| *** thorst has joined #openstack-powervm | 01:08 | |
| *** tjakobs has quit IRC | 01:12 | |
| *** kylek3h has joined #openstack-powervm | 01:16 | |
| *** thorst has quit IRC | 01:16 | |
| *** seroyer has joined #openstack-powervm | 01:17 | |
| *** kylek3h has quit IRC | 01:34 | |
| *** seroyer has quit IRC | 01:51 | |
| *** thorst has joined #openstack-powervm | 02:14 | |
| *** thorst has quit IRC | 02:22 | |
| *** apearson_ has joined #openstack-powervm | 02:38 | |
| *** esberglu has quit IRC | 02:43 | |
| *** thorst has joined #openstack-powervm | 03:20 | |
| *** thorst has quit IRC | 03:26 | |
| *** seroyer has joined #openstack-powervm | 04:08 | |
| *** thorst has joined #openstack-powervm | 04:24 | |
| *** thorst has quit IRC | 04:31 | |
| *** kotra03 has joined #openstack-powervm | 04:32 | |
| *** seroyer has quit IRC | 04:41 | |
| *** k0da has joined #openstack-powervm | 05:10 | |
| *** thorst has joined #openstack-powervm | 05:30 | |
| *** thorst has quit IRC | 05:37 | |
| *** k0da has quit IRC | 05:55 | |
| *** kairo has joined #openstack-powervm | 06:06 | |
| *** kairo has quit IRC | 06:08 | |
| *** kairo has joined #openstack-powervm | 06:08 | |
| *** thorst has joined #openstack-powervm | 06:34 | |
| *** thorst has quit IRC | 06:42 | |
| *** thorst has joined #openstack-powervm | 07:39 | |
| *** thorst has quit IRC | 07:46 | |
| *** k0da has joined #openstack-powervm | 08:02 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** openstackgerrit has joined #openstack-powervm | 08:04 | |
| *** thorst has joined #openstack-powervm | 08:45 | |
| *** thorst has quit IRC | 08:52 | |
| *** thorst has joined #openstack-powervm | 10:47 | |
| *** thorst has quit IRC | 10:52 | |
| *** thorst has joined #openstack-powervm | 11:04 | |
| *** apearson_ has quit IRC | 12:09 | |
| *** seroyer has joined #openstack-powervm | 12:16 | |
| *** mdrabe has joined #openstack-powervm | 12:40 | |
| *** edmondsw has joined #openstack-powervm | 12:40 | |
| *** kylek3h has joined #openstack-powervm | 12:40 | |
| *** wangqwsh has joined #openstack-powervm | 13:07 | |
| *** wangqwsh has quit IRC | 13:08 | |
| efried1 | thorst, before I go looking, are you familiar with the protocol for an APIImpact tag on a commit message? | 13:24 |
|---|---|---|
| thorst | efried1: nope | 13:24 |
| efried1 | k | 13:24 |
| thorst | does your neutron change have an API Impact? | 13:24 |
| efried1 | Yes | 13:24 |
| efried1 | It would help me a bunch if I understood the API | 13:25 |
| thorst | heh | 13:25 |
| efried1 | Particularly how & where it gets used. | 13:25 |
| efried1 | Cause there juuust might be a way I can use it that wouldn't require changing it. | 13:25 |
| efried1 | Though my efforts yesterday yielded no fruit. | 13:25 |
| efried1 | And, as you said, I'd rather not have to muck with the database. | 13:26 |
| thorst | right. Lets propose it up and see what happens | 13:26 |
| thorst | we can maybe ping mestery to see if he can suggest someone for us to follow up with. | 13:26 |
| efried1 | It's proposed. Got some good conversation with one of the neutron folks yesterday, and got the attention of a core. | 13:26 |
| efried1 | She suggested I put an APIImpact tag in my commit message - hence the opening question. | 13:27 |
| thorst | ahh, gotcha | 13:27 |
| thorst | could probably google for some examples | 13:27 |
| efried1 | swhat I'm doing now. | 13:27 |
| adreznec | efried1: Isn't it literally just putting "APIImpact" in your commit message? | 13:28 |
| adreznec | Like DocImpact? | 13:28 |
| efried1 | adreznec, dunno ;-) | 13:28 |
| efried1 | https://review.openstack.org/#/c/358125/ | 13:29 |
| adreznec | https://review.openstack.org/#/q/status:open+AND+(message:ApiImpact+OR+message:APIImpact),n,z | 13:29 |
| *** tjakobs has joined #openstack-powervm | 13:42 | |
| *** kairo has quit IRC | 13:47 | |
| *** kriskend has joined #openstack-powervm | 13:54 | |
| *** esberglu has joined #openstack-powervm | 14:04 | |
| *** tblakes has joined #openstack-powervm | 14:07 | |
| *** dwayne has quit IRC | 14:19 | |
| *** dwayne has joined #openstack-powervm | 14:24 | |
| *** seroyer has quit IRC | 14:41 | |
| *** tblakes has quit IRC | 14:46 | |
| *** seroyer has joined #openstack-powervm | 14:59 | |
| *** apearson_ has joined #openstack-powervm | 15:02 | |
| *** tblakes has joined #openstack-powervm | 15:07 | |
| *** kotra03 has quit IRC | 15:08 | |
| thorst | devstack has decided to stop doing the ovs remapping it seems... | 15:11 |
| adreznec | thorst: side-effect of neutron lib changes? | 15:13 |
| adreznec | Some new config we're missing? | 15:13 |
| thorst | unsure | 15:13 |
| thorst | just know that my current devstack local.conf's isn't working | 15:13 |
| *** kotra03 has joined #openstack-powervm | 15:49 | |
| *** ibmchas has joined #openstack-powervm | 17:08 | |
| *** ibmchas has quit IRC | 17:13 | |
| *** k0da has quit IRC | 17:25 | |
| *** kotra03 has quit IRC | 17:31 | |
| *** k0da has joined #openstack-powervm | 17:32 | |
| *** k0da has quit IRC | 17:41 | |
| *** ibmchas has joined #openstack-powervm | 17:50 | |
| *** ibmchas has quit IRC | 17:54 | |
| tblakes | thorst: efried1: After talking with mdrabe: it looks like we might not want to remove the resize_ from before the VM name on a failed resize. destroy() is dependent on the VM name having resize_ prepended so it knows not to delete that VM. If we remove resize_ before the name and the destroy API is called immediately afterwards, the VM could be deleted. | 18:07 |
| efried1 | yuh | 18:08 |
| mdrabe | Yea I'm thinkin abandon this guy, leave resize_ prepended name on hypervisor | 18:09 |
| *** ibmchas has joined #openstack-powervm | 18:11 | |
| *** ibmchas has quit IRC | 18:15 | |
| thorst | cool | 18:18 |
| *** tblakes has quit IRC | 18:19 | |
| *** tblakes has joined #openstack-powervm | 18:22 | |
| *** ibmchas has joined #openstack-powervm | 18:32 | |
| *** ibmchas has quit IRC | 18:36 | |
| openstackgerrit | Eric Fried proposed openstack/networking-powervm: Mechanism driver & agent for powervm SR-IOV https://review.openstack.org/343423 | 18:46 |
| openstackgerrit | Eric Fried proposed openstack/networking-powervm: Mechanism driver & agent for powervm SR-IOV https://review.openstack.org/343423 | 18:59 |
| thorst | efried1: looked over that...I'm good with it | 19:03 |
| thorst | ready for W+1? | 19:03 |
| *** ibmchas has joined #openstack-powervm | 19:13 | |
| thorst | adreznec: so heres the devstack failure to create my br-ex | 19:14 |
| thorst | 2016-08-23 19:05:38.942 | +^[[38;5;242mlib/neutron_plugins/services/l3:is_provider_network:365 ^[(B^[[m '[' True == True ']' | 19:14 |
| thorst | 2016-08-23 19:05:38.945 | +^[[38;5;242mlib/neutron_plugins/services/l3:is_provider_network:365 ^[(B^[[m '[' True == False ']' | 19:14 |
| thorst | 2016-08-23 19:05:38.948 | +^[[38;5;242mlib/neutron_plugins/services/l3:is_provider_network:368 ^[(B^[[m return 1 | 19:14 |
| thorst | so uhh...yeah. | 19:14 |
| thorst | riddle me that. | 19:14 |
| *** ibmchas has quit IRC | 19:18 | |
| thorst | I see it...filing a devstack bug. | 19:19 |
| *** svenkat has joined #openstack-powervm | 19:21 | |
| adreznec | Cool | 19:21 |
| adreznec | Sorry, busy dealing with system issues | 19:21 |
| svenkat | efried , thorst: this is about port status staying in build after vnic plug | 19:26 |
| thorst | yeah...so the trick is a call to get_device_details will set status of port to build | 19:29 |
| thorst | took me a while to realize that in the sea code | 19:29 |
| thorst | where are you doing a get_device_details? Maybe a heal_and_optimize path? | 19:29 |
| svenkat | ok… so we should avoid invoking get_device_details | 19:29 |
| svenkat | get_device_details is in the middle of processing incoming port and set its state up | 19:30 |
| svenkat | i think it is to gt mac address. but we can get mac address from port itself | 19:30 |
| svenkat | looking | 19:30 |
| thorst | svenkat: you shouldn't avoid it. You should call it if you have a reason to | 19:30 |
| thorst | but | 19:30 |
| thorst | you need to be aware of the repurcussions of calling it. | 19:30 |
| thorst | it is expected that you set the device up afterwards | 19:31 |
| svenkat | oh ok... | 19:31 |
| svenkat | so i think we can avoid getting mac using get_device_details and instead get it from the incoming port itself. | 19:31 |
| svenkat | and use it to call update_device_up | 19:31 |
| efried1 | svenkat, thorst, I don't think that's the issue. We must be calling get_device_details from somewhere else. Looking... | 19:32 |
| svenkat | ok... | 19:33 |
| efried1 | daaah, nope. | 19:33 |
| efried1 | The only place the sriov_agent is using it is here: | 19:34 |
| efried1 | self.update_device_up(self.get_device_details(port['mac_address'])) | 19:34 |
| *** ibmchas has joined #openstack-powervm | 19:34 | |
| efried1 | I.e. we're doing update_device_up immediately after get_device_details. | 19:34 |
| efried1 | So | 19:34 |
| efried1 | Something else is punting the port back to build state? | 19:34 |
| thorst | efried1: I'm not aware of anything else that puts it into a build state | 19:35 |
| efried1 | Does one of those things run asynchronously or something? | 19:35 |
| efried1 | update_device_up calls across the wire, but that should be getting *started* after the get_device_details is already done, neh? | 19:36 |
| *** ibmchas_ has joined #openstack-powervm | 19:36 | |
| svenkat | looking in update_device_up i agent base, what is ‘device’ in the data returend by get_device_details, is it mac address ? | 19:38 |
| *** ibmchas has quit IRC | 19:38 | |
| efried1 | svenkat, looks like it could be. Let's pdb it and find out? | 19:40 |
| svenkat | actually we are writing it in log… | 19:40 |
| svenkat | looking | 19:40 |
| thorst | its an object | 19:41 |
| thorst | look at sea_agent for usage | 19:41 |
| thorst | the device up should be the 'rpc_device' | 19:41 |
| svenkat | self.plugin_rpc.update_device_up(self.context, device['device'],self.agent_id, cfg.CONF.host) | 19:41 |
| svenkat | is the actual code under the covers.. i am trying to gt eto what is device[‘device’] | 19:41 |
| svenkat | let me look at sea code also | 19:42 |
| efried1 | I can't find anything that's calling get_device_details - and that's the *only* thing that sets the device state to BUILD | 19:43 |
| efried1 | So wtf? | 19:43 |
| thorst | efried1: you're checking agent_base? | 19:44 |
| efried1 | thorst, I checked everywhere. The invocations in agent_base aren't getting hit by the sriov_agent. | 19:45 |
| efried1 | At least, I can't see how they would be. | 19:45 |
| efried1 | Uh, we aren't registering the CNA event handler in the SRIOV agent, are we? I was pretty sure I avoided that. Looking again... | 19:45 |
| efried1 | no, just in the sea_agent. | 19:46 |
| efried1 | And that's the only place, other than the sriov_agent's rpc_loop, that we're calling get_device_details. | 19:47 |
| efried1 | svenkat, sanity check: did you remember to restart the agent after pulling down the patch set with the Queue logic? | 19:49 |
| svenkat | yes.. | 19:49 |
| svenkat | strange, i am not seeing any ‘Sending device up” in agent logs… looking... | 19:53 |
| efried1 | svenkat, do you have the log handler for the agent set to debug? | 19:55 |
| svenkat | yes.. agent logs to /var/log/neutro | 19:55 |
| svenkat | n | 19:55 |
| svenkat | my mistake, i missed a line whhile patching srov_agent… i missed putting port in queue | 19:59 |
| svenkat | let me redo this | 19:59 |
| thorst | efried1: you want to chase a bug? :-) | 19:59 |
| efried1 | svenkat, why are you hand-patching the code? | 20:00 |
| svenkat | it is easier for only few lines… | 20:00 |
| efried1 | Got roped into school runs today, out for 1h. Can slack intermittently. | 20:01 |
| svenkat | sure... | 20:01 |
| svenkat | started a deploy | 20:03 |
| svenkat | i got it this time | 20:04 |
| svenkat | so device[‘device’] is mac address | 20:04 |
| svenkat | so we can avoid making get_device_details call | 20:05 |
| svenkat | we already have mac from incoming port | 20:05 |
| thorst | so I just want to be clear | 20:05 |
| thorst | if your intention is that you're going to 'build the port' | 20:05 |
| thorst | you *should* call get_device_details | 20:05 |
| svenkat | ok.. | 20:05 |
| thorst | that's a perfectly OK (and desired) thing to do | 20:05 |
| svenkat | wait, the port is shwoing active now on neutron.. | 20:06 |
| svenkat | let me wait for few minutes to see if deploy is ok | 20:06 |
| *** k0da has joined #openstack-powervm | 20:09 | |
| svenkat | compute got vif plugged event. but not sure why deploy is still initializing | 20:12 |
| *** edmondsw has quit IRC | 20:13 | |
| *** tjakobs has quit IRC | 20:58 | |
| *** miltonm has quit IRC | 21:23 | |
| *** miltonm has joined #openstack-powervm | 21:29 | |
| *** svenkat has quit IRC | 21:33 | |
| *** thorst has quit IRC | 21:44 | |
| *** thorst has joined #openstack-powervm | 21:47 | |
| *** seroyer has quit IRC | 21:49 | |
| *** thorst has quit IRC | 21:51 | |
| *** apearson_ has quit IRC | 21:57 | |
| *** apearson_ has joined #openstack-powervm | 21:58 | |
| *** k0da has quit IRC | 22:07 | |
| *** tblakes has quit IRC | 22:07 | |
| *** esberglu has quit IRC | 22:29 | |
| *** thorst_ has joined #openstack-powervm | 22:36 | |
| efried1 | thorst_, yt? | 22:37 |
| efried1 | nod, please check launchpad bugs mail when able. | 22:38 |
| *** thorst_ has quit IRC | 22:39 | |
| efried1 | neutron change got shot down by armax | 22:39 |
| *** svenkat has joined #openstack-powervm | 22:44 | |
| *** ibmchas_ has quit IRC | 22:49 | |
| *** thorst_ has joined #openstack-powervm | 23:03 | |
| *** thorst_ has quit IRC | 23:05 | |
| *** thorst_ has joined #openstack-powervm | 23:06 | |
| *** thorst_ has quit IRC | 23:10 | |
| *** svenkat has quit IRC | 23:19 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!