| *** martinkennelly has quit IRC | 01:11 | |
| *** zzzeek has quit IRC | 01:15 | |
| *** zzzeek has joined #openstack-placement | 01:17 | |
| *** cdent has quit IRC | 02:10 | |
| *** martinkennelly has joined #openstack-placement | 08:51 | |
| *** martinkennelly has quit IRC | 08:52 | |
| *** cdent has joined #openstack-placement | 12:07 | |
| *** martinkennelly has joined #openstack-placement | 12:58 | |
| cdent | dansmith, melwitt , lbragstad could some of you hit https://review.opendev.org/c/openstack/placement/+/777174 . It’s breaking gabbi’s CI. Please and thank you. | 13:53 |
|---|---|---|
| lbragstad | cdent did you mean lyarwood? | 13:54 |
| cdent | Not really, you were just a name I recognized in the (increasingly small) list of members of the channel and was doing something of a “someone, anyone, please review!” | 13:55 |
| lbragstad | :) | 13:55 |
| cdent | sean-k-mooney probably a good person to tap too | 13:55 |
| sean-k-mooney | is see may name | 13:57 |
| cdent | simple review request for something you’ll be quite familiar with if you cast your mind back | 13:58 |
| sean-k-mooney | ah bumping os-traits min version | 13:59 |
| sean-k-mooney | and test | 13:59 |
| cdent | If that’s something that’s going to be frequently forgotten I’ll have to take placement out of gabbi’s CI checks, which will make me sad somehow | 14:01 |
| sean-k-mooney | what is actuly failing in that ci. the number of traits | 14:01 |
| sean-k-mooney | because you have a newer version fo os-tarits? | 14:02 |
| sean-k-mooney | i kind of feel like that test should be rewritten to be dynamic based on teh os-traits version install in the test env | 14:03 |
| cdent | my ci checks out placement, sets up its functional tests tox env, installs the new gabbi into it, and then runs the tests. | 14:03 |
| cdent | we chose not do that because wanted to make sure that when someone installed placement they did not accidentally downgrade os-traits and miss out on the feature(s) implied by the addition of the traits | 14:03 |
| cdent | building a canary test was the simplest way to ensure the (necessary) coupling was maintained | 14:04 |
| sean-k-mooney | i see can we do a >= test instead | 14:04 |
| sean-k-mooney | im not sure what is valid within gabbit | 14:04 |
| cdent | efried probably has more of the details in his memory. he’s younger than me and thus a bit more elastic in the brain | 14:05 |
| cdent | you can’t really do a >= in a gabbi test like that (maybe fake it with a regex?) but then it wouldn’t be a canary test | 14:05 |
| cdent | the failure is _supposed_ happen, it is supposed to make people fix things | 14:05 |
| cdent | however | 14:05 |
| sean-k-mooney | cdent: ya im just trying to think is there a way to make this fail on the upstrema ci | 14:05 |
| cdent | it does | 14:05 |
| cdent | the issue here is that there haven’t been changed to placement itself since the new os-traits release | 14:06 |
| sean-k-mooney | oh i see | 14:06 |
| cdent | back in the day there used to be frequent enough changes for the canary to sing and be heard regularly | 14:06 |
| cdent | but now not so much | 14:06 |
| cdent | so it is only coincidence that gabbi caught it first | 14:06 |
| sean-k-mooney | yes got it when we do an os-traits release we need to update the placment test to reflect that | 14:07 |
| cdent | (gabbi also doesn’t see many changes these days, but I had a need...) | 14:07 |
| cdent | (thanks dansmith !) | 14:07 |
| * dansmith nods | 14:07 | |
| sean-k-mooney | cdent: we could maybe add a periodic job and review it in the nova team meeting | 14:08 |
| sean-k-mooney | that would catch the failure within 24 hours | 14:08 |
| sean-k-mooney | or well realsitical during the next team meeting | 14:08 |
| cdent | whatever you like, I’m not that worried about it, just hapened to notice and thought I better do my one good deed of the year | 14:09 |
| * cdent takes the rest of the year off | 14:09 | |
| sean-k-mooney | ya no we did cover the os-traits and other placment topics as part of the release checkin but ill try to keep in mind we need to do this too every time we do an os-triats release | 14:10 |
| sean-k-mooney | presumably we may have a similar test for resouce classes | 14:10 |
| cdent | yes | 14:11 |
| sean-k-mooney | thanks cdent for highlight this and well fixing it :) | 14:12 |
| * cdent bows | 14:12 | |
| cdent | all okay in the world otherwise, considering? | 14:14 |
| sean-k-mooney | in terms of placment i belive so | 14:21 |
| cdent | oh, I meant you, life, etc | 14:22 |
| sean-k-mooney | yes | 14:22 |
| sean-k-mooney | i bought a house about a year ago | 14:22 |
| sean-k-mooney | its working out well for my mental health to have the extra space | 14:22 |
| sean-k-mooney | espcially given the last year | 14:22 |
| sean-k-mooney | how about you | 14:23 |
| cdent | all things considered, not bad | 14:23 |
| sean-k-mooney | im a pritty introverted person most of the time so i think im less affected then some. espically since i work form home anyway | 14:23 |
| sean-k-mooney | part of me misses the in person meetups we had though i dont nessisarly miss the travel | 14:24 |
| sean-k-mooney | the localtion are generally nice but im sure the planet is breath a littel eaiser for the global reduciton in air travel | 14:25 |
| sean-k-mooney | cdent: what ocupies your time these days? | 14:26 |
| cdent | i guess one would say “apis for radio area network telemetry” | 14:27 |
| sean-k-mooney | interesting both ran and telemery are areas i only have a highlevel understanding of | 14:29 |
| sean-k-mooney | so i cant say im familar with what that invovles. | 14:30 |
| sean-k-mooney | are you enjoing it? | 14:30 |
| cdent | the actual meaning of the data is pretty much a black box to me, I just need to assemble it in a useful and relatively speedy fashion | 14:30 |
| cdent | some aspects are very interesting, and I’ve learned quite a bit, but it’s not like a vocation or anything | 14:31 |
| sean-k-mooney | ya well without good telemety its hard to do monitoring well and with the amount of stuff that depens on radio these days for internet access its an impoarnt part to get right even if its not the sexiest part it still need to be done by someone and done right | 14:35 |
| *** cdent has quit IRC | 20:06 | |
| *** zzzeek has quit IRC | 20:34 | |
| *** zzzeek has joined #openstack-placement | 20:34 | |
| *** zzzeek has quit IRC | 21:26 | |
| *** zzzeek has joined #openstack-placement | 21:28 | |
| *** zzzeek has quit IRC | 21:49 | |
| *** zzzeek has joined #openstack-placement | 21:53 | |
| openstackgerrit | Merged openstack/placement master: Update traits in tests and requirements https://review.opendev.org/c/openstack/placement/+/777174 | 22:22 |
| *** zzzeek has quit IRC | 23:14 | |
| *** zzzeek has joined #openstack-placement | 23:15 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!