| *** tetsuro has joined #openstack-placement | 00:32 | |
| *** tetsuro has quit IRC | 00:57 | |
| *** tetsuro has joined #openstack-placement | 01:02 | |
| *** tetsuro has quit IRC | 01:28 | |
| *** ykarel|away has joined #openstack-placement | 02:44 | |
| *** ykarel|away has quit IRC | 02:56 | |
| *** tetsuro has joined #openstack-placement | 02:58 | |
| *** ykarel|away has joined #openstack-placement | 03:02 | |
| *** ykarel|away has quit IRC | 03:16 | |
| *** tetsuro has quit IRC | 03:29 | |
| *** ykarel|away has joined #openstack-placement | 03:35 | |
| *** ykarel|away has quit IRC | 03:42 | |
| *** ykarel|away has joined #openstack-placement | 03:50 | |
| *** tetsuro has joined #openstack-placement | 04:03 | |
| *** ykarel|away has quit IRC | 04:32 | |
| *** ykarel|away has joined #openstack-placement | 05:02 | |
| *** ykarel|away is now known as ykarel | 05:05 | |
| *** tetsuro has quit IRC | 05:30 | |
| *** takashin has quit IRC | 05:47 | |
| *** ykarel_ has joined #openstack-placement | 06:18 | |
| *** ykarel has quit IRC | 06:21 | |
| *** tetsuro has joined #openstack-placement | 06:24 | |
| *** ykarel_ is now known as ykarel|meeting | 07:00 | |
| *** tssurya has joined #openstack-placement | 07:08 | |
| *** takashin has joined #openstack-placement | 07:18 | |
| *** helenafm has joined #openstack-placement | 07:48 | |
| gibi | Thank you for submitting a speaking proposal for the Open Infrastructure Summit in Shanghai. | 07:49 |
|---|---|---|
| gibi | bah, wrong windos | 07:50 |
| gibi | but, yeah, I got a reason to get approval to travell to Shanghai | 07:51 |
| *** ykarel has joined #openstack-placement | 08:02 | |
| *** ykarel|meeting has quit IRC | 08:04 | |
| *** ykarel is now known as ykarel|lunch | 08:06 | |
| *** e0ne has joined #openstack-placement | 08:18 | |
| *** cdent has joined #openstack-placement | 08:23 | |
| *** takashin has left #openstack-placement | 08:30 | |
| cdent | gibi or stephenfin : could one of you kick this in because I made it so tetsuro can't: https://review.opendev.org/673505 . please and thank you. | 08:34 |
| *** tetsuro has quit IRC | 08:35 | |
| *** tetsuro has joined #openstack-placement | 08:36 | |
| gibi | cdent: on it | 08:41 |
| cdent | thanks | 08:41 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Trivial: Remove duplicate usage of db context https://review.opendev.org/675060 | 08:49 |
| *** ykarel|lunch is now known as ykarel | 09:02 | |
| *** tetsuro has quit IRC | 09:19 | |
| openstackgerrit | Merged openstack/placement master: Add RequestWideSearchContext.summaries_by_id https://review.opendev.org/674254 | 09:45 |
| openstackgerrit | Merged openstack/placement master: Further optimize _build_provider_summaries https://review.opendev.org/674349 | 09:45 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Clean up the extend_usages_by_provider_tree method https://review.opendev.org/675074 | 09:55 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Remove double join in provider_ids_from_rp_ids https://review.opendev.org/674017 | 10:26 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Improve docs and comments for provider_ids_from_rp_ids https://review.opendev.org/675082 | 10:26 |
| *** spatel has joined #openstack-placement | 10:27 | |
| *** helenafm has quit IRC | 10:29 | |
| *** spatel has quit IRC | 10:31 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Move provider_ids_from_rp_ids to allocation_candidate https://review.opendev.org/675084 | 10:34 |
| cdent | efried: that ^ is an additional followup to the remove double join, not sure if it is the right thing or not, but it struck me while writing the doc followup you asked for | 10:34 |
| *** sean-k-mooney has quit IRC | 10:52 | |
| *** sean-k-mooney has joined #openstack-placement | 11:09 | |
| *** helenafm has joined #openstack-placement | 12:45 | |
| gibi | cdent: I have a quick question in https://review.opendev.org/#/c/675082/1/placement/objects/allocation_candidate.py@519 | 13:00 |
| * cdent looks | 13:00 | |
| gibi | cdent: I guess I found my answer | 13:01 |
| gibi | cdent: in the commit message of https://review.opendev.org/#/c/674017/5 | 13:01 |
| cdent | yeah, the comment around line 472 is supposed to convey that. Perahps it not doing a good enough job? | 13:02 |
| cdent | (I responded anyway) | 13:03 |
| gibi | OK, I think I got it now. Maybe referring to the _get_usages_by_provider_tree as the source of all providers would help a bit | 13:05 |
| cdent | gibi: yeah, can do | 13:06 |
| *** mriedem has joined #openstack-placement | 13:10 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Improve docs and comments for provider_ids_from_rp_ids https://review.opendev.org/675082 | 13:10 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Move provider_ids_from_rp_ids to allocation_candidate https://review.opendev.org/675084 | 13:10 |
| cdent | gibi: I went ahead and added a few more words there ^ | 13:10 |
| cdent | so if you could drop your two +2 back on that would be lovely | 13:10 |
| gibi | cdent: sure. thanks | 13:12 |
| gibi | done | 13:13 |
| *** ykarel is now known as ykarel|afk | 13:15 | |
| *** ykarel_ has joined #openstack-placement | 13:19 | |
| *** ykarel_ has quit IRC | 13:21 | |
| *** ykarel|afk has quit IRC | 13:21 | |
| gibi | cdent: I think I see a bug in ps://review.opendev.org/#/c/673555 | 13:23 |
| * cdent looks | 13:24 | |
| cdent | good catch, I'll fix | 13:25 |
| gibi | cool | 13:25 |
| stephenfin | cdent: Is a 'traitN:MY_TRAIT' extra spec a valid thing? | 13:32 |
| stephenfin | i.e. the trait would be assigned to the numbered resource group | 13:32 |
| gibi | cdent: do I understand correclty tetsuro's -1 in https://review.opendev.org/#/c/674581 only for the doc update you already FUPped? | 13:32 |
| cdent | stephenfin: I don't speak extra spec well. I know there is a way to give it group but I don't remember it off the top of my head without looking somewhere. it is somewhat different from how things are spoken in placement land | 13:33 |
| cdent | gibi: you probably know the answer to stephenfin's query? | 13:33 |
| cdent | gibi: yes, that's right. he had some other questions, but they were for later work | 13:33 |
| gibi | stephenfin: let me look it up | 13:33 |
| gibi | cdent: OK, then I will go and review that series too | 13:34 |
| cdent | also gibi: the bug you've identified looks like it was already there | 13:34 |
| cdent | cool thanks | 13:34 |
| cdent | and I think it may be covered, me tests something | 13:34 |
| gibi | stephenfin: this is how we parse the extra_spec for request groups from_extra_specs | 13:41 |
| gibi | https://github.com/openstack/nova/blob/35e36b0a854c824dfa3789eca8ead4c83f62eb4c/nova/scheduler/utils.py#L144 | 13:41 |
| gibi | stephenfin: so based on the doc in that function it accepts "trait$N:$TRAIT_NAME": "required" | 13:42 |
| stephenfin | gibi: I'm looking at that and it suggests I can use numbered groups for traits, but I couldn't find anything documenting this | 13:42 |
| stephenfin | wait, I glossed over the docstring | 13:43 |
| stephenfin | :) | 13:43 |
| stephenfin | gibi++ | 13:43 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Optimize trait creation to check existence first https://review.opendev.org/673555 | 14:04 |
| cdent | gibi, efried : that fixes it, with confirming test | 14:05 |
| cdent | (take out the added code, test fails) | 14:05 |
| gibi | cdent: we are still lying a bit in that create_at but I guess you don't want the cost of quering trait from the DB again | 14:16 |
| cdent | gibi: the value won't be any different | 14:16 |
| cdent | the only way it can happen is if it is in the same second (I say as much in the commit message) | 14:16 |
| gibi | cdent: OK cool | 14:16 |
| *** altlogbot_1 has quit IRC | 14:46 | |
| *** altlogbot_3 has joined #openstack-placement | 14:47 | |
| openstackgerrit | Merged openstack/placement master: Remove double join in provider_ids_from_rp_ids https://review.opendev.org/674017 | 15:15 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Optimize trait creation to check existence first https://review.opendev.org/673555 | 15:42 |
| cdent | efried, gibi : pep8 fix on that ^. added a too long line when adding to the tests | 15:42 |
| gibi | cdent: ack | 15:43 |
| *** helenafm has quit IRC | 15:45 | |
| *** tssurya has quit IRC | 16:10 | |
| openstackgerrit | Merged openstack/placement master: Run nested-perfload parallel correctly https://review.opendev.org/673505 | 16:11 |
| openstackgerrit | Merged openstack/placement master: Track usage info on RequestWideSearchContext https://review.opendev.org/674581 | 16:11 |
| openstackgerrit | Merged openstack/placement master: Make _get_trees_with_traits return a set https://review.opendev.org/674630 | 16:11 |
| openstackgerrit | Merged openstack/placement master: Use expanding bindparam in extend_usages_by_provider_tree https://review.opendev.org/674647 | 16:11 |
| *** efried is now known as efried_rollin | 16:12 | |
| * cdent will check back in later to see if all that stuff merging broke a bunch of stuff or really made it faster | 16:22 | |
| cdent | otherwise I'm going outside | 16:22 |
| * cdent waves | 16:22 | |
| gibi | o/ | 16:22 |
| *** cdent has quit IRC | 16:22 | |
| *** e0ne has quit IRC | 17:06 | |
| *** artom has quit IRC | 17:13 | |
| *** altlogbot_3 has quit IRC | 17:17 | |
| *** altlogbot_0 has joined #openstack-placement | 17:23 | |
| *** altlogbot_0 has quit IRC | 17:31 | |
| *** altlogbot_1 has joined #openstack-placement | 17:35 | |
| openstackgerrit | Merged openstack/placement master: Trivial: Remove duplicate usage of db context https://review.opendev.org/675060 | 17:41 |
| *** artom has joined #openstack-placement | 18:17 | |
| *** e0ne has joined #openstack-placement | 18:49 | |
| *** e0ne has quit IRC | 19:46 | |
| *** efried_rollin is now known as efried | 19:59 | |
| openstackgerrit | Merged openstack/placement master: Implement a more complex nested-perfload topology https://review.opendev.org/673513 | 20:39 |
| openstackgerrit | Merged openstack/placement master: Clean up the extend_usages_by_provider_tree method https://review.opendev.org/675074 | 21:46 |
| openstackgerrit | Merged openstack/placement master: Improve docs and comments for provider_ids_from_rp_ids https://review.opendev.org/675082 | 22:10 |
| *** mriedem has quit IRC | 22:24 | |
| openstackgerrit | Eric Fried proposed openstack/placement master: Move provider_ids_from_rp_ids to allocation_candidate https://review.opendev.org/675084 | 22:53 |
| *** takashin has joined #openstack-placement | 23:32 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!