Wednesday, 2019-07-31

*** tetsuro has joined #openstack-placement00:55
*** tetsuro has quit IRC02:16
*** tetsuro has joined #openstack-placement02:52
*** tetsuro has quit IRC03:28
*** tetsuro has joined #openstack-placement03:46
openstackgerritMerged openstack/placement master: Extra gabbi tests for same_subtree  https://review.opendev.org/66993004:42
*** belmoreira has joined #openstack-placement06:13
*** artom has quit IRC06:32
*** artom has joined #openstack-placement06:33
*** belmoreira has quit IRC07:28
*** tssurya has joined #openstack-placement07:31
*** cdent has joined #openstack-placement07:36
*** e0ne has joined #openstack-placement07:58
openstackgerritChris Dent proposed openstack/placement master: Use TraitCache for Trait.get_by_name  https://review.opendev.org/67375007:59
*** belmoreira has joined #openstack-placement08:01
*** e0ne has quit IRC08:07
*** tetsuro has quit IRC08:11
*** ttsiouts has joined #openstack-placement08:11
cdentevery single time I use mock I want to burn the whole world down08:12
*** tetsuro has joined #openstack-placement08:17
*** ttsiouts has quit IRC08:21
*** ttsiouts has joined #openstack-placement08:22
*** ttsiouts has quit IRC08:27
*** ttsiouts has joined #openstack-placement08:36
openstackgerritpengyuesheng proposed openstack/placement master: Blacklist sphinx 2.1.0 (autodoc bug)  https://review.opendev.org/67376008:42
openstackgerritChris Dent proposed openstack/placement master: Optimize trait creation to check existence first  https://review.opendev.org/67355508:59
*** belmoreira has quit IRC09:03
openstackgerritChris Dent proposed openstack/placement master: Add apache benchmark (ab) to end of perfload jobs  https://review.opendev.org/67354009:03
*** ttsiouts has quit IRC09:05
*** tetsuro has quit IRC09:06
*** e0ne has joined #openstack-placement09:06
*** ttsiouts has joined #openstack-placement09:09
*** ttsiouts has quit IRC09:23
*** ttsiouts has joined #openstack-placement09:24
*** ttsiouts has quit IRC09:28
openstackgerritMerged openstack/osc-placement master: Update api-ref location  https://review.opendev.org/67276909:37
*** ttsiouts has joined #openstack-placement09:45
*** ttsiouts has quit IRC10:00
*** ttsiouts has joined #openstack-placement10:01
*** ttsiouts has quit IRC10:06
openstackgerritChris Dent proposed openstack/placement master: Run nested-perfload parallel correctly  https://review.opendev.org/67350510:19
openstackgerritChris Dent proposed openstack/placement master: Implement a more complex nested-perfload topology  https://review.opendev.org/67351310:19
openstackgerritChris Dent proposed openstack/placement master: Add apache benchmark (ab) to end of perfload jobs  https://review.opendev.org/67354010:19
*** belmoreira has joined #openstack-placement10:50
*** ttsiouts has joined #openstack-placement11:23
openstackgerritChris Dent proposed openstack/placement master: Remove ProviderIds namedtuple  https://review.opendev.org/67378811:41
*** ttsiouts has quit IRC13:25
*** ttsiouts has joined #openstack-placement13:26
*** mriedem has joined #openstack-placement13:27
*** ttsiouts has quit IRC13:31
*** ttsiouts has joined #openstack-placement13:41
*** belmoreira has quit IRC13:43
*** belmoreira has joined #openstack-placement13:45
*** belmoreira has quit IRC13:56
openstackgerritChris Dent proposed openstack/placement master: Add apache benchmark (ab) to end of perfload jobs  https://review.opendev.org/67354014:13
*** belmoreira has joined #openstack-placement14:15
cdentbelmoreira: have you tweaked innodb_read_io_threads and innodb_write_io_threads on the mysql servers you have behind your placement servers?14:20
cdentefried: was there a reason you didn't +w the sphinx blacklist at https://review.opendev.org/#/c/673760/ ?14:21
belmoreiracdent I running with the default 414:34
cdentthanks belmoreira . that seems reasonable in a reasonably spread out set up, but I'm trying to do some performance testing and with just one database it's not seeming to be enough14:35
belmoreiracdent thanks for let me know. I'm interested in your results14:42
cdentthere's a related stack of work happening around here: https://review.opendev.org/673505 and I wrote about some of it here: https://anticdent.org/profiling-placement-in-docker.html14:43
cdentthe `ab` on the end of that stack of changes is timing out becaue the database isn't keeping up. uwsgi+placement seems to be doing okay, but the db doesn't want to do enough.14:44
openstackgerritChris Dent proposed openstack/placement master: Optimize trait creation to check existence first  https://review.opendev.org/67355514:46
*** belmoreira has quit IRC14:51
efriedcdent: Yeah, it seems like a slam dunk, but I thought having stephenfin send it would be appropriate, since he was involved in the sphinx issue and he's on the core list.14:58
cdentefried: meh, based on reading the issue and stephenfin's already awareness of it, I'd say slam it. Unless there are substantial reasons to delay things, why delay?15:00
*** belmoreira has joined #openstack-placement15:03
efriedcdent: sure, you can +W it if you like.15:04
* cdent does15:04
efriedcdent: btw, your opposition to mock is noted, but it exists for exactly this reason. The test as written in PS4 would blow up against the code as written in PS1, but that's the only way (other than review) that that bug would have been found short of a real field repro.15:18
cdentefried: I know, and I'm sure you know I know. My opposition is not about its utility.15:18
cdentits about its necessity15:19
cdentif we write code that needs mocks then we've written code that could be better15:19
cdentbut at a certain point you just gotta say screw it and deal15:20
efriedinteresting.15:20
cdentI know that in a nova-oriented world, the idea of writing code that doesn't need mocks is insanity, but it is possible (and better, in my opinion, which I ack is much different from others)15:20
efriedso in this case you would have to use, like, a database lock to avoid the possibility of races.15:20
cdentand, in any case I don't really mind: "bug would have been found short of a real field repro". Bugs are how we make sure a community exists15:21
cdentpart of the reason we don't have a community around placement is because it is too damn good :)15:21
efriedfirst world problems15:21
efriedor something15:22
cdentquite15:22
efriedBut I'm sure you've seen the graphs every software shop loves to put in devs' faces15:22
efriedabout the exponential increase in cost of a bug the later it is discovered.15:23
efriedto that end, avoiding field escapes is our job, and in that sense, I *do* mind.15:23
efried(clearly you don't actually object; this is just conversation)15:24
cdentI think the economics of those sorts of graphs are complicated in open source, especially open source which is as socially and economically complex as openstack15:25
cdentto such an extent that I'm not sure we can use standard metrics for in house development health15:25
cdenti mean yeah, if I objected that much, I wouldn't have written the test, but I object enough to moan about it15:26
efriedAgree open source is different for sure15:26
efriedThe slope of the graph may be shallower, but the direction is still the same.15:27
cdentIf I had to pick one of the primary factors in why openstack has a bad architecture one of them (but not the sole) would be over-reliance on mocked unit tests15:27
efriedbecause downstreams still have to package etc.15:27
cdentoh don't get me started on packaging :)15:27
efriedoh, I have no problem with the philosophy of "only use mock and unit tests for things you can't (practically) cover with functional tests"15:28
efriedand e.g. nova has been moving in that direction15:28
cdentit's kind of too late for nova15:28
cdenti mean we can do a better job of finding and fixing bugs with the new style, but changing the architecture, though possible, is very slow15:29
cdentwe're making progress15:29
cdentit's good15:29
cdenti'm not trying to be a totally negative ninny15:29
cdentbut let's just say I have thoughts15:29
cdentwelp, I was hoping the gate was going to give me something to read before I ran out of time, but no.15:34
cdentuntil tomorrow15:34
* cdent waves15:34
efriedo/15:34
*** cdent has quit IRC15:34
*** ttsiouts has quit IRC15:42
*** ttsiouts has joined #openstack-placement15:42
*** tssurya has quit IRC15:46
*** ttsiouts has quit IRC15:47
*** e0ne has quit IRC15:49
*** e0ne has joined #openstack-placement15:50
*** belmoreira has quit IRC15:50
*** efried is now known as efried_rollin15:57
openstackgerritMerged openstack/placement master: Blacklist sphinx 2.1.0 (autodoc bug)  https://review.opendev.org/67376016:45
*** e0ne has quit IRC17:18
*** altlogbot_2 has quit IRC18:19
*** altlogbot_1 has joined #openstack-placement18:20
*** e0ne has joined #openstack-placement18:37
*** e0ne has quit IRC19:02
*** e0ne has joined #openstack-placement19:12
openstackgerritmelanie witt proposed openstack/osc-placement master: Add --amend option to 'resource provider inventory set'  https://review.opendev.org/64089819:21
*** e0ne has quit IRC19:24
*** efried_rollin is now known as efried19:47
*** e0ne has joined #openstack-placement19:55
*** e0ne has quit IRC20:12
*** mriedem has quit IRC20:44
*** mriedem has joined #openstack-placement20:45
*** mriedem has quit IRC20:54
*** mriedem has joined #openstack-placement20:55
*** e0ne has joined #openstack-placement21:37
*** mriedem has quit IRC22:43
*** e0ne has quit IRC23:33

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!