| *** takashin has joined #openstack-placement | 00:10 | |
| openstackgerrit | sean mooney proposed openstack/os-traits master: add libvirt image metadata traits https://review.opendev.org/652996 | 01:07 |
|---|---|---|
| openstackgerrit | sean mooney proposed openstack/os-traits master: add GOP, NONE and VIRTIO grapics models https://review.opendev.org/665830 | 01:11 |
| *** Sundar has joined #openstack-placement | 01:36 | |
| *** tetsuro has joined #openstack-placement | 02:40 | |
| *** tetsuro has quit IRC | 03:11 | |
| *** tetsuro has joined #openstack-placement | 03:51 | |
| *** tetsuro has quit IRC | 03:57 | |
| *** tetsuro has joined #openstack-placement | 04:03 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: DNM: review comment related to agg flow down https://review.opendev.org/666488 | 04:58 |
| *** tetsuro has quit IRC | 05:10 | |
| *** tetsuro has joined #openstack-placement | 05:46 | |
| *** Sundar has quit IRC | 05:47 | |
| *** tetsuro has quit IRC | 05:50 | |
| *** belmoreira has joined #openstack-placement | 06:09 | |
| *** belmoreira has quit IRC | 06:09 | |
| *** tssurya has joined #openstack-placement | 07:20 | |
| *** ttsiouts has joined #openstack-placement | 07:31 | |
| *** helenafm has joined #openstack-placement | 07:31 | |
| *** dklyle has quit IRC | 07:52 | |
| *** takashin has left #openstack-placement | 08:00 | |
| *** tetsuro has joined #openstack-placement | 08:20 | |
| *** belmoreira has joined #openstack-placement | 08:30 | |
| *** tetsuro has quit IRC | 08:31 | |
| *** belmoreira has quit IRC | 08:37 | |
| *** tetsuro has joined #openstack-placement | 08:47 | |
| *** tetsuro has quit IRC | 08:47 | |
| *** tetsuro has joined #openstack-placement | 08:49 | |
| *** tetsuro has quit IRC | 08:59 | |
| *** e0ne has joined #openstack-placement | 09:22 | |
| *** belmoreira has joined #openstack-placement | 09:23 | |
| *** belmoreira has quit IRC | 09:31 | |
| *** belmoreira has joined #openstack-placement | 09:42 | |
| gibi | efried: replied in https://review.opendev.org/#/c/658852/3 | 09:46 |
| *** belmoreira has quit IRC | 09:53 | |
| *** belmoreira has joined #openstack-placement | 10:01 | |
| *** cdent has joined #openstack-placement | 10:16 | |
| cdent | gibi: I think you already commented here about https://review.opendev.org/#/c/666281/ . Care to leave a vote? | 10:24 |
| *** belmoreira has quit IRC | 10:51 | |
| *** belmoreira has joined #openstack-placement | 10:59 | |
| gibi | cdent: sure | 10:59 |
| openstackgerrit | Pawel Baclawski proposed openstack/osc-placement master: Add support for 1.24 microversion https://review.opendev.org/666542 | 11:27 |
| openstackgerrit | Pawel Baclawski proposed openstack/osc-placement master: Add support for 1.24 microversion https://review.opendev.org/666542 | 11:30 |
| *** belmoreira has quit IRC | 11:35 | |
| efried | Thanks for that reply gibi, very helpful | 11:38 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Nested provider performance testing https://review.opendev.org/665695 | 11:39 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Move non-nested perfload shell commands to script https://review.opendev.org/666544 | 11:39 |
| efried | cdent: did you see the thing about using experimental? | 11:42 |
| cdent | I did but figured we were close enough | 11:43 |
| cdent | I've not got the time to iterate closely in the way that experimental would make useful | 11:43 |
| efried | well, I thought it could be a useful thing to do so we could avoid running the job all the time, but run it on demand on patches where we suspect or want to validate performance issues. | 11:44 |
| efried | not so much for iterating on the job itself, which obviously takes a new hit every patch set regardless. | 11:44 |
| efried | anyway, just wanted to make sure you had seen the comment (head-of-review comments are often lost in the noise of inline comments) | 11:45 |
| cdent | oh, no, I prefer running it on everything because I don't want to rely on us thinking to do it, or thinking we know something is going to have performance impact | 11:45 |
| cdent | that wanting it to run all the time is part of why I want to keep it lean | 11:47 |
| cdent | (of course I may have broken it in my latest tune up) | 11:47 |
| openstackgerrit | Merged openstack/placement master: Remove overly-verbose allocation request log https://review.opendev.org/666281 | 12:35 |
| openstackgerrit | Merged openstack/placement master: Update SUSE install documentation https://review.opendev.org/666408 | 12:35 |
| efried | gibi: responded again | 13:06 |
| cdent | gibi, efried: you're both stumbling onto an interesting point that this will help resolve. we sometimes think of traits and things which describe what a resource provider is capable of, but what a trait really is, in terms of its use, is a thing that describes what _we_ can do with this thing. That's especially true for provider traits. | 13:12 |
| cdent | s/and things/as things/ | 13:12 |
| efried | cdent: That's a good crystallization of what I was trying to get at, thanks. | 13:13 |
| cdent | now, if I just had a node, all would be good | 13:14 |
| cdent | efried: (and gibi too) since you're around now: I think I'm going to take next week off. This thing where I'm trying to manage having family visitors local to me and also work is not working out. I'm going to run the risk of not spending any quality time of any duration with them before they go. So I'm going to try to get my votes in on the big deal stuff today and tomorrow | 13:15 |
| efried | You also run the risk of not spending quality time with *us* :P | 13:16 |
| efried | cdent: okay, how long until you take off this evening? | 13:16 |
| cdent | ~4 hours | 13:16 |
| cdent | depends a bit on dinner plans, but at least 4 hours | 13:18 |
| *** mriedem has joined #openstack-placement | 13:23 | |
| efried | tssurya: Are you around to have a look at the nested magic spec you helped seed in Denver? | 13:23 |
| mriedem | gibi: cdent: just had a question in this osprofiler change https://review.opendev.org/#/c/663945/ | 13:24 |
| tssurya | efried: hey sorry I haven't had time to look into it yet :( | 13:24 |
| tssurya | I'll try to keep some time aside for that (https://review.opendev.org/#/c/662191/) asap | 13:25 |
| efried | thanks tssurya. We're getting real close to being able to merge it (I think) but it would be nice to have it vetted by someone in The Real World. (There's also a question inline about "do we need this (yet)?" that you might be able to answer.) | 13:26 |
| tssurya | efried: ack, at present at least downstream we haven't even thought much about the nested part of the world, | 13:28 |
| tssurya | I'll try to read it and answer today | 13:28 |
| cdent | mriedem: lookin | 13:30 |
| cdent | mriedem: tried to give a useful answer, hope it helps | 13:37 |
| mriedem | cdent: ack, and one back at you | 13:43 |
| cdent | mriedem: back again. basically I'm in the "merge what's good enough; if more is needed, do it in a fup, or at least make a story so it's not forgotten" camp | 13:48 |
| mriedem | that's fine. as noted in the commit message comment the detail there would be good for docs, so i'll open a story about documenting osprofiler integration with placement and approve | 13:50 |
| cdent | this is one of the ways in which I'm hoping that storyboard will be better than launchpad | 13:50 |
| openstackgerrit | Eric Fried proposed openstack/placement master: research_context._get_roots_with_traits() https://review.opendev.org/665491 | 13:50 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Refactor anchors_for_sharing_providers https://review.opendev.org/665561 | 13:50 |
| openstackgerrit | Eric Fried proposed openstack/placement master: RequestWideParams and RequestWideSearchContext https://review.opendev.org/665712 | 13:50 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Microversion 1.35: root_required https://review.opendev.org/665492 | 13:50 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Miscellaneous doc/comment/log cleanups https://review.opendev.org/665691 | 13:50 |
| cdent | launchpad bugs are too much like bugs, not tasks | 13:50 |
| efried | cdent: If you could, before you vacate for a week --^ | 13:51 |
| cdent | aye | 13:51 |
| efried | The parts of the spec still under debate are not relevant in that series | 13:51 |
| efried | and | 13:51 |
| efried | I thought about whether, if we were able to implement root_member_of quickly and easily, we should include it in the same microversion with root_required | 13:52 |
| efried | and concluded that we shouldn't. | 13:52 |
| efried | because you can always skip microversions | 13:52 |
| efried | and I'd rather keep smaller pieces of work | 13:52 |
| * cdent nods | 13:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/placement master: Add support for osprofiler in wsgi https://review.opendev.org/663945 | 13:53 |
| cdent | thanks mriedem | 13:54 |
| cdent | each day, in every way, better and better | 13:54 |
| * cdent sparklemotions | 13:54 | |
| *** ttsiouts has quit IRC | 14:20 | |
| *** ttsiouts has joined #openstack-placement | 14:21 | |
| *** ttsiouts has quit IRC | 14:25 | |
| *** ttsiouts has joined #openstack-placement | 14:34 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Adjust parallel concurrency to 1*nproc https://review.opendev.org/666597 | 14:47 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Adjust parallel concurrency to 1*nproc in nested-perfload https://review.opendev.org/666597 | 14:47 |
| *** Sundar has joined #openstack-placement | 14:53 | |
| gibi | mriedem: thanks. I will make a docs patch for osprofiler in placement | 14:58 |
| openstackgerrit | Matt Riedemann proposed openstack/os-traits master: Add COMPUTE_SAME_HOST_COLD_MIGRATE trait https://review.opendev.org/666604 | 14:58 |
| *** dklyle has joined #openstack-placement | 15:16 | |
| openstackgerrit | Eric Fried proposed openstack/placement master: Spec for nested magic 1 https://review.opendev.org/662191 | 15:18 |
| efried | cdent, gibi: ^ | 15:18 |
| efried | Ima go see how hard root_member_of would be... | 15:19 |
| *** ttsiouts has quit IRC | 15:29 | |
| *** ttsiouts has joined #openstack-placement | 15:30 | |
| *** ttsiouts has quit IRC | 15:30 | |
| *** ttsiouts has joined #openstack-placement | 15:30 | |
| *** helenafm has quit IRC | 15:31 | |
| *** ttsiouts has quit IRC | 15:35 | |
| *** e0ne has quit IRC | 15:38 | |
| *** sean-k-mooney1 has joined #openstack-placement | 15:58 | |
| *** sean-k-mooney has quit IRC | 16:03 | |
| *** tssurya has quit IRC | 17:07 | |
| openstackgerrit | Eric Fried proposed openstack/placement master: WIP: Microversion 1.36: root_member_of https://review.opendev.org/666653 | 17:26 |
| efried | cdent: Pretty sure that's it ^ | 17:27 |
| cdent | efried: i'll look at that tomorrow. I'm pushing hard to get through root_required and then need to run off to dinners | 17:27 |
| efried | cdent: ack. need to add test, doc, and microversion paperwork, but existing sql for "providers matching aggs" plus framework from root_required made it pretty easy. | 17:28 |
| efried | If you're reviewing root_required, I guess I'll wait to hit your comments on the bottom patch. Does the DISTINCT hurt anything? | 17:28 |
| cdent | i assume that the query engine will optimize it out, but I'd prefer that we be concerned about good/clean SQL | 17:30 |
| cdent | if you want to fup it, that's fine | 17:30 |
| efried | cdent: ack. If you don't downvote the main patch, I'd rather fup it so as not to have to restack. | 17:33 |
| cdent | efried: i did downvote, some test issues | 17:46 |
| cdent | now really must dash | 17:46 |
| * cdent waves | 17:46 | |
| efried | ight | 17:46 |
| efried | o/ | 17:46 |
| *** cdent has quit IRC | 17:46 | |
| *** Sundar has quit IRC | 17:49 | |
| *** e0ne has joined #openstack-placement | 20:26 | |
| *** e0ne has quit IRC | 20:33 | |
| *** takashin has joined #openstack-placement | 20:51 | |
| mriedem | efried: i left a comment in https://review.opendev.org/#/c/665492/ so cdent is aware | 21:35 |
| mriedem | that i'm a monster | 21:35 |
| mriedem | but i think he already knows that | 21:35 |
| *** mriedem is now known as mriedem_awau | 21:36 | |
| *** mriedem_awau is now known as mriedem_away | 21:36 | |
| *** cdent has joined #openstack-placement | 21:56 | |
| cdent | efried: I'm going to each some of tomorrow's hours today so I can start my weekend early tomorrow. So a) unlike my promise last week, I am going to do a pupdate tomorrow, b) if there's anything you want to discuss, I'm around for a bit | 21:57 |
| efried | cdent: oh, okay. I'm about to push ... | 21:58 |
| openstackgerrit | Eric Fried proposed openstack/placement master: research_context._get_roots_with_traits() https://review.opendev.org/665491 | 21:58 |
| efried | ...this ^ | 21:58 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Refactor anchors_for_sharing_providers https://review.opendev.org/665561 | 21:58 |
| openstackgerrit | Eric Fried proposed openstack/placement master: RequestWideParams and RequestWideSearchContext https://review.opendev.org/665712 | 21:58 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Microversion 1.35: root_required https://review.opendev.org/665492 | 21:58 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Miscellaneous doc/comment/log cleanups https://review.opendev.org/665691 | 21:58 |
| openstackgerrit | Eric Fried proposed openstack/placement master: WIP: Microversion 1.36: root_member_of https://review.opendev.org/666653 | 21:58 |
| efried | and these^ | 21:58 |
| cdent | ayeaye | 21:58 |
| efried | cdent: I did have a question on one of your questions on the microversion patch | 21:59 |
| cdent | shoot | 22:00 |
| efried | cdent: two actually. | 22:00 |
| efried | One was on the "only use this if you have trees" thing | 22:00 |
| efried | which I disagree with - see inline - but maybe we can meet in the middle with a link to the doc if that will satisfy | 22:00 |
| *** david-lyle has joined #openstack-placement | 22:01 | |
| *** dklyle has quit IRC | 22:01 | |
| *** david-lyle is now known as dklyle | 22:01 | |
| efried | The other was about additional verifications in the gabbi tests. Not sure whether you're saying "you could do this in fewer lines" or "you could make this more interesting" or "you're not verifying adequately". | 22:01 |
| cdent | 3rd | 22:02 |
| cdent | we need to know that cn1 showed up | 22:03 |
| cdent | (or whatever it was) | 22:03 |
| cdent | in at least one of the tests | 22:03 |
| cdent | which is saying "this thing I have done has not broken how provider summaries works" | 22:03 |
| cdent | which we know it hasn't | 22:03 |
| cdent | but it should be explicit | 22:03 |
| cdent | I'll reply on the rest on the review | 22:04 |
| efried | oh, you want a "we haven't broken provider summaries", can do | 22:04 |
| efried | cdent: How does a guy do :doc:`/path/to/file#anchor` ? | 22:07 |
| efried | cause ^ that doesn't work | 22:07 |
| cdent | the way I've always done it is to create an internal target with the doc that I care about (which may already exist in this case if you've got an #anchor, and :ref: it | 22:10 |
| efried | okay, was doing the internal target thing, forgot I needed to :ref:, thanks. | 22:10 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Adjust parallel concurrency to 2*nproc in nested-perfload https://review.opendev.org/666597 | 22:14 |
| efried | cdent: Sorry, I get what you're saying, but I just don't agree that we need to try to spell that out in this context. | 22:17 |
| cdent | which context do we, then? | 22:18 |
| cdent | because we tend to oriented our documentation on usage to the complicated things, without much attention to "we have complex things, but it doesn't have to be that way" | 22:19 |
| *** mriedem_away has quit IRC | 22:19 | |
| efried | cdent: how about a paragraph at the front of usage/provider-tree.html? | 22:20 |
| efried | and/or a separate doc somewhere | 22:20 |
| efried | in usage/ | 22:21 |
| efried | I agree what you're saying is worth expressing. Just... not every time we write a feature that has to do with trees. | 22:21 |
| cdent | I'd much rather we were just more conscious of it as a general rule. Your comment about 1.25, 1.29 and 1.33 is something I sometimes do think we should do | 22:22 |
| cdent | becasue we've seen that people frequently read in isolation | 22:22 |
| cdent | but its only recently that I've started thinking about it hard enough to think about ways to deal with it and care about it | 22:22 |
| cdent | I'm not saying drop everything and go back and chage stuff | 22:22 |
| efried | open a task for "docs should describe the simple case and when you don't need anything fancier"? | 22:24 |
| cdent | leave it with me, I'll make some tomorrow morning after I've slept on it. I'm not going to block your change on this issue, it's really a consciousness thing. | 22:26 |
| efried | okay, cool. almost ready with a new rev with those psum test changes. | 22:26 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Miscellaneous doc/comment/log cleanups https://review.opendev.org/665691 | 22:27 |
| openstackgerrit | Eric Fried proposed openstack/placement master: WIP: Microversion 1.36: root_member_of https://review.opendev.org/666653 | 22:27 |
| efried | oh | 22:27 |
| efried | dam | 22:27 |
| efried | it | 22:27 |
| efried | I put 'em on the wrong patch. | 22:28 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Microversion 1.35: root_required https://review.opendev.org/665492 | 22:30 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Miscellaneous doc/comment/log cleanups https://review.opendev.org/665691 | 22:30 |
| openstackgerrit | Eric Fried proposed openstack/placement master: WIP: Microversion 1.36: root_member_of https://review.opendev.org/666653 | 22:30 |
| efried | fixed | 22:30 |
| *** alex_xu has quit IRC | 22:35 | |
| *** alex_xu has joined #openstack-placement | 22:39 | |
| efried | cdent: ima take off here pretty soon; anything further I can do on that series before I go? | 22:48 |
| cdent | I've left another comment about tests (haven't submitted it yet because have another comment in progress) but it is non-blocking | 22:49 |
| *** sean-k-mooney1 has quit IRC | 22:49 | |
| efried | ight | 22:50 |
| *** sean-k-mooney has joined #openstack-placement | 22:55 | |
| cdent | submitted | 22:55 |
| efried | ack, thanks for explaining. | 22:57 |
| efried | cdent: I'm getting doe-eyes, so I'm out. If I don't see you before you vacate, have a nice vacation. | 22:58 |
| cdent | thanks, I'll try | 22:58 |
| *** dklyle has quit IRC | 23:02 | |
| * cdent retires | 23:03 | |
| *** cdent has quit IRC | 23:03 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!