Friday, 2019-05-31

*** mriedem_away has quit IRC00:57
*** amodi has quit IRC05:08
*** takashin has quit IRC05:29
*** e0ne has joined #openstack-placement06:36
openstackgerritPawel Baclawski proposed openstack/osc-placement master: Add support for 1.22 microversion  https://review.opendev.org/65178306:58
openstackgerritPawel Baclawski proposed openstack/osc-placement master: Add support for 1.22 microversion  https://review.opendev.org/65178307:00
gibicdent: logo works for me07:09
openstackgerritPawel Baclawski proposed openstack/osc-placement master: Add support for 1.22 microversion  https://review.opendev.org/65178307:47
*** takashin has joined #openstack-placement08:05
openstackgerritChris Dent proposed openstack/placement master: Spec for nested magic 1  https://review.opendev.org/66219108:26
openstackgerritBalazs Gibizer proposed openstack/os-traits master: Add COMPUTE_NET_VF_PARENT_NAME_REPORTING trait  https://review.opendev.org/65885209:21
*** takashin has left #openstack-placement09:31
*** cdent has joined #openstack-placement09:33
*** cdent has quit IRC10:05
*** cdent has joined #openstack-placement10:39
cdentefried: thanks for the reminder on the map: https://review.opendev.org/#/c/662439/12:03
*** cdent has quit IRC12:13
*** openstack has joined #openstack-placement12:30
*** ChanServ sets mode: +o openstack12:30
*** mriedem has joined #openstack-placement13:05
cdentbrief but sincere moments of joy: https://anticdent.org/placement-update-19-21.html13:52
efriedcdent: what's our current policy on deleting consumers?14:32
efriedDo they go away as soon as all their allocations go away?14:32
cdentpretty much14:33
cdentdo you mean their db row, or their conceptual existence?14:33
efriedwe have a consumers table. So I mean their row in that table I guess14:33
*** openstackstatus has joined #openstack-placement14:34
*** ChanServ sets mode: +v openstackstatus14:34
cdentat the end of 'set_allocations' we call a method to delete the consumer if they have no allocations14:34
cdent'delete_consumers_if_no_allocations'14:34
efriedokay, I see it now, thank you.14:35
cdentthere was lot of argument about that (and consumers in general) but the upshot was that from placement's standpoint (for now) a consumer is something it is only aware of in an ephemeral sense14:35
efriedyeah, I recall all of that, just couldn't remember where we landed. Leaving consumers around forever, once they had their own row in a table, would have made no sense, because there will be a lot of those in a long-lived placement db, but I wanted to make sure.14:36
cdent14:37
efriedcdent: Do we still have anything that we "leave around forever"?14:37
cdentaggregate uuids, maybe14:37
efriedk14:37
cdentand CUSTOM traits and resource classes (which makes sense)14:37
cdentwhile I do imagine us wanting to become "million resource provider capable" I don't know that orphaned aggregates, even at that scale, will matter much14:38
efriedCUSTOM traits, that's totally going to be a problem once people start doing CUSTOM_CREATED_AT_20190531_094014:40
cdentyou spin that kind of rope into your life, you're welcome to hang?14:42
cdentpeople are welcome to create their own clean up tools in that case?14:43
mriedemthe delete consumer once there are no more allocatoins was a thing that bit nova with a race in the gate,14:43
mriedemi believe the issue was shelve offload and then immiatedly unshelve, scheduling would fail b/c the consumer generatoin was gone or something,14:43
mriedembecause we changed the vm status before removing the allocatoins14:43
mriedemit was fun14:43
efriedgood times14:43
* cdent checks "fun" in the dictionary14:44
mriedemagree that if people starting doing "openstack resource provider trait create CUSTOM_$(uuidgen)" then it's their own fault14:45
cdentespecially since we don't create traits on the fly: an explicit creation step is required14:47
cdentcleaning them up out from under people would be a problem14:47
efriedmeh, as long as we don't allow deletion when in use, it doesn't matter to the client that the next time they use CUSTOM_FOO it has a different internal ID.14:50
efriedbut ^ assumes we went to creating traits automatically when used.14:50
cdentwhich, let's not14:52
cdentbecause then there's no protection against typos14:52
efriedagreed. cause then we might need generations somewhere we don't have them yet, can't think through exactly where.14:53
mriedemsomeone can write a script to purge old unused traits after a given created_at time if they want14:57
mriedemin one of the 50 ops repos14:57
cdent50+114:57
openstackgerritKashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits  https://review.opendev.org/65519314:58
efriedcdent: 1:1 allocation:consumer?15:07
efriedthat's probably the wrong question15:08
cdentit depends on what you are calling an "allocation"15:08
efriedyeah15:08
-openstackstatus- NOTICE: Gerrit is now entering its maintenance window. Expect Gerrit outages in the near future. We will notify when it is back up and running.15:08
*** ChanServ changes topic to "Gerrit is now entering its maintenance window. Expect Gerrit outages in the near future. We will notify when it is back up and running."15:08
cdentthere are multiple rows in the allocation table per consumer15:08
cdents/are/can be/15:08
cdentefried: is there something you are thinking about that's leading to these questions?15:08
efriedand can be against different resource providers15:08
cdentyes15:09
efriedbecause sharing15:09
efriedbut we wouldn't enforce even if multiple nonsharing15:09
efriedbecause tree15:09
efriedbut we wouldn't enforce even if multiple nonsharing in different trees15:09
efriedbecause we don't.15:09
cdenti'm not parsing any of what you just said15:09
efriedyeah, I'm reviewing the consumer types spec and bikeshedding on the name of the new 'count' field.15:10
efriedIt needs to say what it's a count of15:10
efriedand I thought 'allocation_count', but it's really 'consumer_count'15:10
efriedbecause "one allocation" doesn't really make sense, as noted above.15:11
efried"the group of one consumer's allocations" or "one row in the allocations table", and here the intent is the former, so we should just say "consumer" instead.15:11
* cdent needs to re-review that spec15:11
* cdent usually does such things on a monday15:13
efriedcdent: wait for a) gerrit to be back up, b) me to post my blast of comments.15:13
efriedSome of them are actually going to be good.15:13
efriedSo Monday might be best :)15:13
* cdent withholds judgement15:13
cdentIf you suggest that consumers persist, I will get out a large knife and brandish it like a crazy person, throw it, and run away into the hills15:14
*** e0ne has quit IRC15:14
edleafecdent: so just another Friday15:15
cdentpretty much15:16
edleafeConsumers that don't consume - what a concept!15:16
mriedemwell i'd post my comments on the nested magic 1 spec but can't15:18
mriedemi'm not qualified to vote on it either way15:18
edleafemriedem: why not? Can't you pull a rabbit out of a hat?15:19
mriedemnot sure which comment that question is directed at15:19
mriedemassuming nested magic15:19
mriedemhence the rabbit, i get it15:19
cdentmriedem: if it makes insufficient sense for you to be able to vote or comment effectively, perhaps it needs to be improved and you should say so?15:20
cdentthat said, it seems to take about 27 years of indoctrination to participate in a topic that includes numa or nested, so something like 98 for both...15:21
mriedemif i actually had a thing i needed to implement then i could stand it up against the proposed change and see if it would solve my problem, but i don't, besides the resourceless request group stuff15:21
mriedemwhich is fairly straight-forward15:21
mriedemi just have a general feeling of dread for both performance in general (to account for handling these types of requests), the complexity in maintaining it, and weird edge cases we haven't thought of or hit yet, but won't until we actually have something using this, which is likely nova/cyborg15:22
mriedemand once we do,15:23
mriedemwe'll need even more query params to be like, "yeah so i want all of this stuff as before, but also now a new magical fairy unicorn knob b/c you're doing part of my thing wrong"15:23
mriedem"wrong"15:23
cdentI know that feeling well15:24
cdentI said much the same thing somewhere in the pre-ptg discussions15:24
mriedemi also tend to think that if the query param structure gets any more complicated than this, because of the need for more magical fairy unicorn knobs, we'll need to consider a json request payload15:24
mriedemjust to visualize the damn thing15:24
efried^ comes up pretty much every release15:25
edleafemriedem: agree. And I think that is a pretty strong smell15:25
edleafewhich is why I've generally pushed back againt it15:25
edleafe*against15:25
mriedemit's just an impl detail15:25
* efried chauffeurs while gerrit is down15:25
mriedemgiven my current state of corporate affairs i'm in a limbo of how much i need to care about numa or cyborg modeling in placement for that matter,15:26
cdentmriedem: speaking of visualisation, did you see this little toy a friend and I have been playing with: https://cdent.github.io/placeview/15:26
mriedemso i'm not overly concerned on this stuff just yet :)15:26
cdentmriedem: we need you to reivew and vote anyway, unless we want me or eric to be self voting15:27
mriedemi have not15:27
mriedemregarding the spec, i'm assuming tetsuro is much more on top of this stuff than i am15:27
cdentyes, that's true15:27
cdentbut you have a unique attention to detail skill that's very valuable, even when you don't "get it"15:28
mriedemask my wife for her opinion about that particular skill of mine15:29
cdentha! I'm sure she suffers greatly.15:31
openstackgerritMerged openstack/placement master: Bump openstackdocstheme to 1.30.0  https://review.opendev.org/66235615:41
cdentbbs15:45
*** cdent has quit IRC15:46
*** cdent has joined #openstack-placement15:51
*** ChanServ changes topic to "See https://docs.openstack.org/placement/latest/ and https://developer.openstack.org/api-ref/placement/"16:00
openstackgerritKashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits  https://review.opendev.org/65519316:02
mriedemgerrit is back yay, ok nested magic spec comments posted16:03
cdentthanks16:05
efriedcdent: done with review16:07
efriedof consumer types16:07
cdentskimming I see that I'm going to have to not skim before making a legit response as there's at least one thing that made me squirm16:09
cdentwill do that monday16:10
efriedcdent: Feel like approving https://review.opendev.org/#/c/655193/ before you head out?16:11
cdenti haven't been following that one closely, so I'd need to look properly given it had so much dancing16:11
efriedcouple separate efforts waiting on that, and depends-on doesn't work for reasons, so it would be nice to get that in a release.16:12
cdentwell, we wouldn't likely do a release on friday, so waiting on my +W for monday morn is probably safe16:13
*** mriedem is now known as mriedem_hangry16:14
cdentefried: I'm timed out, if some of the other os-traits stuff is close and you think so, point it out and I'll get what I can early monday and see about starting the release process16:21
efriedight16:21
* cdent waves16:25
*** cdent has quit IRC16:25
-openstackstatus- NOTICE: Gerrit is back up and running again. Thank you for your patience and sorry for the delay in this notification (we thought the statusbot was still busy updating channel topics).16:47
efriedstephenfin, mriedem_hangry: What problem are you seeing with that footnote? It wffm16:52
stephenfinefried: I was just going on what mriedem_hangry said but didn't check it myself16:52
*** amodi has joined #openstack-placement17:18
*** mriedem_hangry is now known as mriedem18:44
*** openstackgerrit has quit IRC19:01
*** amodi has quit IRC19:47
*** e0ne has joined #openstack-placement20:07
*** e0ne has quit IRC20:12
*** e0ne has joined #openstack-placement20:13
*** e0ne has quit IRC20:30
*** openstackgerrit has joined #openstack-placement20:55
openstackgerritEric Fried proposed openstack/placement master: Spec for nested magic 1  https://review.opendev.org/66219120:55
*** dklyle has quit IRC20:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!