| *** ttsiouts has joined #openstack-placement | 00:10 | |
| *** ttsiouts has quit IRC | 00:16 | |
| *** Sundar has quit IRC | 00:22 | |
| *** ttsiouts has joined #openstack-placement | 00:45 | |
| *** ttsiouts has quit IRC | 01:18 | |
| *** edleafe has quit IRC | 02:26 | |
| *** irclogbot_2 has quit IRC | 02:26 | |
| *** irclogbot_0 has joined #openstack-placement | 02:29 | |
| *** ttsiouts has joined #openstack-placement | 02:30 | |
| *** ttsiouts has quit IRC | 03:04 | |
| *** ttsiouts has joined #openstack-placement | 04:09 | |
| *** ttsiouts has quit IRC | 04:43 | |
| *** ttsiouts has joined #openstack-placement | 05:12 | |
| *** ttsiouts has quit IRC | 05:16 | |
| *** ttsiouts has joined #openstack-placement | 05:49 | |
| *** ttsiouts has quit IRC | 06:23 | |
| *** helenafm has joined #openstack-placement | 07:13 | |
| *** ttsiouts has joined #openstack-placement | 07:29 | |
| *** e0ne has joined #openstack-placement | 07:31 | |
| *** tssurya has joined #openstack-placement | 07:46 | |
| *** tssurya has quit IRC | 08:05 | |
| *** tssurya has joined #openstack-placement | 08:20 | |
| *** ttsiouts has quit IRC | 08:32 | |
| *** ttsiouts has joined #openstack-placement | 09:03 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Fixups from removing null provider protections https://review.opendev.org/660951 | 09:16 |
|---|---|---|
| *** ttsiouts has quit IRC | 09:37 | |
| *** cdent has joined #openstack-placement | 10:03 | |
| *** ttsiouts has joined #openstack-placement | 10:40 | |
| *** ttsiouts has quit IRC | 10:59 | |
| *** ttsiouts has joined #openstack-placement | 11:00 | |
| cdent | I turn my back for one minut and urllib3 breaks everything | 11:08 |
| *** ttsiouts has quit IRC | 11:14 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: DNM: perfload with written allocations https://review.opendev.org/660754 | 11:53 |
| openstackgerrit | Merged openstack/placement master: Change "Missing Root Provider IDs" upgrade check to a failure https://review.opendev.org/658164 | 12:08 |
| openstackgerrit | Merged openstack/placement master: Add blocker alembic migration for null root_provider_ids https://review.opendev.org/658182 | 12:08 |
| cdent | yay! | 12:08 |
| *** edleafe has joined #openstack-placement | 12:16 | |
| *** Sundar has joined #openstack-placement | 12:17 | |
| *** Sundar has quit IRC | 12:17 | |
| *** ttsiouts has joined #openstack-placement | 12:28 | |
| *** e0ne has quit IRC | 12:57 | |
| *** ttsiouts has quit IRC | 12:58 | |
| *** mriedem has joined #openstack-placement | 13:03 | |
| *** Sundar has joined #openstack-placement | 13:45 | |
| *** ttsiouts has joined #openstack-placement | 14:02 | |
| openstackgerrit | Merged openstack/placement master: Remove null root provider protections https://review.opendev.org/657716 | 14:09 |
| cdent | yay! | 14:15 |
| efried | \o/ | 14:25 |
| *** ttsiouts has quit IRC | 14:36 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Avoid traversing summaries in _check_traits_for_alloc_request https://review.opendev.org/660691 | 14:47 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Use trait strings in ProviderSummary objects https://review.opendev.org/660692 | 14:47 |
| *** helenafm has quit IRC | 15:31 | |
| *** tssurya has quit IRC | 15:35 | |
| *** ttsiouts has joined #openstack-placement | 15:43 | |
| *** ttsiouts has quit IRC | 15:45 | |
| *** ttsiouts has joined #openstack-placement | 15:46 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: DNM: perfload with written allocations https://review.opendev.org/660754 | 15:59 |
| openstackgerrit | Ed Leafe proposed openstack/placement master: Fix typo in usage-policy.yaml https://review.opendev.org/661044 | 16:05 |
| edleafe | Trivial typo fix ^^ | 16:05 |
| cdent | edleafe: what version of yaml and python were you using when it failed? | 16:06 |
| edleafe | It was in my feature branch, with python 3.6 (not sure of yaml) | 16:06 |
| cdent | I think it was probably failing for other reasons then because the test is just bad. With the typo the url is http://049653a2-9f4b-4259-a797-f2da73582f70:8001/usages?project_id=$ENVIRON['PROJECT_ID] | 16:08 |
| edleafe | it came over the wire as the literal string: $ENVIRON['PROJECT_ID] | 16:08 |
| cdent | jinx | 16:08 |
| edleafe | yep | 16:08 |
| cdent | there probably needs to be some actual usages in order for it to be proper | 16:08 |
| edleafe | Just wondering how it ever merged like that | 16:09 |
| cdent | it does work | 16:09 |
| cdent | because that's a valid project id | 16:09 |
| cdent | (which don't limit it to uuid because of reasons) | 16:09 |
| edleafe | Hmmm... | 16:09 |
| edleafe | Oh, I see - I was using string formatting to add it to a query, and the presence of single quotes is what screwed it up | 16:10 |
| edleafe | i.e., uuid: '$ENVIRON['PROJECT_ID']' | 16:10 |
| cdent | the value of the queries don't really matter in the test becuase it's just trying to check that you can access the url | 16:10 |
| * cdent fast approves | 16:11 | |
| cdent | nice find | 16:13 |
| cdent | all this looking at the code is going to find all sorts of gems | 16:13 |
| *** cdent has quit IRC | 16:15 | |
| *** ttsiouts has quit IRC | 16:16 | |
| edleafe | Found the same typo in usage.yaml. Must have been a coppa pasta thing | 16:45 |
| edleafe | I'd combine them, but https://review.opendev.org/#/c/661044/ is already +W'd | 16:46 |
| *** ttsiouts has joined #openstack-placement | 16:48 | |
| *** ttsiouts has quit IRC | 16:53 | |
| openstackgerrit | Ed Leafe proposed openstack/placement master: Fix typo in usage.yaml https://review.opendev.org/661052 | 16:55 |
| edleafe | Second typo ^^ | 16:55 |
| efried | edleafe: You can still combine | 17:11 |
| efried | I'll fast approve | 17:11 |
| *** ttsiouts has joined #openstack-placement | 17:26 | |
| *** e0ne has joined #openstack-placement | 17:29 | |
| openstackgerrit | Merged openstack/placement master: Fixups from removing null provider protections https://review.opendev.org/660951 | 17:35 |
| edleafe | efried: How? I thought only cdent could stop it at that point | 17:39 |
| efried | edleafe: no, just propose a new ps and it yanks it out of the gate. | 17:39 |
| edleafe | efried: TIL | 17:39 |
| *** wwriverrat has joined #openstack-placement | 17:53 | |
| *** ttsiouts has quit IRC | 17:59 | |
| efried | edleafe: soooo.... are you going to do that? | 18:06 |
| efried | oh, I guess mriedem already approved the second patch too. shrug | 18:07 |
| edleafe | Uh, I already pushed the second. I was going to just let it be, but if you think it's cleaner... | 18:07 |
| efried | edleafe: neither patch has gotten a zuul node yet, so you'd be doing the gate a small favor by consolidating | 18:08 |
| efried | but up to you. | 18:08 |
| openstackgerrit | Ed Leafe proposed openstack/placement master: Fix typo in usage.yaml and usage-policy.yaml https://review.opendev.org/661044 | 18:10 |
| edleafe | efried: done | 18:10 |
| efried | edleafe: thanks, +A | 18:12 |
| *** klindgren has quit IRC | 18:13 | |
| *** klindgren has joined #openstack-placement | 18:14 | |
| *** mriedem has quit IRC | 18:37 | |
| *** mriedem has joined #openstack-placement | 18:43 | |
| *** e0ne has quit IRC | 18:53 | |
| *** e0ne has joined #openstack-placement | 18:54 | |
| *** ttsiouts has joined #openstack-placement | 19:09 | |
| *** tssurya has joined #openstack-placement | 19:39 | |
| *** e0ne has quit IRC | 19:39 | |
| *** ttsiouts has quit IRC | 19:42 | |
| *** ttsiouts has joined #openstack-placement | 20:56 | |
| *** Sundar has quit IRC | 21:06 | |
| *** Sundar has joined #openstack-placement | 21:18 | |
| *** ttsiouts has quit IRC | 21:26 | |
| *** ttsiouts has joined #openstack-placement | 21:42 | |
| openstackgerrit | Eric Fried proposed openstack/placement master: WIP: Spec for nested magic https://review.opendev.org/658510 | 22:09 |
| *** Sundar has quit IRC | 22:12 | |
| *** mriedem has quit IRC | 22:13 | |
| openstackgerrit | Eric Fried proposed openstack/placement master: Spec for nested magic https://review.opendev.org/658510 | 22:27 |
| efried | edleafe, tetsuro, cdent, tssurya, mriedem, Sundar, gibi: This ^ is complete, un-WIP, ready for real review. (NB: Latest PS I took liberties with the template to make it better organized and more readable. I think this is okay build-wise because we don't have the openstack-specs-jobs template in placement, but we'll see.) | 22:29 |
| edleafe | efried: heading out now, but opened in a tab to enjoy with morning coffee | 22:30 |
| efried | thanks | 22:31 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Gabbi test cases for can_split https://review.opendev.org/658192 | 22:35 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/661131 | 22:55 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Fix typo in usage.yaml and usage-policy.yaml https://review.opendev.org/661044 | 22:56 |
| openstackgerrit | Eric Fried proposed openstack/placement master: Canary test for os-traits version https://review.opendev.org/661132 | 23:03 |
| efried | edleafe: FYI, your test failures were not from your patch. Fixed and rebased accordingly ^ | 23:06 |
| *** tssurya has quit IRC | 23:38 | |
| *** ttsiouts has quit IRC | 23:42 | |
| *** ttsiouts has joined #openstack-placement | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!