Thursday, 2019-03-28

tetsurogood morning00:30
openstackgerritTetsuro Nakamura proposed openstack/placement master: Spec: Support filtering by forbidden aggregates 1  https://review.openstack.org/64770401:11
openstackgerritTetsuro Nakamura proposed openstack/placement master: Spec: Support filtering by forbidden aggregates 2  https://review.openstack.org/64770501:11
*** jaypipes has quit IRC05:09
*** jaypipes has joined #openstack-placement05:09
*** tetsuro has quit IRC05:35
*** e0ne has joined #openstack-placement07:17
*** e0ne has quit IRC07:19
*** tetsuro has joined #openstack-placement07:46
*** ttsiouts has joined #openstack-placement07:50
*** gryf has quit IRC07:59
*** tssurya has joined #openstack-placement08:03
openstackgerritTetsuro Nakamura proposed openstack/placement master: Negative member_of query with microversion 1.32  https://review.openstack.org/64139308:09
openstackgerritTetsuro Nakamura proposed openstack/placement master: Refactor ResourceProviderListTestCase  https://review.openstack.org/64833908:09
openstackgerritTetsuro Nakamura proposed openstack/placement master: Refactor ResourceProviderListTestCase  https://review.openstack.org/64833908:15
*** ttsiouts has quit IRC08:26
*** ttsiouts has joined #openstack-placement08:26
*** helenafm has joined #openstack-placement08:28
*** takashin has left #openstack-placement08:30
*** ttsiouts has quit IRC08:30
*** ttsiouts has joined #openstack-placement09:01
openstackgerritTetsuro Nakamura proposed openstack/placement master: Negative member_of query with microversion 1.32  https://review.openstack.org/64139309:35
openstackgerritTetsuro Nakamura proposed openstack/placement master: Refactor ResourceProviderListTestCase  https://review.openstack.org/64833909:35
openstackgerritTetsuro Nakamura proposed openstack/placement master: Fix debug log getting allocation_candidates  https://review.openstack.org/64835709:43
*** e0ne has joined #openstack-placement09:47
*** cdent has joined #openstack-placement10:01
openstackgerritTetsuro Nakamura proposed openstack/placement master: Refactor aggregate _get_trees_matching_all()  https://review.openstack.org/64836310:01
cdenttetsuro, gibi, stephenfin: If you get a chance today to look at the stack of "how to placement" starting https://review.openstack.org/#/c/647788/ that would be good. I'd prefer that we have all had a look and decided it is okay before we merge it.10:03
* cdent coffees10:03
tetsurosure, I will have a look.10:05
*** tetsuro has quit IRC10:11
gibicdent: would it be possible to add a untriaged bug query link to the doc here? https://review.openstack.org/#/c/647789/2/doc/source/contributor/contributing.rst@5710:21
*** melwitt has quit IRC10:26
*** e0ne has quit IRC10:31
*** melwitt has joined #openstack-placement10:32
*** e0ne has joined #openstack-placement10:36
gibicdent: went though the contributor doc patch series. Nice doc. I left suggestion here and there10:40
*** ttsiouts has quit IRC10:57
*** ttsiouts has joined #openstack-placement10:57
*** e0ne has quit IRC10:58
*** ttsiouts has quit IRC11:02
*** e0ne has joined #openstack-placement11:05
*** cdent has quit IRC11:21
jaypipesefried, edleafe, dansmith: morning. responded on https://review.openstack.org/#/c/648147/. please forgive me, I wasn't aware of this new approach before yesterday. let me know if I summarized the two approaches appropriately in my comment on the patch, please. I'm fine either way, I guess. was just surprised by the approach due to being out for a couple weeks and remembering a different decision being made at the PTGs.11:27
*** cdent has joined #openstack-placement11:27
*** ttsiouts has joined #openstack-placement12:08
openstackgerritChris Dent proposed openstack/placement master: Fill in the bugs section of contributing.rst  https://review.openstack.org/64778912:23
openstackgerritChris Dent proposed openstack/placement master: Fill in reviewing section of contributing.rst  https://review.openstack.org/64779012:23
openstackgerritChris Dent proposed openstack/placement master: Fill in the New Features section of contributing.rst  https://review.openstack.org/64811312:23
openstackgerritChris Dent proposed openstack/placement master: Fill in the Writing Code section of contributing.rst  https://review.openstack.org/64817612:23
*** e0ne has quit IRC12:41
*** e0ne has joined #openstack-placement12:43
sean-k-mooneyjaypipes: to avoid addtional surprise and invite input im propose a similar approch here https://review.openstack.org/#/c/647578/12:52
openstackgerritChris Dent proposed openstack/osc-placement master: Update home-page  https://review.openstack.org/63005313:12
*** ttsiouts has quit IRC13:13
*** ttsiouts has joined #openstack-placement13:13
*** ttsiouts has quit IRC13:18
*** e0ne has quit IRC13:20
efriedjaypipes: Responded. Good discussion.13:34
*** ttsiouts has joined #openstack-placement13:40
efriedgibi: got time to relook at https://review.openstack.org/#/c/647789/ series? Easy updates, should be quick +A all the way up.13:46
efriedoh, you're on it.13:46
gibiefried: on it, an on a meeting in parallel :)13:47
openstackgerritMerged openstack/placement master: Add initial framing for a contributing doc  https://review.openstack.org/64778813:48
efriedcdent: fungi raises an interesting point: I assume we're not doing anything to make placement specs publish to specs.o.o rather than docs.o.o13:48
cdentefried: correct we are not publishing to specs.o.o. That's an acknowledged situation that may or may or may not be a limitation13:49
cdentgiven our predilection for using specs and aux docs, I think it's fine13:49
cdentI don't see the branching issue as an issue (for us)13:50
*** ttsiouts has quit IRC13:50
*** ttsiouts has joined #openstack-placement13:51
efriedagree updates to a spec implemented in $release should wind up in $release, even if that means backporting the spec update itself. But that's fine.13:51
efriedbecomes like any doc update really.13:52
jaypipessean-k-mooney: ack, thanks for the heads up. will review.13:54
cdentI don't see a strong need for nova to change. Nothing is broken by leaving things as they are, is it?13:54
efriednot really13:54
efriedmore work than benefit13:54
efriedif you mean the part about moving specs into the main repo13:54
openstackgerritAbhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance  https://review.openstack.org/64121013:55
efriedbetter tracking of future/backlog and rejected/dead blueprints is still something I want to do.13:55
*** ttsiouts has quit IRC13:55
cdentyeah, agree that having a place to save ideas make sense13:57
sean-k-mooneycdent: efried i just replied on the mailing list by the way in the context of the future of nova specs/blueprits13:57
efriedyup, I'm caught up.14:00
efriedsean-k-mooney: I don't disagree that it would be workable to consolidate specs into the nova repo, but I don't think we would gain anything significant from it to make it worth the legwork of doing it.14:01
*** ttsiouts has joined #openstack-placement14:01
sean-k-mooneyefried: well the main benifit i see is discoverablity and in the case where we have work item list in the spec you can mark those items as done as you proceed14:02
sean-k-mooneybut in the hopefully rare event where we need to update the spec after approval it also allows that update to be linked with the patch that cause teh change.14:05
sean-k-mooneycdent: and no there isnt a stong need for nova to change. stephenfin and i wanted to propose the change before the nova-core group was added to nova-spec-core14:11
* cdent has limited skin in this game14:11
cdentI made statement in the spirit of "there's a lot to do, why add more?"14:12
sean-k-mooneyah well most of my reaon for doing it went away with the addtion of nova-core to nova-specs-core14:12
stephenfinefried, sean-k-mooney: I tried doing it. It's a lot of work, especially if we want to keep history14:13
stephenfinfor rather limited ROI14:13
sean-k-mooneystephenfin: you can use the old oslo incubator script to help but ya14:13
efriedstephenfin: Mm, I hadn't considered history. I thought about moving the existing specs wholesale from the specs repo, but yeah, we would lose the git chain that way.14:13
efriedyeah, unless we do the magic that edleafe and cdent did to seed the placement repo14:14
stephenfinyou could do git magic but it's awkward14:14
stephenfinon account of nova being an existing repo14:14
stephenfinand the two repos not sharing a common commit14:14
efriedSo yeah, unless there's more benefit than what we've discussed so far, IMO we should leave it.14:14
sean-k-mooneyyou can do it relitivly simplely but yuou end up with 2 git roots and you either need a force push or need to revew each pathc14:14
sean-k-mooneyso is somewhat painful14:14
sean-k-mooneystephenfin: care to remove it form the PTG agenda so14:15
sean-k-mooneymost of my desire for it was to encourcage more cores and non cores to read and review specs14:16
stephenfinsean-k-mooney: Aye, I was trying to find this article https://www.destroyallsoftware.com/blog/2017/the-biggest-and-weirdest-commits-in-linux-kernel-git-history14:16
sean-k-mooneystephenfin: you should look at some of the history of networking-ovs-dpdk we ported some neutron code into it with the history a few time and then decided it was too much hassel to continue so stopped14:17
stephenfinsean-k-mooney: Sure, done14:17
*** ttsiouts has quit IRC14:17
*** ttsiouts has joined #openstack-placement14:18
*** ttsiouts has quit IRC14:22
*** ttsiouts has joined #openstack-placement14:29
*** e0ne has joined #openstack-placement14:38
openstackgerritMerged openstack/osc-placement master: Update home-page  https://review.openstack.org/63005314:41
openstackgerritMerged openstack/placement master: Add link to case studies in alloc_cands api-ref  https://review.openstack.org/64771614:42
*** edleafe_ has joined #openstack-placement15:00
*** e0ne has quit IRC15:14
*** edleafe_ has quit IRC15:17
*** e0ne has joined #openstack-placement15:20
dansmithjaypipes: ack; details in the nova spec may help clear things up if you haven't read it15:24
dansmithcdent: it sounds like you're leaning towards nixing the SUPPORT_ stem right?15:26
cdentdansmith: not quite. It's more like I want someone who has a stronger opinion to express one so that I don't have decide because my native inclination is to just go with whatever but I fear that as soon as that happens someone will surface and be all "omg, how could you?"15:28
dansmithokay I dgaf either.. so hopefully someone with gaf or we can not dwell on indecision :)15:28
dansmith*will15:29
cdenti figure if nothing happens tomorrow, the people's have spoken by not speaking and we just go with it15:30
dansmithaight15:30
jaypipesdansmith, cdent: I'm not bothered by the SUPPORT_ thing, but I do think COMPUTE_IMAGE_TYPE_AMI is fine as well.15:31
dansmithheh okay15:31
cdentgood thing we're not working an emergency room15:32
jaypipeslol15:32
jaypipesplacemergency.15:32
* cdent adds to lexicon15:33
cdentedleafe: do you have an opinion? You think about names sometimes...15:34
* edleafe is typing on the review right now...15:35
cdenthuzzah15:37
edleafeYou might want to hold the huzzah...15:37
dansmithbtw, on the aggregate vs traits question,15:39
dansmithwe really can't make it "just work" if we go the aggregate route because compute nodes can't and shouldn't be changing their own aggregate membership nor attributes of those15:40
*** e0ne has quit IRC15:40
dansmithso either we do this to enforce a "it never makes sense to send an unsupportable image to a compute", or we do the same in a terribly inefficient scheduler filter which won't work for people like cern, or we make admins do this all manually15:41
edleafedansmith: that's a good analysis perspective. My only point is that from a placement/os-traits POV, either approach should be fine.15:42
dansmithyeah, I know, I'm just saying why I think this does need to be traits-based, not that anyone is really arguing15:43
cdentcdent: I'm a pluralist, I'll huzzah opinion giving, even I don't agree with the opinion15:43
edleafeSo it should be up to the nova/glance/cinder teams to determine which would work best15:43
dansmithcdent: I think his point was he wasn't helping push it either direction15:43
edleafedansmith: bingo15:43
cdentUgh, I'm tired, I jusg pinged myself instead of ed15:43
edleafecdent: as long as you don't start private messaging yourself...15:44
cdentI should consider that15:44
cdentdansmith: I'm ready to make a judgement, based on the total lack of opinions from anyone:15:45
cdentnobody is saying SUPPORT needs to be there, so take it out15:45
cdentHow's that?15:45
dansmithI keep trying to justify why it should be there, but I can't really15:46
dansmithmy reasoning was around the multiple-ness of it15:46
cdentthen we can merge this thing, make a release and what ed says about it being not os-traits problem anymore can be true15:46
dansmithbut traits are kinda that way anyway15:46
cdentyeah15:46
openstackgerritMerged openstack/placement master: Fix debug log getting allocation_candidates  https://review.openstack.org/64835715:49
openstackgerritMerged openstack/placement master: Document alloc-candidates-in-tree  https://review.openstack.org/64730915:49
openstackgerritDan Smith proposed openstack/os-traits master: Add COMPUTE_IMAGE_TYPE_* traits  https://review.openstack.org/64814715:54
dansmithcdent: ^15:54
cdentword15:54
cdentyeah, that looks much less dumb, somehow15:56
edleafeWow, what a compliment!15:56
edleafe:)15:56
cdentso, the way I'm checking that this are kosher is import os_traits and the doing a dir() on the module15:57
cdentwhich lists all the traits, and with SUPPORT stacked up in there it looked, well, dumb15:58
cdentin both the sense of "stupid" as well "as unable to express"15:58
openstackgerritMerged openstack/placement master: Fill in the bugs section of contributing.rst  https://review.openstack.org/64778915:59
openstackgerritMerged openstack/placement master: Fill in reviewing section of contributing.rst  https://review.openstack.org/64779015:59
* dansmith is greatly offended15:59
cdenti bet16:01
openstackgerritMerged openstack/os-traits master: Add COMPUTE_IMAGE_TYPE_* traits  https://review.openstack.org/64814716:22
*** ttsiouts has quit IRC16:24
dansmithactual huzzah16:25
*** tssurya has quit IRC16:27
*** e0ne has joined #openstack-placement16:27
efrieddansmith: https://review.openstack.org/#/c/648147/4/os_traits/compute/image.py@14 if you agree, I can propose that if you like.16:39
*** helenafm has quit IRC16:40
dansmithand if I don't? :)16:40
efriedwhat would the objection be?16:42
efriedI guess I can propose it and you can shoot it down in gerrit.16:42
dansmithefried: oh I have no objection, you just gave me a choice so I'm exploring options :)16:46
openstackgerritEric Fried proposed openstack/os-traits master: Add contextual comment about image type traits  https://review.openstack.org/64846616:46
efriedalright punk ^16:46
* dansmith gasps at the language16:47
efriedThat was the edited-for-TV version. You should see all the responses I typed and then deleted.16:48
dansmithI noticed your lips were mouthing a different word than your fingers.. I hate that.16:48
cdentthis is the description of "idependent" when it comes to release types: https://releases.openstack.org/reference/release_models.html#independent I think it is probably better for os-traits and os-resource-classes. If you disagree, shout. (I'll ask on the pupdate too)16:51
cdentand I'll try to spell independent correctly16:51
dansmithobvi16:52
edleafeefried: can I assume that that list of disk formats will only grow, and never remove any?16:55
dansmithcdent: I assume this will be os-traits 0.9.0 right?16:56
cdent0.12.0 (0.11.0 is the version on the pypi right now)16:56
dansmithedleafe: I suppose if glance were to stop supporting one it would shrink, but I kinda doubt that would happen16:56
efriededleafe: I would think so.16:56
dansmithoh okay16:56
efriededleafe: I suspect you're saying that comment could be extended to say, "but don't ever remove any, even if glance does"16:57
dansmithedleafe: efried I would expect the trait list to never shrink16:57
dansmithyeah16:57
efriedagree with that16:57
cdentdansmith: it would not surprise me if some requirements.txt file somewhere didn't get updated16:57
dansmithcdent: yeah current nova is 0.8.016:57
cdentremoving traits is not allowed16:57
edleafeefried: yeah, I wasn't sure if some formats were deigned to be "archaic" and no longer listed.16:58
cdentso saying in the comment would be somewhat redundant16:58
efriedcdent: Not sure I agree about os-* being independent.16:58
cdentwhy?16:58
cdentthe reason is so we can release every time we update it16:58
efriedso we never have to tag stable e.g.?16:59
dansmiththere would never be a reason to have a stable os-traits, that I can think of16:59
efriedMeh, I guess I could be convinced. What does #openstack-release have to say about it?16:59
cdentthey suggested it16:59
efriedoh, well then.16:59
efried++16:59
dansmithlol16:59
cdentefried: I remain curious/confused why you were concerned?17:00
dansmithyou gave him the choice and he's exploring options? :D17:01
* cdent reevaluated pluralism17:01
efriedcdent: because I was thinking about who consumes those and how they're going to care about "stability" as release cutoffs approach.17:02
efriedos-* should be fairly stable17:02
efriedbut there was a recent snafu in os-brick that has me a bit paranoid on that front.17:02
dansmithos-brick is an actual library17:02
efriedanyway, it's not a big deal; releasing with every change makes sense.17:02
cdentos-brick actually does things, yeah?17:02
dansmiththis is a public add-only enum17:02
efriedin this case it was a very similar change in os-brick, just aliasing some consts17:03
efrieddoes 'independent' still get bot proposals to u-c?17:04
* cdent doesn't know how that process works for any style of release17:05
*** e0ne has quit IRC17:07
*** e0ne has joined #openstack-placement17:08
openstackgerritMerged openstack/placement master: Fill in the New Features section of contributing.rst  https://review.openstack.org/64811317:08
openstackgerritMerged openstack/placement master: Fill in the Writing Code section of contributing.rst  https://review.openstack.org/64817617:09
openstackgerritMerged openstack/placement master: Spec: Support filtering by forbidden aggregates 1  https://review.openstack.org/64770417:09
openstackgerritMerged openstack/placement master: Spec: Support filtering by forbidden aggregates 2  https://review.openstack.org/64770517:09
*** e0ne has quit IRC17:17
openstackgerritMerged openstack/os-traits master: Add contextual comment about image type traits  https://review.openstack.org/64846617:18
openstackgerritMerged openstack/placement master: Prepare for negative member_of queryparam  https://review.openstack.org/64139117:18
*** e0ne has joined #openstack-placement17:21
*** e0ne has quit IRC17:45
*** Sundar has joined #openstack-placement17:57
*** e0ne has joined #openstack-placement19:33
*** jaypipes_ has joined #openstack-placement19:54
*** jaypipes has quit IRC19:54
*** e0ne has quit IRC20:00
*** efried has quit IRC20:22
*** efried has joined #openstack-placement20:26
*** cdent has quit IRC20:27
*** efried has quit IRC20:44
*** takashin has joined #openstack-placement20:54
*** efried has joined #openstack-placement20:58
*** openstackgerrit has quit IRC21:07
*** efried has quit IRC21:09
*** openstackgerrit has joined #openstack-placement21:20
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for API policy updates  https://review.openstack.org/54785021:20
*** efried has joined #openstack-placement21:23
*** Sundar has quit IRC23:15
*** takashin has quit IRC23:20

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!