| *** takashin has joined #openstack-placement | 00:01 | |
| openstackgerrit | Merged openstack/placement master: Move ResourceClass and ResourceClassList to own module https://review.openstack.org/641432 | 00:24 |
|---|---|---|
| openstackgerrit | Merged openstack/placement master: Remove the ResourceClassList class https://review.openstack.org/641433 | 00:24 |
| *** ttsiouts has quit IRC | 00:28 | |
| *** ttsiouts has joined #openstack-placement | 00:29 | |
| *** ttsiouts has quit IRC | 00:33 | |
| *** mriedem_away is now known as mriedem | 00:54 | |
| *** mriedem has quit IRC | 01:04 | |
| *** Sundar has quit IRC | 01:38 | |
| *** takashin has left #openstack-placement | 05:30 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Prepare for negative member_of queryparam https://review.openstack.org/641391 | 07:03 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Prepare for negative member queryparam 2 https://review.openstack.org/641392 | 07:03 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Negative member_of query with microversion 1.32 https://review.openstack.org/641393 | 07:03 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Turn max-complexity back to 14 https://review.openstack.org/641958 | 07:52 |
| *** tssurya has joined #openstack-placement | 08:28 | |
| *** ttsiouts has joined #openstack-placement | 08:32 | |
| *** ttsiouts has quit IRC | 08:37 | |
| *** ttsiouts has joined #openstack-placement | 08:42 | |
| *** mcgiggler has joined #openstack-placement | 09:03 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Move Trait and TraitList to own module https://review.openstack.org/641500 | 09:49 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Update get trait and traits calls that were writers to reader https://review.openstack.org/641501 | 09:49 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Remove the TraitList class https://review.openstack.org/641663 | 09:49 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Move allocation candidate classes and methods https://review.openstack.org/641788 | 09:49 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Reorder classes and methods in allocation_candidate https://review.openstack.org/641789 | 09:49 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Move Trait and TraitList to own module https://review.openstack.org/641500 | 09:55 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Update get trait and traits calls that were writers to reader https://review.openstack.org/641501 | 09:55 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Remove the TraitList class https://review.openstack.org/641663 | 09:55 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Move allocation candidate classes and methods https://review.openstack.org/641788 | 09:55 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Reorder classes and methods in allocation_candidate https://review.openstack.org/641789 | 09:55 |
| *** cdent has joined #openstack-placement | 10:30 | |
| *** cdent has quit IRC | 11:33 | |
| *** mcgiggler has quit IRC | 12:18 | |
| *** ttsiouts has quit IRC | 12:19 | |
| *** ttsiouts has joined #openstack-placement | 12:20 | |
| *** cdent has joined #openstack-placement | 12:21 | |
| *** ttsiouts has quit IRC | 12:24 | |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | 12:31 |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | 12:39 |
| *** ttsiouts has joined #openstack-placement | 12:44 | |
| *** mriedem has joined #openstack-placement | 13:38 | |
| *** cdent has quit IRC | 14:06 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.openstack.org/642030 | 14:24 |
| *** mcgiggler has joined #openstack-placement | 14:24 | |
| *** cdent has joined #openstack-placement | 14:41 | |
| *** s10 has joined #openstack-placement | 14:50 | |
| *** efried is now known as fried_rice | 14:51 | |
| cdent | fried_rice: in case you care, I'll either miss or be late to monday's meeting. just published a pupdate with what I'm aware of | 14:53 |
| cdent | mriedem: when you get a moment could you check to see if you agree with the analysis in https://storyboard.openstack.org/#!/story/2005168 (about policy initialization in placement) | 15:10 |
| cdent | no rush | 15:10 |
| mriedem | umm, seems fine...i just copied all of that framework stuff from nova and it's possible i missed something or nova also has a latent bug | 15:13 |
| cdent | I would guess nova probably has it too, but it doesn't get exercised because the concurrency hit that the perfload job makes doesn't happen much in the real world | 15:15 |
| fried_rice | cdent: ack | 15:18 |
| *** s10 has quit IRC | 15:32 | |
| *** s10 has joined #openstack-placement | 15:32 | |
| *** s10 has quit IRC | 15:32 | |
| *** s10 has joined #openstack-placement | 15:33 | |
| *** s10 has quit IRC | 15:33 | |
| *** s10 has joined #openstack-placement | 15:34 | |
| *** s10 has quit IRC | 15:34 | |
| *** s10 has joined #openstack-placement | 15:34 | |
| *** s10 has quit IRC | 15:35 | |
| *** s10 has joined #openstack-placement | 15:35 | |
| *** s10 has quit IRC | 15:36 | |
| *** s10 has joined #openstack-placement | 15:36 | |
| *** s10 has quit IRC | 15:36 | |
| *** s10 has joined #openstack-placement | 15:37 | |
| *** s10 has quit IRC | 15:37 | |
| *** s10 has joined #openstack-placement | 15:38 | |
| *** s10 has quit IRC | 15:38 | |
| *** s10 has joined #openstack-placement | 15:38 | |
| *** s10 has quit IRC | 15:39 | |
| *** s10 has joined #openstack-placement | 15:39 | |
| *** s10 has quit IRC | 15:40 | |
| *** s10 has joined #openstack-placement | 15:40 | |
| *** s10 has quit IRC | 15:40 | |
| *** s10 has joined #openstack-placement | 15:41 | |
| mriedem | btw, | 15:41 |
| *** s10 has quit IRC | 15:41 | |
| mriedem | it's great that i have to re-learn html from 15 years ago to use storyboard | 15:41 |
| *** s10 has joined #openstack-placement | 15:42 | |
| *** s10 has quit IRC | 15:42 | |
| *** s10 has joined #openstack-placement | 15:42 | |
| cdent | markdown. you almost got it | 15:43 |
| *** s10 has quit IRC | 15:43 | |
| cdent | ``` instead of `` | 15:43 |
| cdent | at least you get some formatting, unlike launchpad... | 15:43 |
| *** s10 has joined #openstack-placement | 15:43 | |
| *** s10 has quit IRC | 15:44 | |
| *** s10 has joined #openstack-placement | 15:44 | |
| *** s10 has quit IRC | 15:44 | |
| *** s10 has joined #openstack-placement | 15:45 | |
| *** s10 has quit IRC | 15:45 | |
| *** fried_rice is now known as efried_afk | 15:48 | |
| cdent | pug attack! | 16:02 |
| *** efried_afk is now known as fried_rice | 16:16 | |
| fried_rice | wha | 16:16 |
| cdent | a bunch of pugs came into this cafe | 16:18 |
| *** sean-k-mooney has quit IRC | 16:23 | |
| *** belmoreira has quit IRC | 16:34 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.openstack.org/642030 | 16:34 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Make policy init more threadsafe https://review.openstack.org/642068 | 16:36 |
| cdent | edleafe: you still interested in pursuing the inventory -> inventory.py stuff? | 16:43 |
| edleafe | cdent: Sure, I can take that if you like | 16:44 |
| cdent | it's more a question of do you want it, if not I'll just do it (now ish) | 16:44 |
| edleafe | Not wanting to sound lazy, but if you already have the mental path forward, it might be easier for you | 16:45 |
| edleafe | I was just trying to ease your workload a bit | 16:45 |
| cdent | my brain is pretty oriented that way, and I'm itching to have it done, so yeah, I'll do it. You can plan the next great butter churn | 16:46 |
| edleafe | Mmmmmm... butter... | 16:46 |
| *** ttsiouts has quit IRC | 16:58 | |
| *** e0ne has joined #openstack-placement | 17:03 | |
| *** e0ne has quit IRC | 17:08 | |
| *** mriedem is now known as mriedem_burgers | 17:43 | |
| *** fried_rice is now known as fried_rolls | 17:43 | |
| *** cdent has quit IRC | 17:47 | |
| *** mcgiggler has quit IRC | 17:51 | |
| *** tssurya has quit IRC | 17:55 | |
| *** cdent has joined #openstack-placement | 18:24 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Move Inventory and InventoryList to own file https://review.openstack.org/642111 | 18:59 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Remove InventoryList class https://review.openstack.org/642112 | 18:59 |
| *** mriedem_burgers is now known as mriedem | 19:16 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Reorder objects.resource_provider https://review.openstack.org/642137 | 20:11 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Remove ResourceProviderList class https://review.openstack.org/642138 | 20:11 |
| cdent | jaypipes, fried_rolls, edleafe that's ^ the end of the remove list stack | 20:11 |
| edleafe | cdent: ack | 20:12 |
| fried_rolls | woot | 20:12 |
| jaypipes | cdent: coo. | 20:12 |
| cdent | the reorder one is hairy, but nothing actually changes | 20:13 |
| *** irclogbot_2 has quit IRC | 20:13 | |
| *** e0ne has joined #openstack-placement | 20:24 | |
| fried_rolls | cdent: ya know, a thing that worries me about all this is that it will probably make the git blame game a lot harder. | 20:54 |
| cdent | yes, it will. backports too. but costs and benefits and all that. | 20:55 |
| cdent | the git blame side was already pretty messy | 20:55 |
| cdent | to some extent it is better to get it over with | 20:55 |
| fried_rolls | yeah, I suppose. | 20:56 |
| *** fried_rolls is now known as fried_rice | 20:56 | |
| fried_rice | ^oops | 20:56 |
| *** e0ne has quit IRC | 21:03 | |
| cdent | digging around in profile information for GET /allocation_candidates is _fascinating_ | 21:47 |
| fried_rice | cdent: what do you mean, profile information? | 21:55 |
| fried_rice | oh, you mean performance | 21:55 |
| fried_rice | I'm interested | 21:55 |
| cdent | I've stuck http://werkzeug.pocoo.org/docs/0.14/contrib/profiler/ in placement, and am viewing the results with https://jiffyclub.github.io/snakeviz/ | 21:56 |
| fried_rice | but first: how do you feel about making placement.objects.resource_provider a package containing inventory, aggregate, and maybe others | 21:57 |
| fried_rice | as a way to further split up resource_provider.py which is still 2KLOC | 21:58 |
| cdent | it would be nice to make it smaller | 22:02 |
| fried_rice | I can play with that after we make a call on https://review.openstack.org/#/c/642137/1 | 22:04 |
| fried_rice | cause I'm not convinced we should do that. | 22:04 |
| cdent | yeah, I'm not entirely convinced either, but was in that sort of automatic just-do-it thing | 22:06 |
| cdent | If you're intrigued by the idea of splitting it up, then that certainly removes any urgency to make it ordered | 22:06 |
| fried_rice | We should at least reverse the top two patches, but if we start doing other things below it (like what I'm talking about) it's going to be a nightmare to keep rebased. | 22:18 |
| cdent | fried_rice: if you think you will do the split up, then I'll just remove the reordering entirely, if you agree? | 22:39 |
| *** irclogbot_2 has joined #openstack-placement | 23:01 | |
| *** edleafe_ has quit IRC | 23:24 | |
| fried_rice | cdent: let us make it so. | 23:35 |
| cdent | righyho | 23:35 |
| cdent | once I climb out of this little hole I've found myself in | 23:35 |
| fried_rice | How do you feel about the pure resource provider stuff living in __init__.py? This is the only part I haven't figured out yet. | 23:36 |
| fried_rice | That would make zero refactor in the things referring to those bits | 23:36 |
| fried_rice | but having stuff in __init__.py is kind of... not don? | 23:36 |
| fried_rice | done | 23:36 |
| cdent | It depends a ton on who you talk to and where it is happening. If you have deep hierarchy it can be really annoying | 23:40 |
| cdent | or if the init does things (you may recall me moving a bunch of wsgi-related stuff out of nova's various __init__ | 23:40 |
| fried_rice | This one wouldn't. | 23:40 |
| cdent | i'd get opinions from jaypipes and edleafe before going too far in that direction | 23:40 |
| fried_rice | It would be the difference between leaving | 23:41 |
| fried_rice | import placement.objects.resource_provider as rp_obj | 23:41 |
| fried_rice | in all the places it's used versus changing it to something more like | 23:41 |
| fried_rice | import placement.objects.resource_provider.<what?> as rp_obj | 23:41 |
| fried_rice | and what do we call that thing? | 23:41 |
| fried_rice | placement.objects.resource_provider.resource_provider? | 23:41 |
| cdent | you could also import some things into __init__ instead of implementing them there | 23:44 |
| cdent | if that seemed better | 23:44 |
| cdent | I don't have a strong opinion which is why I'm trying to redirect to jay and ed, cuz seems they might | 23:44 |
| fried_rice | ack | 23:49 |
| *** fried_rice is now known as efried | 23:56 | |
| efried | o/ | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!