Monday, 2019-02-25

*** ttsiouts has quit IRC00:04
*** ttsiouts has joined #openstack-placement00:05
*** ttsiouts has quit IRC00:09
openstackgerritTetsuro Nakamura proposed openstack/placement master: Adds check for duplicate alloc_cands  https://review.openstack.org/63893602:56
openstackgerritTetsuro Nakamura proposed openstack/placement master: in_tree alloc_cands support with microversion 1.31  https://review.openstack.org/63572303:52
*** bhagyashris has joined #openstack-placement05:29
*** tetsuro has joined #openstack-placement05:56
*** ttsiouts has joined #openstack-placement07:29
*** belmoreira has joined #openstack-placement07:40
*** ttsiouts has quit IRC07:52
*** ttsiouts has joined #openstack-placement07:52
*** ttsiouts has quit IRC07:57
*** takashin has left #openstack-placement07:59
*** helenafm has joined #openstack-placement08:36
*** rubasov has joined #openstack-placement08:40
*** tssurya has joined #openstack-placement08:48
*** e0ne has joined #openstack-placement08:51
*** giblet is now known as gibi08:55
openstackgerritTetsuro Nakamura proposed openstack/nova-specs master: Update alloc-candidates-in-tree  https://review.openstack.org/63903308:56
*** ttsiouts has joined #openstack-placement09:00
openstackgerritTetsuro Nakamura proposed openstack/placement master: in_tree alloc_cands support with microversion 1.31  https://review.openstack.org/63572309:07
*** tetsuro has quit IRC09:07
*** cdent has joined #openstack-placement09:47
*** cdent has quit IRC09:56
*** bhagyashris has quit IRC10:02
*** cdent has joined #openstack-placement10:43
*** ttsiouts has quit IRC11:23
*** ttsiouts has joined #openstack-placement11:36
*** finucannot is now known as stephenfin11:40
*** cdent has quit IRC12:17
*** ttsiouts has quit IRC12:31
*** ttsiouts has joined #openstack-placement12:32
*** cdent has joined #openstack-placement12:34
*** ttsiouts has quit IRC12:37
cdentIf we want normalize_name in os-resource-classes we need to merge it asap: https://review.openstack.org/#/c/634258/12:47
*** e0ne has quit IRC12:47
*** ttsiouts has joined #openstack-placement12:48
cdentjaypipes, fried_rice ^13:26
*** e0ne has joined #openstack-placement13:35
jaypipescdent: done13:36
cdentthanks13:36
cdentI'll do a release before thursay13:36
openstackgerritMerged openstack/os-resource-classes master: Add normalize_name utility  https://review.openstack.org/63425813:45
cdentfried_rice: you in the house?13:58
cdentscheduler placement meeting in #openstack-meeting-alt now ish13:59
*** fried_rice is now known as efried14:04
*** ttsiouts has quit IRC14:04
*** ttsiouts has joined #openstack-placement14:05
*** ttsiouts has quit IRC14:06
*** ttsiouts has joined #openstack-placement14:06
openstackgerritEric Fried proposed openstack/placement master: Add DISK_GB to compute in SharedStorageFixture  https://review.openstack.org/63892914:43
openstackgerritEric Fried proposed openstack/placement master: Prepare in_tree allocation candidates  https://review.openstack.org/63572214:43
openstackgerritEric Fried proposed openstack/placement master: in_tree alloc_cands support with microversion 1.31  https://review.openstack.org/63572314:43
openstackgerritEric Fried proposed openstack/placement master: Add second shared provider to SharedStorageFixture  https://review.openstack.org/63871214:43
efriedcdent: I'm happy with this series ^14:46
cdentroger, moving location, but will go back to it when home14:46
efriedjaypipes: you may want to have a look also ^14:46
*** mriedem has joined #openstack-placement14:47
efried(It's still tetsuro's; I just fixed a typo and rebased)14:47
* efried fuels14:47
*** cdent has quit IRC14:53
*** e0ne has quit IRC15:03
*** e0ne has joined #openstack-placement15:05
jaypipesefried: will try.15:32
efriedjaypipes: If you're overloaded, you can probably leave it alone and cdent will get it. But it's a pretty small and simple change, should be kind of fun to review if you need a "break" from more challenging things :)15:40
jaypipesefried: ya, I'll try. gibi's bw patches are top prio right now15:45
*** ttsiouts has quit IRC16:11
*** ttsiouts has joined #openstack-placement16:12
*** ttsiouts has quit IRC16:16
*** cdent has joined #openstack-placement16:18
*** e0ne has quit IRC16:26
*** e0ne has joined #openstack-placement16:31
openstackgerritStephen Finucane proposed openstack/nova-specs master: Add 'flavor-extra-spec-image-property-validation' spec  https://review.openstack.org/63873416:40
*** dklyle_ has quit IRC16:40
*** helenafm has quit IRC16:44
*** ttsiouts has joined #openstack-placement16:51
*** dklyle has joined #openstack-placement16:55
*** ttsiouts has quit IRC16:59
*** ttsiouts has joined #openstack-placement16:59
*** ttsiouts has quit IRC17:04
*** e0ne has quit IRC17:18
*** IvensZambrano has joined #openstack-placement17:26
openstackgerritEric Fried proposed openstack/placement master: Fix a bad granular gabbi test  https://review.openstack.org/63916818:12
efriedcdent: interesting thing I found while doing something unrelated ^18:12
cdenthmmm. yeah18:13
efriedIt would be nice if duplicate keys were detected and warned somehow (and warnings made errors). But I suspect the duplicate keys are folded together by the yaml parser, so gabbi might not be able to help us here.18:13
cdentlike I said in my response on one of tetsuro's patches: I think we are likely to find warts and sundry18:13
cdentyeah, it's yaml18:13
efriedperhaps there's a 'strict' yaml parser option?18:13
cdentnot yet18:13
cdentthere will be soon18:13
efriedokay.18:13
efriedwell, in the meantime, there.18:14
* cdent does some googling18:14
cdentefried: yeah, known bug: https://github.com/yaml/pyyaml/issues/16518:15
efriednoyce. I'll add that to the commit message.18:16
cdentthe workarounds are more cumbersom than I'd like to put in gabbi given that I ought to be able to pressure the new(ish) maintainer of pyyaml18:16
openstackgerritEric Fried proposed openstack/placement master: Fix a bad granular gabbi test  https://review.openstack.org/63916818:16
efrieddone18:16
efriedoh, yeah, that ought to be at least an *option* to catch at the yaml parser levle.18:17
efriedlevel18:17
cdentah, you know what efried18:22
efriedsometimes18:22
cdentquery_parameters does support duplicate keys in a sense18:22
efriedwhat?18:22
efriedoh?18:22
cdentyou ought to be able to do: member_of2:18:23
cdent - $ENVIRON['AGGA']18:23
efriedo18:23
* efried tries...18:23
cdentif it's value is a list, it will do the right thing18:23
cdentI think18:23
cdentwhich makes sense because the python notion of encoding query params is a dict of lists18:24
efriedit won't do ?member_of2=[$agga, in:$aggb,$aggc] ?18:24
cdent(and I have  collegue from long ago who would never have let me get away with not supporting it)18:24
cdenttry it, should be quick, right?18:25
efriedYeah. works.18:25
efriedthanks cdent, will update the patch, cause that's prettier.18:25
* cdent nods18:25
cdentheh, it's even in the docs: (search for query_parameters) https://gabbi.readthedocs.io/en/latest/example.html18:26
* cdent has a _great_ memory18:26
cdentnot18:26
cdentefried: note the "not necessarily in that order" if that matters to you18:27
efriedit matters that the order shouldn't matter, so it would be nice if it were deterministic, but I don't think I care enough to make it so atm.18:28
efriedbecause if it were deterministic, I should really dup the test case with them in both orders.18:28
openstackgerritChris Dent proposed openstack/placement master: Optionally migrate database at service startup  https://review.openstack.org/61905018:29
openstackgerritEric Fried proposed openstack/placement master: Fix a bad granular gabbi test  https://review.openstack.org/63916818:31
efriedcdent: done, much better, thank you.18:31
cdentyay!18:31
efriedcdent: "The other option would be to generation two different clauses and then only and them once the where is called." -- Absent typeface distinctions, "and then only and them once the where is called" would be pretty cryptic to the uninitiated :)18:36
openstackgerritMerged openstack/placement master: Add DISK_GB to compute in SharedStorageFixture  https://review.openstack.org/63892918:36
cdentindeed18:37
efriedcdent: Do you want me to fix https://review.openstack.org/#/c/635722/ or wait for tetsuro?18:38
cdentno need to wait, I thought about doing it myself, but was trying to do a full run through of outstanding patches, so if you're there, do it18:39
cdentjaypipes, mriedem : easy clean up needs another +2 : https://review.openstack.org/#/c/636221/18:40
cdentand https://review.openstack.org/#/c/636236/18:40
*** IvensZambrano has quit IRC18:42
*** e0ne has joined #openstack-placement18:44
cdentefried: I'm struggling to re-convince myself that the gabbi integration tests started at https://review.openstack.org/#/c/601614/ are worth it. Could you please reflect back to me why you think it is a good idea?18:46
efriedcdent: You had me convinced when you said they weren't strictly redundant with tempest-full18:47
efried...which I agree we should be running.18:47
efriedLet me put it this way: The coverage might be redundant. But the ability to write these tests in gabbi is super useful IMO.18:47
*** tssurya has quit IRC18:47
efriedso it seems a shame to throw away this work just because we haven't *yet* written any tests that are unique to the gabbi framework.18:48
efriedI'm not going to go to war for it though.18:48
* cdent hopes no one goes to war18:48
cdentthanks18:49
cdenti reckon that's sufficient18:49
* cdent will do it after dinner18:52
openstackgerritEric Fried proposed openstack/placement master: Prepare in_tree allocation candidates  https://review.openstack.org/63572219:01
openstackgerritEric Fried proposed openstack/placement master: in_tree[N] alloc_cands with microversion 1.31  https://review.openstack.org/63572319:01
openstackgerritEric Fried proposed openstack/placement master: Add second shared provider to SharedStorageFixture  https://review.openstack.org/63871219:01
efriedcdent: ^ done19:02
*** IvensZambrano has joined #openstack-placement19:40
melwittefried: re: bug smash, I think it's a fine idea. don't feel you need to wait for me to organize it, I'd be happy if you wanted to. but if you'd like me to organize it, I can. just let me know19:59
openstackgerritMerged openstack/placement master: Adds tests for granular single shared rp request  https://review.openstack.org/63893520:04
openstackgerritMerged openstack/placement master: Adds check for duplicate alloc_cands  https://review.openstack.org/63893620:04
efriedmelwitt: It was cdent's idea! Mea non culpa!20:12
melwittheh20:13
efriedI'll talk to cdent and we'll figure something out. I think a bug smash is appropriate regardless of what we end up doing for bug tracking, but I wanted to be able to use the excuse of waiting until that was sorted...20:14
*** IvensZambrano has quit IRC20:15
melwitt:) makes sense. sounds good20:15
openstackgerritEric Fried proposed openstack/placement master: Optionally migrate database at service startup  https://review.openstack.org/61905020:19
cdentmelwitt, efried : bah! It wasn't my idea. I never used the term "bug smash" that was efried!20:20
* cdent passes the buck another time20:20
melwitthaha20:21
cdentefried: in_tree +W up to your added test20:30
efriedcdent: woot, thx20:30
efriedI guess the added test needs another reviewer.20:31
efriedLet's see, who spoke last?20:31
efriedmelwitt!20:31
melwittlol20:32
efriedkidding, it's not really your wheelhouse, but if you feel like it: https://review.openstack.org/#/c/63871220:32
efriedjust don't retaliate by asking me to review something quota.20:32
melwittheh20:38
cdentefried: just to be clear on the dependency idea20:57
cdentall the short jobs would still run in parallel20:57
cdentbut you'd know within 5 minutes of a failure20:58
cdentrather than needing to wait on grenade and tempest20:58
openstackgerritChris Dent proposed openstack/placement master: Initial integration test using gabbits  https://review.openstack.org/60161421:05
openstackgerritChris Dent proposed openstack/placement master: Use gabbi-tempest job from gabbi-tempest plugin  https://review.openstack.org/60750821:05
cdentefried: I believe that ^ gets some of the concerns mentioned, but it probably ought to wait until it runs through the gate as I tweaked some things for clarity and haven't been able to test it21:06
efriedcdent: It was my understanding that you were saying "wait to start long jobs; if short jobs fail, bail out and don't start the long jobs at all"21:06
cdentthat's correct, yes, but "short jobs all run at the same time"21:07
efriedlike they do today21:07
cdentyes21:07
efrieddandy21:07
cdentthe expectation is that if a unit or functional fails, then grenade and tempest will too21:07
cdentso why wait21:07
efriedoh, because a) not necessarily - in fact quite often it's just the test that's broken; and b) the failure will manifest in quite different ways that aren't unit tested, which is why we need them. The latter is the not-wanting-to-iterate thing.21:09
melwittyeah, I must confess I'm guilty of working on my first draft of patches that fail unit/func tests but pass tempest, letting zuul verify that things are working21:10
cdentIf a) then the result is the same: it's still a wasted grenade and tempest run, which costs node time and your time.21:10
cdentmelwitt: yeah, that makes quite a lot of sense in nova where there are many pieces21:10
melwittinstead of spending time tweaking unit/func tests between each iteration. I could have run tempest locally with devstack to verify things instead but I didn't21:11
cdentbut in placement, where it is basically just the api, and the functional tests cover that whole thing, functional tests end up being the "am I doing it right" filter21:11
mriedemi *never* run tempest locally21:11
melwittyeah, I was thinking in placement-land might not be nearly as compelling to do that way21:11
efriedYeah, so running tempest locally - or even running full tox - is a nonstarter for me. My laptop melts through my desk.21:11
cdentefried: in nova, sure21:11
efried(well, full tox in placement is okay)21:11
efriedyeah.21:11
cdentthis is why I didn't put [all] in the subject line21:12
melwittyeah, makes sense21:12
cdentplacement is fairly unique in this regard21:12
efriedyeah, in placement there's not really an excuse for pushing up changes that fail py/func21:12
cdentit has tests that are both very complete and very fast21:12
cdent(only "complete" becuase there's not that much there to complete)21:12
melwittyeah, that's fair21:13
openstackgerritMerged openstack/placement master: tox: Don't write byte code (maybe)  https://review.openstack.org/63699521:13
openstackgerritMerged openstack/placement master: Use tox 3.1.1 fixes  https://review.openstack.org/63699721:13
cdent(not because we are like supercoders (ahoy!) or something)21:13
melwitt:)21:13
* cdent makes yet another tshirt21:13
cdentmriedem: if you're conscious you want to get https://review.openstack.org/#/c/638712 if you're feeling it? Clears out that stack21:14
mriedemmaybe21:18
openstackgerritEric Fried proposed openstack/placement master: Test for multiple limit/group_policy qparams  https://review.openstack.org/63622121:21
*** e0ne has quit IRC21:21
efriedjaypipes, cdent: Easy manual rebase on ^ if you want to re+A quick.21:22
cdentyeah, just confirming it21:22
cdentI think for my next trick I need a local pypi mirror21:24
mriedemcdent: efried: comments/questions in https://review.openstack.org/#/c/638712/21:33
mriedemclearly i'm late to the GET /a_c?in_tree party21:33
cdentthose are why you get invited21:35
mriedemwell i think i figured out my confusion in the test21:36
mriedemnumbered vs unnumbered request groups with numbered in_tree filters21:36
cdentthe numbered request stuff causes rather an explosion of confusion21:37
mriedemyeah, hence https://review.openstack.org/#/c/635723/9/api-ref/source/parameters.yaml@7021:38
cdentMy expectation would be that that comes later, when something is actually using this stuff. Much of placement is out of sync with the actual using reality21:39
efriedmriedem: responded. Do you want me to fix those things here or throw a fup?21:40
mriedemefried: i'm getting really tired of tracking follow ups at this point :)21:40
cdentOnly later because then it could be done in a concrete fashion21:40
efriedokay, will respin, stand by.21:40
mriedemi'm not sure what concrete fashion has to do with later21:40
mriedemseems like a chicken and egg issue to me,21:41
mriedemnova is going to want to use the in_tree thing for stuff like forced host scheduling21:41
mriedembut nova, as the api user/client, needs to now how the api works21:41
cdentsure21:41
mriedemwithout digging into code and gabbits...21:41
mriedemjust playing devil's advocate and saying i'm a new contributor and all21:41
cdentI hear ya21:42
mriedemi guess granular in_tree is going to be more of a cyborg thing21:42
mriedemto which i'll happily punt for now21:42
cdentprobably. and at this point even reading the phrase "granular in_tree" makes me go "yeah, okay, mmm hmm" and want to wait and see how it progress before trying to evaluate documentation about it21:43
cdentbut on the flip side of that: if tetsuro is coming along with fixes for that stuff, the last thing we want to do is discourage them21:43
efriedmriedem: I don't agree that it's just a cyborg thing. If we ever want to e.g. migrate an instance with shared storage while the storage stays put, we'll want to say "give me allocation candidates where VCPU/MEMORY_MB are anywhere, and DISK_GB stays in SS1".21:45
efriedmriedem: I mean, yeah, I guess we could force the VCPU/MEMORY_MB resources into a numbered group so the shared storage could be wedged into the unnumbered group so we wouldn't have to use in_treeN. But that would suck worse than using in_treeN. And what if multiple shared storages?21:46
openstackgerritChris Dent proposed openstack/placement master: Initial integration test using gabbits  https://review.openstack.org/60161421:50
openstackgerritChris Dent proposed openstack/placement master: Use gabbi-tempest job from gabbi-tempest plugin  https://review.openstack.org/60750821:50
openstackgerritEric Fried proposed openstack/placement master: Add second shared provider to SharedStorageFixture  https://review.openstack.org/63871221:52
openstackgerritEric Fried proposed openstack/placement master: Test for multiple limit/group_policy qparams  https://review.openstack.org/63622121:52
efriedmriedem: ^21:52
efriedcdent: in case you want another look21:52
*** e0ne has joined #openstack-placement21:54
*** e0ne has quit IRC21:55
*** takashin has joined #openstack-placement21:56
*** e0ne has joined #openstack-placement22:05
*** e0ne has quit IRC22:08
*** s10 has joined #openstack-placement22:11
openstackgerritChris Dent proposed openstack/placement master: Remove redundant second cast to int  https://review.openstack.org/63920322:12
efriedcdent: wanna re+A https://review.openstack.org/#/c/638712/ and https://review.openstack.org/#/c/636221/ before you go to bed (which you should do soon)?22:28
cdenti'm looking at that now, gonna put a -.5 on it22:28
*** avolkov has quit IRC22:30
efriedone step forward, two steps back22:39
openstackgerritEric Fried proposed openstack/placement master: Add second shared provider to SharedStorageFixture  https://review.openstack.org/63871222:40
openstackgerritEric Fried proposed openstack/placement master: Test for multiple limit/group_policy qparams  https://review.openstack.org/63622122:40
efriedcdent: ^22:40
cdentayup22:40
mriedemdoh i knew i should have -1ed over that punctuation22:47
cdentefried: here we go. those integrated gabbits have just revealed a real bug that is tested by neither standard tempest, nor the functional tests. you win.22:50
cdentyou can also have a does of "you're right" because the issue is with another instance of func.sum22:50
cdent(which suggests that when those merge, we should add a full spectrum run of the api as a gate/gabbit )22:54
efriedcdent: I love it when a plan comes together.22:58
* cdent lights efried's cigar22:58
efriedfunny, these days "Hannibal" brings Anthony Hopkins to mind.22:58
* cdent pours the chianti23:01
openstackgerritChris Dent proposed openstack/placement master: Cast Usage.usage to int  https://review.openstack.org/63921623:09
openstackgerritChris Dent proposed openstack/placement master: Initial integration test using gabbits  https://review.openstack.org/60161423:09
openstackgerritChris Dent proposed openstack/placement master: Use gabbi-tempest job from gabbi-tempest plugin  https://review.openstack.org/60750823:09
cdentefried: if we're in the business tonight of crushing pending reviews: three more on https://review.openstack.org/#/q/status:open+project:openstack/placement+branch:master+topic:cd/less-ovo23:13
cdentall have jay's +223:13
efriedcdent: ack, getting there, but it may not be tonight.23:13
efriedNeed to rebuild my janky kitchen23:14
* cdent wants to wake up tomorrow to all the placement code merged23:14
cdentdid you unbuild it?23:14
efriedgetting new countertops. When we removed the old ones, one cabinet disintegrated. And today when they installed, another one was found to be about an inch lower than its counterpart (heh) on the other side of the dishwasher, so much shimming was necessary. We have to go make that permanent.23:16
cdentgood luck23:16
efriedyeah, thanks. Loathe carpentry.23:16
cdentwe're blowing out the back of the house later this year (if all goes to plan). that part of the house is the kitchen. I expect to find bad mojo lurking.23:17
*** cdent has left #openstack-placement23:19
*** cdent has joined #openstack-placement23:19
*** s10 has quit IRC23:34
efriedcdent: https://review.openstack.org/#/c/636807/ has some things that could be tweaked, but you can do 'em in a separate patch if you like. lmk if you want me to +W.23:43
cdentI'll fix those in that, the _updates one is especially ick23:44
efriedight23:45
openstackgerritChris Dent proposed openstack/placement master: Don't use OVO with ResourceProvider and ResourceProviderList  https://review.openstack.org/63680723:49
cdentefried: that ^ should do it. I hope23:50
openstackgerritChris Dent proposed openstack/placement master: Initial integration test using gabbits  https://review.openstack.org/60161423:56
openstackgerritChris Dent proposed openstack/placement master: Use gabbi-tempest job from gabbi-tempest plugin  https://review.openstack.org/60750823:56
openstackgerritChris Dent proposed openstack/placement master: Remove redundant second cast to int  https://review.openstack.org/63920323:58
cdentefried: I think you were right about the antibiotics making me new23:59
efriedcdent: that's great to hear.23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!