| *** mriedem has joined #openstack-placement | 07:49 | |
| *** rubasov has joined #openstack-placement | 07:58 | |
| *** e0ne has joined #openstack-placement | 07:58 | |
| *** e0ne has quit IRC | 08:00 | |
| *** rubasov has quit IRC | 08:02 | |
| *** tetsuro has joined #openstack-placement | 08:08 | |
| *** e0ne has joined #openstack-placement | 08:49 | |
| *** cdent has joined #openstack-placement | 08:58 | |
| *** rubasov has joined #openstack-placement | 09:10 | |
| *** e0ne has quit IRC | 09:13 | |
| *** e0ne has joined #openstack-placement | 09:18 | |
| *** rubasov has quit IRC | 09:21 | |
| cdent | mriedem, dansmith: are we in a position to start merging and/or reviewing the grenade/devstack/alembic stuff? | 09:23 |
|---|---|---|
| dansmith | cdent: I +2d the grenade patch right? | 09:23 |
| cdent | if we can iterate on that stuff to done-ness this week, that would be a nice outcome | 09:23 |
| dansmith | I haven't looked at the alembic patches yet | 09:23 |
| mriedem | could probably just +W the grenade change given garyk had a +2 on it before my last change | 09:24 |
| cdent | I can roust gary to do that if we want some formal | 09:24 |
| mriedem | i think dan could proxy gary's re-approval | 09:24 |
| dansmith | done | 09:25 |
| cdent | thanks | 09:25 |
| cdent | so that means pretty much everything else pending is hung on the alembic stuff | 09:26 |
| cdent | I can say with a fair degree of confidence that I went down many roads and edge cases on that stuff. it does what it intends to do | 09:27 |
| mriedem | i just need some uninterrupted time to digest it, which isn't probably going to happen real soon | 09:29 |
| cdent | take the tests on faith ;) | 09:29 |
| cdent | i'll recheck the integration test-related patches that depend on it | 09:30 |
| dansmith | cdent: is there a patch up to add the tempest and grenade jobs to the placement repo? | 09:32 |
| cdent | dansmith: not grenade yet, no, but there is some very simple intergration experiments (with refinements in following patches): https://review.openstack.org/#/c/601614/ | 09:33 |
| dansmith | cdent: right, but you're going to need to run the regular devstack/tempest and grenade jobs on placement right? | 09:34 |
| dansmith | right..right | 09:34 |
| *** e0ne has quit IRC | 09:35 | |
| cdent | There hasn't been full discussion on what the full plan is with regard to running which/what integration tests. My preference would be to test with more focus | 09:35 |
| *** e0ne has joined #openstack-placement | 09:36 | |
| *** e0ne has quit IRC | 09:36 | |
| cdent | as in mriedem just asked about running tempest-full, and I'd rather not do that | 09:36 |
| cdent | but that's a personal preference | 09:36 |
| dansmith | I don't see how we could not run a full tempest (and grenade) against placement, | 09:36 |
| dansmith | given that landing something in placement that breaks nova (especially upgrade) is easily doable | 09:37 |
| dansmith | that's why glance (as an example) runs one to make sure they don't hose nova, cinder, etc | 09:37 |
| mriedem | i have to move to my room, got a session at 11 | 09:38 |
| *** mriedem has quit IRC | 09:38 | |
| *** mriedem has joined #openstack-placement | 09:38 | |
| cdent | dansmith: Perhaps, but I was hoping (perhaps naively so) that we could figure out a much more narrow set of sanity tests (thus the use of gabbits) | 09:39 |
| dansmith | cdent: yeah, that doesn't seem like suitable coverage to me | 09:44 |
| dansmith | cdent: maybe start with the more conventional set of things and then argue for reduction after a year or so of not breaking things? | 09:44 |
| cdent | well, we're all in this together, I'm not saying my preference should be the way we go, just what it is | 09:44 |
| cdent | those patches provide us with a set of tools that are useful for doing integration tests in a style that is familiar to people who make placement, but we can have another set of patches right next to it that do the normal things | 09:45 |
| *** mriedem has quit IRC | 09:46 | |
| cdent | dansmith: so if you are able/willing to make those patches that would be great | 09:47 |
| cdent | I guess they would need to depends-on https://review.openstack.org/#/c/600162/ | 09:47 |
| * cdent goes upstairs | 09:48 | |
| cdent | i've added a link to the above chat to the review of the gabbi-based stuff | 09:49 |
| *** mriedem has joined #openstack-placement | 09:50 | |
| *** cdent has quit IRC | 09:50 | |
| *** tetsuro has quit IRC | 09:53 | |
| *** e0ne has joined #openstack-placement | 10:01 | |
| *** cdent has joined #openstack-placement | 10:02 | |
| *** tetsuro has joined #openstack-placement | 10:12 | |
| cdent | dansmith: I'm not doing anything right now, so I'll push up patches for those jobs to see how they go | 10:36 |
| *** e0ne has quit IRC | 10:38 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Add neutron-grenade-multinode jobs https://review.openstack.org/617562 | 10:39 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Add tempest-full job to check and gate https://review.openstack.org/617565 | 10:42 |
| *** tetsuro has quit IRC | 10:46 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Initial integration test using gabbits https://review.openstack.org/601614 | 10:52 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Use gabbi-tempest job from gabbi-tempest plugin https://review.openstack.org/607508 | 10:52 |
| *** tetsuro has joined #openstack-placement | 11:00 | |
| *** tetsuro has quit IRC | 11:15 | |
| *** mriedem has quit IRC | 11:28 | |
| *** cdent has quit IRC | 11:32 | |
| openstackgerrit | wanghui proposed openstack/nova-specs master: Remove the duplicate words https://review.openstack.org/617615 | 11:48 |
| *** tetsuro has joined #openstack-placement | 11:54 | |
| *** tetsuro_ has joined #openstack-placement | 11:56 | |
| *** tetsuro has quit IRC | 11:56 | |
| *** mriedem has joined #openstack-placement | 12:24 | |
| *** rubasov has joined #openstack-placement | 12:34 | |
| *** gryf has joined #openstack-placement | 12:44 | |
| *** tetsuro_ has quit IRC | 12:45 | |
| *** cdent has joined #openstack-placement | 12:52 | |
| *** tetsuro has joined #openstack-placement | 12:56 | |
| cdent | dansmith, mriedem : grenade and tempest happy: https://review.openstack.org/#/c/617565/ and https://review.openstack.org/#/c/617562/ | 12:56 |
| *** e0ne has joined #openstack-placement | 12:57 | |
| *** e0ne has quit IRC | 12:57 | |
| cdent | jaypipes: if you get a chance, the alembic changes want your brain to be sure they good: https://review.openstack.org/#/c/614350/ | 12:57 |
| *** e0ne has joined #openstack-placement | 12:58 | |
| mriedem | +2 on the grenade job change | 13:03 |
| cdent | thanks | 13:04 |
| mriedem | actually, | 13:05 |
| mriedem | i think if placement just uses the integrated-gate template, it should get both of these | 13:05 |
| mriedem | let me look | 13:05 |
| cdent | looks like it's in the legacy templates | 13:08 |
| cdent | (which I didn't look in because "legacy") | 13:09 |
| cdent | mriedem: I'll go ahead and fix it | 13:10 |
| mriedem | hmm yeah so integrated-gate-py35 adds tempest-full-py35 | 13:10 |
| mriedem | but not grenade | 13:10 |
| *** e0ne has quit IRC | 13:10 | |
| mriedem | http://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/zuul.d/project-templates.yaml#n1394 | 13:10 |
| mriedem | http://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/zuul.d/zuul-legacy-project-templates.yaml#n57 | 13:10 |
| mriedem | we don't have py35 for grenade, is probably why | 13:11 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Add integrated-gate templates to .zuul.yaml https://review.openstack.org/617565 | 13:14 |
| cdent | mriedem: swift? | 13:14 |
| mriedem | ? | 13:15 |
| mriedem | as in, why don't we have a grenade py35 job? | 13:15 |
| cdent | yeah | 13:16 |
| cdent | anyway, I've added both integrated-gate templates | 13:16 |
| mriedem | we should be able to have a grenade py35 job, not sure if anyone has tested it. i think dhellmann has investigated it at least. i know someone (jroll?) raised the question about whether or not we can test py2 -> py3 via grenade to make sure py27 nova-compute can talk to py35 nova-conductor | 13:17 |
| mriedem | that's a more complicated scenario and i'm not sure if anyone is working on it | 13:18 |
| mriedem | gmann might know as well | 13:18 |
| mriedem | i can probably crank out a patch to test py35 on grenade | 13:18 |
| cdent | is that kind of testing really necessary? I mean if we are testing the services in py2 and py3 at various branches and things like that, the actual upgradey parts aren't python. It's another case over-bombing, isn't it? | 13:22 |
| *** rubasov has quit IRC | 13:28 | |
| mriedem | its part of the drop py2 currency push | 13:37 |
| mriedem | we dont need to run both grenade jobs | 13:37 |
| mriedem | iow, you have integrated-gate and integrated-gate-py35, which means you'll get 2 tempest jobs (py2 and py3) and grenade (py2) | 13:38 |
| mriedem | i'm saying, | 13:38 |
| mriedem | if we have a grenade-py3 job in integrated-gate-py35, then we just use that | 13:38 |
| mriedem | that == that template | 13:39 |
| mriedem | and don't use the legacy one | 13:39 |
| cdent | cool with me | 13:41 |
| *** rubasov has joined #openstack-placement | 13:43 | |
| mriedem | ta da https://review.openstack.org/617661 | 13:55 |
| cdent | syntax error :( | 13:56 |
| *** tetsuro has quit IRC | 13:56 | |
| mriedem | fixed | 14:04 |
| mriedem | and part of the template now https://review.openstack.org/617662 | 14:04 |
| *** rubasov has quit IRC | 14:08 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Add integrated-gate-py35 template to .zuul.yaml https://review.openstack.org/617565 | 14:08 |
| cdent | depends-on updated | 14:08 |
| *** tetsuro has joined #openstack-placement | 14:18 | |
| cdent | tetsuro: are you at summit? | 14:27 |
| tetsuro | cdent: I'm in the same room with you | 14:29 |
| cdent | ah, well, good :) | 14:29 |
| cdent | tetsuro: I was hoping to encourage you to look at https://review.openstack.org/#/c/614350/ even if it's not an area of expertise. That stack of code is basically blocking everything. | 14:30 |
| tetsuro | Yes, I've been aware of that branch, but have left it since as you said it's not an area of expertise, but I'm also aware that you've been pinging some people to look into that so... okay, let me look into that. | 14:34 |
| *** e0ne has joined #openstack-placement | 14:34 | |
| cdent | tetsuro: thanks. as far as I can tell everyone is wanting someone else to look, so we all just need to look | 14:35 |
| cdent | since nobody (of the placement reviewers) is an expert on this | 14:35 |
| edleafe | cdent: I tested that alembic stuff as much as I could without finding any more issues. So more eyes on it would be good. | 14:50 |
| cdent | edleafe: yeah, said something much in that same vein earlier today. It needs eyes, any eyes. | 14:51 |
| *** mriedem has quit IRC | 14:57 | |
| *** e0ne has quit IRC | 15:05 | |
| *** cdent has quit IRC | 15:05 | |
| *** tetsuro has quit IRC | 15:06 | |
| *** mriedem has joined #openstack-placement | 15:16 | |
| mriedem | googly eyes? | 15:17 |
| *** cdent has joined #openstack-placement | 15:19 | |
| *** rubasov has joined #openstack-placement | 15:27 | |
| cdent | mriedem: gold star for you, grenade-py3 job (in the grenade patch itself) is failing on nova inventory verification: http://logs.openstack.org/65/617565/3/check/grenade-py3/2520e43/logs/grenade.sh.txt.gz#_2018-11-13_15_12_58_375 | 15:31 |
| mriedem | huh | 15:32 |
| cdent | my reaction exactly | 15:38 |
| *** efried has joined #openstack-placement | 15:45 | |
| *** efried has quit IRC | 15:50 | |
| *** rubasov has quit IRC | 15:59 | |
| *** cdent has quit IRC | 16:04 | |
| *** rubasov has joined #openstack-placement | 16:05 | |
| mriedem | edleafe: your dreams have come true https://review.openstack.org/#/c/614350/ | 16:12 |
| *** cdent has joined #openstack-placement | 16:15 | |
| *** efried has joined #openstack-placement | 16:17 | |
| *** tetsuro has joined #openstack-placement | 16:25 | |
| *** mriedem has quit IRC | 16:25 | |
| edleafe | s/dreams/nightmares | 16:32 |
| *** rubasov has quit IRC | 16:38 | |
| *** tetsuro has quit IRC | 16:38 | |
| *** irclogbot_2 has joined #openstack-placement | 16:39 | |
| *** irclogbot_2 has quit IRC | 16:43 | |
| *** rubasov has joined #openstack-placement | 17:00 | |
| *** cdent has quit IRC | 17:02 | |
| *** efried has quit IRC | 17:06 | |
| *** rubasov has quit IRC | 17:19 | |
| *** e0ne has joined #openstack-placement | 18:05 | |
| *** e0ne has quit IRC | 18:30 | |
| *** irclogbot_2 has joined #openstack-placement | 19:10 | |
| openstackgerrit | Ed Leafe proposed openstack/placement master: Added alembic environment https://review.openstack.org/614350 | 19:23 |
| openstackgerrit | Ed Leafe proposed openstack/placement master: Delete the old migrations https://review.openstack.org/611440 | 19:23 |
| openstackgerrit | Ed Leafe proposed openstack/placement master: Add a document for creating DB revisions https://review.openstack.org/614024 | 19:23 |
| openstackgerrit | Ed Leafe proposed openstack/placement master: WIP - Show an alembic migration https://review.openstack.org/614025 | 19:23 |
| *** rubasov has joined #openstack-placement | 19:52 | |
| *** irclogbot_2 has quit IRC | 20:11 | |
| *** irclogbot_2 has joined #openstack-placement | 20:20 | |
| *** rubasov has quit IRC | 20:27 | |
| *** cdent has joined #openstack-placement | 20:58 | |
| *** cdent has quit IRC | 21:08 | |
| *** e0ne has joined #openstack-placement | 22:34 | |
| *** e0ne has quit IRC | 22:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!