Friday, 2018-08-31

*** mriedem_lawnboy is now known as mriedem01:04
*** mriedem has quit IRC01:10
*** lei-zh has joined #openstack-placement01:52
*** lei-zh has quit IRC02:31
*** lei-zh1 has joined #openstack-placement02:31
openstackgerritLeopard Ma proposed openstack/nova master: Replace assertRaisesRegexp with assertRaisesRegex  https://review.openstack.org/59841503:15
openstackgerrithuanhongda proposed openstack/nova master: Fix instance delete stuck in deleting task_state  https://review.openstack.org/59808403:21
*** lei-zh1 has quit IRC03:32
*** nicolasbock has quit IRC03:33
openstackgerritBrin Zhang proposed openstack/nova-specs master: Resource retrieving: add changes-before filter  https://review.openstack.org/59197603:44
*** jaypipes has quit IRC04:04
*** jaypipes has joined #openstack-placement04:04
*** lei-zh1 has joined #openstack-placement04:06
*** lei-zh1 has quit IRC04:11
*** lei-zh1 has joined #openstack-placement05:46
openstackgerritLeopard Ma proposed openstack/nova master: Replace assertRaisesRegexp with assertRaisesRegex  https://review.openstack.org/59841506:25
*** e0ne has joined #openstack-placement06:50
*** e0ne has quit IRC06:52
*** lei-zh1 has quit IRC06:58
*** lei-zh1 has joined #openstack-placement06:59
*** tssurya has joined #openstack-placement07:12
openstackgerritChen proposed openstack/nova master: Fix SOFT_DELETE vm_state string  https://review.openstack.org/59848207:56
openstackgerritBrin Zhang proposed openstack/nova-specs master: Resource retrieving: add changes-before filter  https://review.openstack.org/59197608:45
openstackgerritBrin Zhang proposed openstack/nova-specs master: Resource retrieving: add changes-before filter  https://review.openstack.org/59197608:48
*** ttsiouts has joined #openstack-placement08:49
*** e0ne has joined #openstack-placement09:01
openstackgerritBalazs Gibizer proposed openstack/nova master: Consumer gen support for delete instance allocations  https://review.openstack.org/59159709:06
*** lei-zh1 has quit IRC09:21
openstackgerritChen proposed openstack/nova master: Fix filter server list with SOFT_DELETED status  https://review.openstack.org/59744309:45
-openstackstatus- NOTICE: Jobs using devstack-gate (legacy devstack jobs) have been failing due to an ara update. We use now a newer ansible version, it's safe to recheck if you see "ImportError: No module named manager" in the logs.09:57
*** ttsiouts has quit IRC10:09
openstackgerritMerged openstack/nova master: Delete instance_group_member records from API DB during archive  https://review.openstack.org/58894310:13
*** cdent has joined #openstack-placement10:21
*** nicolasbock has joined #openstack-placement10:33
*** stephenfin is now known as finucannot10:46
*** gibi is now known as giblet10:53
*** ttsiouts has joined #openstack-placement11:12
cdentgiblet, efried, edleafe, jaypipes, melwitt: it lives! https://git.openstack.org/cgit/openstack/placement11:22
gibletwoot11:22
cdentinput is desired on https://review.openstack.org/#/c/598380/ if you haven't already provided it11:22
openstackgerritRadoslav Gerganov proposed openstack/nova master: Do not dump all instances in the scheduler  https://review.openstack.org/59861111:38
*** e0ne has quit IRC11:44
cdentedleafe: I've gone ahead and done https://review.openstack.org/#/c/598602/ as my curiosity didn't want to wait. Any automation you do should probably base off that.11:52
cdentI've also made this change https://review.openstack.org/#/c/598603/ so that the new repo will report here11:52
gibletcdent: left feedback on https://review.openstack.org/#/c/59860211:58
gibletsoo good to see that repo separation is moving forward11:59
cdentthanks12:04
cdentyes12:04
cdentgiblet: responded, I hope it's clear why I've chosen the way I've chosen12:11
openstackgerritsahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages  https://review.openstack.org/53216812:13
gibletcdent: I don't use gitreview so I basically don't know what we loose if the .gitreview file is not correct.12:15
cdentold school!12:15
gibletcdent: but if this change is needed for the gitreview users I'm fine with it12:15
cdentdo you use some other automation, or just your own calls to git?12:15
gibletcdent: I just use git push review HEAD:refs/for/master/<topic>12:17
cdenti've become so habituated to git review that I'm pretty sure I've forgotten the underlying steps12:18
gibletcdent: it seems that placement-core is empty https://review.openstack.org/#/admin/groups/1936,members so nobody can approve code at the moment12:18
cdentcd nova; git review -v -d <id> ; do some stuff ; git review is may daily mantra12:18
cdentgiblet: yeah, I've made a request to infra to get nova-core in there12:19
gibletcdent: that git review is like black magic to me :) I like to know what happen in git12:19
cdentI assume that's the right starting point (as in, I shouldn't have myself added and then add nova-core)12:19
gibletI think that was the agreed initial setup12:20
cdentgiblet: i'm going to be away for some of the afternoon, so if there's no action on that soonish, if you have the time to poke infra about it, that would be helpful12:21
gibletcdent: I still have about 2 hours in the office before the the weekend so I can check back to infra12:22
cdentthanks12:22
gibletcdent: thank you for your effort on the repo separation12:23
cdentyou're welcome, it's nice to see it finally taking shape12:23
*** jaypipes is now known as leakypipes12:44
*** cdent has quit IRC12:55
*** e0ne has joined #openstack-placement12:55
*** tssurya has quit IRC12:59
* edleafe gets to the keyboard with a nice cup of coffee13:01
edleafeGuess we need to change the gerrit bot to look at openstack/placement for this channel now13:17
edleafegiblet: efried: cdent: I've pushed my stack of changes on top of cdent's zuul job change, starting with https://review.openstack.org/#/c/598941/13:18
edleafe^^ These are all the mechanical movements and replacements that are needed to make placement sort of close to working. I broke them down into 10 logical steps so that they would be easy to review13:20
*** ttsiouts has quit IRC13:24
*** ttsiouts has joined #openstack-placement13:30
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Delete instance_group_member records from API DB during archive  https://review.openstack.org/59895313:36
gibletedleafe: ack13:37
gibletcdent, edleafe, efried: infra fixed the placement-core group to contain nova-core so now we have approve rights as well13:37
efriedwoot. I'm still working through the gov patches13:38
*** efried is now known as fried_rice13:38
gibletedleafe: https://review.openstack.org/#/c/598940 will not be mergabel without a noop-jobs template13:39
edleafegiblet: Heh, it wouldn't import it with a .zuul.yaml file, which is why cdent added it back in the first patch13:40
edleafeShould I squash his patch into this?13:40
gibletedleafe: squash seems appropriate in this case13:41
edleafegiblet: do you know why cdent's patch says "Cannot Merge", while the base one doesn't?13:42
gibletedleafe: I have no idea13:42
* edleafe is learning more infra than he cares to13:42
gibletI'm guessing that it is the missing jobs13:42
edleafeSo... add at least one gate job?13:43
gibletnoop-jobs template will be enough based on the docs13:43
edleafeok, off to squash!13:43
gibletedleafe: https://docs.openstack.org/infra/manual/creators.html#add-jobs-for-your-project13:44
edleafethanks13:44
* giblet have to leave soon but will wait for the squash to leave +2 on it :)13:44
*** mriedem has joined #openstack-placement13:45
openstackgerritBalazs Gibizer proposed openstack/nova master: Consumer gen support for put allocations  https://review.openstack.org/59164713:45
*** ttsiouts has quit IRC13:47
*** alex_xu has quit IRC13:47
*** alex_xu has joined #openstack-placement13:53
edleafegiblet: got a merge conflict on gerrit. Might take a little while to straighten out13:56
gibletedleafe: thanks for the notice. The I will leave now and try to check back later13:57
edleafeThanks giblet13:57
*** giblet is now known as giblet_off13:57
fried_riceedleafe: Anyone propose the gerritbot patches to make placement repo changes show up in this channel?13:57
edleafefried_rice: not that I know of13:58
fried_ricek, I can look into that, if I can remember how.13:58
fried_riceCause that's, like, important.13:58
giblet_offfried_rice: cden did that13:58
fried_riceokay.13:58
edleafegiblet_off: fried_rice: cdent: Pushed the stack with cdent's patch squashed13:58
giblet_offfried_rice: https://review.openstack.org/#/c/598603/13:59
edleafeoops - hold off13:59
edleafethe merge didn't do what I needed13:59
edleafeThought that was too easy :)13:59
*** ttsiouts has joined #openstack-placement14:08
fried_riceedleafe: Let me know if I did something wrong here, but...14:12
fried_riceI cloned the placement repo from the link that shows up in gerrit, then diffed it against nova14:12
fried_riceand it looks like we're missing some of the more recent commits.14:12
fried_ricelike from the reshaper series.14:12
fried_ricee.g. https://review.openstack.org/#/c/596497/14:13
* fried_rice scrambles to see whether that merged before or after we said we'd pull the trigger...14:14
*** mriedem has quit IRC14:14
fried_ricedamn.14:14
*** mriedem has joined #openstack-placement14:15
fried_riceby ten minutes.14:15
edleafefried_rice: I pulled a fresh master for nova before running the extraction14:15
fried_riceyeah, that one merged ten minutes later.14:15
edleafeIt shouldn't be too hard to apply the diff to the extracted code, no?14:15
fried_riceedleafe: We missed it when looking for patches that needed to be included.14:15
fried_riceNo, it should be easy enough, but then it needs to merge before all the pathing changes.14:16
fried_riceAlso14:16
fried_ricethere were patches further up in the reshaper series that were "all nova side" but which touched e.g. placement.rst14:16
edleafeNo, the pathing changes are trivial to handle14:16
fried_riceedleafe: But procedurally, I want the two patches to look identical.14:17
edleafefried_rice: I don't see how that's possible. And I don't see why the pathing in some import statements is critical to be identical14:18
fried_riceWell, the diff itself would be identical, since the import lines are far enough away from the actual changes. But the deltas would be to different files depending whether it landed before or after the repathing.14:23
fried_ricewhoops, I guess there's some git config patches I need to be on top of first, so my review winds up being proposed to the correct repo?14:25
*** cdent has joined #openstack-placement14:26
cdentedleafe: you've done something weird with https://review.openstack.org/#/c/598940/14:26
cdentit doesn't not need to exist and is the thing blocking the children14:26
cdentsigh: s/not//14:26
edleafecdent:14:27
edleafecdent: yeah, I know14:27
cdentk14:27
edleafeI think it was an artifact of the juggling done in my GitHub repo14:27
cdenti left a comment anyway14:27
edleafesure14:27
fried_ricecdent: In other news, we missed https://review.openstack.org/#/c/596497/14:27
fried_riceI'm trying to propose it to the placement repo, but I'm probably missing some kind of git-review bootstrapping...14:27
edleafeI'm working in your patch into my series14:27
fried_riceedleafe: was this ^ to me?14:28
edleafenope, for cdent14:28
cdentfried_rice: you can't propose until after https://review.openstack.org/#/c/598602/ merges14:28
edleafeshit14:28
edleafepushed a new series based on cdent's stuff, and https://review.openstack.org/#/c/598940/ still is in there14:29
cdentand there's no point proposing anything until after we get the tests working, so best that we just remember that that missed thing needs to be cherry picked later14:29
cdentedleafe: you want I to try to fix it?14:30
edleafecdent: what hash do you have for master?14:30
fried_riceI can't even git-review -d anything.14:30
cdentactually edleafe you can just abandon your change https://review.openstack.org/#/c/598602/ is parented to master14:30
cdentfried_rice: change .gitreview to have the right repo value14:30
fried_riceyeah, still freezing.14:30
* cdent tries14:31
edleafecdent: on my machine that patch doesn't exist. I have your patch rebased onto 1a45f11, which shows up as master for me14:31
fried_riceI think I effed something up by getting partway without having done that. I recloned and am making progress now.14:31
fried_ricecdent: How come it's necessary to wait until things get working? I wanted to start off by having a clean diff between nova/ and placement/. And I need this commit (and part of one other) to make that happen.14:32
edleafefried_rice: for one thing, it effs up the process we worked out14:32
cdentfried_rice: it's not _necessary_ to wait, I just figured we would want to wait until the tests were working14:32
edleafefried_rice: the initial commit was going to be one thing, but at your and others request, it was broken into steps14:33
cdentedleafe: my master is 1a45f11a060d614:33
cdentedleafe: are you working in a repo that has remotes of both openstack/placement and edleafe/placement?14:33
edleafecdent: so I abandoned the bad patch, but it still shows your change based on it14:34
fried_riceedleafe: Yeah, I would have had a much harder time finding this snafu if we had done the monolithic commit.14:34
edleafecdent: no, remotes are updated.14:34
edleafefried_rice: agreed. So we know the problem, and we'll correct it as soon as we can14:34
cdentthe abandoned patch will continue to show my patch based on it forever. that doesn't matter14:34
cdentwhat matters is that https://review.openstack.org/#/c/598602/ is based on master14:34
cdentand it is14:35
edleafecdent: yeah. Hey, the noop jobs passed for it!!!14:36
cdentedleafe, fried_rice, giblet_off, leakypipes : basically if want to continue working (at least using git-review) without too much faffing he base of https://review.openstack.org/#/c/598602/ needs to merge14:37
fried_riceYeah, I can see that being the case. Why is edleafe -1 on it?14:37
cdentnova-core is now placement-core so they should have the power14:37
cdentbecause he hasn't caught up with himself yet14:37
edleafefried_rice: and because I had a question about gate jobs. I was +1 before14:38
edleafeIt's a very soft -114:38
openstackgerritMerged openstack/nova master: api-ref: add a warning about calling swap volume directly  https://review.openstack.org/59649214:38
fried_ricecdent, edleafe: +214:38
cdentthanks fried_rice14:38
edleafeNow that the Cannot Merge is gone, I'm back to +114:39
fried_rice"8:44:52 AM * giblet have to leave soon but will wait for the squash to leave +2 on it :)"14:41
fried_riceWhat squash? Did that happen?14:41
cdentI have no idea what that's about14:42
fried_rice(trying to suss whether I can legitimately fast-approve that one)14:42
cdentthanks leakypipes14:42
leakypipesyep14:43
edleafefried_rice: go back to 8:39 to the start of that conversation14:44
edleafeIt was essentially a way of getting rid of the artifact patch that I just abandoned14:44
edleafeThat was before we understood where that patch came from14:45
fried_ricecdent, edleafe: I proposed  https://review.openstack.org/59898814:46
cdentfried_rice: I'm not sure how we're going to get that to work with https://review.openstack.org/#/c/598941/ and the automated stack above it14:47
cdentare you saying you want your change in before all that stuff?14:47
fried_riceyes, let me restate the reasoning, might have been before you entered the room.14:47
edleafeIt's gonna f up the rest of the extraction series14:47
fried_ricecdent: It's because I want to be able to `diff placement/ nova/` cleanly as a baseline to start reviewing gerrit patches.14:48
* edleafe goes to make more coffee14:49
fried_riceedleafe: Well, fwiw, I just rebased that whole series on top of my patch and it went fine.14:49
cdentyeah, I heard that fried_rice, but we messed up and missed that change. If we special case that one in, it messed up all the already existing patches we have for fixing stuff. Do we want to redo all those patches because of this one missed thing? Or can we just accept that we made a mistaked and deal?14:49
cdentif the rebase is okay, then maybe it is fine14:49
fried_riceThat patch had no renames and no deltas near the imports.14:49
cdentI don't really mind as long as other cores are not going to be surprised and freak out14:50
fried_ricethat's the thing. Cores who are using the same strategy (diff initial placement/ and nova/) are going to be freaked out by the difference, be like where tf did this come from14:51
cdentI have no insight to what strategies people are using, so I don't have an opinion14:51
fried_ricewithout proposing the rebased series, is there some way to figure out if it's okay?14:52
cdentwhat do you mean by okay?14:53
cdentthe top of that stack is still not a working system, so there's no formal definition of okay, yet14:54
*** rubasov has quit IRC14:55
fried_riceright, swhy I'm asking. Is the fact that the rebase went through enough?14:56
cdentI guess you just want to make sure the changes in your patch are present in the file you expect them to be in in the top of the stack14:58
cdentif so, then disco14:58
fried_ricethat's correct.14:59
fried_riceso14:59
fried_riceshould I push the rebased series?14:59
cdenthuzzah: https://review.openstack.org/#/c/598602/ merged! first commit. woot.15:00
cdentyes15:00
cdentbut rebase again15:00
fried_ricewhy?15:00
fried_ricemy patch was already on top of 60215:00
cdentwell, if you use git-review it will take care of it15:00
fried_riceI mean, I don't mind doing it again15:00
cdentno, is fine15:00
fried_riceI think I have auto-rebase switched off.15:00
fried_ricecdent: Done.15:01
cdentwe need another infra for https://review.openstack.org/#/c/598603/15:01
fried_ricebtw, gibi said you proposed the patches to make placement repo changes show up in this channel. Wherezat?15:01
cdentjinx15:01
fried_ricethx, +1. You bugging infra about that one?15:02
openstackgerritMerged openstack/nova master: Remove old check_attach version check in API  https://review.openstack.org/58834815:02
edleafecdent: Do we still want nova and nova-specs showing up here? They already show up in -nova15:03
fried_riceI agree they could/should be removed later.15:03
fried_riceWe definitely still want nova-specs, since that's where placement specs still live until the divorce is final.15:04
cdentedleafe: for now, yeah, I figured it was temporarily the right thing, as specs are still in nova-specs and to assuage some of the concerns about nova-side stuff being missed out15:04
fried_ricecdent, edleafe: There's one more change needed to make the repositories match.15:09
edleafe"...there's one more thing"15:10
fried_riceliterally15:10
fried_ricehttps://review.openstack.org/#/c/585034/20/doc/source/user/placement.rst15:10
fried_riceefried@efried-ThinkPad-W520:~/Neo$ diff --exclude=.git --exclude=.zuul.yaml --exclude=.gitreview -r nova placement/ 2>&1 | grep -v '^Only in nova'15:11
fried_ricediff '--exclude=.git' '--exclude=.zuul.yaml' '--exclude=.gitreview' -r nova/doc/source/user/placement.rst placement/doc/source/user/placement.rst15:11
fried_rice60d5915:11
fried_rice< * `inventory and allocation data migration`_ (reshaping provider trees)15:11
fried_rice66d6415:11
fried_rice< .. _inventory and allocation data migration: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/reshape-provider-tree.html15:11
cdentfried_rice: that's going to be a bit more challenging15:12
fried_riceBecause other stuff is changing nearby?15:12
fried_riceI'll propose it on top. This one should be relatively easy to explain away.15:12
cdentgiven that it is docs, I think you're better off fixing that by hand and not worrying about history15:12
fried_riceack15:12
cdentif you're going to do it on top, don't do it yet15:13
cdentif you're going to put it near the bottom, then go ahead15:13
cdentbut if you're able to cope with the diff, I'd say wait until we have running docs jobs. If you want a clean diff, put it in the stack you just made15:13
fried_riceI'll see if it rebases cleanly again.15:14
*** e0ne has quit IRC15:14
openstackgerritMatt Riedemann proposed openstack/nova master: Don't persist zero allocation ratios in ResourceTracker  https://review.openstack.org/59836515:14
fried_ricecdent, edleafe: That rebase went clean as well. Okay to push?15:17
edleafefried_rice: on top of your other patch?15:18
cdentokay with me, if it makes your life easier.15:18
fried_riceYes, on top of the other one, and underneath the rest of the series.15:18
edleafeI only want to have to retool my patch series once15:18
edleafefried_rice: ok, then cool15:18
fried_riceDo you have to retool anything if the rebase was clean?15:18
fried_ricedone15:19
edleafeyes - I have to change what the patch series is based on15:19
edleafeYou think I rebase 10 patches by hand?15:19
fried_ricewhat do you mean?15:19
fried_riceI already rebased the rest of the series.15:19
edleafescripts, baby!15:19
fried_ricesorry, I don't follow.15:20
fried_riceanyway, I'm happy with the "baseline" now.15:20
edleafeI automate rebasing locally.15:20
cdentyeah, I'm not sure what edleafe is talking about15:20
cdentno new patches need to be pushed, fried_rice's stuff is applying cleaning in the middle15:20
cdentedleafe: is all your automation already pushed, or is there more?15:20
cdentwe don't need to do it again15:21
edleafecdent: it's pushed. If a change is needed, though, then I have to update the series15:21
edleafethat's all15:21
cdentif a change is needed wouldn't we pull the series down and update it by hand at this stage?15:22
* cdent thinks he's missing some detail15:22
edleafeI think you don't manage git branches the same way I do, so you don't understand my approach. Suffice it to say that it isn't a major hassle, just a minor one.15:24
fried_ricecdent, edleafe: I left an explanatory note on https://review.openstack.org/#/c/599001/15:25
cdenti gotta go pick up my failed car, biab15:30
*** ttsiouts has quit IRC15:38
*** ttsiouts has joined #openstack-placement15:39
*** ttsiouts has quit IRC15:43
*** e0ne has joined #openstack-placement15:45
*** e0ne has quit IRC15:56
*** openstackgerrit has quit IRC16:06
*** mriedem is now known as mriedem_away16:21
*** fried_rice is now known as fried_rolls16:27
*** mriedem_away is now known as mriedem17:50
*** openstackgerrit has joined #openstack-placement18:15
openstackgerritMatt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API  https://review.openstack.org/46967518:15
openstackgerritAdam Harwell proposed openstack/nova stable/pike: Add apply_cells to nova-manage  https://review.openstack.org/59905018:48
openstackgerritMerged openstack/nova master: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504918:51
openstackgerritMerged openstack/nova master: Compute: Handle reshaped provider trees  https://review.openstack.org/57623618:51
openstackgerritMerged openstack/nova master: Do test_reshape with an actual startup  https://review.openstack.org/59721818:52
openstackgerritMerged openstack/nova master: Fix reshaper report client functonal test nits  https://review.openstack.org/59833018:52
*** openstackstatus has quit IRC18:58
*** fried_rolls is now known as fried_rice19:23
*** e0ne has joined #openstack-placement19:36
*** openstackstatus has joined #openstack-placement19:38
*** ChanServ sets mode: +v openstackstatus19:38
openstackgerritDan Smith proposed openstack/nova master: Move conductor wait_until_ready() delay before manager init  https://review.openstack.org/59835319:50
*** openstackstatus has quit IRC19:55
*** openstackstatus has joined #openstack-placement19:58
*** ChanServ sets mode: +v openstackstatus19:58
cdentgoodnight all20:01
*** cdent has quit IRC20:02
*** e0ne has quit IRC20:06
*** openstackstatus has quit IRC20:11
*** openstackstatus has joined #openstack-placement20:12
*** ChanServ sets mode: +v openstackstatus20:12
*** nicolasbock has quit IRC20:16
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Fix image-defined numa claims during evacuate  https://review.openstack.org/59906220:17
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Move conductor wait_until_ready() delay before manager init  https://review.openstack.org/59906420:22
*** openstackstatus has quit IRC20:36
*** openstackstatus has joined #openstack-placement20:38
*** ChanServ sets mode: +v openstackstatus20:38
openstackgerritEric Fried proposed openstack/nova master: Other host allocs may appear in gafpt during evac  https://review.openstack.org/59730120:51
openstackgerritEric Fried proposed openstack/nova master: Other host allocs may appear in gafpt during evac  https://review.openstack.org/59730120:55
openstackgerritsean mooney proposed openstack/nova master: add caching to _build_regex_range  https://review.openstack.org/59907120:55
*** e0ne has joined #openstack-placement20:56
*** e0ne has quit IRC21:00
openstackgerritMatt Riedemann proposed openstack/nova master: Null out instance.availability_zone on shelve offload  https://review.openstack.org/59908722:20
*** mriedem has quit IRC22:32

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!