Tuesday, 2018-08-21

*** cdent has quit IRC00:02
*** yikun has joined #openstack-placement03:24
*** Nel1x has quit IRC03:34
*** yikun has quit IRC06:11
openstackgerritChen proposed openstack/nova stable/rocky: Update ssh configuration doc  https://review.openstack.org/59404106:31
openstackgerritChen proposed openstack/nova stable/rocky: Revisons on notifications doc  https://review.openstack.org/59404206:37
*** tssurya has joined #openstack-placement06:52
openstackgerritJiri Suchomel proposed openstack/nova master: Ignore deleted instances when populating with availability zones  https://review.openstack.org/59405007:13
*** tetsuro has quit IRC07:36
*** tetsuro has joined #openstack-placement08:08
*** e0ne has joined #openstack-placement08:10
*** cdent has joined #openstack-placement08:33
*** mriedem has joined #openstack-placement09:42
openstackgerritJiri Suchomel proposed openstack/nova master: Set default AZ explicitely for instances without host. Ignore deleted instances when populating with availability zones  https://review.openstack.org/59405010:26
openstackgerritJiri Suchomel proposed openstack/nova master: Set default AZ explicitely for instances without host.  https://review.openstack.org/59405010:27
* cdent tries to break some stuff10:43
*** e0ne has quit IRC11:36
openstackgerritBrin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter  https://review.openstack.org/59197611:44
openstackgerritJiri Suchomel proposed openstack/nova master: Filter out instances without a host when populating AZ  https://review.openstack.org/59405011:47
openstackgerritMatt Riedemann proposed openstack/nova master: Re-activate source host port bindings on live migration rollback  https://review.openstack.org/59413911:53
*** yikun_ has joined #openstack-placement11:57
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [placement] Use oslotest uuidsentinel  https://review.openstack.org/59414412:05
openstackgerritBrin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter  https://review.openstack.org/59197612:07
openstackgerritBrin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter  https://review.openstack.org/59197612:23
openstackgerritJiri Suchomel proposed openstack/nova master: Filter out instances without a host when populating AZ  https://review.openstack.org/59405012:26
cdentmriedem: care to speculate why on one host (ubuntu bionic) I get varying numbers (~50 - ~150) of failures like this on current master: http://paste.openstack.org/show/728513/  in clean virtualenvs, both python 2.7 and 3.6, but not on another host (osx)12:33
cdent^ that is only a problem on a host with a lot of cpus and when only running the placement tests, so it basically comes down to conf not being initialized properly. will fix.13:02
*** efried is now known as efried_goatin13:03
* cdent is glad he knows about efried_goatin's nanny13:05
mriedemcdent: so you figured it out?13:08
*** s10 has joined #openstack-placement13:08
cdentmriedem: yeah, I think so. it's basically global conf being tricksy13:09
mriedemi remember having to muck with that b/c oslo_policy in nova.conf is different (and only for nova) so the placement group thing is a bit different13:09
mriedemi.e. [placement]/policy_file i think13:09
cdentso yeah, registering the policy opts in the gabbi fixture makes the problem go away13:10
cdentwhich is a good enough fix for now, but it means we got some leakage, but from what I've been able to discern that's always been the case with the functional tests and conf13:11
cdentand I'm not clear how, or even if, to fix it13:11
openstackgerritChris Dent proposed openstack/nova master: Set policy_opt defaults in placement gabbi fixture  https://review.openstack.org/59417213:28
cdentmriedem that ought to fix it13:29
mriedemcdent: so the gabbi tests dont' go through this right? https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/wsgi.py#L7113:32
cdentcorrect, but they do go through deploy, and it is in deploy where the option is used13:32
mriedem+213:34
cdent:slack thumb of upness:13:35
*** efried_goatin is now known as efried13:37
mriedemyou stick your slacks in a sack mister13:38
mriedemsay what you will about irc, at least we don't have animated gifs13:39
*** e0ne has joined #openstack-placement13:40
efrieddude, my client was translating emojis to images and it was making me freakin crazy.13:42
cdent:) :(13:42
efriedThere was no actual option to turn it off - I had to go hacking into internal configs.13:42
efriedoh, I took care of it. Because e.g. ^^ (which I use all the time to mean, "look at the above - no, really, look at the above") was showing up as an emoji.13:42
mriedem;P13:44
openstackgerritMatt Riedemann proposed openstack/nova master: Filter out instances without a host when populating AZ  https://review.openstack.org/59405013:44
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Filter out instances without a host when populating AZ  https://review.openstack.org/59417813:50
edleafeah, now we know how to mess with efried13:54
efriedLike I said, it's no longer an issue. I had to hack the client, but it was that or pick a new client.13:55
edleafedoh!13:56
openstackgerritJiri Suchomel proposed openstack/nova stable/pike: Filter out instances without a host when populating AZ  https://review.openstack.org/59418413:58
openstackgerritSurya Seetharaman proposed openstack/nova stable/queens: Filter out instances without a host when populating AZ  https://review.openstack.org/59418514:00
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Filter out instances without a host when populating AZ  https://review.openstack.org/59418514:06
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Filter out instances without a host when populating AZ  https://review.openstack.org/59418414:14
openstackgerritMatt Riedemann proposed openstack/nova master: Merge config drive extension response into server controller  https://review.openstack.org/58422314:53
openstackgerritMatt Riedemann proposed openstack/nova master: Merge extended server attributes extension response  https://review.openstack.org/58459014:53
openstackgerritMatt Riedemann proposed openstack/nova master: Merge keypair extension response into server view builder  https://review.openstack.org/58474814:53
openstackgerritMatt Riedemann proposed openstack/nova master: Merge server usage extension response into server view builder  https://review.openstack.org/58526214:53
openstackgerritMatt Riedemann proposed openstack/nova master: Merge security groups extension response into server view builder  https://review.openstack.org/58547514:53
openstackgerritMatt Riedemann proposed openstack/nova master: Merge extended_status extension response into server view builder  https://review.openstack.org/59209214:53
openstackgerritDan Smith proposed openstack/nova master: WIP: Record cell success/failure/timeout in CrossCellLister  https://review.openstack.org/59426514:56
openstackgerritJose Castro Leon proposed openstack/nova master: Add extend in-use volumes support for RBD  https://review.openstack.org/59427315:04
cdentedleafe: you still away?15:15
cdentwas wondering about the state of your filtering experiments15:16
*** s10 has quit IRC15:18
*** alex_xu has quit IRC15:23
openstackgerritMatt Riedemann proposed openstack/nova master: Explicitly fail if trying to attach SR-IOV port  https://review.openstack.org/59189815:42
*** e0ne has quit IRC15:44
openstackgerritChris Dent proposed openstack/nova master: Set policy_opt defaults in placement deploy unit test  https://review.openstack.org/59433415:57
cdentmriedem, efried followup on the unit test side15:58
mriedem+216:01
openstackgerritDan Smith proposed openstack/nova master: Batch results per cell when doing cross-cell listing  https://review.openstack.org/59269816:16
openstackgerritDan Smith proposed openstack/nova master: List instances from all cells explicitly  https://review.openstack.org/59371716:16
openstackgerritDan Smith proposed openstack/nova master: Make instance_list perform per-cell batching  https://review.openstack.org/59313116:16
openstackgerritEric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692716:16
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503316:17
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane  https://review.openstack.org/58459816:17
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459916:17
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464816:17
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503416:17
openstackgerritEric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504916:17
openstackgerritEric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees  https://review.openstack.org/57623616:17
openstackgerritEric Fried proposed openstack/nova master: [placement] Regex consts for placement schema  https://review.openstack.org/59186316:17
efriedrebase only ^16:17
openstackgerritEric Fried proposed openstack/nova master: [placement] Regex consts for placement schema  https://review.openstack.org/59186316:19
openstackgerritEric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692716:20
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503316:20
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane  https://review.openstack.org/58459816:20
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459916:20
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464816:20
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503416:20
openstackgerritEric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504916:20
openstackgerritEric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees  https://review.openstack.org/57623616:20
efriedShuffle to put schema consts on bottom (cdent FYI) ^16:20
cdentroger16:21
cdentefried: gonna stroll but when I come back will run through that stack16:35
efriedcdent: I'm still doing things16:35
efriedaddressing the -1 from jay and fixing nits along the way16:35
efriedbut the deltas there should be small, so feel free to review, just knowing that you'll have to come back and do the delta after.16:36
* cdent is curious about efried's development patterns and tooling16:36
cdentbut i'll worry about that later16:36
* cdent strolls16:36
efriedcdent: Happy to splain16:36
cdentlaterz16:36
*** s10 has joined #openstack-placement16:39
*** s10 has quit IRC16:46
*** nicolasbock has joined #openstack-placement16:59
*** sean-k-mooney has quit IRC17:00
edleafecdent: back17:04
edleafecdent: I ran it once with coarse results. Now I'm going through each file to see if we want to keep it or not.17:04
edleafee.g., most of the release notes are nova-specific, but there are a few placement release notes17:05
openstackgerritMerged openstack/nova master: Update resources once in update_available_resource  https://review.openstack.org/52002417:36
openstackgerritMerged openstack/nova master: Set policy_opt defaults in placement gabbi fixture  https://review.openstack.org/59417217:36
openstackgerritMerged openstack/nova master: Set policy_opt defaults in placement deploy unit test  https://review.openstack.org/59433417:39
*** e0ne has joined #openstack-placement17:42
cdentedleafe: so you're saying, basically, that it worked for some form of "worked"?17:46
cdentefried: the thing I was interested in was basically: you pushed twice to gerrit twice when you did the rebase and then the reordering, why?17:47
efriedcdent: Yeah, I figured that was what you were interested in.17:48
edleafeOh, it worked. I just ran it with the major directories. Now it's running with this: http://paste.openstack.org/show/728546/17:48
efriedAs a reviewer, I like to be able to diff patch sets without rebases in the way.17:48
efriedSo as a courtesy to others who might feel the same way, I like to do rebases separately from actual fixes.17:48
efriedbecause patch sets are cheap.17:48
efriedway cheaper than the time and effort it takes me to visually differentiate between rebase-delta and actual-change-delta.17:49
* cdent nods at efried 17:50
*** tssurya has quit IRC17:50
cdentI guess have a form of "don't overstimulate the gate" ptsd. A form that is not particularly logical. I agree that the clean diffing is goodness17:53
cdentefried: anyway, are you still "doing things" on that set17:55
efriedcdent: Yes, still working my way up. Posting answers when done locally.17:56
cdentcool. when we finally get this stack merged it will feel nicde17:57
cdentor even nice17:57
efriedaaaaaand I fucked it up.  Gods damn it to the seven hells.18:01
cdentoh noes18:02
openstackgerritDan Smith proposed openstack/nova stable/queens: Fix cancel_all_events event name parsing  https://review.openstack.org/59208618:04
openstackgerritDan Smith proposed openstack/nova stable/queens: Wait for network-vif-plugged before starting live migration  https://review.openstack.org/59173518:04
openstackgerritDan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting  https://review.openstack.org/59177518:04
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: Don't react to VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED events  https://review.openstack.org/59450818:30
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: Don't react to VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED events  https://review.openstack.org/59450818:33
*** e0ne has quit IRC18:57
cdent'night all19:16
*** cdent has quit IRC19:16
mriedem(12:48:29 PM) efried: As a reviewer, I like to be able to diff patch sets without rebases in the way.19:31
mriedem+100019:31
mriedemunnecessary rebase on master in a long, big series is death19:31
efriedI'm sure people have tools for looking at such diffs cleanly...19:32
*** melwitt has quit IRC19:33
*** melwitt has joined #openstack-placement19:34
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event  https://review.openstack.org/59452719:36
mriedemif i have to diff a rebase in between,19:36
mriedemi just put up 2 side by side browser tabs of the 2 patch sets19:36
mriedemand eyeball it19:36
mriedemsort of like comparing a backport19:36
*** rubasov has quit IRC19:39
*** mriedem is now known as mriedem_afk19:39
efriedmriedem_afk: Okay, that's what I do as well. So - no better tooling at least that you know of. (I think dansmith says he downloads the deltas and does a fancy diff-of-diffs or something.)19:44
openstackgerritEric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692719:54
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503319:54
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider raise  https://review.openstack.org/58459819:54
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459919:54
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464819:55
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503419:55
openstackgerritEric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504919:55
openstackgerritEric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees  https://review.openstack.org/57623619:55
efriedcdent, jaypipes: ^ ready except the top one, which is going to need a new rebase & test fixup since https://review.openstack.org/#/c/520024/ merged.19:55
*** mriedem_afk is now known as mriedem21:04
openstackgerritDmitry Sutyagin proposed openstack/nova-specs master: Allow disabling KSM / mem-merge via extra spec  https://review.openstack.org/59319721:40
*** mriedem is now known as mriedem_away22:22
openstackgerritEric Fried proposed openstack/nova master: [placement] Regex consts for placement schema  https://review.openstack.org/59186323:05
openstackgerritEric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692723:05
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503323:05
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider raise  https://review.openstack.org/58459823:05
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459923:05
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464823:05
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503423:05
openstackgerritEric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504923:05
openstackgerritEric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees  https://review.openstack.org/57623623:05
efriedcdent, jaypipes: ^ rebased and fixed up to resolve merge conflict and tweak (hopefully all the right) tests for the _update call reduction. Should be ready for full review now.23:05
efriedmriedem_away, dansmith, melwitt, gibi_off: ^23:06
melwittack23:06
openstackgerritBrin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter  https://review.openstack.org/59197623:42
openstackgerritDan Smith proposed openstack/nova master: Batch results per cell when doing cross-cell listing  https://review.openstack.org/59269823:48
openstackgerritDan Smith proposed openstack/nova master: List instances from all cells explicitly  https://review.openstack.org/59371723:48
openstackgerritDan Smith proposed openstack/nova master: Make instance_list perform per-cell batching  https://review.openstack.org/59313123:48
openstackgerritDan Smith proposed openstack/nova master: Record cell success/failure/timeout in CrossCellLister  https://review.openstack.org/59426523:48
openstackgerritDan Smith proposed openstack/nova master: Make CELL_TIMEOUT a constant  https://review.openstack.org/59457023:48
openstackgerritDan Smith proposed openstack/nova master: Stash the cell uuid on the context when targeting  https://review.openstack.org/59457123:48
openstackgerritDan Smith proposed openstack/nova master: Make RecordWrapper record RequestContext and expose cell_uuid  https://review.openstack.org/59457223:48

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!