| *** Kevin_Zheng has joined #openstack-placement | 00:20 | |
| *** edmondsw has joined #openstack-placement | 00:42 | |
| *** edmondsw has quit IRC | 00:48 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_compute_api.py (4) https://review.openstack.org/568462 | 01:03 |
|---|---|---|
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5) https://review.openstack.org/570842 | 01:04 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6) https://review.openstack.org/571330 | 01:04 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992 | 01:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993 | 01:05 |
| openstackgerrit | Merged openstack/nova master: Retry decorator fix for instances which go into ERROR state during bulk delete https://review.openstack.org/563418 | 01:20 |
| openstackgerrit | Merged openstack/nova master: Set default of oslo.privsep.daemon logging to INFO level https://review.openstack.org/586643 | 02:01 |
| *** diga has joined #openstack-placement | 03:57 | |
| *** mriedem has quit IRC | 04:49 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Enable nested allocation candidates in scheduler https://review.openstack.org/585672 | 05:02 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Functional test for booting with nested resources https://review.openstack.org/527728 | 05:02 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add the guideline to write API reference https://review.openstack.org/569058 | 05:24 |
| *** tetsuro has quit IRC | 05:38 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] api-ref: add traits parameter https://review.openstack.org/578048 | 05:38 |
| *** tetsuro has joined #openstack-placement | 05:43 | |
| *** e0ne has joined #openstack-placement | 05:59 | |
| openstackgerrit | Chen proposed openstack/nova master: Fix bad links for admin-guide https://review.openstack.org/580259 | 06:27 |
| *** takashin has left #openstack-placement | 06:33 | |
| *** e0ne has quit IRC | 06:51 | |
| *** peereb has joined #openstack-placement | 07:10 | |
| openstackgerrit | huanhongda proposed openstack/nova master: NIT: Delete duplicated word in comments https://review.openstack.org/587302 | 07:10 |
| *** ttsiouts has joined #openstack-placement | 07:48 | |
| *** cdent has joined #openstack-placement | 07:55 | |
| *** ttsiouts has quit IRC | 07:59 | |
| openstackgerrit | jichenjc proposed openstack/nova master: remove ec2 object definitions https://review.openstack.org/557150 | 08:14 |
| openstackgerrit | jichenjc proposed openstack/nova master: remove ec2 db functions https://review.openstack.org/557572 | 08:14 |
| *** avolkov has joined #openstack-placement | 08:22 | |
| *** ttsiouts has joined #openstack-placement | 08:26 | |
| *** tssurya has joined #openstack-placement | 08:26 | |
| openstackgerrit | jichenjc proposed openstack/nova master: add zvm into support matrix https://review.openstack.org/532720 | 08:28 |
| openstackgerrit | jichenjc proposed openstack/nova master: Add zvm admin intro and hypervisor information https://review.openstack.org/533125 | 08:28 |
| openstackgerrit | jichenjc proposed openstack/nova master: Add zvm CI information https://review.openstack.org/533512 | 08:28 |
| cdent | weird: https://bugs.launchpad.net/nova/+bug/1784577 | 08:33 |
| openstack | Launchpad bug 1784577 in OpenStack Compute (nova) "Some allocation candidate tests for sharing providers fail in python 3.6 (and work in python 3.5)" [Medium,Confirmed] | 08:33 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Functional test for booting with nested resources https://review.openstack.org/527728 | 08:59 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Functional test for moving with nested resources https://review.openstack.org/587350 | 08:59 |
| *** diga has quit IRC | 09:07 | |
| *** e0ne has joined #openstack-placement | 09:13 | |
| gibi | cdent: could that behavior change caused by that python 3.6+ makes the insertion ordered? | 09:15 |
| gibi | s/makes the/makes the dict/ | 09:16 |
| cdent | I haven't look closely enough to really know | 09:16 |
| gibi | me neither | 09:17 |
| gibi | just guessing | 09:17 |
| cdent | it's a good guess | 09:21 |
| tetsuro | Interesting. Not happy to hear that, though. I'll look into that! | 09:30 |
| cdent | tetsuro: thank you! | 09:32 |
| *** tetsuro has quit IRC | 09:57 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Retry allocation writes server side https://review.openstack.org/586048 | 09:57 |
| *** ttsiouts has quit IRC | 10:14 | |
| *** ttsiouts has joined #openstack-placement | 10:19 | |
| *** ttsiouts has quit IRC | 10:24 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Remove redundant join in _anchors_for_sharing_providers https://review.openstack.org/587377 | 10:31 |
| openstackgerrit | Merged openstack/nova master: Fix being able to hard reboot a pausing instance https://review.openstack.org/566143 | 10:32 |
| openstackgerrit | Merged openstack/nova master: Update install guide for placement database configuration https://review.openstack.org/578013 | 10:32 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fixtures: Track attachments within CinderFixtureNewAttachFlow https://review.openstack.org/587013 | 10:51 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug#1784353 https://review.openstack.org/587014 | 10:51 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Recreate attachments during a reschedule https://review.openstack.org/587071 | 10:51 |
| *** tetsuro has joined #openstack-placement | 10:54 | |
| *** ttsiouts has joined #openstack-placement | 10:59 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/nova master: 'Updated_at' is NULL when show aggregate info https://review.openstack.org/580271 | 11:12 |
| cdent | tetsuro: you learning anything about that py36 situation? | 11:44 |
| tetsuro | No, I just reproduced the bug locally just now | 11:45 |
| tetsuro | cdent:Did you already get any ideas? | 11:46 |
| cdent | no, I haven't had a chance to look closely. gibi mentioned above about maybe changes in how dicts are handled in 3.6, but not sure. | 11:46 |
| tetsuro | Seems that duplication check I added before is not working. | 11:48 |
| * cdent nods | 11:48 | |
| cdent | which is very odd. that it is fragile in the face of version changes suggests there might be something more fundamental wrong :( | 11:49 |
| tetsuro | You're right the code may be kind of slippy slope... Look into this again to see what I can do to improve. | 11:50 |
| tetsuro | Hope this bug is a good bug that lead us to better way to go | 11:51 |
| cdent | would be great if that's the case | 11:51 |
| tetsuro | Anyway it's time to get out of the office. I'll look into this more closely tomorrow. | 11:53 |
| cdent | thanks very tetsuro | 11:53 |
| tetsuro | Thank you, too. Have a good day and night! | 11:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fixtures: Track attachments within CinderFixtureNewAttachFlow https://review.openstack.org/587013 | 12:12 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug#1784353 https://review.openstack.org/587014 | 12:12 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Recreate attachments during a reschedule https://review.openstack.org/587071 | 12:12 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't poison Host._init_events if it's already mocked https://review.openstack.org/585748 | 12:17 |
| *** edmondsw has joined #openstack-placement | 12:24 | |
| *** rubasov has quit IRC | 12:25 | |
| *** rubasov has joined #openstack-placement | 12:25 | |
| openstackgerrit | Lajos Katona proposed openstack/osc-placement master: Random names for functional tests https://review.openstack.org/542745 | 12:47 |
| openstackgerrit | Lenny Verkhovsky proposed openstack/nova master: WIP workaround for RHEL7.5 qemu 2.0 https://review.openstack.org/587409 | 12:56 |
| *** ttsiouts has quit IRC | 13:01 | |
| *** ttsiouts has joined #openstack-placement | 13:01 | |
| *** ttsiouts has quit IRC | 13:04 | |
| *** ttsiouts has joined #openstack-placement | 13:04 | |
| *** mriedem has joined #openstack-placement | 13:05 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Improve NeutronFixture and remove unncessary stubbing https://review.openstack.org/587412 | 13:10 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168 | 13:25 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Ensure attachment cleanup on failure in driver.pre_live_migration https://review.openstack.org/587439 | 13:45 |
| mriedem | cdent: re the 'RT hits placement a lot' thread, we still have https://bugs.launchpad.net/nova/+bug/1742467 and i think it still applies since compute isn't shared provider aware, | 14:07 |
| openstack | Launchpad bug 1742467 in OpenStack Compute (nova) "Compute unnecessarily gets resource provider aggregates during every update_available_resource run" [Medium,Triaged] | 14:07 |
| mriedem | although UPT will still pull all aggregates on each call right? | 14:07 |
| cdent | yeah, but if we could get down to once a periodic that would be nice | 14:07 |
| cdent | this https://review.openstack.org/#/c/587050/ didn't blow up spectactularly | 14:08 |
| cdent | I was hoping it might, so as to learn something | 14:08 |
| * efried not terribly surprised ^ | 14:09 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Improve NeutronFixture and remove unncessary stubbing https://review.openstack.org/587412 | 14:16 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove unnecessary PlacementFixture setups https://review.openstack.org/587490 | 14:34 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: fix disk_bus handling for root disk https://review.openstack.org/584999 | 14:52 |
| openstackgerrit | Merged openstack/nova master: Remove superfluous network stubbing in func test https://review.openstack.org/587134 | 14:54 |
| *** peereb has quit IRC | 15:06 | |
| openstackgerrit | Merged openstack/nova master: Fix formatting for vcpu_pin_set and reserved_huge_pages https://review.openstack.org/587206 | 15:13 |
| openstackgerrit | Merged openstack/nova master: [placement] api-ref: add traits parameter https://review.openstack.org/578048 | 15:13 |
| *** e0ne has quit IRC | 15:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle binding_failed vif plug errors on compute restart https://review.openstack.org/587498 | 15:24 |
| openstackgerrit | Merged openstack/nova stable/queens: Disable limits if force_hosts or force_nodes is set https://review.openstack.org/584616 | 15:29 |
| openstackgerrit | Merged openstack/nova stable/queens: Add functional regressions tests for server_group_members OverQuota https://review.openstack.org/581845 | 15:29 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup comp_node, res_prov, services, aggregate_hosts during cell deletion https://review.openstack.org/546660 | 15:43 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup comp_node, res_prov, services, aggregate_hosts during cell deletion https://review.openstack.org/546660 | 15:45 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: track down why inventory placement calls multiply https://review.openstack.org/587510 | 16:01 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: track down why inventory placement calls multiply https://review.openstack.org/587510 | 16:02 |
| cdent | jaypipes: that looks like it is duplicating the analysis that I did in my blog post. I list out the order of the method calls on what is getting inventory. all four in one periodic job are explained | 16:08 |
| cdent | oh, wait, this is better | 16:08 |
| cdent | carry on | 16:08 |
| cdent | no, I don't know. I'm confused. | 16:09 |
| cdent | jaypipes: is there an issue with PUTs multiplying? | 16:12 |
| *** rubasov has quit IRC | 16:13 | |
| jaypipes | cdent: it's totally just an exploratory thing... I'm curious where all the calls are coming from and just added that log message because I'm looking into it. | 16:18 |
| cdent | jaypipes: I'm curious to know what you find out. I've not seen much duplication on write ops, just read | 16:18 |
| efried | cdent: Ought we to duplicate nova's cors gabbits into placement with https://review.openstack.org/#/c/587183/ ? | 16:22 |
| efried | cdent: Disregard. | 16:23 |
| cdent | efried: I'm confused, nova doesn't use gabbits, those are placements gabbits, but they don't exercise that code | 16:23 |
| efried | yeah, forget I said anything. | 16:23 |
| cdent | rogher | 16:23 |
| *** tssurya has quit IRC | 16:32 | |
| *** yikun has quit IRC | 16:47 | |
| *** ttsiouts has quit IRC | 16:48 | |
| *** ttsiouts has joined #openstack-placement | 16:48 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use placement 1.28 in scheduler report client https://review.openstack.org/583667 | 16:52 |
| *** ttsiouts has quit IRC | 16:53 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258 | 16:58 |
| openstackgerrit | melanie witt proposed openstack/nova master: Don't overwrite greenthread-local context in host manager https://review.openstack.org/582332 | 17:14 |
| *** e0ne has joined #openstack-placement | 17:52 | |
| openstackgerrit | Merged openstack/nova stable/queens: Fix TypeError in prep_resize allocation cleanup https://review.openstack.org/581741 | 18:28 |
| openstackgerrit | Merged openstack/nova master: [placement] Retry allocation writes server side https://review.openstack.org/586048 | 18:28 |
| openstackgerrit | Merged openstack/nova master: Remove redundant join in _anchors_for_sharing_providers https://review.openstack.org/587377 | 18:28 |
| openstackgerrit | Merged openstack/nova stable/queens: Handle HostMappingNotFound when deleting a compute service https://review.openstack.org/583566 | 18:28 |
| openstackgerrit | Merged openstack/nova master: Don't poison Host._init_events if it's already mocked https://review.openstack.org/585748 | 18:28 |
| efried | cdent: As I'm working the tests for the last reshaper patch, I'm discovering more about the repetition of placement-ish stuff. | 18:47 |
| cdent | oh aye? | 18:47 |
| efried | I'm sure this was already clear in your head, but _init_compute_host does all the same shit that _update does. | 18:47 |
| efried | in fact the former calls the latter. | 18:47 |
| cdent | yes | 18:47 |
| cdent | that's what I said in my email/blog post | 18:47 |
| efried | I'm certain it is :) | 18:47 |
| efried | so | 18:48 |
| efried | take a look at this: | 18:48 |
| efried | https://review.openstack.org/#/c/576236/18/nova/compute/resource_tracker.py@710 | 18:48 |
| efried | What if we wrapped _init_compute_node in `if startup:` ? | 18:49 |
| efried | Cause assuming the method name and the comment are at all accurate/complete, it should only be necessary on startup, nah? | 18:49 |
| cdent | you'd think so, but when I did this analysis the first time around febish 2017, it was not at all clear that the method name was true at all and I couldn't figure it out on my lonesome | 18:50 |
| cdent | we talked about digging deeper and then got distracted | 18:50 |
| efried | yeah, looking at _init_compute_node, it does a lot of stuffs that don't look init-ish. | 18:51 |
| efried | okay, _setup_pci_tracker is already a singleton, so that can go. | 18:52 |
| efried | so the only thing left is this _copy_resources thing. | 18:52 |
| openstackgerrit | Merged openstack/nova stable/queens: unquiesce instance after quiesce failure https://review.openstack.org/581451 | 18:53 |
| cdent | efried: have you already had a gander at https://review.openstack.org/#/c/587050/ ? I assume based on your early "not surprised" comment | 18:53 |
| efried | and that comes from the virt driver's get_available_resource; so it needs to be done on periodic. | 18:53 |
| efried | cdent: Yes, I checked that before I pinged you. | 18:53 |
| cdent | ✔ | 18:54 |
| efried | I had looked at it before and understood what it was doing, but hadn't put it fully into context until I got into the aforementioned testing. | 18:54 |
| efried | cdent: I'm gonna put this out there as an idea: | 18:55 |
| efried | We pull copy_resources out of _init_compute_node and instead do it in _update_available_resource; *and* we condition _init_compute_node with `if startup:`. | 18:55 |
| * cdent holds breath | 18:55 | |
| efried | The latter has been nonobvious outside the context of the reshaper patch because percolating the `startup` param down the call stack was nontrivial. But with that in place, ^ might make sense. | 18:56 |
| cdent | I agree that it feels right. Hard to say if it is actualy right. | 18:56 |
| efried | Once I'm at a stopping point with the tests I'm writing, I'll propose a patch on top that does this and see if the world blows to smithereens. | 18:57 |
| cdent | cool sounds great | 18:57 |
| efried | or as my friend's kid says, to submarines. | 18:57 |
| *** tssurya has joined #openstack-placement | 18:58 | |
| cdent | it would be great if not blowing to smithereens inspired huge confidence | 18:58 |
| cdent | we need some Marko Ramius | 18:59 |
| cdent | melwitt, mriedem : cool to backport https://review.openstack.org/#/c/586048/ (server-side allocation rewrites) to queens? | 19:02 |
| cdent | It will conflict, but mostly because of moved files. | 19:02 |
| *** e0ne has quit IRC | 19:06 | |
| mriedem | cdent: without looking at the details of the change, it seems ok, i know it's a problem | 19:08 |
| melwitt | cdent: problem only goes back to queens, right? | 19:08 |
| mriedem | i'd probably want some burn in time before we start merging it in stable though | 19:08 |
| mriedem | it goes all the way back i think | 19:08 |
| melwitt | oh ok | 19:09 |
| mriedem | well, pike | 19:09 |
| mriedem | when the scheduler starting doing claims | 19:09 |
| mriedem | *started | 19:09 |
| cdent | I'll keep tabs on it | 19:11 |
| * cdent retires | 19:14 | |
| cdent | good night all | 19:14 |
| *** cdent has quit IRC | 19:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add functional scale test for Stats.__deepcopy__ time https://review.openstack.org/587606 | 19:19 |
| *** e0ne has joined #openstack-placement | 19:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add recreate test for bug 1784705 https://review.openstack.org/587614 | 20:04 |
| openstack | bug 1784705 in OpenStack Compute (nova) "ResourceTracker.stats can leak across multiple ironic nodes" [High,Triaged] https://launchpad.net/bugs/1784705 | 20:04 |
| *** avolkov has quit IRC | 20:10 | |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: fix disk_bus handling for root disk https://review.openstack.org/584999 | 20:41 |
| openstackgerrit | sean mooney proposed openstack/nova master: add regression test for bug 1759420 https://review.openstack.org/587615 | 20:41 |
| openstack | bug 1759420 in OpenStack Compute (nova) "nova does not correctly support HW_DISK_BUS=sata or usb for kvm/qemu" [Medium,In progress] https://launchpad.net/bugs/1759420 - Assigned to sean mooney (sean-k-mooney) | 20:41 |
| *** e0ne has quit IRC | 20:51 | |
| *** edmondsw has quit IRC | 21:00 | |
| *** edmondsw has joined #openstack-placement | 21:01 | |
| *** edmondsw has quit IRC | 21:01 | |
| *** edmondsw has joined #openstack-placement | 21:01 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add recreate test for bug 1784705 https://review.openstack.org/587614 | 21:31 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make ResourceTracker.stats node-specific https://review.openstack.org/587636 | 21:31 |
| openstack | bug 1784705 in OpenStack Compute (nova) queens "ResourceTracker.stats can leak across multiple ironic nodes" [High,Triaged] https://launchpad.net/bugs/1784705 | 21:31 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add recreate test for RT.stats bug 1784705 https://review.openstack.org/587614 | 22:10 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make ResourceTracker.stats node-specific https://review.openstack.org/587636 | 22:10 |
| openstack | bug 1784705 in OpenStack Compute (nova) "ResourceTracker.stats can leak across multiple ironic nodes" [High,In progress] https://launchpad.net/bugs/1784705 - Assigned to Matt Riedemann (mriedem) | 22:10 |
| *** mriedem has quit IRC | 22:14 | |
| *** edmondsw has quit IRC | 22:23 | |
| *** edmondsw has joined #openstack-placement | 22:23 | |
| *** edmondsw has quit IRC | 22:30 | |
| *** edmondsw has joined #openstack-placement | 22:31 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 22:34 |
| *** tssurya has quit IRC | 22:46 | |
| openstackgerrit | Merged openstack/nova master: Remove unnecessary PlacementFixture setups https://review.openstack.org/587490 | 23:00 |
| *** edmondsw has quit IRC | 23:11 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!