Monday, 2018-07-16

*** tetsuro has joined #openstack-placement03:02
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338703:36
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765803:36
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424003:36
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334003:36
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334403:36
*** tetsuro has quit IRC03:37
*** tetsuro has joined #openstack-placement03:38
*** tetsuro has quit IRC03:41
*** tetsuro has joined #openstack-placement03:42
*** tetsuro has quit IRC03:55
*** tetsuro has joined #openstack-placement04:12
*** tetsuro has quit IRC04:26
*** tetsuro has joined #openstack-placement04:53
*** tetsuro has quit IRC04:54
*** e0ne has joined #openstack-placement04:59
*** e0ne has quit IRC04:59
*** tetsuro has joined #openstack-placement05:11
*** tetsuro has quit IRC05:14
openstackgerritjichenjc proposed openstack/nova master: Adjust log style and remove ocata support  https://review.openstack.org/57646206:55
openstackgerritjichenjc proposed openstack/nova master: Not reraise DiskNotFound if instance is resized  https://review.openstack.org/57141007:00
openstackgerritjichenjc proposed openstack/nova master: mv generate_glance_url to get_image_endpoint_url  https://review.openstack.org/51140007:03
*** peereb has joined #openstack-placement07:17
openstackgerritjichenjc proposed openstack/nova master: remove ec2 object definitions  https://review.openstack.org/55715007:19
openstackgerritjichenjc proposed openstack/nova master: remove ec2 db functions  https://review.openstack.org/55757207:19
openstackgerritsahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages  https://review.openstack.org/53216807:34
*** giblet_off is now known as gibi07:38
openstackgerritTuan Do Anh proposed openstack/nova-specs master: fix tox python3 overrides  https://review.openstack.org/57979307:47
*** ttsiouts has joined #openstack-placement07:53
*** cdent has joined #openstack-placement08:10
*** tssurya has joined #openstack-placement08:16
openstackgerritjichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception  https://review.openstack.org/54115208:24
*** e0ne has joined #openstack-placement08:56
*** e0ne has quit IRC09:05
*** edmondsw has joined #openstack-placement09:10
*** e0ne has joined #openstack-placement09:13
*** edmondsw has quit IRC09:15
openstackgerritfupingxie proposed openstack/nova master: Delete allocations when it is re-allocated  https://review.openstack.org/58289909:15
*** peereb has quit IRC09:19
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031709:26
openstackgerritLei Zhang proposed openstack/nova master: Docs for reporting CPU traits feature  https://review.openstack.org/58290209:26
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Address nits in server group policy series  https://review.openstack.org/58161609:31
openstackgerritStephen Finucane proposed openstack/nova master: Remove support for /os-floating-ips-bulk REST API  https://review.openstack.org/58291210:06
*** e0ne has quit IRC10:28
*** ttsiouts has quit IRC10:32
*** e0ne has joined #openstack-placement10:34
*** edmondsw has joined #openstack-placement10:58
*** e0ne has quit IRC11:02
*** edmondsw has quit IRC11:03
*** e0ne has joined #openstack-placement11:15
*** ttsiouts has joined #openstack-placement11:18
cdentefried, jaypipes: I think I've got /reshaper past where eric rang out of time last week. Could of the existing gabbi tests are failing where expected. I'll go ahead and push it back up so we can discuss it more11:18
cdentThe failing tests are failing in ways that seemed expected based on eric's review of the parent11:19
openstackgerritChris Dent proposed openstack/nova master: WIP: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692711:24
cdentjaypipes: efried : ^11:25
cdentwill look into additional tests after a couple of other things11:25
deepak_mouryacdent:  Hi11:25
cdenthi deepak_mourya11:26
deepak_mouryaIs there anything left for this patch https://review.openstack.org/#/c/579423/ ?11:26
deepak_mouryaerror_code one11:26
* cdent looks11:26
cdentdeepak_mourya: looks good. when jaypipes comes around today he ought to be able to merge that11:28
cdentbiab11:29
deepak_mouryacdent:  okay no problem :)11:30
*** edmondsw has joined #openstack-placement11:53
*** edmondsw has quit IRC11:56
jaypipescdent: col, ty sir12:07
cdentjaypipes: diddling with the tests some more now12:08
jaypipesdeepak_mourya: +W'd!12:09
jaypipescdent: ack, they're tricky. tetsuro had some good input on them on one of the revisions.12:09
* cdent nods12:09
openstackgerritMerged openstack/nova master: network: Always retrieve network information if available  https://review.openstack.org/56444412:18
openstackgerritsean mooney proposed openstack/nova master: DNM test of intel nfv ci test changes  https://review.openstack.org/58294112:30
openstackgerritStephen Finucane proposed openstack/nova master: Remove support for /os-floating-ip-dns REST API  https://review.openstack.org/58294312:33
*** edmondsw has joined #openstack-placement12:34
efriedō/12:35
efriedcdent, jaypipes: What's the latest?  Anything I should look at right away?12:36
cdentefried: I'm just gonna push up some additional tests on https://review.openstack.org/#/c/576927/12:36
cdentI fixed the rebase block you timed out on12:36
efriedcdent: rgr.  And fwiw, when I started playing, I was going down the exact same path.12:37
efriedpulling that "ensure consumers for allocations" method out of set_allocations12:37
efriedand reusing it.12:37
*** edmondsw has quit IRC12:39
jaypipesefried, cdent: I'm trying to wrap up the pupdate for last week... sorry, was super sick all weekend (and still sick) and didn't get it done12:39
efriedThanks jaypipes. Hope you feel better quickly.12:40
cdentsick on weekends is the worst12:40
efriedcdent: The 'capacity exceeded' errors on the gabbi tests, those are ones we expect, right?12:42
cdentyes12:42
cdentthere's more about that in my forthcoming commit (which clarifies the tests and adds a bit more error handling)12:43
efriedbeaut12:43
openstackgerritStephen Finucane proposed openstack/nova master: Remove support for /os-floating-ips-bulk REST API  https://review.openstack.org/58291212:51
openstackgerritStephen Finucane proposed openstack/nova master: Remove support for /os-floating-ip-dns REST API  https://review.openstack.org/58294312:51
cdentsweet, hit an unexpected but real bug12:54
efriedyay testing12:54
openstackgerritChris Dent proposed openstack/nova master: WIP: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692712:58
cdentefried, jaypipes : please chew on that for while. I'm going to have some lunch. It's still not complete but is closer in ways that ought to be informative12:58
cdentthe last test in the gabbit is the 'unexpected but real bug'12:59
cdentbiab12:59
*** edmondsw has joined #openstack-placement13:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Add UUID validation for consumer_uuid  https://review.openstack.org/58037313:23
*** e0ne has quit IRC13:25
*** alex_xu has quit IRC13:29
*** e0ne has joined #openstack-placement13:32
*** alex_xu has joined #openstack-placement13:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Escalate UUID validation warning to error in test  https://review.openstack.org/54038613:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Enhance service restart in functional env  https://review.openstack.org/51255213:42
openstackgerritBalazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env  https://review.openstack.org/51255313:42
openstackgerritBalazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor  https://review.openstack.org/51262313:42
openstackbug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer)13:42
*** mriedem has joined #openstack-placement13:48
efriedScheduler/placement meeting in #openstack-meeting-alt in 7 minutes13:53
*** takashin has joined #openstack-placement13:55
jaypipesefried: were you wanting to add in tetsuro's additional test assertions from his comment on https://review.openstack.org/#/c/582383/2/nova/tests/functional/api/openstack/placement/db/test_reshape.py?14:01
efriedjaypipes: Did you see my response there? I thought it would be as/more effective to add them to the gabbits in the subsequent patch.14:02
jaypipesefried: if not, I can.14:02
efriedjaypipes: you can see some of that from cdent in his latest updates.14:02
openstackgerritStephen Finucane proposed openstack/nova master: Replace support matrix ext with common library  https://review.openstack.org/48130414:04
*** openstackgerrit has quit IRC14:04
*** openstackgerrit has joined #openstack-placement14:10
openstackgerritBalazs Gibizer proposed openstack/nova master: Call generate_image_url only for legacy notification  https://review.openstack.org/56452814:10
openstackgerritMerged openstack/nova stable/queens: hardware: fix hugepages memory usage per intances  https://review.openstack.org/58173614:27
*** ttsiouts has quit IRC14:44
*** ttsiouts has joined #openstack-placement14:47
*** takashin has left #openstack-placement14:47
openstackgerritMerged openstack/nova stable/pike: Backport tox.ini to switch to stestr  https://review.openstack.org/58049214:52
openstackgerritMerged openstack/nova master: Resource_provider API handler does not return specific error codes  https://review.openstack.org/57942314:52
jaypipescdent: yes, I am not going to summits any more. or at least, as long as they are all marketing BS.15:07
jaypipescdent: I'll probably end up having to attend the "T" or "U" summits because they are being merged back together with the PTGs, unfortunately.15:07
jaypipescdent: but I'll end up going to as little of the summit side as possible and sticking to the PTG parts.15:07
cdentsince boston, all I've done is forum stuff15:08
cdentexcept to watch efried and edleafe15:09
cdentjaypipes: yeah, killing the ptg is very :(15:10
gibido I see correctly that DELETE /allocations/{consumer_uuid} does not have a way to provide / assert consumer generation? I don't say I desperatly need to have that I'm just curious15:10
jaypipescdent: I watched efried and edleafe afterwards on video. good presentation.15:11
jaypipescdent: same with belmiro's presentation.15:11
cdentI always say to myself that I will watch the video and never do.15:11
jaypipescdent: but given that I can watch those (few) interesting presentations after the fact, I don't see a need to attend the summit as a whole. certainly not for the keynotes.15:11
* cdent nods15:11
jaypipescdent: the one nice thing about watching the vids online is trying to identify contributors from the back of their heads. luckily, your hair is easily identifiable ;)15:12
jaypipesdeepak_mourya: your patch is now merged (rp error codes)15:13
jaypipesdeepak_mourya: ty for your patience in reviews and for these patches. they are very much welcome!15:13
efriedgibi: That's one of the main reasons when we did the consumer gen work that we made it so you can PUT with an empty 'allocations' dict to delete.15:14
openstackgerritMerged openstack/nova master: Transform aggregate.update_prop notification  https://review.openstack.org/46257615:15
gibiefried: ahh I see. So when we bump the report client to 1.28 then we need to replace DELETE /allocations with PUT /allocations as well to keep it safe15:16
gibiefried: like in https://github.com/openstack/nova/blob/6ca30fd8323029604e60b611fc63a80c87dee84a/nova/scheduler/client/report.py#L183715:16
efriedgibi: Yes, exactly so.15:16
gibiefried: thanks15:16
efriedgibi: I did something similar for inventory deletions a while back.15:17
openstackgerritsean mooney proposed openstack/nova master: DNM test of intel-nfv-ci-test changes  https://review.openstack.org/58294115:19
cdentjaypipes, efried, gibi : I've got to take sarah to the doc (sprained her ankle this is a followup) but I'll be back around a bit later to followup on reshaper stuff15:20
gibiefried: btw, we have hard dependency between consumer gen (1.28) and nrp a_c (1.29) due to the fact that claim uses the api version that is used by the a_c query https://github.com/openstack/nova/blob/6ca30fd8323029604e60b611fc63a80c87dee84a/nova/scheduler/client/report.py#L155315:20
jaypipescdent: no worries, take care15:21
gibicdent: take care15:21
efriedgibi: If we're going through this stuff, it wouldn't hurt my feelings if we unwound that so it didn't have to be one version.15:22
efriedgibi: Better yet, I would prefer if we didn't take that parameter at all, and just used the right versions internally.15:22
efriedgibi: Since we now require placement to be updated first, we ought to be able to do that, and remove the business where we try to detect the host's max version.15:23
gibiefried: I have to read the history of this param first to know why we introduced it in the first place15:24
efriedgibi: I suspect it's because we didn't used to enforce "placement upgrades first". So we couldn't be sure we had the latest, and had to figure out from the host.  See https://github.com/openstack/nova/blob/6ca30fd8323029604e60b611fc63a80c87dee84a/nova/conductor/manager.py#L63015:24
*** tssurya has quit IRC15:30
gibiefried: when you say 'host' which host do you mean? compute host? For me it seems that the version is determined only be code in the get_allocation_candidates call15:33
gibihttps://github.com/openstack/nova/blob/16a2db6f23d150330dc82a56d0cf10366b004210/nova/scheduler/manager.py#L14815:33
efriedgibi: I was just trying to track that down. I don't know what that 'host' variable actually *is* at that point.15:33
openstackgerritMatt Riedemann proposed openstack/nova master: Update HostState.instances during _consume_selected_host  https://review.openstack.org/58297615:34
gibiefried: I think that is a Selection object15:34
efriedgibi: It looks like edleafe did a lot of the code around this. Perhaps he can shed some light on allocation_request_version - and tell us if we don't need it anymore, which would be neat.15:35
gibiefried: good point15:37
efriedgibi: Here's where that param was added: https://review.openstack.org/#/c/495854/15:39
openstackgerritMerged openstack/nova master: Microversion 2.64 - Use new format policy in server group  https://review.openstack.org/56753415:41
openstackgerritMerged openstack/nova master: do not assume 1 consumer in AllocList.delete_all()  https://review.openstack.org/58238215:43
jaypipesefried: fix for LP #1781430 now merged ^15:44
openstackLaunchpad bug 1781430 in OpenStack Compute (nova) "AllocationList.delete_all() incorrectly assumes a single consumer" [High,Fix released] https://launchpad.net/bugs/1781430 - Assigned to Jay Pipes (jaypipes)15:44
efriedjaypipes: woot15:55
edleafeefried: I argued against the need for allocation_request_version, but others insisted it was necessary. It would be an extremely contrived situation for an AR to be received at one version, and then used as a claim for a different microversion. I had convinced jaypipes at one point, but dansmith overruled.16:19
edleafeSo we're stuck with it. If you want to remove it, you need to talk to dansmith when he returns16:20
*** e0ne has quit IRC16:21
efriededleafe: Do you recall if it had anything to do with the possibility (now extinct) of placement being at different versions on different hosts?16:24
efriededleafe: or on the host vs conductor? That's not possible anymore, right, since you have to upgrade placement first?16:24
jaypipesefried: that was exactly the reason dansmith wanted to have the AR version in the payload.16:25
edleafeefried: to be honest, I really don't remember. Like I said, take it up with Dan16:25
efriedjaypipes: Okay, and at this point is that still a thing?16:26
jaypipesefried: no idea. is there a reason for the question? have you run into something about that?16:26
efriedjaypipes: Yeah, gibi was starting to look into bumping our allocs code to use consumer gens and nrp, and noticed that they're currently locked together by an allocations_request_version kwarg that's passed all the way from the conductor to the compute/reportclient.16:27
efriedjaypipes: I allowed as how there should be no need for them to be locked together; and started looking at that kwarg and thinking maybe we can get rid of it entirely.16:28
efrieddepending why it's there in the foist place.16:28
jaypipesefried: not sure I would say they are "locked together". I mean, yes, the placement's API version is passed to in the AR payload, down to the compute node. but is that causing some sort of problem per-se, for upping the microversion that the reportclient sends?16:28
efriedjaypipes: Not a problem, no. They're "locked together" in the code as currently written. And I'm trying to figure out if it's okay to break that open.16:29
jaypipesefried: in other words, AFAIK, the microversion sent from the placement service in its response for GET /allocation_candidates will be the microversion that particular placement server is at when the request was sent. The scheduler uses that version in its call to PUT /allocations (claim_resources()) and sends the alternate ARs down to the compute node.16:31
jaypipesefried: I fail to see where a problem would enter in w.r.t. that particular version bein in the alternate ARs.16:31
efriedjaypipes: Right. Is there any reason not to hardcode GET /a_c to 1.29 and PUT /allocs to 1.28??16:31
openstackgerritMerged openstack/nova master: Transform instance.live_migration_force_complete notification  https://review.openstack.org/48056116:33
openstackgerritMerged openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338716:34
openstackgerritMerged openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765816:34
jaypipesefried: you mean in the reportclient? I don't see a reason to hardcode the PUT /allocations at all if the version is being passed in the payload returned from GET /allocation_candidates16:34
efriedI'll have to go look at the API ref again. We're passing a version back with GET /a_c ?? I wasn't aware of that.16:37
jaypipesefried: no, I think we're just sending the OpenStack-API-Version value in the payload for the alternate ARs.16:44
jaypipesefried: but I'd have to check16:44
efriedI'll look once I'm off the phone16:44
jaypipesefried: for migrations, apparently we are hard-coding to 1.12 for some reason... https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L50116:47
efriedright16:48
efriedI'm guessing that's based on a historical point where 1.12 was the minimum version, and never been changed since then.16:48
jaypipesefried: and for everything else, we're hard-coding to the granular AC version for some reason. https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L34216:48
cdentjaypipes, efried: we made an explicit choice to always choose a specific version when making any request. which was a way of saying "we should never change this" but rather "we're acking the body structures here"16:57
cdentso if we want to change them, it's fine16:57
cdentbut when doing so we have to check that the assumptions the callers make are okay.16:57
*** ttsiouts has quit IRC17:15
*** ttsiouts has joined #openstack-placement17:15
jaypipescdent: ack, makes sense17:16
*** ttsiouts has quit IRC17:19
efriedgibi: ^17:24
cdentsigh17:37
efried?17:38
cdentI think most of you probably read through the contraction typo: s/which was/which wasn't/17:38
efriedyes17:38
efriedThe 'but rather' gave it away.17:38
cdentthe cdentease filter is relatively easy to learn too17:38
cdentthere are definite patterns17:39
* cdent makes dinner17:39
efriedwhat, make this the opposite of what it says?17:39
efriedbut only sometimes17:39
efriedThe only way that's easy to learn is by already knowing what you're going to say.17:39
efriedWhich, to be fair, is often doable. Except when it's not.17:39
*** tssurya has joined #openstack-placement17:46
openstackgerritMatt Riedemann proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations  https://review.openstack.org/56350517:57
openstackgerritMatt Riedemann proposed openstack/nova master: Compute: add support to abort queued live migration  https://review.openstack.org/56854217:57
openstackgerritMatt Riedemann proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file  https://review.openstack.org/58156217:57
openstackgerritMatt Riedemann proposed openstack/nova master: API: add support to abort queued live migration in microversion 2.65  https://review.openstack.org/57313617:57
*** e0ne has joined #openstack-placement18:14
openstackgerritsean mooney proposed openstack/nova master: DNM test of intel-nfv-ci-test changes  https://review.openstack.org/58294118:30
*** ttsiouts has joined #openstack-placement18:31
openstackgerritSurya Seetharaman proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration  https://review.openstack.org/56681318:52
*** e0ne has quit IRC19:05
openstackgerritAndreas Jaeger proposed openstack/nova master: Move legacy-tempest-dsvm-nova-os-vif in repo  https://review.openstack.org/58302319:12
openstackgerritAndreas Jaeger proposed openstack/nova master: Move legacy-tempest-dsvm-nova-os-vif in repo  https://review.openstack.org/58302319:14
openstackgerritEric Fried proposed openstack/nova master: Conf option cross-reference in config docs  https://review.openstack.org/58302519:16
*** e0ne has joined #openstack-placement19:25
*** e0ne has quit IRC19:26
cdentefried, jaypipes: I'm going to retire. If you are able to drop some thoughts on https://review.openstack.org/#/c/576927/ before my morning, I'll endeavor to address them. At the moment I think the main issues are outside the handler. There are, however, plenty more tests to make.19:47
efriedack, have a good night.19:48
* cdent waves19:49
*** cdent has quit IRC19:49
jaypipesefried: so which one of us is supposed to rebase 576236 and get address gibi and tetsuro's requests? :)20:01
efriedjaypipes: I think we let that one (the client side) go stale for a while until we've satisfied ourselves that the other two are copacetic.20:02
efriedjaypipes: So the question is, who's going to work those requests and in which (possibly both) of the other two?20:03
efriedguess it is both patches.20:03
openstackgerritMerged openstack/nova master: Add UUID validation for consumer_uuid  https://review.openstack.org/58037320:03
efriedjaypipes: How are you for time/bandwidth at the moment?20:04
jaypipesefried: stretched pretty thin with $work items20:20
openstackgerritMerged openstack/nova master: network: Retrieve tunneled status in '_get_physnet_info'  https://review.openstack.org/56444520:20
openstackgerritRick Bartra proposed openstack/nova master: Add granularity to os-services API  https://review.openstack.org/57855320:20
efriedjaypipes: okay. I'll give you a buzz if my afternoon opens up and I get a chance to look into it; you do the same, and whoever gets there first, gets there first.  Dig?20:20
*** ttsiouts has quit IRC20:24
*** ttsiouts has joined #openstack-placement20:24
*** ttsiouts has quit IRC20:28
jaypipesefried: today's afternoon or tomorrow's afternoon?20:31
efriedjaypipes: Either/both :)20:31
jaypipesefried: I'm busy today tracking down rabbitmq issues in some of our prod clusters. so I def won't get to it today. I could work on it tomorrow morning though.20:42
efriedjaypipes: Roger that. Just leave me a note here if/when you start on it.20:43
jaypipesefried: will do, thanks.20:45
openstackgerritMerged openstack/nova master: Update HostState.instances during _consume_selected_host  https://review.openstack.org/58297621:24
openstackgerritMatt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API  https://review.openstack.org/46967521:31
openstackgerritMultipleCrashes proposed openstack/nova master: Retry decorator fix for instances which go into ERROR state during bulk delete  https://review.openstack.org/56341821:38
*** tssurya has quit IRC22:07
openstackgerritMerged openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424022:32
*** edmondsw has quit IRC22:43
openstackgerritEric Fried proposed openstack/nova master: Conf option cross-reference in config docs  https://review.openstack.org/58302522:44
efriedmriedem: Made oslo.config patch https://review.openstack.org/#/c/583064/ and Depends-On'd ^ to it, so now :oslo.config:option:`foo.bar` will show up as a link in the HTML, but as [foo]/bar in the sample.22:45
*** edmondsw has joined #openstack-placement22:45
efried...if everything works, that is.22:46
efriedwhoops, meant that for -nova. Oh well, sue me.22:46
*** edmondsw has quit IRC22:50
*** bauzas has quit IRC23:43
*** bauzas has joined #openstack-placement23:43

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!