| *** takashin has joined #openstack-placement | 00:12 | |
| openstackgerrit | Merged openstack/nova master: Update process doc to be more generic about point of contact https://review.openstack.org/582312 | 00:30 |
|---|---|---|
| openstackgerrit | Merged openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498 | 00:43 |
| openstackgerrit | Vu Cong Tuan proposed openstack/nova-specs master: Switch to stestr https://review.openstack.org/581284 | 01:04 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add functional regression test for bug 1778305 https://review.openstack.org/582407 | 01:34 |
| openstackgerrit | melanie witt proposed openstack/nova master: Don't generate service UUID for deleted services https://review.openstack.org/582408 | 01:34 |
| openstack | bug 1778305 in OpenStack Compute (nova) "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Undecided,In progress] https://launchpad.net/bugs/1778305 - Assigned to melanie witt (melwitt) | 01:34 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add functional regression test for bug 1764556 https://review.openstack.org/582435 | 01:34 |
| openstack | bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,In progress] https://launchpad.net/bugs/1764556 | 01:34 |
| openstackgerrit | Chen proposed openstack/nova master: fix cellv2 delete_host https://review.openstack.org/582171 | 01:51 |
| openstackgerrit | Julia Kreger proposed openstack/nova master: ironic: provide facilities to gracefully navigate versions https://review.openstack.org/582416 | 01:53 |
| openstackgerrit | Julia Kreger proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 01:56 |
| *** mriedem has quit IRC | 02:04 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.live_migration_force_complete notification https://review.openstack.org/480561 | 02:19 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 02:32 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 02:44 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | 02:45 |
| openstackgerrit | Merged openstack/nova master: Follow up for Ie49d605c66062d2548241d7e04f5a2a6b98c011e https://review.openstack.org/582292 | 02:45 |
| openstackgerrit | Merged openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 02:45 |
| openstackgerrit | Merged openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 02:59 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 03:32 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240 | 03:44 |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: ironic: Log an error when API version is not available https://review.openstack.org/582447 | 04:35 |
| *** e0ne has joined #openstack-placement | 05:10 | |
| *** tetsuro has joined #openstack-placement | 05:28 | |
| *** e0ne has quit IRC | 05:50 | |
| *** e0ne has joined #openstack-placement | 05:58 | |
| *** e0ne has quit IRC | 05:59 | |
| *** e0ne has joined #openstack-placement | 06:01 | |
| *** e0ne has quit IRC | 06:06 | |
| *** e0ne has joined #openstack-placement | 06:06 | |
| *** e0ne has quit IRC | 06:09 | |
| *** e0ne has joined #openstack-placement | 06:17 | |
| *** e0ne_ has joined #openstack-placement | 06:21 | |
| *** e0ne has quit IRC | 06:22 | |
| *** e0ne has joined #openstack-placement | 06:22 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240 | 06:26 |
| *** e0ne_ has quit IRC | 06:26 | |
| *** tssurya has joined #openstack-placement | 06:29 | |
| *** e0ne_ has joined #openstack-placement | 06:33 | |
| *** e0ne_ has quit IRC | 06:33 | |
| *** e0ne has quit IRC | 06:35 | |
| *** e0ne has joined #openstack-placement | 06:40 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Address nits in server group policy series https://review.openstack.org/581616 | 06:43 |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: ironic: Log an error when API version is not available https://review.openstack.org/582447 | 06:45 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | 06:45 |
| *** tetsuro has quit IRC | 06:48 | |
| *** e0ne has quit IRC | 06:48 | |
| *** tetsuro has joined #openstack-placement | 06:49 | |
| *** tetsuro has quit IRC | 06:57 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019 | 06:58 |
| *** tssurya has quit IRC | 06:58 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562 | 06:59 |
| *** tetsuro has joined #openstack-placement | 07:00 | |
| *** tssurya has joined #openstack-placement | 07:00 | |
| *** peereb has joined #openstack-placement | 07:18 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | 07:41 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562 | 07:53 |
| *** ttsiouts has joined #openstack-placement | 08:00 | |
| *** e0ne has joined #openstack-placement | 08:07 | |
| *** tetsuro has quit IRC | 08:18 | |
| *** takashin has left #openstack-placement | 08:30 | |
| *** gibi is now known as giblet_off | 08:35 | |
| *** tetsuro has joined #openstack-placement | 08:35 | |
| *** tetsuro has quit IRC | 08:45 | |
| *** tetsuro has joined #openstack-placement | 08:45 | |
| *** tetsuro has quit IRC | 08:51 | |
| *** ttsiouts has quit IRC | 08:59 | |
| *** tetsuro has joined #openstack-placement | 09:01 | |
| openstackgerrit | tianhui proposed openstack/nova master: Change default video model from cirrus to vga https://review.openstack.org/582471 | 09:03 |
| *** ttsiouts has joined #openstack-placement | 09:14 | |
| *** tetsuro has quit IRC | 09:39 | |
| openstackgerrit | Chen proposed openstack/nova master: Clean up group members in db when delete https://review.openstack.org/581403 | 09:43 |
| openstackgerrit | huanhongda proposed openstack/nova-specs master: Return "deleted" and "estimated_reclaim" time of instance for admin https://review.openstack.org/581638 | 09:57 |
| *** tetsuro has joined #openstack-placement | 10:04 | |
| openstackgerrit | Chen proposed openstack/nova master: fix cellv2 delete_host https://review.openstack.org/582171 | 10:07 |
| *** ttsiouts has quit IRC | 10:08 | |
| *** ttsiouts has joined #openstack-placement | 11:08 | |
| openstackgerrit | Merged openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019 | 11:16 |
| *** edmondsw has joined #openstack-placement | 11:33 | |
| *** jaypipes is now known as leakypipes | 12:34 | |
| leakypipes | efried: ping me when you're around. we need to talk about this reshape DB work. | 12:34 |
| leakypipes | efried: basically, if you want me to take a strategy of "determine the actual changes that need to be performed instead of replacing the world", I will need to not call any of the existing methods like AllocationList.create_all() because they are destructive and blow away all allocations for all consumers involved in the allocation list object before re-creating them. If you want me to do that, so be it, but it's not the "replace the | 12:38 |
| leakypipes | world" strategy that everyone (except me) wanted to go with. | 12:38 |
| leakypipes | (and if it sounds like I'm annoyed because I'd originally suggested to do a PATCH operation with the caller just stating the changes that needed to be performed, it's because I am indeed annoyed) | 12:40 |
| *** mriedem has joined #openstack-placement | 12:40 | |
| leakypipes | I'm going to get some more coffee and go work on some other code for a while. ping me when you're ready to discuss and hopefully I'll be a bit calmer. | 12:40 |
| * leakypipes works on being calmer and less aggressive | 12:42 | |
| *** leakypipes is now known as smokypipes | 12:42 | |
| *** tetsuro has quit IRC | 12:45 | |
| *** tetsuro has joined #openstack-placement | 12:45 | |
| *** tetsuro has quit IRC | 12:45 | |
| *** ttsiouts has quit IRC | 12:54 | |
| *** smokypipes is now known as leakypipes | 12:58 | |
| mriedem | i know what can calm you down https://review.openstack.org/#/c/574488/ | 12:59 |
| mriedem | wink wink | 12:59 |
| leakypipes | mriedem: done | 13:12 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Online migration tool for populating queued-for-delete https://review.openstack.org/582536 | 13:12 |
| *** edleafe is now known as figleaf | 13:21 | |
| openstackgerrit | Merged openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 13:31 |
| mriedem | hot dog! | 13:34 |
| *** peereb has quit IRC | 13:44 | |
| *** ttsiouts has joined #openstack-placement | 14:00 | |
| *** efried is now known as fried_rice | 14:11 | |
| fried_rice | leakypipes: I'm here. | 14:12 |
| fried_rice | leakypipes: Are you saying that an existing PUT /allocations/{c} or POST /allocations operation will a) not check consumer gens and/or b) reset the gens to 0? That doesn't seem right. | 14:14 |
| fried_rice | leakypipes: I don't think we need to go full PATCH to make this work. If you're not already in the middle, wanna let me dork with it for a few minutes? | 14:15 |
| fried_rice | mriedem, leakypipes: I just noticed the placement api ref is missing response examples for GET /allocations <1.12 | 14:39 |
| fried_rice | Isn't that where the allocations were in list format? | 14:40 |
| mriedem | no, | 14:40 |
| mriedem | i think you're thinking of the changes to PUT and POST where we changed those to match GET | 14:41 |
| mriedem | https://developer.openstack.org/api-ref/placement/#request-microversions-1-0-1-11 | 14:41 |
| fried_rice | okay, cool. | 14:41 |
| mriedem | PUT < 1.12 was list format | 14:41 |
| fried_rice | Then I agree with dansmith (and PS5 me). | 14:42 |
| *** ttsiouts has quit IRC | 14:43 | |
| fried_rice | mriedem: left comments on heal allocs. If you can refute my argument (again) I'll +A. | 14:46 |
| *** ttsiouts has joined #openstack-placement | 14:50 | |
| mriedem | fried_rice: as in the thing i already replied to and noted that cdent was inline with the same thinking? | 14:57 |
| mriedem | oh nvm i see | 15:00 |
| mriedem | so if i understand correctly, GET /allocations/consumer_id 1.0 -> 1.27 is the exact same *except* for project_id/user_id returned in the top of the response body starting in 1.12 | 15:01 |
| mriedem | RIGHT?! | 15:01 |
| fried_rice | mriedem: Yes, that seems to be true (checked in the source code as well) | 15:02 |
| fried_rice | i.e. resp.json()['allocations'] never changed (even up to 1.29) | 15:03 |
| mriedem | so the requested change is to just always request 1.12 right? | 15:03 |
| mriedem | but i can keep the kwarg to return the full response vs just the resp.json()['allocations'] part right? | 15:04 |
| mriedem | because i'm not going to update all callers of this method in this change | 15:04 |
| mriedem | and will flip a gd table if i have to do it before | 15:04 |
| fried_rice | mriedem: Correct | 15:08 |
| fried_rice | mriedem: Though I would like to see you flip a table. | 15:09 |
| leakypipes | mriedem: ftr, I'm totally cool with doing any of those change for heal_allocations() in a followup. | 15:09 |
| mriedem | i'm doing the thing now | 15:09 |
| leakypipes | mriedem: I'd prefer to see that merged and make progress vs nitpicking it to death. | 15:09 |
| mriedem | running tests now | 15:09 |
| fried_rice | leakypipes: Not for the fact that we want to backport this, I would agree. | 15:10 |
| mriedem | naw it's fine, i just wasn't making the connection on the 1.12 thing until now | 15:10 |
| mriedem | and was confusing it with PUT /allocations 1.12 and the request body format change | 15:10 |
| leakypipes | mriedem: lots to be confused about for sure. | 15:10 |
| mriedem | placement is starting to get hair where there previously was no hair | 15:11 |
| mriedem | it's confusing times | 15:11 |
| * mriedem would tweet that if he tweeted | 15:11 | |
| fried_rice | leakypipes: Regarding reshaper, you want me to play with the "straddling inventory changes" thing? | 15:12 |
| leakypipes | fried_rice: you can if you want | 15:16 |
| leakypipes | fried_rice: in other words, I'm not going to stop you. | 15:17 |
| openstackgerrit | Chen proposed openstack/nova master: fix cellv2 delete_host https://review.openstack.org/582171 | 15:18 |
| leakypipes | fried_rice: I think you will find that you're not going to be able to use any of the existing methods: AllocationList.create_all() and ResourceProvider.set_inventory(). | 15:18 |
| leakypipes | fried_rice: because they blow away history and re-create it all from scratch. | 15:18 |
| fried_rice | leakypipes: noted. | 15:18 |
| fried_rice | leakypipes: Isn't AllocationList.create_all() (now replace_all()) what we use from PUT /allocations/{c} ? | 15:19 |
| leakypipes | fried_rice: yes. | 15:20 |
| leakypipes | fried_rice: and POST /allocations | 15:20 |
| fried_rice | leakypipes: okay, so my goal is to use that guy. It's the inventory changes I want to split up. | 15:20 |
| leakypipes | fried_rice: good luck. | 15:21 |
| fried_rice | leakypipes: I'm talking about doing it in three steps, total. | 15:21 |
| fried_rice | leakypipes: Not splitting into individual pieces. | 15:21 |
| leakypipes | fried_rice: like I said, good luck :) | 15:21 |
| fried_rice | leakypipes: i.e. [Inventory changes that don't remove any inventories] [AllocationList.replace_all()] [Inventory changes that delete inventories] | 15:21 |
| leakypipes | fried_rice: don't use ResourceProvider.set_inventory() then, since it'll blow away all your inventory records for the provider. | 15:22 |
| fried_rice | leakypipes: I should be able to use whatever the API uses to set inventories. Cause you can change inventories with allocations from the API as long as the end result still has the resource classes you started with. Even if you're reducing capacity below what's allocated, we let you go "into the red" that way. | 15:24 |
| leakypipes | fried_rice: like I said, good luck :) I'll be listening for your cries of horror. | 15:27 |
| fried_rice | ack | 15:27 |
| fried_rice | ^ not a cry of horror (yet) | 15:27 |
| leakypipes | fried_rice: no, that would have been "eck" or "eek". | 15:29 |
| *** ttsiouts has quit IRC | 15:30 | |
| *** ttsiouts has joined #openstack-placement | 15:33 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Heal allocations with incomplete consumer information https://review.openstack.org/574488 | 15:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor _heal_instances_in_cell https://review.openstack.org/577896 | 15:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance https://review.openstack.org/577905 | 15:39 |
| mriedem | fried_rice: leakypipes: ^ | 15:40 |
| fried_rice | mriedem: +2 | 15:41 |
| leakypipes | mriedem: the sarlacc pits await. | 15:44 |
| mriedem | YES | 15:45 |
| mriedem | just aim a little higher | 15:45 |
| mriedem | now you've got me craving colt 45 | 15:45 |
| leakypipes | :) | 15:46 |
| mriedem | melwitt: ^ another runways slot will open up today | 15:46 |
| melwitt | /fistpump | 15:47 |
| mriedem | for https://review.openstack.org/#/c/416487/ which needs a 2nd +2 | 15:47 |
| melwitt | yeah, I've got those on my list if someone doesn't get to them first | 15:47 |
| melwitt | oh, that's next in the runways queue, gotcha | 15:48 |
| *** ttsiouts has quit IRC | 15:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Skip more rebuild tests for cells v1 job https://review.openstack.org/581717 | 15:53 |
| *** tssurya has quit IRC | 15:53 | |
| *** e0ne has quit IRC | 15:54 | |
| fried_rice | leakypipes: You gonna have a look at the reshaper client side WIP for sanity today? | 16:04 |
| leakypipes | fried_rice: sure. link? | 16:04 |
| fried_rice | https://review.openstack.org/#/c/576236/ | 16:04 |
| fried_rice | really just to make sure I'm following what we agreed on, and there are no wild surprising things in there | 16:05 |
| fried_rice | leakypipes: Note I've also got a spec amendment up: https://review.openstack.org/#/c/582350/ | 16:05 |
| *** fried_rice is now known as fried_rolls | 16:18 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | 16:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | 16:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562 | 16:47 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440 | 17:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_metadata field https://review.openstack.org/564441 | 17:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata https://review.openstack.org/564452 | 17:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series https://review.openstack.org/582651 | 17:41 |
| *** fried_rolls is now known as fried_rice | 18:15 | |
| *** tssurya has joined #openstack-placement | 18:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API: add support to abort queued live migration in microversion 2.64 https://review.openstack.org/573136 | 18:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | 18:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562 | 18:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API: add support to abort queued live migration in microversion 2.64 https://review.openstack.org/573136 | 18:46 |
| *** tssurya has quit IRC | 18:59 | |
| fried_rice | leakypipes: Got that approach to work just fine. Posting in a sec. | 19:01 |
| fried_rice | leakypipes: it also checks consumer gens correctly (did the =99 thing and it broke as expected) | 19:02 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PoC: reshaper guts with inventory two-step https://review.openstack.org/582663 | 19:07 |
| fried_rice | leakypipes: ^^ | 19:08 |
| fried_rice | for your perusal and ultimate squashage if you think it's workable. | 19:08 |
| leakypipes | ack | 19:09 |
| *** tssurya has joined #openstack-placement | 19:21 | |
| openstackgerrit | Merged openstack/nova master: Heal allocations with incomplete consumer information https://review.openstack.org/574488 | 19:27 |
| fried_rice | melwitt, mriedem: That's a runway slot? ^ | 19:28 |
| *** tssurya_ has joined #openstack-placement | 19:30 | |
| mriedem | fried_rice: as in one is open? | 19:31 |
| mriedem | fried_rice: it was the last remaining item in the add-consumer-generation bp | 19:31 |
| fried_rice | mriedem: right | 19:31 |
| mriedem | so it was in a slot yes | 19:31 |
| mriedem | now it can be out of the slot | 19:31 |
| fried_rice | right | 19:31 |
| * fried_rice kicks translator | 19:31 | |
| mriedem | i'm not sure if you're saying it shouldn't have been slotted, or "it's merged so let's free up the slot" | 19:32 |
| fried_rice | the latter | 19:32 |
| mriedem | well then i wholeheartedly agree | 19:34 |
| fried_rice | something about a dutchie | 19:34 |
| fried_rice | which, by the way, Renae also had never heard of. | 19:34 |
| fried_rice | and she *did* grow up in this country, in the '80s | 19:34 |
| mriedem | tbf, | 19:35 |
| mriedem | i wasn't familiar with that song in my youth | 19:35 |
| fried_rice | you would have been in diapers when it came out | 19:35 |
| * fried_rice assumes you're not in diapers currently | 19:35 | |
| mriedem | i guess that's accurate | 19:36 |
| mriedem | born in 81 | 19:36 |
| mriedem | as for whether or not i'm currently still soiling myself, that's for me to know | 19:37 |
| leakypipes | fried_rice: good work on that reshaping reshaper into a reshaped shapely shape. once I'm done with a local patch I'll pull yours and squash. | 19:38 |
| fried_rice | leakypipes: Schweetness | 19:38 |
| leakypipes | fried_rice: I think you meant "reschweetness". | 19:40 |
| *** tssurya_ has quit IRC | 19:40 | |
| fried_rice | I should be working on my German. Resüssekeit | 19:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle HostMappingNotFound when deleting a compute service https://review.openstack.org/582674 | 19:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop using HostAPI.service_delete https://review.openstack.org/582680 | 20:00 |
| *** e0ne has joined #openstack-placement | 20:12 | |
| *** tssurya_ has joined #openstack-placement | 20:18 | |
| *** tssurya has quit IRC | 20:22 | |
| *** tssurya_ has quit IRC | 20:23 | |
| *** tssurya has joined #openstack-placement | 20:23 | |
| *** mriedem has quit IRC | 20:40 | |
| fried_rice | leakypipes: How do you feel about us shoving all the reshaper patches into a series at this point? Double-edged sword: better because we can keep the dependencies straight without Depends-On weirdness, but awkward because three different authors. | 20:56 |
| fried_rice | leakypipes: If you haven't gotten started yet, I can do that and squash in the inventory two-step thing. Then start working on expanding tests for cdent's microversion patch (to do real reshapes in addition to the existing sniff tests) and adding tests for the client side. | 20:58 |
| leakypipes | fried_rice: go for it. still trying to fix bugs on a diff patch | 21:00 |
| fried_rice | ack | 21:00 |
| leakypipes | fried_rice: please re-add in the LOG statements when you rebase/squash | 21:00 |
| fried_rice | leakypipes: You have a local edit for the nits on your reshaper db patch? | 21:00 |
| fried_rice | leakypipes: ('Done' responses to comments but no new PS in gerrit) | 21:00 |
| leakypipes | fried_rice: I do but they were tiny. feel free to fix those yourself when rebasing. | 21:01 |
| fried_rice | ight | 21:01 |
| leakypipes | ty sir | 21:01 |
| *** tssurya_ has joined #openstack-placement | 21:27 | |
| *** tssurya has quit IRC | 21:29 | |
| *** e0ne_ has joined #openstack-placement | 21:42 | |
| *** e0ne has quit IRC | 21:42 | |
| -openstackstatus- NOTICE: logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown. | 21:51 | |
| *** ChanServ changes topic to "logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown." | 21:51 | |
| fried_rice | leakypipes: Having transaction misbehavior on reshape. You around? | 21:54 |
| fried_rice | leakypipes: So we're doing three steps: 1) inventory hybrid; 2) allocations; 3) inventory final | 21:56 |
| fried_rice | When I make step 2 fail (with a bogus consumer generation) the rp gen bump from step 1 isn't getting rolled back. | 21:56 |
| fried_rice | actually, even if I make step 1 fail, same thing, the rp gen is still getting bumped. | 21:59 |
| fried_rice | oh. This is probably because I'm inside of whatever layer (wsgi?) does the outermost rollbacky thing, huh | 22:00 |
| fried_rice | I guess I'll test this from the outside via gabbi in the microversion patch. | 22:01 |
| *** figleaf is now known as edleafe | 22:05 | |
| *** e0ne_ has quit IRC | 22:12 | |
| *** e0ne has joined #openstack-placement | 22:13 | |
| leakypipes | fried_rice: yup. everything needs to be done within the reshape() function. see my comment in the docstring of that function | 22:16 |
| fried_rice | leakypipes: But it is. | 22:16 |
| fried_rice | leakypipes: So your test sets up the original invs & allocs; then it calls reshaper. | 22:16 |
| leakypipes | fried_rice: well, if that's the case, save what you have and push. I'll take a looksie tomorrow late morning (I'm off for the night now) | 22:17 |
| fried_rice | leakypipes: What I'm doing is, before I call reshaper, I muck with a generation somewhere. Call reshaper, and it fails, as it should, because gen mismatch. So far so good. | 22:17 |
| leakypipes | fried_rice: k | 22:17 |
| fried_rice | leakypipes: Then I fix the generation - back to its original value - and call reshaper again. It should succeed, because the failed one should have rolled back. | 22:17 |
| fried_rice | but it doesn't - I get ConcurrentUpdate again. | 22:17 |
| fried_rice | and debug printfs show that rp gens are staying incremented. | 22:18 |
| fried_rice | So either the transaction behavior is supposed to happen *outside* of the scope of reshaper, or... something else. | 22:18 |
| leakypipes | fried_rice: unfortunately, I'm taking off for the night. like I mentioned, feel free to push what you have and I'll have a look tomorrow? | 22:19 |
| fried_rice | ight | 22:20 |
| fried_rice | thanks | 22:20 |
| leakypipes | sorry man | 22:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: perform reshaper operations in single transaction https://review.openstack.org/582383 | 22:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 22:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 22:28 |
| *** edmondsw has quit IRC | 22:31 | |
| *** e0ne has quit IRC | 22:33 | |
| *** fried_rice is now known as efried | 22:36 | |
| *** tssurya_ has quit IRC | 23:26 | |
| *** edmondsw has joined #openstack-placement | 23:26 | |
| *** leakypipes is now known as jaypipes | 23:31 | |
| *** edmondsw has quit IRC | 23:31 | |
| *** ChanServ changes topic to "See https://docs.openstack.org/nova/latest/user/placement.html and https://developer.openstack.org/api-ref/placement/" | 23:35 | |
| -openstackstatus- NOTICE: logs.openstack.org is back on-line. Changes with "POST_FAILURE" job results should be rechecked. | 23:35 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!