| *** edmondsw has joined #openstack-placement | 01:13 | |
| *** edmondsw has quit IRC | 01:18 | |
| *** tetsuro has joined #openstack-placement | 01:38 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832 | 01:44 |
|---|---|---|
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628 | 01:44 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Refactor policies to policy in InstanceGroup DB model https://review.openstack.org/579113 | 01:44 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375 | 01:44 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 01:45 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy https://review.openstack.org/571166 | 01:45 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 01:45 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 01:45 |
| *** jaypipes has quit IRC | 02:06 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Regression test for bug 1779818 https://review.openstack.org/580011 | 02:08 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Update root providers in same tree https://review.openstack.org/580246 | 02:08 |
| openstack | bug 1779818 in OpenStack Compute (nova) "child's root provider is not updated." [Medium,Confirmed] https://launchpad.net/bugs/1779818 | 02:08 |
| *** jaypipes has joined #openstack-placement | 02:15 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 02:56 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 02:58 |
| *** edmondsw has joined #openstack-placement | 03:02 | |
| *** edmondsw has quit IRC | 03:06 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240 | 03:21 |
| openstackgerrit | Chason Chan proposed openstack/nova master: Update install guide for placement database configuration https://review.openstack.org/578013 | 03:24 |
| openstackgerrit | Chen proposed openstack/nova master: Fix bad links for admin-guide https://review.openstack.org/580259 | 03:24 |
| openstackgerrit | Vishakha Agarwal proposed openstack/nova master: 'Updated_at' is NULL when show aggregate info https://review.openstack.org/580271 | 03:49 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.live_migration_rollback_dest notification https://review.openstack.org/480214 | 04:20 |
| openstackgerrit | jichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception https://review.openstack.org/541152 | 04:25 |
| openstackgerrit | jichenjc proposed openstack/nova master: Avoid live migrate to same host https://review.openstack.org/542689 | 04:25 |
| *** edmondsw has joined #openstack-placement | 04:51 | |
| *** edmondsw has quit IRC | 04:55 | |
| *** e0ne has joined #openstack-placement | 05:18 | |
| *** e0ne has quit IRC | 05:21 | |
| *** nicolasbock has joined #openstack-placement | 05:49 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended availability zone controller https://review.openstack.org/502859 | 06:16 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 06:25 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 06:25 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 06:25 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 06:25 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 06:25 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019 | 06:47 |
| *** rubasov has left #openstack-placement | 06:55 | |
| *** rubasov has joined #openstack-placement | 07:02 | |
| *** tssurya has joined #openstack-placement | 07:09 | |
| openstackgerrit | Merged openstack/nova master: Merge server create schema for user data extension https://review.openstack.org/578349 | 07:19 |
| *** peereb has joined #openstack-placement | 07:22 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/queens: Fix unbound local when saving an unchanged RequestSpec https://review.openstack.org/580309 | 07:32 |
| *** e0ne has joined #openstack-placement | 07:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance-live_migration_post notification https://review.openstack.org/480119 | 07:56 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 07:59 |
| *** edmondsw has joined #openstack-placement | 08:28 | |
| *** ttsiouts has joined #openstack-placement | 08:30 | |
| *** edmondsw has quit IRC | 08:32 | |
| *** tssurya has quit IRC | 08:44 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver https://review.openstack.org/554195 | 08:59 |
| *** tssurya has joined #openstack-placement | 09:02 | |
| *** ttsiouts has quit IRC | 09:06 | |
| *** ttsiouts has joined #openstack-placement | 09:19 | |
| *** e0ne has quit IRC | 09:21 | |
| *** e0ne has joined #openstack-placement | 09:23 | |
| *** ttsiouts has quit IRC | 09:34 | |
| *** ttsiouts has joined #openstack-placement | 09:36 | |
| openstackgerrit | Merged openstack/nova master: Time how long pre_live_migration() takes https://review.openstack.org/574481 | 09:37 |
| *** ttsiouts has quit IRC | 09:50 | |
| *** ttsiouts has joined #openstack-placement | 10:05 | |
| *** ttsiouts has quit IRC | 10:06 | |
| *** ttsiouts has joined #openstack-placement | 10:07 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support deleting data volume when destroy instance https://review.openstack.org/580336 | 10:07 |
| *** ttsiouts has quit IRC | 10:11 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: add mtu to libvirt xml for ethernet and bridge types https://review.openstack.org/578010 | 10:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: add qemu version check when configuring mtu for network https://review.openstack.org/580188 | 10:21 |
| *** e0ne has quit IRC | 10:28 | |
| *** tssurya has quit IRC | 10:29 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform volume.usage notification https://review.openstack.org/580345 | 11:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform volume.usage notification https://review.openstack.org/580345 | 11:18 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform volume.usage notification https://review.openstack.org/580345 | 11:18 |
| *** ttsiouts has joined #openstack-placement | 11:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.live_migration_post notification https://review.openstack.org/480119 | 11:27 |
| *** edmondsw has joined #openstack-placement | 11:29 | |
| *** takashin has left #openstack-placement | 11:30 | |
| *** tetsuro has quit IRC | 11:35 | |
| gibi | jaypipes: hi! regarding https://bugs.launchpad.net/nova/+bug/1780107 what is you view about the missing foreign key between Consumer.project_id - Project.id and Consumer.user_id - User.id ? | 12:05 |
| openstack | Launchpad bug 1780107 in OpenStack Compute (nova) "The default of the missing project_id and user_id in placement is an invalid UUID" [Medium,Triaged] - Assigned to Jay Pipes (jaypipes) | 12:05 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support deleting data volume when destroy instance https://review.openstack.org/580336 | 12:07 |
| *** e0ne has joined #openstack-placement | 12:07 | |
| *** edmondsw has quit IRC | 12:07 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386 | 12:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use valid UUID in the placement gabbits https://review.openstack.org/580357 | 12:09 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: make incomplete_consumer_project_id a valid UUID https://review.openstack.org/580358 | 12:11 |
| jaypipes | gibi: ^ | 12:11 |
| jaypipes | gibi: one character patch, multi-paragraph commit message... :) | 12:11 |
| *** edmondsw has joined #openstack-placement | 12:13 | |
| jaypipes | gibi: I can add a migration that adds those FK constraints. I've been meaning to do that for a while now... | 12:15 |
| gibi | jaypipes: as heal allocation will fix the db content I'm OK with the fix. Do you want ot fix the uuid value in https://github.com/openstack/nova/blob/187f80a32c8b5cdfc115e9b90f4818f3d9d1f8fe/nova/tests/functional/api/openstack/placement/gabbits/ensure-consumer.yaml#L14 as well? | 12:15 |
| jaypipes | gibi: I can, yes. | 12:16 |
| gibi | jaypipes: that foregin key would have helped cden and me to understand the schema yesterday | 12:16 |
| *** edmondsw_ has joined #openstack-placement | 12:16 | |
| gibi | jaypipes: thanks | 12:17 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: make incomplete_consumer_project_id a valid UUID https://review.openstack.org/580358 | 12:18 |
| jaypipes | gibi: done ^ | 12:18 |
| *** edmondsw has quit IRC | 12:19 | |
| deepak_mourya | jaypipes: Hi | 12:19 |
| deepak_mourya | I want to add test for the placement_inuse error code, but some confusion is there while working on it https://review.openstack.org/#/c/551165/1 | 12:20 |
| jaypipes | gibi: there's been a slow evolution of this DB schema towards a normalized model. originally, we had allocations table with just a consumer_id column that was a VARCHAR(255) and we placed the consumer UUID in there. then we split out a consumers table and changed the allocations table to have an integer FK reference to the consumers table, and the consumers table had a VARCHAR(255) project_id and user_id field. Then we split out the | 12:20 |
| jaypipes | projects and users table. The FKs to those last tables just were forgotten by me, sorry. | 12:20 |
| jaypipes | deepak_mourya: wrong link :) that's an aodhclient patch... | 12:22 |
| gibi | jaypipes: I'm +2 on https://review.openstack.org/#/c/580358 | 12:22 |
| gibi | jaypipes: thank for the info about how the db schema evolved | 12:22 |
| deepak_mourya | oops sorry https://review.openstack.org/#/c/579423/4/nova/api/openstack/placement/handlers/resource_provider.py | 12:23 |
| jaypipes | gibi: and I'm +2 on https://review.openstack.org/#/c/580357/ :) | 12:23 |
| openstackgerrit | garyk proposed openstack/nova master: Prevent compute manager freeze when greenpool is full https://review.openstack.org/575034 | 12:23 |
| gibi | jaypipes: as a side track I realized that PUT /allocations/{consumer_id} does not have validation about the UUIDness of the consumer_id Is there a reason for not validated that in the API? | 12:24 |
| jaypipes | gibi: none that I can think of, no. | 12:27 |
| gibi | jaypipes: then I will try to add that | 12:28 |
| jaypipes | deepak_mourya: one sec. I think there's a functional test that exists already for that ProviderInUser scenario. lemme find it. | 12:29 |
| *** mriedem has joined #openstack-placement | 12:31 | |
| jaypipes | deepak_mourya: ok, no, there is no gabbit that is testing that scenario, unfortunately. you have two choices. the first choice would be to put a call to DELETE /resource_providers/$ENVIRON['RP_UUID'] directly below here in the allocations.yaml gabbit: https://github.com/openstack/nova/blob/master/nova/tests/functional/api/openstack/placement/gabbits/allocations.yaml#L135 | 12:33 |
| jaypipes | deepak_mourya: the second choice would be to copy that block that does the allocation into the resource-providers.yaml gabbit and add the DELETE call in that gabbit file. | 12:34 |
| jaypipes | deepak_mourya: I think probably the first choice would be good, but you may want to get cdent's thoughts on that. | 12:34 |
| deepak_mourya | jaypipes: i have tried one something but it failed others too like this | 12:35 |
| deepak_mourya | - name: fail to delete inuse resource provider | 12:35 |
| deepak_mourya | DELETE: /resource_providers/$ENVIRON['RP_UUID'] | 12:35 |
| deepak_mourya | request_headers: | 12:35 |
| deepak_mourya | accept: application/json | 12:35 |
| deepak_mourya | status: 409 | 12:35 |
| deepak_mourya | response_strings: | 12:35 |
| deepak_mourya | - "Unable to delete resource provider $ENVIRON['RP_UUID']" | 12:35 |
| deepak_mourya | response_json_paths: | 12:35 |
| deepak_mourya | $.errors[0].code: placement.resource_provider.inuse | 12:35 |
| jaypipes | deepak_mourya: you need to allocate against the resource provider, though, before the error will be raised :) | 12:36 |
| jaypipes | deepak_mourya: that particular error code is raised when you attempt to delete a resource provider that is "in use" -- i.e. the provider has had some of its inventory allocated to a consumer. | 12:37 |
| jaypipes | deepak_mourya: that's why you need to call PUT /allocations before the DELETE /resource_providers call. | 12:37 |
| jaypipes | deepak_mourya: and the resource-providers.yaml gabbit doesn't ever call PUT /allocations, which is why I recommend putting that new test for DELETE /resource_providers in the allocations.yaml gabbit directly after the test I linked above. | 12:38 |
| *** efried is now known as efried_off | 12:38 | |
| efried_off | cdent: yes | 12:39 |
| deepak_mourya | jaypipes: ok got it, that is why error was appeared . | 12:39 |
| jaypipes | deepak_mourya: cool. lemme know if you have any further questions. happy to help. | 12:39 |
| jaypipes | efried_off: cdent isn't online curretly... | 12:39 |
| efried_off | jaypipes: I know, but he p!spys | 12:39 |
| jaypipes | :) ah, ok | 12:40 |
| efried_off | or whatever that command is | 12:40 |
| *** e0ne has quit IRC | 12:48 | |
| *** ttsiouts has quit IRC | 12:54 | |
| *** ttsiouts has joined #openstack-placement | 12:55 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix whitespace damage https://review.openstack.org/580370 | 12:55 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 13:02 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 13:03 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add UUID validation for consumer_uuid https://review.openstack.org/580373 | 13:04 |
| gibi | jaypipes: here ^^ is the consumer_uuid validation | 13:05 |
| *** tssurya has joined #openstack-placement | 13:10 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix min_version for parent_provider_uuid in responses https://review.openstack.org/579577 | 13:14 |
| *** cdent has joined #openstack-placement | 13:15 | |
| jaypipes | gibi: hmm, I thought we had a way of doing the UUID format checking in JSONSchema... | 13:22 |
| jaypipes | gibi: I think it would be nicer to consolidate all the validation stuff into JSONSchema, but then again, I don't believe we use JSONSchema for the URL paramters, so this looks OK to me. | 13:23 |
| gibi | jaypipes: we have something for query parameters but nothing form URL path segments | 13:23 |
| jaypipes | gibi: ack | 13:24 |
| jaypipes | gibi: btw, what am I missing... why is "fcfa516a-abbe-45d1-8152-d5225d82e596" a bad UUID? | 13:25 |
| jaypipes | gibi: nm, I'm stupid. | 13:25 |
| jaypipes | gibi: "not-a-uuid" is the not a UUID :) | 13:25 |
| jaypipes | gibi: +2 | 13:25 |
| gibi | jaypipes: thanks :) | 13:26 |
| cdent | jaypipes, gibi: there's a small part of me that isn't certain that 400 is the right reponse for poorly formed path segment. A part of me says 404. But 400 is more practical and useful. | 13:32 |
| cdent | also I left a comment about how I'm not sure if being stricly uuid for consumer identifiers is the right way to go. it probably is, but I expressed some of the concerns/costs I could think of | 13:33 |
| cdent | edleafe: if you're around and have an opinion on https://review.openstack.org/#/c/580373/ | 13:34 |
| *** ttsiouts has quit IRC | 13:35 | |
| edleafe | cdent: I'm around. Will look | 13:35 |
| cdent | thanks | 13:35 |
| edleafe | cdent: I think you're right: the original concept was that the label could be anything. Since Nova is the only current use case for placement, though, and a instance UUID is the only thing we ever encounter, I think that the assumption was changed to UUIDs-only a while ago. | 13:38 |
| edleafe | I'm fully in favor of not restricting it, but I think those choices were already made | 13:38 |
| edleafe | Another result of placement remaining in Nova, IMO | 13:38 |
| gibi | cdent: I'm fine to go to the other direction and unrestrict the consumer_id. But then we have to figure out what can be there. Today the DB restricts it to String(36) | 13:40 |
| gibi | cdent: the current situation is feels a bad middle ground for me. DB and the object model has some assumptions but the API validates nothing | 13:41 |
| jaypipes | consumer_id was always a UUID. | 13:44 |
| jaypipes | from the beginning. | 13:44 |
| jaypipes | thus the String(36) definition. | 13:44 |
| mriedem | btw, the instance.project_id and user_id don't have to be UUIDs | 13:48 |
| mriedem | those are | 13:48 |
| mriedem | Column(String(255)) in nova | 13:48 |
| deepak_mourya | jaypipes: can you point me out the mistake or as per the suggested approach | 13:49 |
| deepak_mourya | name: fix inuse test for provider | 13:49 |
| deepak_mourya | PUT: /allocations/599ffd2d-526a-4b2e-8683-f13ad25f9958 | 13:49 |
| deepak_mourya | request_headers: | 13:49 |
| deepak_mourya | content-type: application/json | 13:49 |
| deepak_mourya | data: | 13:49 |
| deepak_mourya | allocations: | 13:49 |
| deepak_mourya | - resource_provider: | 13:49 |
| deepak_mourya | uuid: $ENVIRON['RP_UUID'] | 13:49 |
| deepak_mourya | resources: | 13:49 |
| deepak_mourya | DISK_GB: 10 | 13:49 |
| deepak_mourya | DELETE: /reseource_providers/$ENVIRON['RP_UUID'] | 13:49 |
| deepak_mourya | status: 409 | 13:49 |
| deepak_mourya | response_strings: | 13:49 |
| jaypipes | deepak_mourya: that should be a 204 response. after you PUT the allocations, the *next* test in the gabbit should be the DELETE /resource_providers/$ENVIRON['RP_UUID'] and it is *that* test which should expect the 409. | 13:52 |
| jaypipes | deepak_mourya: so, you need to do this above the DELETE: line: | 13:53 |
| jaypipes | - name: now try to delete the provider | 13:53 |
| jaypipes | along with a blank line... | 13:53 |
| jaypipes | mriedem: right, because Keystone's project and user IDs were not originally UUIDs... | 13:54 |
| jaypipes | mriedem: however, you can't create a project or user in Keystone and set the ID of the project/user at the same time. Keystone always creates a UUID value for the ID now. | 13:54 |
| deepak_mourya | jaypipes: ok will update this soon, Thanks bythe way ;) | 13:55 |
| jaypipes | deepak_mourya: no prob! | 13:55 |
| jaypipes | mriedem: so technically, we could change projects.external_id to VARCHAR(36) if we really wanted to... | 13:56 |
| *** e0ne has joined #openstack-placement | 13:59 | |
| *** ttsiouts has joined #openstack-placement | 14:00 | |
| cdent | edleafe: sorry, agree with what you said, but was more asking about 400 v 404 on the bad path parameter | 14:04 |
| edleafe | Oh, sorry | 14:04 |
| cdent | gibi: I agree that we need to go solidly one way or another | 14:05 |
| edleafe | Unless we define it strictly as a UUID, it should be 404. If we do define it as a UUID, then 400 | 14:05 |
| cdent | jaypipes: I distinctly recall conversations prior to when we coded the Allocations table, the option of it not being a uuid. It was coded as String(36) in 007a3a35413, but in the mitaka spec it was a VARCHAR(64) and I distincly remember some conversations about it being flexible on purpose. It's okay if we want to constrain it, but like I said in the comment that imposes some constraints on the clients that use | 14:09 |
| cdent | placement. | 14:09 |
| cdent | That's okay, but we need to mentally ack that | 14:09 |
| cdent | edleafe: yeah, that's kind of where I'm at. so given the way the wind is currently blowing, probably fine as is | 14:09 |
| *** tssurya has quit IRC | 14:15 | |
| mriedem | jaypipes: keystone's api reference clearly shows the project id doesn't have to be a uuid https://developer.openstack.org/api-ref/identity/v3/index.html#id404 | 14:19 |
| mriedem | "id": "0c4e939acacf4376bdcd1129f1a054ad", | 14:19 |
| cdent | mriedem: that is a uuid, just without the dashes | 14:21 |
| jaypipes | cdent: I don't think it is... | 14:21 |
| cdent | jaypipes: I just checked by creating a uuid from it | 14:21 |
| cdent | uuid.UUID('0c4e939acacf4376bdcd1129f1a054ad') | 14:22 |
| jaypipes | ah, yes. | 14:22 |
| cdent | which is part of why we have this bug | 14:22 |
| jaypipes | my character counting skills are clearly terrible | 14:22 |
| jaypipes | cdent: what do you mean? | 14:22 |
| cdent | https://bugs.launchpad.net/nova/+bug/1758057 | 14:22 |
| openstack | Launchpad bug 1758057 in OpenStack Compute (nova) "When creating uuid-based entities we can duplicate UUIDs" [Undecided,In progress] - Assigned to Rajat Sharma (tajar29) | 14:22 |
| jaypipes | ack | 14:23 |
| cdent | sorry, was slow on pasting the continuation there | 14:23 |
| cdent | mriedem: which is not to say that keystone is enforcing uuids, just that that example doesn't provide it. I'm solidly on the side of the "we really ought to be very flexible" | 14:24 |
| cdent | s/provide/prove/ | 14:24 |
| jroll | I'm 90% sure keystone project IDs don't have to be uuids, fwiw | 14:27 |
| *** tssurya has joined #openstack-placement | 14:34 | |
| * mriedem asks the source of truth in -keystone | 14:37 | |
| *** gagehugo has joined #openstack-placement | 14:41 | |
| *** gagehugo has left #openstack-placement | 14:56 | |
| *** knikolla has joined #openstack-placement | 14:57 | |
| bhagyashris | jaypipes: Hi, keen to know about further plans regarding spec https://review.openstack.org/#/c/555081/ | 14:58 |
| jaypipes | bhagyashris: twas killed by inertia. unlikely to be in Rocky. | 14:59 |
| bhagyashris | jaypipes: ok. thank you :) | 15:01 |
| bhagyashris | jaypipes: for confirmation | 15:02 |
| mriedem | (9:55:56 AM) knikolla: mriedem: for projects, unless they are using their own custom made driver, yes. for users, not. ldap users don't have UUIDs. | 15:04 |
| mriedem | (9:56:10 AM) knikolla: bf97c38af9e3a2db2f63190683180b138c57f393a2ebea70287698e1fc427072 | demo | 15:04 |
| knikolla | o/ | 15:21 |
| *** peereb has quit IRC | 15:22 | |
| *** edleafe- has joined #openstack-placement | 15:26 | |
| *** tssurya has quit IRC | 15:28 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: delete auto-created consumers on fail https://review.openstack.org/579921 | 15:34 |
| jaypipes | cdent: thx for your review on ^^. addressed your comments. | 15:34 |
| cdent | jaypipes: I guess the "figure out a way to use transactions" bit is a non-starter (at least for now)? | 15:36 |
| jaypipes | cdent: sorry, not following you.. | 15:40 |
| jaypipes | cdent: you mean for the reshaper? | 15:40 |
| cdent | jaypipes: my top level comment on that review | 15:40 |
| cdent | instead of the in code comments | 15:40 |
| jaypipes | cdent: ah | 15:41 |
| *** e0ne has quit IRC | 15:42 | |
| jaypipes | cdent: you're basically advocating pushing everything in there into a big method in objects/resource_provider.py, right? basically, what edleafe's original solution was that I was negative on, right? | 15:42 |
| cdent | Not that directly, no. I was just wondering if there was a way to get the db to do the work for us. | 15:43 |
| cdent | I don't actually remember what edleafe's implementation was, nor your concerns with it: I was on holiday then. | 15:43 |
| mriedem | btw, i thought about asking for the rollback in a db transaction but wasn't sure how feasible that was | 15:45 |
| cdent | Simply that looking at the situation now we have a classic case where a rollback would be nice | 15:45 |
| mriedem | because that would be ideal | 15:45 |
| jaypipes | I can rewrite it, but it will cause delay in getting this fixed. and the rewritten code will not be any simpler (likely will be a lot more complex) than what is there now. | 15:47 |
| edleafe | cdent: my implementation only created the consumer record at the end of the process. If there was any failure, the whole thing rolled back and there was no "orphan" | 15:47 |
| jaypipes | edleafe: there was also no project or user concept in your code. | 15:48 |
| jaypipes | edleafe: so there was less to do, essentially. | 15:48 |
| edleafe | jaypipes: there were lots of other differences. I was just commenting on the relevant one | 15:48 |
| jaypipes | edleafe: because storing denormalized data in a single table is easier than storing the normalized data in three... | 15:49 |
| jaypipes | in any case, just let me know what you want me to do and I'll do it. I need to leave now for an hour and a half or so. ciao. | 15:49 |
| mriedem | i'm ok with a backportable bolt on for now, which could be later refactored into something using transactions which i agree will be more complicated and definitely not something we'd want to backport if we can help it | 15:50 |
| *** mgagne has joined #openstack-placement | 15:55 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302 | 15:58 |
| *** edleafe- has quit IRC | 15:58 | |
| *** ttsiouts has quit IRC | 16:31 | |
| *** ttsiouts has joined #openstack-placement | 16:31 | |
| openstackgerrit | Andreas Karis proposed openstack/nova master: Add documentation for emulator threads policy https://review.openstack.org/579956 | 16:33 |
| *** ttsiouts has quit IRC | 16:36 | |
| openstackgerrit | Andreas Karis proposed openstack/nova master: Add documentation for emulator threads policy https://review.openstack.org/579956 | 16:41 |
| *** e0ne has joined #openstack-placement | 17:03 | |
| cdent | does anyone know if this bug is resolved. it looks at least partially so: https://bugs.launchpad.net/nova/+bug/1731072 | 17:09 |
| openstack | Launchpad bug 1731072 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters returns garbage with multiple aggregates" [Medium,Confirmed] | 17:09 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 17:20 |
| jaypipes | cdent: I *think* tetsuro had fixed that... | 17:35 |
| cdent | yeah, that's my feeling as well: *think* but not certain | 17:35 |
| *** e0ne has quit IRC | 17:36 | |
| jaypipes | maybe efried_off knows.. | 17:57 |
| cdent | yeah, my todo list said to ask him | 18:01 |
| cdent | but that _off bit put me off | 18:01 |
| *** e0ne has joined #openstack-placement | 18:01 | |
| *** e0ne_ has joined #openstack-placement | 18:03 | |
| *** e0ne__ has joined #openstack-placement | 18:05 | |
| *** e0ne has quit IRC | 18:06 | |
| *** e0ne_ has quit IRC | 18:08 | |
| *** ttsiouts has joined #openstack-placement | 18:43 | |
| *** purplerbot has quit IRC | 18:48 | |
| *** purplerbot has joined #openstack-placement | 18:48 | |
| *** cdent has quit IRC | 18:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: factor out compute service start in ServerMovingTest https://review.openstack.org/580473 | 19:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: factor out compute service start in ServerMovingTest https://review.openstack.org/580473 | 20:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Moving more utils to ProviderUsageBaseTestCase https://review.openstack.org/580490 | 20:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add functional test for deleting a compute service https://review.openstack.org/580491 | 20:14 |
| openstackgerrit | Matthew Treinish proposed openstack/nova stable/pike: Backport tox.ini to switch to stestr https://review.openstack.org/580492 | 20:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: api-ref: add a note in DELETE /os-services about deleting computes https://review.openstack.org/580494 | 20:17 |
| openstackgerrit | Matthew Treinish proposed openstack/nova stable/pike: Backport tox.ini to switch to stestr https://review.openstack.org/580492 | 20:20 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Block deleting compute services which are hosting instances https://review.openstack.org/580496 | 20:25 |
| openstackgerrit | Matthew Treinish proposed openstack/nova stable/pike: Backport tox.ini to switch to stestr https://review.openstack.org/580492 | 20:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Delete allocations from API if nova-compute is down https://review.openstack.org/580498 | 20:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/580499 | 20:38 |
| *** tssurya has joined #openstack-placement | 20:39 | |
| *** takashin has joined #openstack-placement | 20:47 | |
| *** cdent has joined #openstack-placement | 20:58 | |
| *** cdent has quit IRC | 21:33 | |
| *** tssurya has quit IRC | 21:36 | |
| *** e0ne__ has quit IRC | 21:41 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova-specs master: Use list of dict for ip_addresses field in metadata https://review.openstack.org/580514 | 21:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (2) https://review.openstack.org/573481 | 21:59 |
| *** e0ne has joined #openstack-placement | 22:00 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova-specs master: Use list of dict for ip_addresses field in metadata https://review.openstack.org/580514 | 22:04 |
| *** nicolasbock has quit IRC | 22:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform volume.usage notification https://review.openstack.org/580345 | 22:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform volume.usage notification https://review.openstack.org/580345 | 22:26 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104 | 22:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106 | 22:37 |
| *** edmondsw_ has quit IRC | 22:40 | |
| *** edmondsw has joined #openstack-placement | 22:41 | |
| *** edmondsw has quit IRC | 22:45 | |
| *** e0ne has quit IRC | 22:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Default embedded instance.flavor.disabled attribute https://review.openstack.org/580522 | 23:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Default embedded instance.flavor.disabled attribute https://review.openstack.org/580523 | 23:05 |
| *** ttsiouts has quit IRC | 23:05 | |
| *** ttsiouts has joined #openstack-placement | 23:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Default embedded instance.flavor.disabled attribute https://review.openstack.org/580525 | 23:08 |
| *** mriedem has quit IRC | 23:08 | |
| *** ttsiouts has quit IRC | 23:10 | |
| *** ttsiouts has joined #openstack-placement | 23:11 | |
| *** ttsiouts has quit IRC | 23:17 | |
| *** ttsiouts has joined #openstack-placement | 23:18 | |
| *** ttsiouts has quit IRC | 23:22 | |
| *** ttsiouts has joined #openstack-placement | 23:22 | |
| *** ttsiouts has quit IRC | 23:32 | |
| openstackgerrit | Merged openstack/nova master: Default embedded instance.flavor.disabled attribute https://review.openstack.org/579925 | 23:33 |
| *** ttsiouts has joined #openstack-placement | 23:33 | |
| *** ttsiouts has quit IRC | 23:35 | |
| *** ttsiouts has joined #openstack-placement | 23:35 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!