Friday, 2018-06-08

*** tetsuro has joined #openstack-placement00:27
openstackgerritTetsuro Nakamura proposed openstack/nova master: placement: Use INNER JOIN for requied traits  https://review.openstack.org/57311300:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs  https://review.openstack.org/51960101:05
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix nits in nested provider allocation candidates(2)  https://review.openstack.org/57347501:20
*** mriedem_afk is now known as mriedem01:23
*** mriedem is now known as mriedem_afk01:37
*** tetsuro has quit IRC01:53
*** tetsuro has joined #openstack-placement01:53
*** mriedem_afk is now known as mriedem01:54
*** mriedem has quit IRC02:10
openstackgerritShuo Liu proposed openstack/nova-specs master: fix spelling mistake  https://review.openstack.org/57347902:20
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (2)  https://review.openstack.org/57348102:22
openstackgerritShuo Liu proposed openstack/nova-specs master: fix spelling mistake in rst file  https://review.openstack.org/57348702:49
openstackgerritSteve Kowalik proposed openstack/nova master: Switch to oslo_messaging.ConfFixture.transport_url  https://review.openstack.org/57304603:26
*** tetsuro has quit IRC04:48
*** tetsuro has joined #openstack-placement04:49
*** bhagyashri_s has quit IRC05:01
*** bhagyashri_s has joined #openstack-placement05:05
-openstackstatus- NOTICE: Zuul stopped receiving gerrit events around 04:00UTC; any changes submitted between then and now will probably require a "recheck" comment to be requeued. Thanks!06:01
*** e0ne has joined #openstack-placement06:09
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804506:25
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all providers - multiple providers  https://review.openstack.org/55948006:25
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all providers - single provider  https://review.openstack.org/57354506:25
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix nits in nested provider allocation candidates(2)  https://review.openstack.org/57347506:37
*** e0ne has quit IRC06:44
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create  https://review.openstack.org/52031306:45
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Create specs directory for Stein  https://review.openstack.org/57360207:06
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add microversion for nested allocation candidate  https://review.openstack.org/56548707:15
*** e0ne has joined #openstack-placement07:26
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix nits in placement-return-all-resources series  https://review.openstack.org/57360407:34
*** bauzas is now known as PapaOurs07:38
openstackgerritTetsuro Nakamura proposed openstack/nova master: WIP: Optimize member_of check for nested providers  https://review.openstack.org/57320307:38
*** tetsuro has quit IRC07:43
*** takashin has left #openstack-placement08:03
*** ttsiouts has joined #openstack-placement08:12
*** gibi is now known as giblet08:18
openstackgerritZhenyu Zheng proposed openstack/nova master: API: add support to abort queued live migration in microversion 2.63  https://review.openstack.org/57313608:31
openstackgerritBalazs Gibizer proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing  https://review.openstack.org/56045908:45
gibletjaypipes, efried: I had to update ^^ to fix the functional test failure and added to extra assert as well. I think the 3 of us can send this in now.08:48
giblets/to/two/08:55
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models.  https://review.openstack.org/56337508:57
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object  https://review.openstack.org/57362808:57
*** ttsiouts has quit IRC09:16
*** ttsiouts has joined #openstack-placement09:16
*** ttsiouts has quit IRC09:20
*** ttsiouts has joined #openstack-placement09:21
*** edmondsw has joined #openstack-placement09:26
*** edmondsw has quit IRC09:30
openstackgerritShuo Liu proposed openstack/nova master: fix keytone to keystone in releasenotes.po  https://review.openstack.org/57364009:30
openstackgerritjiang wei proposed openstack/nova master: Add action initiator attribute to the instance info  https://review.openstack.org/53624309:33
*** ttsiouts has quit IRC09:34
*** ttsiouts has joined #openstack-placement09:36
*** ttsiouts has quit IRC10:06
openstackgerritZhenyu Zheng proposed openstack/nova master: API: add support to abort queued live migration in microversion 2.63  https://review.openstack.org/57313610:08
openstackgerritBhagyashri Shewale proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing  https://review.openstack.org/56045910:27
*** stephenfin is now known as finucannot10:44
*** ttsiouts has joined #openstack-placement11:00
openstackgerritBalazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request  https://review.openstack.org/57331711:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object  https://review.openstack.org/56884012:02
*** nicolasbock has joined #openstack-placement12:13
*** ttsiouts has quit IRC12:32
jaypipesgiblet: +2 from me.12:36
*** ttsiouts has joined #openstack-placement12:37
*** edleafe is now known as figleaf12:37
*** bhagyashris_ has joined #openstack-placement12:44
*** ttsiouts has quit IRC12:45
*** bhagyashri_s has quit IRC12:48
*** edmondsw has joined #openstack-placement13:02
*** ttsiouts has joined #openstack-placement13:04
gibletjaypipes: I can send it to the gate, do we want to wait for efried to take a look too?13:06
*** edmondsw has quit IRC13:06
jaypipesgiblet: I'm cool with you sending it, yes.13:14
jaypipesgiblet: efried wrote a chunk of it so didn't want to +W it.13:14
gibletjaypipes: Ohh, OK. sending it through...13:14
bhagyashris_jaypipes, giblet: Thanks for review :)13:18
gibletbhagyashris_: thanks for working on fixing the bug13:19
bhagyashris_:)13:21
jaypipesbhagyashris_: no worries, thanks for your patience with us.13:21
*** efried is now known as fried_rice13:21
jaypipesooooh.13:21
*** jaypipes is now known as leakypipes13:21
bhagyashris_jaypipes: :) no issues13:28
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_info field  https://review.openstack.org/56444113:30
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add InstanceNUMANetworkInfo object  https://review.openstack.org/56444213:30
openstackgerritStephen Finucane proposed openstack/nova master: network: Unchain _get_phynet_info from _get_port_vnic_info  https://review.openstack.org/56444313:30
openstackgerritStephen Finucane proposed openstack/nova master: network: Add 'create_resource_requests' to network API  https://review.openstack.org/56444413:30
openstackgerritStephen Finucane proposed openstack/nova master: network: Add '_get_network_tunnel_status'  https://review.openstack.org/56444513:30
*** mriedem has joined #openstack-placement13:32
fried_ricegiblet, leakypipes, bhagyashris_: \ō/13:35
gibletfried_rice: happy Friday!13:35
leakypipesfried_rice: is that a halo?13:35
bhagyashris_\o/13:36
fried_riceleakypipes: It only really looks like that with the double-arm 'yay' going on.  It's my crew cut.13:38
leakypipes:)13:38
-openstackstatus- NOTICE: A misapplied distro security package update caused many jobs to fail with a MERGER_FAILURE error between ~06:30-12:30 UTC; these can be safely rechecked now that the problem has been addressed13:47
*** edmondsw has joined #openstack-placement13:54
openstackgerritEric Fried proposed openstack/nova master: fix tox python3 overrides  https://review.openstack.org/57297413:58
PapaOursfried_rice: you know that I like diagrams, don't you ? :)13:59
fried_ricePapaOurs: I was just teasin, daddy bear.13:59
* PapaOurs chilling14:00
PapaOursfried_rice: honestly, using segdiag is fine with me14:00
PapaOursfried_rice: it's just that you wrote something I think that's just implementation stuff14:00
fried_ricePapaOurs: I agree it wouldn't have been sufficient on its own - but the necessary details are called out in the sections below, yes?  Is there anything missing?14:00
fried_riceoh.  Yeah, I like to write specs in such a way that anyone could go and implement them, even if the original authors all go down in a plane crash.  I must have learned that in school.14:01
PapaOurs:)14:02
fried_ricePapaOurs: Seriously though, thinking through the impl raised some design questions it's better to address now.  Like whether we need the list of affected providers.  Which I still need to think through some more.14:04
PapaOursfried_rice: sure, but the concern I have is that people could be -1 because of some implementation discussion, while they could miss the main reason why we provide this spec, ie. the new placement API resource14:05
fried_ricePapaOurs: Well, we definitely need the spec to include more than just the placement API piece.14:07
fried_ricePapaOurs: That's only part of the picture.14:07
PapaOursfried_rice: sure, of course14:07
PapaOursanyway, see this comment I made as a just nit14:08
PapaOursfried_rice: if people discuss about the main one, fine with me14:08
fried_ricePapaOurs: Your point is taken, though.  If we start to get into too much of a battle there, I can remove some impl details.14:08
fried_ricePapaOurs: Hoping it doesn't come to that.14:08
PapaOursfried_rice: cool then14:08
PapaOursfried_rice: yeah, hopefully too !14:08
fried_ricePapaOurs: btw, unrelated subject, the DISK_GB/libvirt thing is in the gate.  Did you want to have a look at that before it disappears?14:09
PapaOurswell, if it's in the gate.. :)14:09
PapaOursI was more looking at specs14:09
fried_ricePapaOurs: Okay.  I thought you were keeping an eye on that for your own purposes.  But maybe you only cared about the prior one that implemented update_provider_tree.  Anyway https://review.openstack.org/560459 if interested.14:10
openstackgerritJay Pipes proposed openstack/nova master: placement: always create consumer records  https://review.openstack.org/56767814:12
openstackgerritJay Pipes proposed openstack/nova master: add consumers generation field  https://review.openstack.org/55795814:12
openstackgerritJay Pipes proposed openstack/nova master: placement: Allocation.consumer field  https://review.openstack.org/56540514:12
openstackgerritJay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict()  https://review.openstack.org/56540714:12
openstackgerritJay Pipes proposed openstack/nova master: Add a microversion for consumer generation support  https://review.openstack.org/56560414:12
openstackgerritStephen Finucane proposed openstack/nova master: network: Unchain _get_phynet_info from _get_port_vnic_info  https://review.openstack.org/56444314:18
openstackgerritStephen Finucane proposed openstack/nova master: network: Add 'create_resource_requests' to network API  https://review.openstack.org/56444414:18
openstackgerritStephen Finucane proposed openstack/nova master: network: Retrieve tunneled status in '_get_network_info'  https://review.openstack.org/56444514:18
leakypipesfried_rice: +2 on reshaper spec. I have a few nits but it appropriately captures the spirit of the discussion and the agreed-upon implementation.14:38
fried_riceleakypipes: Roger that, thanks for reviewing.  I will be respinning fyi.14:39
fried_riceleakypipes: I would like to discuss the performance impact that edmondsw brought up, related to our needing to gather allocations on every periodic.14:39
leakypipesfried_rice: I don't see why we'd need to do that on every periodic run.14:40
fried_riceleakypipes: The obvious answer is to cache like we do the provider_tree - which is something you suggested in passing (adding allocations to ProviderTree)14:40
leakypipesfried_rice: in fact, pretty sure if we do that, Surya and CERN will run screaming.14:41
fried_riceleakypipes: Chicken/egg.  Only the virt driver can tell us whether we're doing a migration, but unless we make it a two-step process (update_provider_tree() -> indicates migration needed -> discover and send allocations -> get altered allocations back)....14:42
fried_riceback in 10.14:43
leakypipesfried_rice: ack. that two-stage process *might* be worthwhile investigating, but could be done if performance woes ensue from this original approach.14:44
fried_riceleakypipes: Another option is only doing this thing on compute startup.  Problem there is, if it fails, how to redrive?14:51
openstackgerritBalazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec  https://review.openstack.org/56726715:03
openstackgerritBalazs Gibizer proposed openstack/nova master: Add bandwidth related standard resource classes  https://review.openstack.org/57084715:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler  https://review.openstack.org/56726815:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding  https://review.openstack.org/56945915:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request  https://review.openstack.org/57331715:13
*** ttsiouts has quit IRC15:28
*** ttsiouts has joined #openstack-placement15:30
*** cdent has joined #openstack-placement15:40
*** cdent has quit IRC15:40
*** e0ne has quit IRC15:41
mriedemfried_rice: we could likely set some kind of db flag to indicate we have or haven't done the migratoin check for a given instance15:52
mriedemset a flag when starting, and then set again when done - even if we didn't need to migrate anything15:53
mriedemcould be a system_metadata flag per instance.15:53
mriedemthat's a lot of db updates if you're restarting 1000 computes at once15:53
fried_ricemriedem: Mm.  And sounds pretty complicated.15:54
fried_ricemriedem: When would you set the flag?15:54
mriedemwhenever you start checking the migrations - on compute start, but thread it out15:54
mriedemfor the ironic flavor migration and my patch to migrate old bdm attachment records, we thread that out15:54
mriedemand they are idempotent, i.e. they know when they don't need to do anything15:54
mriedemfried_rice: https://review.openstack.org/#/c/549130/15:55
mriedemmight only need to set a flag once - get all instances on a given host that don't have the system_metadata flag set (nrp-migrated=True?)15:55
mriedemso for instances that don't have the flag on that host on startup, process them and then set the flag as you process each one15:56
mriedemthen it's a one time thing, not during every periodic15:56
mriedemdansmith: ^15:56
fried_ricemriedem: So on compute start, set the flag;15:57
fried_ricethen in update, if the flag is set, collect allocations and send them to the virt driver15:57
fried_ricethen in update_provider_tree, only make migration-y changes if allocations is not None (and otherwise, what, continue to model the old way?)15:57
fried_ricethen in update_from_provider_tree, check whether allocations is not None and if so, do the /migrator thing15:57
fried_riceif that succeeds, unset the flag15:57
fried_riceotherwise leave it set for the next periodic15:57
dansmithwe can't thread it out I think,15:57
dansmithbecause we have to convert them all at the same time as updating our inventory right?15:58
dansmithwe need to do this before we let the rest of the startup procedure complete15:58
fried_riceyeah, it wouldn't be a per-instance flag.15:58
mriedemok so then that's update_available_resources as fried_rice said above15:58
dansmithnot sure we need a marker, because if we don't complete, we're just going to re-generate the new state of the world15:58
dansmithmriedem: right, but one-shot head of time, and if it doesn't complete we bail15:58
mriedempoint is, i'd like to only do this once per startup, and not refresh the wold every periodic to know if we've already done this15:59
fried_ricedansmith: The issue is that we're trying to avoid needing to collect allocations every periodic.15:59
dansmithyeah, has to be that way I think15:59
fried_ricebecause that's expensive.15:59
dansmithfried_rice: agreed, which is why it should be one specific operation we call at startup15:59
mriedemthat's why i suggested a flag15:59
dansmithmriedem: but per instance is not a thing15:59
dansmithyou have to convert them all at once15:59
fried_ricedansmith: agree15:59
mriedembut how do you know if you don't need to run it on every other restart of the servioce?15:59
fried_rice^16:00
mriedemif this is a one time thing, we shouldn't check this on every startup if we can help it16:00
dansmithchecking to see if the current allocations look like what we expect at service start is less expensive than pulling flags for all our instances and then doing the migration right?16:00
mriedemif it's not per-instance, then it's per-host i guess16:01
mriedembut we don't have host metadata to store random stuff16:01
dansmithor, we just check our own inventory.. if we have migrated our inventory, our instances had to go with it16:01
fried_riceThe other thing leakypipes and I discussed above was having a separate ComputeDriver method that asks provider_migrate_needed(provider_tree).  We only pull allocations to send to update_provider_tree if that answers True.16:01
mriedemif pulling all of the current allocations isn't a big deal, then meh16:01
mriedemi'm pretty sure we already do pull allocations during every update_available_resources periodic16:01
dansmithwe have to update our inventory and allocations atomically, so if our inventory looks good (which is inexpensive to pull and we have to do it anyway) then we're good16:01
dansmithelse we migrate16:01
openstackgerritBalazs Gibizer proposed openstack/nova master: Fix unbound local when saving an unchanged RequestSpec  https://review.openstack.org/57376816:02
fried_riceIf we don't think the expense of pulling allocations is an issue, then we're good as written.  Do you think this is something we can just defer until/unless it's a problem?16:02
dansmithdefer what until when?16:03
mriedemthis is what i was thinking of, which is different https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L125316:03
fried_ricesuperdansmith: defer <figuring out a way to avoid pulling the allocations every time> until <someone (CERN) complains that it's killing them>16:04
fried_rices/every time/every periodic/16:04
dansmithdefer not effectively doing the migration on every periodic?16:04
mriedemi'm thinking about that periodic that CERN had to disable16:05
mriedemb/c it killed them on startup16:05
dansmithfried_rice: mriedem: can we hangout this real quick to make sure we're on the same page/16:05
mriedemwasn't that pulling allocatoins?16:05
dansmithyeah, CERN definitely needs this to be right16:05
dansmithmriedem: yes16:05
dansmithassociations actually, but..16:05
mriedemi have to leave here in about 5 minutes16:05
dansmithokay, I'm trying to avoid a conflict too16:06
mriedemi could after i'm back16:06
dansmithoh okay16:06
mriedemmy afternoon is openish16:06
dansmithmine isn't, but..16:06
dansmithbut agree, this has to be relatively low impact from the start16:06
dansmiththey had to actively remove the association sync to function at all, this'll definitely break them16:06
dansmith(if we don't do it well)16:07
*** cdent has joined #openstack-placement16:08
cdentfried_rice: I'm still planning to look at the shaping spec today, but I'm running a bit behind schedule: slept for 19 hours16:09
fried_ricecdent: cool mon.16:09
cdentcombo of jet lag and the remainder of conference-cold16:09
fried_ricedansmith: I can (sigh) start an etherpad with some options...16:10
*** ttsiouts has quit IRC16:11
* cdent adds etherpaddingn to fried_rice's cv16:14
fried_ricevay16:14
*** ttsiouts has joined #openstack-placement16:18
*** ttsiouts has quit IRC16:22
fried_ricedansmith, mriedem, leakypipes, cdent: https://etherpad.openstack.org/p/reshape-provider-tree-performance16:28
fried_riceedmondsw: ^16:28
fried_ricebbl16:29
*** fried_rice is now known as fried_rolls16:29
leakypipessweet.. "old jaypipes" is gone now.16:30
cdentfinally died16:31
cdentso old16:31
leakypipesyep16:31
leakypipesthe ghost finally moved on.16:31
fried_rollsfor now.  In previous pads it took him a while to show up.16:33
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276616:46
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143516:46
openstackgerritChris Dent proposed openstack/nova master: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385716:46
openstackgerritChris Dent proposed openstack/nova master: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406717:02
-openstackstatus- NOTICE: The Zuul scheduler was offline briefly to clean up from debugging a nodepool issue, so changes uploaded or approved between 16:50 and 17:15 UTC may need to be rechecked or reapproved (all already queued changes are in the process of being reenqueued now)17:24
*** edleafe has joined #openstack-placement17:33
*** figleaf has quit IRC17:35
*** edleafe is now known as figleaf18:13
openstackgerritChris Dent proposed openstack/nova stable/queens: Ensure resource class cache when listing usages  https://review.openstack.org/57381118:36
cdentmriedem: ^ no conflicts after all, just gerrit not liking file moves18:39
mriedemah18:39
*** fried_rolls is now known as fried_rice18:43
*** bhagyashri_s has joined #openstack-placement20:00
*** bhagyashris_ has quit IRC20:03
*** bhagyashris_ has joined #openstack-placement20:11
*** bhagyashri_s has quit IRC20:15
*** e0ne has joined #openstack-placement20:27
fried_ricemriedem, cdent, leakypipes, dansmith, edmondsw: Only Chris expressed a preference on https://etherpad.openstack.org/p/reshape-provider-tree-performance20:39
fried_riceShall I move forward with "conditioned by virt driver"?20:39
fried_rice(NB: I proposed a tweak to the code flow that doesn't entail an extra method)20:39
leakypipesfried_rice: I haven't looked at the etherpad much yet, sorry :(20:43
leakypipesfried_rice: can we discuss more on the etherpad and on Monday?20:43
fried_ricesure.  I'm leaving a note on the spec that will hopefully make sure we don't forget the issue.20:43
leakypipesk, thx20:44
fried_ricefigleaf: Can you have a look at https://review.openstack.org/#/c/573113/ when you get a chance please?21:22
fried_ricefigleaf: Basically need you to be my second +2 if you can follow the sql21:23
*** e0ne has quit IRC22:00
*** nicolasbock has quit IRC22:06
*** fried_rice is now known as efried22:35
figleafefried: sorry, already started the weekend. Will look on Monday.23:15
*** figleaf is now known as edleafe23:15
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276623:30
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143523:30
openstackgerritChris Dent proposed openstack/nova master: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385723:30
openstackgerritChris Dent proposed openstack/nova master: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406723:31
openstackgerritChris Dent proposed openstack/nova master: Extract part of PlacementFixture to placement  https://review.openstack.org/56835923:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!