| bhitesh9 | vkmc, gouthamr: Hello, hope you are doing well. | 08:33 |
|---|---|---|
| bhitesh9 | I am trying to reproduce bug (https://bugs.launchpad.net/python-manilaclient/+bug/1967312), but I am a bit confused in bug description, when you say "In the list implementation", you mean manila list? | 08:34 |
| bhitesh9 | and kindly guide me on how to reproduce this, this is low-hanging-fruit but the whole ecosystem is a bit of overwhelming for me right now. | 08:35 |
| bhitesh9 | What I am assuming that how can I reproduce this: | 08:36 |
| bhitesh9 | 1) create shared file system | 08:36 |
| bhitesh9 | 2) list the created shared file system using manila list | 08:36 |
| bhitesh9 | Disclaimer: messed up with devstack in my VM, deleted it and created a fresh one :p | 08:37 |
| bhitesh9 | I need community's help to report my contribution on outreachy portal, today is the last day at 4:00PM UTC. Kindly guide my way I liked this project as well I am very enthusiastic about cloud. | 08:40 |
| bhitesh9 | Thanks in advance. | 08:40 |
| bhitesh9 | Update regarding username: | 10:23 |
| bhitesh | bhitesh and bhitesh9 belong to same person | 10:27 |
| bhitesh | sometime a get first username and sometime a get second choice of username, just for no confusion, thanks | 10:28 |
| carloss | o/ bhitesh - I believe it refers to using the `is_soft_deleted` parameter while performing manila list, using a version between "2.35" and "2.68" | 12:00 |
| bhitesh | carloss: kindly tell me the website where openstack folks paste their code output and share via link | 12:02 |
| bhitesh | carloss: I am not able to create new share at first place it is asking for share type, stuck in a loop | 12:02 |
| carloss | paste.opendev.org | 12:03 |
| carloss | so to reproduce, you would need to: create a shared file system, list the created shared file system with `--soft-delete` (using a version between 2.35 and 2.68) | 12:03 |
| carloss | to do that you'll need to modify this file in your env: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/api_versions.py#L30 | 12:04 |
| carloss | and set it to 2.68 for example | 12:04 |
| carloss | yes, you will need a share type - but it should be getting the default at this point | 12:04 |
| carloss | the fix itself would consist of changing the type of search_opts here: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shares.py#L357 | 12:05 |
| carloss | so instead of using search_opts=None, we'll need to declare it as a dictionary | 12:05 |
| bhitesh | carloss: I have some issues while creating shared file system using manila kindly check this paste link : https://paste.opendev.org/show/bxLhVOAO7ybWeOBD9pw1/ | 12:32 |
| carloss | oh, I believe this doc is outdated | 12:33 |
| carloss | bhitesh: I'll get you some doc, one minute please | 12:33 |
| * carloss while doing so finds a doc bug :) | 12:34 | |
| carloss | https://docs.openstack.org/manila/latest/admin/shared-file-systems-share-types.html#share-type-operations | 12:34 |
| carloss | on the type create, manila shouldn't show up twice | 12:34 |
| carloss | but this should help | 12:34 |
| carloss | and to load the credentials, you'll need to go to your devstack folder and run | 12:34 |
| carloss | `source openrc` | 12:35 |
| carloss | and it'll load the environment variables into your session | 12:35 |
| bhitesh | okay, on it | 12:35 |
| bhitesh | carloss: successfully created share-type and share file system, but when using command "manila list --soft-delete" getting "ERROR: Filtering by is_soft_deleted is only available with manila API version >= 2.69" | 13:04 |
| bhitesh | but I didn't changed MAX_VERSION yes | 13:05 |
| bhitesh | and one more question when I will change in any file I need to restart that service like "systemctl restart devstack@service_name"? | 13:06 |
| carloss | hmmm, the validation in the CLI is working then, one sec please | 13:06 |
| carloss | what if you try only listing shares, in the version 2.68 without the --soft-delete | 13:08 |
| carloss | ? | 13:08 |
| carloss | I'm afraid you wouldn't be able to reproduce, after checking the bug report and the code for both OSC and manilaclient | 13:10 |
| carloss | > so instead of using search_opts=None, we'll need to declare it as a dictionary | 13:10 |
| carloss | we could do this change either way though, just to reinforce that we would never run into the issue | 13:10 |
| bhitesh | when I do "manila list" getting back the file system I created. | 13:22 |
| bhitesh | so need to convert None into dictionary now? | 13:23 |
| bhitesh | I mean empty or it will be having any default value? | 13:24 |
| carloss | yes, converting none into a dictionary | 13:29 |
| bhitesh | carloss: I will be changing file which is under /opt/stack/python-manilaclient/... and devstack is setup under ~/devstack. so how am I be able to commit those changes? | 13:39 |
| carloss | you'd need to go to the python-manilaclient folder and commit the changes from there | 13:40 |
| carloss | https://docs.openstack.org/doc-contrib-guide/quickstart/first-timers.html - here's some good documentation to help | 13:42 |
| bhitesh | Oo, I see. I didn't worked in such project where whole project is bootstrap out of multiple projects, things are getting interesting. | 13:43 |
| bhitesh | carloss: I am getting some error while executing "git review -s" kindly have a look, paste link: https://paste.opendev.org/show/b1QFbZM9EiE8hvktlJA1/ | 14:02 |
| carloss | Description: fatal: No Contributor Agreement on file for user Hitesh Bhati <hbhatiwork@gmail.com> - this seems to be the issue bhitesh | 14:03 |
| bhitesh | I generated a new ssh key and added into my opendev account | 14:03 |
| carloss | you'd need to sign the individual contributor agreement | 14:04 |
| carloss | getting you a link | 14:04 |
| carloss | https://docs.openstack.org/contributors/common/setup-gerrit.html#individual-contributor-license-agreement-icla | 14:04 |
| bhitesh | Okay now I accepted the agreement, but I was able to do the same on sandbox, that was sandbox that's why? | 14:08 |
| carloss | i think it was | 14:08 |
| bhitesh | so we need to agree on particular repo or need to do once for all? | 14:11 |
| carloss | doing once will solve it for any contribution you might do in any other repo in the future :) | 14:12 |
| bhitesh | carloss: I pushed my commit, kindly have a look : https://review.opendev.org/c/openstack/python-manilaclient/+/863652 | 14:15 |
| rotensepro | bhitesh: Hi mate, i think improving the commit message will be cool. Look at the documentation here >>> https://wiki.openstack.org/wiki/GitCommitMessages | 14:21 |
| bhitesh | sure | 14:22 |
| bhitesh | rotensepro: thanks for suggestion | 14:25 |
| carloss | ++ - code looks correct, rotensepro's suggestion is also something I'd suggest | 14:26 |
| carloss | also using Closes-Bug: #1234567 tag in your commit | 14:27 |
| carloss | commit message* | 14:27 |
| bhitesh | carloss: can I use this review link as contribution in outreachy? | 14:32 |
| carloss | bhitesh: yes, you can :) | 14:36 |
| bhitesh | carloss gouthamr: there is a question in outreachy final application which is "Outreachy internship project timeline", what should I gave answer to it, I didn't discussed yet and only few minutes are left? | 15:13 |
| carloss | iirc there was an example in the project itself | 15:17 |
| carloss | bhitesh: is that it? | 15:18 |
| carloss | in the project's intern tasks | 15:18 |
| bhitesh | okay | 15:18 |
| *** dtantsur_ is now known as dtantsur | 17:56 | |
| *** dtantsur_ is now known as dtantsur | 18:29 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!