| francie | Hello carloss, maaritanmn: Please review - https://review.opendev.org/c/openstack/python-manilaclient/+/815157 | 07:33 |
|---|---|---|
| francie | The gate is happy now | 07:33 |
| maaritamm | francie, o/ | 08:29 |
| francie | Hello | 08:29 |
| maaritamm | please note that if you misspell my nickname, I don't get the notification. I only see your messages when I check the channel :) | 08:29 |
| maaritamm | about the change, I see you still need to address a comment from carloss | 08:30 |
| francie | okay let me see. I always mispell your name. :) | 08:30 |
| maaritamm | where you check for the api version, it should be 'if not' instead of 'if' :) | 08:30 |
| maaritamm | right now the patch is doing the opposite, blocking the wait option for api versions 2.45 and higher | 08:31 |
| francie | I think I did on line 2275 | 08:31 |
| francie | on the latest patch. Let me confirm | 08:31 |
| francie | Oh I see | 08:33 |
| francie | Thanks | 08:33 |
| francie | Ok! Fixed | 08:45 |
| francie | Thanks | 08:45 |
| maaritamm | cool, I'll take a look shortly :) | 09:11 |
| carloss | thanks francie! | 10:20 |
| carloss | thanks maaritamm! :) | 10:20 |
| francie_D | o/ | 11:34 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!