| *** gouthamr_ is now known as gouthamr | 06:19 | |
| francie | Hello vkmc, maaritanm: Good morning | 09:13 |
|---|---|---|
| francie | I am getting 'fake_share' does not exist | 09:14 |
| francie | https://review.opendev.org/c/openstack/python-manilaclient/+/815157 | 09:14 |
| maaritamm | francie, hey, I am looking into your test now. I'll do some debugging and let you know if I figure out what it is the issue :) | 14:14 |
| maaritamm | francie, also, please note that you are misspelling my nick, I don't get the notifications then... | 14:15 |
| francie_D | Oh! I see. Thanks | 14:21 |
| francie_D | If I could mock the `find_resource`? | 14:35 |
| maaritamm | francie_D, yes we need to mock the find_resource, and we need it to return a fake share that has an allow() function that also needs to return a fake access_rule | 15:33 |
| maaritamm | here is an example: https://paste.opendev.org/show/810978/ | 15:33 |
| francie_D | taking a look | 15:33 |
| maaritamm | I added some comments to the actual command code, to explain my thoughts | 15:34 |
| francie_D | Fantastic! Thanks very much | 15:36 |
| maaritamm | Sure, np :) | 15:37 |
| francie_D | Wow! <maaritamm>: I have a success run of the unit test | 16:02 |
| francie_D | Thanks soo much! :) | 16:02 |
| maaritamm | francie_D, nice, happy to hear that! :) | 16:22 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!