| francie | Good morning all | 06:46 |
|---|---|---|
| francie | Welcome mbeas_ | 06:46 |
| francie | maaritanm: Hi | 07:07 |
| vkmc | francie, o/ | 08:06 |
| vkmc | morning! | 08:06 |
| francie | Thanks vkmc | 08:06 |
| francie | concerning this: https://bugs.launchpad.net/python-manilaclient/+bug/1898311 | 08:06 |
| francie | I am looking at here: https://github.com/openstack/python-manilaclient/blob/0f9ba9a7d36140a80bcd547c9720149e588d9556/manilaclient/osc/v2/share_access_rules.py#L37 | 08:07 |
| francie | I might be wrong but the idea is to add '--wait' option correct? | 08:07 |
| vkmc | francie, that's correct | 08:38 |
| vkmc | sorry, if you need to caught my attention type "vkmc" and that will trigger a notification to me :) | 08:38 |
| francie | Thanks | 08:38 |
| vkmc | francie, you have some examples of how this was implemented | 08:39 |
| vkmc | see for example | 08:39 |
| francie | okay | 08:39 |
| vkmc | https://review.opendev.org/c/openstack/python-manilaclient/+/804062 | 08:39 |
| vkmc | https://review.opendev.org/c/openstack/python-manilaclient/+/799997 | 08:40 |
| -opendevstatus- NOTICE: zuul needed to be restarted, queues were lost, you may need to recheck your changes | 08:47 | |
| francie | Thanks vkmc, taking a look already | 09:13 |
| vkmc | cool | 09:14 |
| vkmc | let me know if you need any pointer | 09:14 |
| francie | sure I will | 09:15 |
| mbeas | Hi | 13:51 |
| mbeas | Victoria I am trying to work on the bug | 13:52 |
| mbeas | I have opened it in my vs code connecting remote to my VM | 13:52 |
| mbeas | I have opened the utils.py file | 13:53 |
| mbeas | as far as I see I have to read about the six library, because I haven`t used it before | 13:54 |
| mbeas | I am on this line now: if six.PY3: | 13:55 |
| mbeas | member_type = inspect.isfunction | 13:55 |
| mbeas | else: | 13:55 |
| mbeas | member_type = inspect.ismethod | 13:55 |
| mbeas | line 290 - 293 | 13:55 |
| mbeas | as I understand I should remove all these lines despite the line 291 | 13:55 |
| mbeas | and I should correct the indentation of lline 291 | 13:55 |
| mbeas | is this ok? | 13:55 |
| mbeas | sorry to ask about these things but it is the first time contributing to open source and I don`t want to make a mess instead of correcting things | 13:56 |
| mbeas | i am currently reading here: https://six.readthedocs.io/ | 13:59 |
| mbeas | and trying to convert the methods belonging to six, to python 3 equivalents | 14:02 |
| vkmc | mbeas, a few things | 14:08 |
| vkmc | mbeas, if you are pasting a big chunk of text (like code or logs) you can use https://paste.opendev.org/ | 14:08 |
| vkmc | mbeas, now, what you need to do in order to fix that | 14:09 |
| vkmc | mbeas, since we want to remove the six library usage | 14:09 |
| vkmc | mbeas, you need to keep the instructions that comply with py3 syntax, and delete the instructions that comply with py2 syntax | 14:09 |
| mbeas | yes, I undestand | 14:10 |
| vkmc | in that if clause you shared, the line "member_type = inspect.isfunction" corresponds to the py3 syntax | 14:11 |
| vkmc | so you need to keep that | 14:11 |
| vkmc | you can get rid of the if clause and the py2 instruction | 14:11 |
| vkmc | does that make sense? | 14:11 |
| mbeas | yes, I did it | 14:11 |
| mbeas | I am currently coming to the end of the fixes | 14:12 |
| mbeas | there is only one left to do | 14:12 |
| mbeas | and then I will ask you how to proceed | 14:13 |
| mbeas | it was easier than I firstly thought | 14:13 |
| mbeas | thank you very much for your help | 14:13 |
| mbeas | still something | 14:13 |
| mbeas | as I am understanding by reading the code you use spaces and not tabs | 14:14 |
| mbeas | Victoria I finished the fixes | 14:28 |
| mbeas | please could you help me | 14:28 |
| vkmc | mbeas, ok, submit it for review | 14:28 |
| mbeas | what should I do now? | 14:28 |
| vkmc | mbeas, https://docs.opendev.org/opendev/infra-manual/latest/developers.html | 14:29 |
| mbeas | thank you victoria | 14:40 |
| vkmc | anytime | 14:42 |
| vkmc | <mbeas> as I am understanding by reading the code you use spaces and not tabs <- yes, you can make sure your syntax is correct by running the pep8 tests | 14:42 |
| vkmc | tox -e pep8 | 14:42 |
| mbeas | ok, thank you | 14:43 |
| mbeas | i will run it now -) | 14:43 |
| mbeas | after running the command i get an error | 14:52 |
| mbeas | ./manila/utils.py:39:1: F401 'oslo_utils.encodeutils' imported but unused | 14:52 |
| mbeas | ERROR: InvocationError | 14:52 |
| mbeas | to my understanding it is related to python2 | 14:56 |
| mbeas | I have to remove it too | 14:56 |
| mbeas | thank you for the command, it helped me find other fixes -) | 14:58 |
| mbeas | Victoria, another question: do I have to make changes to the comments? | 15:00 |
| mbeas | there is a comment that mentions Python 2 | 15:01 |
| mbeas | finally I got: pep8: commands succeeded | 15:07 |
| mbeas | congratulations :) | 15:07 |
| vkmc | yay, awesome! | 15:56 |
| vkmc | if that is done | 15:56 |
| vkmc | then just commit | 15:56 |
| vkmc | and git review | 15:56 |
| mbeas | Victoria sorry one more time | 16:40 |
| mbeas | I am having problems with git review | 16:40 |
| mbeas | Please make sure you have the correct access rights | 16:41 |
| mbeas | and the repository exists. | 16:41 |
| mbeas | Could not connect to gerrit. | 16:41 |
| mbeas | Finally it is pushed online. | 16:46 |
| mbeas | https://review.opendev.org/c/openstack/manila/+/815136 | 17:00 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!