archanaserver | vkmc, o/ | 04:54 |
---|---|---|
archanaserver | this patch, share group command implementation is working find and passed all the test cases but failing at tox docs | 04:54 |
archanaserver | https://review.opendev.org/c/openstack/python-manilaclient/+/801740 | 04:54 |
archanaserver | *fine | 04:59 |
archanaserver | vkmc, how can i fix this? i tried rechecking! | 05:00 |
vkmc | archanaserver, hey Archu! | 07:02 |
vkmc | looking into this | 07:02 |
vkmc | archanaserver, did you fix the assertion errors? | 07:02 |
archanaserver | vkmc, so yesterday maari share me example with another approach i tried those and that works. | 07:17 |
archanaserver | https://paste.opendev.org/show/808248/ | 07:17 |
archanaserver | https://paste.opendev.org/show/808249/ | 07:18 |
archanaserver | build succeeded finally \o/ https://review.opendev.org/c/openstack/python-manilaclient/+/801740 | 07:19 |
vkmc | nice! | 07:20 |
vkmc | archanaserver, do you understand what is going on there? | 07:20 |
vkmc | archanaserver, the proposed solution I mean | 07:21 |
vkmc | or do you need to go over it? | 07:21 |
archanaserver | i understand a little bit but that would be great if help me to go over it :) | 07:22 |
vkmc | archanaserver, oki, so did you ask Maari when she suggested that to you? | 07:22 |
vkmc | is very important that when you get feedback from a person you think and understand what is going on | 07:22 |
archanaserver | no i didn't | 07:23 |
vkmc | archanaserver, oki, next time you should ask them to get more context if you don't understand things | 07:25 |
vkmc | this is key for your next role | 07:25 |
vkmc | you need to come up with your own solutions, be able to understand what is going on, be able to debug things | 07:25 |
vkmc | and if you cannot do that, ask for help | 07:25 |
archanaserver | yes, okay i'll ask here and will keep this in my mind for the next time | 07:25 |
vkmc | but ask for punctual things | 07:25 |
vkmc | yes, please practice that | 07:26 |
vkmc | consider that for your next role you will need to do a technical interview, and you will need to show you can do this | 07:26 |
archanaserver | sure and sorry for this! i'll consider this from now | 07:27 |
vkmc | no need to be sorry, I hope you consider this as a constructive feedback for your next career steps :) | 07:28 |
archanaserver | yes for sure and thanks a lot for this feedback :) | 07:30 |
vkmc | np | 07:32 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!