| archanaserver | vkmc, o/ | 09:17 |
|---|---|---|
| archanaserver | vkmc, hi morning! | 09:17 |
| vkmc | archanaserver, morning! | 09:17 |
| vkmc | archanaserver, sorry, couldn't get back to you yesterday | 09:18 |
| vkmc | archanaserver, I saw the same issues on my env | 09:18 |
| vkmc | so... let's debug those on our one on one | 09:18 |
| vkmc | plus, I saw gouthamr's comments | 09:18 |
| vkmc | we can discuss that too | 09:18 |
| archanaserver | vkmc, yes sure i was thinking about that | 09:18 |
| archanaserver | vkmc, also i was trying to commit my new patch for adding -wait flag to the share group | 09:19 |
| vkmc | archanaserver, awesome! | 09:19 |
| vkmc | archanaserver, good job on that | 09:19 |
| archanaserver | but as both create and delete are part of same launchpad bug no., so i'm facing this issue while doing git review | 09:20 |
| archanaserver | http://paste.openstack.org/show/807255/ | 09:20 |
| archanaserver | will git rebase -i will solve this issue? | 09:20 |
| vkmc | archanaserver, so you created the new branch on top of the other bug branch, right? | 09:21 |
| archanaserver | yes | 09:21 |
| vkmc | archanaserver, that created a dependency between the two | 09:21 |
| vkmc | archanaserver, it won't hurt, but it was not necessary | 09:21 |
| vkmc | archanaserver, you can submit it for review anyways | 09:22 |
| vkmc | archanaserver, it won't affect your other patch | 09:22 |
| archanaserver | vkmc, oh great then | 09:22 |
| vkmc | archanaserver, just finished running tests on the manila change you are working | 15:27 |
| vkmc | archanaserver, the environment was outdated, that's how we were seeing those issues | 15:27 |
| vkmc | but everything is fine | 15:27 |
| archanaserver | vkmc, okie, so do I need to update the env? | 15:28 |
| vkmc | archanaserver, yeah, we can do so | 15:28 |
| vkmc | archanaserver, but actually not needed | 15:29 |
| vkmc | archanaserver, at least not right now | 15:29 |
| archanaserver | vkmc, so we can leave that for now! | 15:29 |
| vkmc | yes! | 15:29 |
| vkmc | just wanted to let you know | 15:29 |
| archanaserver | vkmc, also here(https://review.opendev.org/c/openstack/python-manilaclient/+/789018) ashley's comment | 15:33 |
| archanaserver | vkmc, i'm not sure about it, if that test updates needs to be in the release note or not | 15:33 |
| vkmc | archanaserver, I don't think we need to include that on the reno, there are not bug fixes, we just changed the way we are creating mocks and we needed to update other tests to follow the same model | 15:36 |
| vkmc | they are not* | 15:36 |
| archanaserver | vkmc, then i'll update the reno! | 15:38 |
| vkmc | archanaserver, you can also ask Ashley what she is suggesting | 15:40 |
| archanaserver | vkmc, yes sure, thanks :) | 15:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!