| archanaserver | hi vkmc, o/ | 08:10 |
|---|---|---|
| vkmc | hi archanaserver, o- | 08:10 |
| vkmc | o/ | 08:10 |
| archanaserver | vkmc: addressed your commend here -> https://review.opendev.org/c/openstack/manila-ui/+/798807 , but i'm having issue in assigning the size of the operation(in my case share_type_quotas) how we are assigning those? | 08:10 |
| archanaserver | *comment | 08:10 |
| vkmc | archanaserver, not sure I follow | 08:11 |
| vkmc | size of the operation? | 08:11 |
| archanaserver | here -> https://github.com/openstack/manila-ui/blob/master/manila_ui/tests/api/test_manila.py#L636-L640 in the expected_result dict we have different operation like share_groups, share_group_snapshots etc with the value | 08:16 |
| archanaserver | those int values indicate sizes right? | 08:16 |
| archanaserver | so i want to know from where we are assigning those size | 08:17 |
| archanaserver | vkmc: does my question make sense to you? | 08:29 |
| vkmc | archanaserver, it does now | 08:30 |
| vkmc | archanaserver, so, it's a test, so any number would do | 08:30 |
| archanaserver | vkmc, ok | 08:40 |
| vkmc | archanaserver, when we write tests we use random values... trying to think on how a user would use it | 08:40 |
| vkmc | that in general | 08:40 |
| vkmc | other kind of tests try to test "border cases" | 08:41 |
| archanaserver | vkmc, got it! | 08:43 |
| vkmc | cool! | 08:43 |
| archanaserver | vkmc, where can i find the unit test report of the patch set | 08:50 |
| archanaserver | like this one https://541801f70bf0c1edba87-2344f8d71749bd5aac75027308191d87.ssl.cf1.rackcdn.com/795990/4/check/openstack-tox-py36/6c99e33/testr_results.html#javascript:showTestDetail('div_ft2.1') | 08:50 |
| vkmc | archanaserver, on zuul | 08:50 |
| vkmc | once the run is done | 08:50 |
| vkmc | you will see a comment from zuul | 08:51 |
| vkmc | with the gate listing | 08:51 |
| vkmc | and all the gates that run your patch | 08:51 |
| vkmc | you can click on the link to the gate you want | 08:51 |
| vkmc | and you will get to the logs | 08:51 |
| archanaserver | oh okay, thanks! | 08:54 |
| archanaserver | vkmc, submitted the manila ui patch here -> https://review.opendev.org/c/openstack/manila-ui/+/798807 and it build succeeded | 10:17 |
| archanaserver | vkmc, also about the manila patch, it's failing in some cases. i can't figure out the error, can i commit it for review? | 10:17 |
| archanaserver | vkmc, i have added some manila ui and python-manilaclient bug links in our 1:1 doc and i want to start working on any one of those parallelly | 10:20 |
| archanaserver | can you check it? | 10:20 |
| vkmc | archanaserver, sure | 12:01 |
| vkmc | archanaserver, is the manila patch already updated? | 12:21 |
| vkmc | so I review | 12:22 |
| vkmc | and I'll check our doc | 12:22 |
| archanaserver | vkmc, no not yet | 12:22 |
| archanaserver | vkmc, submitting the latest patch | 12:23 |
| vkmc | archanaserver, great! | 12:23 |
| vkmc | just checked the bugs you saw on manila-ui and on the python-manilaclient | 12:23 |
| vkmc | feel free to take all three | 12:23 |
| vkmc | in fact, there is one related to the internship task... which is the quotas one | 12:23 |
| archanaserver | that's great! thanks | 12:24 |
| archanaserver | but i need some info on the python-manilaclient one | 12:24 |
| vkmc | archanaserver, sure, what kind of info? | 12:33 |
| archanaserver | vkmc, like how can i manage or unmanage --wait option in a share server (didn't find anything similar) | 12:40 |
| vkmc | archanaserver, so it's very similar to the --wait option you added for share-groups | 12:42 |
| vkmc | archanaserver, you need to find the command in the shell for manage/unmanage and add that control | 12:42 |
| archanaserver | vkmc, ah okie make sense, let me go through the codebase then i'll let you know if i get stuck somewhere :) | 12:43 |
| vkmc | archanaserver, nice! | 12:43 |
| archanaserver | vkmc, also i find that you mention in the our doc about internship extension | 12:45 |
| vkmc | archanaserver, yes! | 12:46 |
| vkmc | we might need to extend the internship for 1-2 weeks, would you be open to do that? | 12:46 |
| archanaserver | vkmc, yes | 12:48 |
| vkmc | archanaserver, cool | 12:57 |
| vkmc | I can give more details in our one on one, but basically organizers need to see more contributions to the project | 12:57 |
| vkmc | so we need to keep working on learning new skills and working on new patches | 12:57 |
| archanaserver | vkmc, sure | 13:40 |
| vkmc | archanaserver, about the manila change | 14:32 |
| vkmc | py38 run is already available | 14:32 |
| vkmc | check out the testr_results file | 14:33 |
| vkmc | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5f4/795990/8/check/openstack-tox-py38/5f46bcb/testr_results.html | 14:33 |
| vkmc | if you check, you see that test_share_group_snapshot_members_get, test_share_group_snapshot_get_all_by_project_with_details, test_share_group_snapshot_get_all_with_detail, test_share_group_snapshot_members_get_all are failing with a similar issue than the test that you fixed | 14:34 |
| vkmc | by dropping the sqlalchemy model | 14:34 |
| vkmc | you need to do the same, but for the attributes failing for those tests | 14:34 |
| vkmc | and test_share_group_snapshot_get is failing with | 14:34 |
| vkmc | AttributeError: 'ShareGroupSnapshot' object has no attribute 'pop' | 14:34 |
| vkmc | this is the file and the line with the issue -- File "/home/zuul/src/opendev.org/openstack/manila/manila/tests/db/sqlalchemy/test_api.py", line 1242, in test_share_group_snapshot_get | 14:35 |
| vkmc | if we check that file on that line | 14:36 |
| vkmc | in your change | 14:36 |
| vkmc | we see... "sg_snap = db_utils.create_share_group_snapshot(sg['id'])" | 14:37 |
| vkmc | let's see what db_utils.create_share_group_snapshot returns | 14:37 |
| vkmc | probably a share_group_snapshot object | 14:37 |
| vkmc | https://github.com/openstack/manila/blob/master/manila/tests/db_utils.py#L46-L54 | 14:39 |
| vkmc | well, a sqlalchemy model | 14:40 |
| vkmc | it's not a dict | 14:40 |
| vkmc | so it doesn't have the pop attribute | 14:40 |
| vkmc | you would need to create the dict first | 14:40 |
| vkmc | and then pop that attribute out | 14:40 |
| vkmc | does that make sense_ | 14:43 |
| vkmc | ? | 14:45 |
| archanaserver | vkmc, sorry was on outreachy zulip intern chat | 14:48 |
| archanaserver | vkmc, i'm looking into it now! | 14:48 |
| archanaserver | vkmc, yes it makes sense now | 14:54 |
| vkmc | archanaserver, oki, great! | 14:55 |
| vkmc | archanaserver, once you are done with the changes | 14:55 |
| vkmc | archanaserver, run "tox -e pep8" and "tox -e py38" | 14:56 |
| vkmc | so you make sure those are passing | 14:56 |
| vkmc | and you don't need to wait for the ci to finish | 14:56 |
| archanaserver | vkmc, yeah sure | 14:59 |
| vkmc | cool | 15:00 |
| archanaserver | vkmc, what is sqlalchemy model here (that you mentioned above) | 18:22 |
| vkmc | archanaserver, in which test? | 18:36 |
| archanaserver | test_share_group_snapshot_get | 18:36 |
| vkmc | ok... let's inspect the error | 18:42 |
| archanaserver | sure | 18:43 |
| vkmc | this is the current test | 18:46 |
| vkmc | https://github.com/openstack/manila/blob/master/manila/tests/db/sqlalchemy/test_api.py#L1239-L1245 | 18:46 |
| vkmc | http://paste.openstack.org/show/807209/ | 18:47 |
| vkmc | this is your fix | 18:47 |
| archanaserver | yes | 18:47 |
| vkmc | the share_group object is composed by several attributes and it is represented as a dictionary | 18:47 |
| vkmc | dictionaries have keys and values | 18:47 |
| vkmc | so, the share group has attributes such as... name: "my-share-group", id: "1234" | 18:48 |
| vkmc | and so on | 18:48 |
| vkmc | one of the attributes that this share group has, is a reference to an entry in the database | 18:48 |
| vkmc | which is this sqlalchemy model object | 18:48 |
| vkmc | which is the share group | 18:48 |
| vkmc | references differ necessarily because we are talking about two different share groups: the one we created, and the fake | 18:49 |
| vkmc | so we only want to compare the other attributes, that are equal | 18:49 |
| vkmc | in your change you are doing things right, but the order in which you are executing steps is wrong | 18:50 |
| vkmc | http://paste.openstack.org/show/807210/ | 18:51 |
| vkmc | check out how I changed L4 | 18:51 |
| archanaserver | yeah, this is what i did my local changes | 18:52 |
| vkmc | nice! | 18:53 |
| vkmc | and is that working for you? or are you getting some other error? | 18:53 |
| archanaserver | i got your point now | 18:53 |
| archanaserver | getting the same error | 18:54 |
| vkmc | with those changes in place? | 18:54 |
| vkmc | if you want we can do a pair programming session and finish that patch | 18:57 |
| vkmc | let me know :) | 18:57 |
| archanaserver | yes sure give me 5 mint | 18:57 |
| vkmc | it can be tomorrow as well, it's kinda late for you already | 18:58 |
| archanaserver | ah yes, i was just thinking that this patch is taking so much time and making me anxious to focus on main internship task :/ | 19:00 |
| archanaserver | also i'm not on track i guess :( as per our timeline | 19:02 |
| archanaserver | but sure we can do pair programming tomorrow, thanks! | 19:02 |
| vkmc | archanaserver, it's fine, the goal is that you build up technical skills | 19:09 |
| vkmc | this is as important as the main internship task | 19:09 |
| archanaserver | vkmc, wow then this is what i'm doing with my each contributions, thank you so much :) | 19:14 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!