| *** kafilat <kafilat!uid465399@id-465399.tooting.irccloud.com> has joined #openstack-outreachy | 08:23 | |
| *** archanaserver <archanaserver!uid502680@id-502680.brockwell.irccloud.com> has joined #openstack-outreachy | 08:45 | |
| archanaserver | hi @vkmc, happy monday o/ | 08:48 |
|---|---|---|
| archanaserver | do we have session today on devstack?/ | 08:54 |
| vkmc | hi archanaserver! | 09:35 |
| vkmc | I'll schedule for tomorrow | 09:41 |
| vkmc | if that works for you | 09:41 |
| archanaserver | yes sure | 09:41 |
| archanaserver | Also about that reviewing part, i read the documentation and gone through this https://review.opendev.org/q/project:openstack/python-manilaclient+status:open | 09:43 |
| archanaserver | but didn't find any in which i can start reviewing | 09:43 |
| archanaserver | i mean there is already some assigned for the same | 09:43 |
| archanaserver | *someone | 09:43 |
| vkmc | archanaserver, it's ok, reviews are collaborative | 09:45 |
| vkmc | it's expected that more than one person look at the code and submit reviews | 09:45 |
| vkmc | it's needed 2 positive reviews from core reviewers to merge the code, but having reviews from everyone help to reach to that point | 09:46 |
| archanaserver | okay cool! | 09:57 |
| archanaserver | so should i start my text task in reviewing side or is there any task you have for me? | 09:58 |
| vkmc | I do | 10:00 |
| vkmc | I see that https://review.opendev.org/c/openstack/python-manilaclient/+/789018 is failing for the py36 gate | 10:00 |
| vkmc | have you looked into this? | 10:00 |
| archanaserver | oh no | 10:01 |
| archanaserver | it was working fine when i committed it | 10:01 |
| archanaserver | i'm on it | 10:02 |
| vkmc | archanaserver, cool! | 10:02 |
| archanaserver | about that openinfra live show, i have a few questions to clarify | 10:04 |
| archanaserver | is now a good time? | 10:04 |
| vkmc | sure | 10:09 |
| vkmc | I have to get back to that | 10:09 |
| archanaserver | sure thing, let me know when. so that we can work on some questions :) (i'm nervous though) | 10:23 |
| vkmc | ok | 10:23 |
| vkmc | I'll prepare a few questions to guide the conversation, sync with diablo_rojo (Kendall Nelson from OpenInfra) | 10:24 |
| vkmc | and will get back to you as soon as we do have some format | 10:24 |
| vkmc | and then we can go over questions and brainstorm a bit | 10:24 |
| vkmc | sounds good? | 10:24 |
| archanaserver | yeah! | 10:24 |
| vkmc | cool | 10:24 |
| kafilat | vkmc: hi :) | 11:11 |
| kafilat | Are we still on for meeting at 15.00 | 11:11 |
| vkmc | hi kafilat! | 12:09 |
| vkmc | no, I didn't sent the invite | 12:09 |
| vkmc | I have other meetings today so couldn't make the slot | 12:10 |
| vkmc | I was thinking on scheduling it for tomorrow | 12:10 |
| vkmc | would that work for you? | 12:10 |
| kafilat | Yes. | 12:18 |
| kafilat | Tomorrow's fine :) | 12:18 |
| kafilat | Thanks | 12:18 |
| vkmc | cool :) | 12:28 |
| vkmc | thanks | 12:28 |
| vkmc | I'll send the invite to your calendar | 12:28 |
| vkmc | please decline or accept depending on your availability | 12:28 |
| vkmc | if not we can reschedule | 12:28 |
| archanaserver | vkmc: gone through my changes and run the tox command again it's showing "py36: commands succeeded congratulations :)" | 12:56 |
| vkmc | archanaserver, ok, we can trigger a recheck in the ci | 12:57 |
| vkmc | and see if that reproduces there | 12:57 |
| vkmc | you can add a comment in your change in gerrit | 12:57 |
| vkmc | with the word | 12:57 |
| vkmc | "recheck" | 12:57 |
| archanaserver | okay sure | 12:57 |
| archanaserver | but how can we trigger the ci for the recheck? (i don't know about that) | 12:59 |
| vkmc | that's how you do it: your change and submit a review with the word "recheck" on it | 13:00 |
| vkmc | and that will trigger it | 13:00 |
| vkmc | let me do that for you | 13:00 |
| archanaserver | ya sure | 13:00 |
| vkmc | https://review.opendev.org/c/openstack/python-manilaclient/+/789018 <- like that | 13:00 |
| archanaserver | ah gotcha | 13:01 |
| archanaserver | also, i need to add a release note for my both patch? | 13:07 |
| vkmc | I would't add release note to your changes | 13:15 |
| vkmc | but maybe gouthamr can chime in later and let us know what he thinks ^ | 13:15 |
| archanaserver | i saw release note in every patch so that why i ask, if i'm missing this every time | 13:23 |
| archanaserver | but yes sure! | 13:23 |
| vkmc | archanaserver, add for the python-manilaclient one :) | 13:29 |
| vkmc | I saw a reno added for a last change | 13:29 |
| vkmc | so you are right | 13:29 |
| archanaserver | Build succeeded -> https://review.opendev.org/c/openstack/python-manilaclient/+/789018 🥺 | 13:57 |
| archanaserver | okie cool, i'll add release note then | 13:57 |
| archanaserver | seeing "Verified +1" in python-manilaclient patch, made my day 😊 (after sooo long, finally!!) | 14:01 |
| archanaserver | thanks vkmc :) | 14:02 |
| vkmc | yaay! | 14:02 |
| vkmc | awesome! | 14:02 |
| vkmc | I'll review soon | 14:02 |
| archanaserver | yeah 🥳 | 14:03 |
| archanaserver | so i need to run this command reno new slug-goes-here under python-manilaclient project to create a new note file | 14:34 |
| vkmc | archanaserver, yes, you are right... in your branch, and you need to specify the name of the bug you are working on | 14:38 |
| vkmc | I think it's called "slug" in the documentation | 14:44 |
| vkmc | and then you have to edit the release note | 14:44 |
| vkmc | to include what you want to include | 14:44 |
| archanaserver | yes, reading the documentation and implementing it in my branch | 15:19 |
| vkmc | cool! | 15:25 |
| vkmc | archanaserver, here you have some examples of release notes | 15:36 |
| vkmc | https://github.com/openstack/python-manilaclient/tree/master/releasenotes/notes | 15:36 |
| vkmc | if you want to check names or content | 15:36 |
| vkmc | I like the bug-<bugnumber>-description slug format | 15:36 |
| vkmc | but there are no rules about that | 15:36 |
| archanaserver | okay so when i open release note file to edit, few things are already there like prelude,features,issues and etc. | 15:41 |
| vkmc | yeah | 15:41 |
| vkmc | you have to manually delete the sections that shouldn't be there | 15:41 |
| vkmc | and keep the one you need | 15:41 |
| vkmc | and add some text | 15:41 |
| vkmc | explaining what changed | 15:41 |
| vkmc | https://github.com/openstack/python-manilaclient/blob/master/releasenotes/notes/bug-1898304-add-wait-to-share-create-delete-f121073f2f4402ff.yaml | 15:41 |
| vkmc | check this example | 15:41 |
| archanaserver | oh so i need to do this manually | 15:41 |
| archanaserver | got it! | 15:42 |
| archanaserver | adding changes | 15:42 |
| vkmc | yes | 15:46 |
| vkmc | cool! | 15:46 |
| archanaserver | ok now when i do git commit -a --amend, i'm getting this https://usercontent.irccloud-cdn.com/file/7F78kdzL/Screenshot%202021-06-14%20at%209.18.50%20PM.png | 15:49 |
| archanaserver | so here i need to add commit msgs again? | 15:49 |
| archanaserver | i'm confused | 15:49 |
| archanaserver | would it be good, if i do git review? | 15:55 |
| gouthamr | archanaserver: that looks like a git merge in progress, can you quit without saving | 15:56 |
| gouthamr | archanaserver: what does "git status" and "git log" give you? | 15:58 |
| archanaserver | gouthamr: git status is showing untracked file(release note i have just added) | 15:59 |
| archanaserver | git log is this https://usercontent.irccloud-cdn.com/file/OVvExbrf/Screenshot%202021-06-14%20at%209.29.35%20PM.png | 15:59 |
| vkmc | something is wrong with your index | 16:01 |
| vkmc | the git merge shouldn't be there | 16:01 |
| gouthamr | right, i'd suggest "git reset 711648" and then git commit -a --amend | 16:03 |
| archanaserver | gouthamr: getting this https://usercontent.irccloud-cdn.com/file/JNaf4TBZ/Screenshot%202021-06-14%20at%209.35.52%20PM.png | 16:06 |
| archanaserver | so many untracked files showing up | 16:06 |
| gouthamr | yep, and they're not your changes? | 16:12 |
| gouthamr | doesn't look like it | 16:12 |
| archanaserver | yes, they aren't mine | 16:12 |
| gouthamr | did you just add the release note file? | 16:12 |
| archanaserver | yes only release note file | 16:13 |
| gouthamr | if yes, you can save that file "git stash <filepath>" | 16:13 |
| gouthamr | git reset --hard | 16:13 |
| gouthamr | and then "git stash pop" | 16:13 |
| archanaserver | ok, let me try this | 16:14 |
| archanaserver | showing fatal: unknown subcommand: releasenotes/notes/bug-1898318-add-wait-flag-for-deleting-a-share-group-operation-c602ba9faad411be.yaml | 16:15 |
| archanaserver | when i do git stash <filepath> | 16:15 |
| vkmc | archanaserver, share a tmat | 16:27 |
| vkmc | tmate* | 16:27 |
| vkmc | with us | 16:27 |
| vkmc | :) | 16:27 |
| archanaserver | okie | 16:28 |
| archanaserver | ssh session: ssh CaGfX4FS7sqGXPuVZsWRSpWrC@sfo2.tmate.io | 16:28 |
| archanaserver | tmate link | 16:28 |
| vkmc | oki | 16:28 |
| archanaserver | also my previous changes gone :( | 16:30 |
| archanaserver | no not this one | 16:32 |
| archanaserver | the release note file i have created is -> releasenotes/notes/bug-1898318-add-wait-flag-for-deleting-a-share-group-operation-c602ba9faad411be.yaml | 16:32 |
| vkmc | cool | 16:33 |
| vkmc | previous changes? | 16:33 |
| vkmc | ok, that should be fixed now | 16:34 |
| vkmc | I saw you made a git pull | 16:35 |
| vkmc | that broke your index | 16:35 |
| vkmc | normally we do rebases :) | 16:35 |
| vkmc | so... what I did | 16:35 |
| archanaserver | yes i did that | 16:35 |
| vkmc | was to look for all the history of changes with git reflog | 16:36 |
| vkmc | recover your change | 16:36 |
| vkmc | with git reset | 16:36 |
| vkmc | stash all the files we don't needed because they were for a different commit | 16:36 |
| vkmc | git rebase -i master | 16:36 |
| vkmc | to update the base | 16:36 |
| vkmc | then added your release note that was untracked | 16:36 |
| vkmc | and then run unit tests to make sure | 16:37 |
| vkmc | ah, and wrapped the commit message... it's a good practice to wrap commit messages to 80 chars | 16:37 |
| vkmc | py39 gate is failing for some reason, we can debug later that | 16:37 |
| vkmc | do you think there is something missing? | 16:37 |
| archanaserver | sure thanks! i'm on it next time | 16:38 |
| vkmc | with git diff master we can see the differences between master and the current branch | 16:38 |
| archanaserver | in py39 gate? | 16:38 |
| vkmc | I think it looks good | 16:38 |
| vkmc | no no, this question is unrelated to the gate :) | 16:38 |
| archanaserver | yes looks good, but why py39 failing | 16:39 |
| archanaserver | oh yes | 16:39 |
| vkmc | no idea... I'll debug it later | 16:39 |
| vkmc | good thing is | 16:39 |
| vkmc | it's a non-voting job | 16:39 |
| vkmc | and seems to be unrelated to your code | 16:39 |
| vkmc | :D | 16:39 |
| vkmc | so your code is fine | 16:39 |
| archanaserver | oh cool then | 16:40 |
| vkmc | cool! | 16:40 |
| vkmc | off you go, git review | 16:40 |
| archanaserver | so now we can do git review, right? | 16:40 |
| vkmc | and we should be done | 16:40 |
| vkmc | yes | 16:40 |
| vkmc | I'm exiting the tmate | 16:40 |
| archanaserver | okie | 16:40 |
| archanaserver | done :) | 16:41 |
| vkmc | ++ | 16:42 |
| vkmc | good job! | 16:42 |
| archanaserver | thanks @vkmc and @gouthamr for helping me to fix this :) | 16:42 |
| archanaserver | thanks a lot! 😊 | 16:43 |
| gouthamr | good stuff! :) | 16:54 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
