| gouthamr | Hey archanaserver, yeah we don’t put screenshots because they tend to go out of date :) | 02:02 |
|---|---|---|
| gouthamr | archanaserver: can you share your local.conf on paste.openstack.org? | 02:03 |
| archanaserver | Hi @gouthamr, okay i got it. | 05:15 |
| archanaserver | and here is my local.conf | 05:15 |
| archanaserver | http://paste.openstack.org/show/806298/ | 05:15 |
| vkmc | o/ | 08:25 |
| vkmc | morning | 08:25 |
| archanaserver | hi @vkmc, good morning :) | 08:36 |
| vkmc | about the share category in the dashboard, you spotted a bug :) | 08:38 |
| vkmc | share category under the system tab* | 08:38 |
| archanaserver | oh wow!! | 08:39 |
| vkmc | and yeah, we don't have screenshots in our guides | 08:39 |
| vkmc | but | 08:39 |
| vkmc | on the contrary, since our ui is versioned, we could add those | 08:39 |
| vkmc | we can talk with the rest of the community to hear their thoughts before doing so | 08:39 |
| archanaserver | okie sure | 08:43 |
| vkmc | and... reviewing your change now | 08:51 |
| archanaserver | great! i need to work on adding commit msgs and a few more things | 08:55 |
| vkmc | yeah | 09:20 |
| vkmc | also, to run some of the tests locally | 09:20 |
| vkmc | for instance | 09:20 |
| vkmc | pep8 | 09:20 |
| vkmc | you can do so with "tox -e pep8" | 09:20 |
| vkmc | in your repo | 09:20 |
| vkmc | :) | 09:20 |
| vkmc | we can talk about that a bit more in a bit, in our one on one | 09:21 |
| archanaserver | yes sure | 09:23 |
| archanaserver | @vkmc i can't find any link in mail to join our one on one | 09:57 |
| vkmc | oops, sorry | 09:58 |
| vkmc | adding | 09:58 |
| archanaserver | okie :) | 09:58 |
| archanaserver | hi @vkmc, i have followed your reviews and completed the code changes. https://usercontent.irccloud-cdn.com/file/ytCmb23u/Screenshot%202021-06-03%20at%207.43.55%20PM.png | 14:16 |
| archanaserver | And while running "sudo tox -e pep8" command for pep8 testing it passed | 14:16 |
| archanaserver | but while running this command for py36 tests, it throws so many thing which is little but confusing | 14:17 |
| archanaserver | if you can help me with this by connecting through tmate | 14:18 |
| vkmc | archanaserver++ | 14:38 |
| vkmc | great! | 14:38 |
| archanaserver | okie here is the ssh link | 14:46 |
| archanaserver | ssh session: ssh pNUq2V4wD96dSFjh5krxTvJtH@sfo2.tmate.io | 14:48 |
| vkmc | oki | 14:52 |
| vkmc | did you fix the tests? | 14:52 |
| archanaserver | only pep8 | 14:53 |
| vkmc | ahh | 14:53 |
| vkmc | you would need to fix that issue with the ddt decorator | 14:54 |
| vkmc | in order to fix the tests | 14:54 |
| archanaserver | yeah, completed this fix with ddt decorator | 14:55 |
| archanaserver | should i commit the changes now for review? | 14:55 |
| vkmc | let's see | 14:56 |
| archanaserver | yes | 14:57 |
| vkmc | ok, the output says | 14:57 |
| vkmc | that 3 tests failed | 14:57 |
| vkmc | - Failed: 3 | 14:57 |
| vkmc | let's look at the errors | 14:57 |
| archanaserver | how can i get this status? | 14:58 |
| vkmc | which status? | 14:58 |
| archanaserver | output with 3 tests failed | 14:58 |
| archanaserver | is there any specific command for that, py36? | 14:59 |
| vkmc | is the last couple of lines when I run "sudo tox -e py36" | 14:59 |
| archanaserver | aah okie, let me check this | 15:00 |
| vkmc | oki | 15:00 |
| vkmc | all yours, if you want to rerun | 15:00 |
| archanaserver | but where can i find these 3 failed cases, so that i can work on it | 15:02 |
| vkmc | well, let's inspect the output | 15:03 |
| vkmc | http://paste.openstack.org/show/806331/ | 15:04 |
| vkmc | L1 is the name of the test | 15:05 |
| vkmc | since we use ddt, we see the param we are passing in the signature | 15:05 |
| vkmc | manilaclient.tests.unit.v2.test_shell.ShellTest.test_share_group_delete_wait <- test name | 15:05 |
| vkmc | AttributeError: 'str' object has no attribute 'ShareGroup' <- error | 15:05 |
| vkmc | File "/opt/stack/python-manilaclient/manilaclient/tests/unit/v2/test_shell.py", line 2752, in <listcomp> | 15:06 |
| vkmc | share_group.ShareGroup(fake_manager, {'id': '1234'}) <- line that raised the error | 15:06 |
| vkmc | joins us on the weekly meeting on #openstack-meeting-alt :) | 15:07 |
| archanaserver | okie looking into it | 15:07 |
| archanaserver | yeah joined :) | 15:08 |
| vkmc | cool! | 15:08 |
| archanaserver | thanks 😊 | 15:09 |
| archanaserver | hi vkmc i worked in this issue to fix this, but i am not able to fix this | 18:10 |
| archanaserver | might be i'm missing something important | 18:10 |
| archanaserver | if you can help me with that | 18:10 |
| archanaserver | :) | 18:10 |
| vkmc | sure | 18:10 |
| vkmc | submit your latest patch for review | 18:10 |
| vkmc | and we can take a look | 18:10 |
| archanaserver | ya sure, then submitting right now. | 18:11 |
| archanaserver | submitted the latest patch for review | 18:28 |
| vkmc | nice! | 18:35 |
| archanaserver | :) | 18:39 |
| archanaserver | i'm clocking out for the day (it's already 12 AM here :sleeping:) will continue work on the fix and make sure to fix it by tomorrow | 18:50 |
| archanaserver | thanks :) | 18:50 |
| vkmc | same here, ttyt o/ | 18:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
