| *** dtantsur|afk is now known as dtantsur | 08:03 | |
| *** dtantsur is now known as dtantsur|mtg | 08:03 | |
| *** etingof has quit IRC | 08:24 | |
| *** jpich has joined #openstack-outreachy | 08:58 | |
| *** yajushiSri has joined #openstack-outreachy | 11:24 | |
| yajushiSri | Can we discuss queries related to bugs here, or should it be on Launchpad only? | 11:26 |
|---|---|---|
| yajushiSri | I have a rather trivial question. So if yes, please refer to my latest comment on: https://bugs.launchpad.net/manila/+bug/1802424 | 11:30 |
| openstack | Launchpad bug 1802424 in Manila "No user message when share shrinking fails at the driver" [Undecided,New] - Assigned to Yajushi Srivastava (yajushisri) | 11:30 |
| yajushiSri | It would be great if somebody could help me with my first contribution. :) | 11:30 |
| vkmc | yajushiSri, what is the question? | 11:34 |
| vkmc | hi o/ | 11:34 |
| vkmc | this channel is ok for all questions regarding to how to contribute and outreachy in general | 11:35 |
| yajushiSri | It is well described in my latest comment here: https://bugs.launchpad.net/manila/+bug/1802424 I just need to know if the changes I've made are sufficient. | 11:37 |
| openstack | Launchpad bug 1802424 in Manila "No user message when share shrinking fails at the driver" [Undecided,New] - Assigned to Yajushi Srivastava (yajushisri) | 11:37 |
| vkmc | yajushiSri, two things | 11:39 |
| vkmc | 1. that bug was assigned to other person, have you talked with the other person before taking it? | 11:39 |
| vkmc | 2. seems the right approach, go ahead and submit a patch for it | 11:39 |
| yajushiSri | No, I didn't know that I was supposed to. Should I reassign? | 11:40 |
| vkmc | it's ok now, you usually take bugs that are not assigned | 11:40 |
| vkmc | if they are assigned, it means that someone may be working on that | 11:40 |
| vkmc | and if that happens, you might step on some other person work | 11:41 |
| yajushiSri | Oh okay, I'll keep this in mind. Thank you. I will probably talk to her before submitting a patch then. :) | 11:41 |
| vkmc | sounds good | 11:42 |
| vkmc | the approach seems ok and usually the best way to get comments is to submit the patch and then get the reviews | 11:44 |
| vkmc | so you are in the right path | 11:44 |
| yajushiSri | Okay, thanks a lot! | 11:45 |
| vkmc | np! | 11:45 |
| *** enriquetaso has joined #openstack-outreachy | 12:09 | |
| *** yajushiSri has quit IRC | 12:16 | |
| *** yajushiSri has joined #openstack-outreachy | 12:43 | |
| *** yajushiSri has quit IRC | 13:06 | |
| *** yajushiSri has joined #openstack-outreachy | 13:08 | |
| *** yajushiSri has quit IRC | 13:13 | |
| *** yajushiSri has joined #openstack-outreachy | 13:38 | |
| *** yajushiSri has quit IRC | 14:20 | |
| *** yajushiSri has joined #openstack-outreachy | 14:20 | |
| yajushiSri | vkmc, Thank you so much! Submitted my first patch ever for review. :D | 14:21 |
| vkmc | yajushiSri, well done! | 14:21 |
| yajushiSri | Thanks. | 14:22 |
| vkmc | yajushiSri, you will need to resubmit | 14:29 |
| vkmc | git combined your change with the change in the top | 14:29 |
| vkmc | yajushiSri, the usual way to fix this would be to do | 14:30 |
| vkmc | git checkout master | 14:30 |
| vkmc | git pull origin master | 14:30 |
| vkmc | git checkout bug/<yourbugnumber> | 14:30 |
| vkmc | git rebase -i master | 14:31 |
| vkmc | rebase it | 14:31 |
| vkmc | remove the files that doesn't belong to your change | 14:31 |
| vkmc | and resubmit for review | 14:31 |
| *** yajushiSri has quit IRC | 14:35 | |
| *** yajushiSri has joined #openstack-outreachy | 14:37 | |
| yajushiSri | vkmc, I'm so sorry, I got disconnected. The last message on my log is: <yajushiSri> In this order, right? | 14:37 |
| yajushiSri | Could you resend the messages after this? | 14:38 |
| vkmc | I didn't get that message | 14:45 |
| yajushiSri | I guess you were talking about "manila/share/.manager.py.un~" and "manila/share/manager.py~". I have removed them. Do I have to remove the change from Gerrit before submitting a fresh patch? | 14:46 |
| yajushiSri | I have followed the these steps: git checkout master | git pull origin master | git checkout bug/<yourbugnumber> | git rebase -i master | Removed files that didn't belong to my change. Let me know if I should 'Abandon' the Change on Gerrit. And, submit the patch again. | 14:55 |
| *** s0ru has joined #openstack-outreachy | 14:59 | |
| s0ru | o/ vkmc enriquetaso, I uploaded the changes on gerrit already, I think Transpec worked fine finally n.n | 15:02 |
| vkmc | yajushiSri, no, but you need to make sure your change is aligned to master | 15:05 |
| vkmc | yajushiSri, and yes, remove the temp files | 15:05 |
| vkmc | s0ru, super! | 15:05 |
| vkmc | s0ru, will review it later, also will add some other reviewers that might help with the job | 15:06 |
| s0ru | \o/ | 15:13 |
| enriquetaso | s0ru++ | 15:26 |
| yajushiSri | vkmc, I squashed the previous commit and the one with suggested changes. I have submitted the patch for review. Let me know if it seems alright. | 15:34 |
| *** dtantsur|mtg is now known as dtantsur|afk | 15:50 | |
| *** yajushiSri has quit IRC | 16:29 | |
| *** yajushiSri has joined #openstack-outreachy | 16:31 | |
| *** yajushiSri has quit IRC | 17:03 | |
| *** jpich has quit IRC | 17:37 | |
| *** enriquetaso has quit IRC | 18:54 | |
| *** ivy has joined #openstack-outreachy | 19:04 | |
| *** ivy has quit IRC | 21:06 | |
| *** s0ru has quit IRC | 21:23 | |
| *** yajushiSri has joined #openstack-outreachy | 23:14 | |
| *** yajushiSri has quit IRC | 23:34 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!