| *** mhen_ is now known as mhen | 01:51 | |
| *** elodilles_pto is now known as elodilles | 05:53 | |
| dtantsur | Another futurist question folks. Was it intended that stopping one worker thread always stop all threads? | 14:03 |
|---|---|---|
| dtantsur | I'm trying to understand if I should fix that or work around it. | 14:04 |
| dtantsur | hberaud[m]: if you have an opinion ^^ | 14:04 |
| hberaud[m] | no sorry, no idea | 14:05 |
| dtantsur | magical futurist :D | 14:05 |
| dtantsur | ThreadWorker is not a part of the public API, I suspect I can change it | 14:06 |
| TheJulia | I *suspect* it was always expected if you base it on a direct mapping | 14:11 |
| hberaud[m] | probably | 14:13 |
| opendevreview | Dmitry Tantsur proposed openstack/futurist master: Fix ThreadWorker.stop to stop only this worker https://review.opendev.org/c/openstack/futurist/+/955478 | 14:15 |
| TheJulia | At the same time, when I was looking at it last week as well, I was wondering the same thing as Dmitry | 14:16 |
| opendevreview | Dmitry Tantsur proposed openstack/futurist master: WIP: Add DynamicThreadPoolExecutor that resizes itself https://review.opendev.org/c/openstack/futurist/+/955217 | 14:17 |
| dtantsur | okay, added the stop() fix to the chain. Now a few more unit tests, and we're good to go. | 14:17 |
| TheJulia | very cool | 14:20 |
| opendevreview | Merged openstack/futurist master: Trivial: avoid noqa in __init__.py https://review.opendev.org/c/openstack/futurist/+/955374 | 15:33 |
| opendevreview | Dmitry Tantsur proposed openstack/futurist master: Add DynamicThreadPoolExecutor that resizes itself https://review.opendev.org/c/openstack/futurist/+/955217 | 15:34 |
| dtantsur | ready for review ^^ (cc TheJulia) | 15:34 |
| TheJulia | Thanks, restarted my local ironic with that. So far so good | 16:52 |
| TheJulia | averaging ~7.5 minutes per pass | 17:17 |
| TheJulia | I'll let it run for a while, if you want logs I can dump them out, but in the grand scheme of the universe I'm pretty good with it as-is | 17:17 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!