| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Add threading backend implementation using cotyledon and standard threads https://review.opendev.org/c/openstack/oslo.service/+/945720 | 00:08 |
|---|---|---|
| *** mhen_ is now known as mhen | 01:55 | |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Add threading backend implementation using cotyledon and standard threads https://review.opendev.org/c/openstack/oslo.service/+/945720 | 10:32 |
| hberaud[m] | tkajinam: FYI we have finally unblocked the gates, and we are now able to apply your clean up file https://github.com/eventlet/eventlet/pull/1021. I resolved the conflict but unfortunately I'm now blacklisted from the authorized reviewers as I co-authored your patch. If you force a push I'll be able to review it again, else we have to wait for my co-maintainers. Up to you. | 12:02 |
| *** tosky_ is now known as tosky | 12:27 | |
| tkajinam | hberaud[m], I force-pushed the updated version. I hope I did it correctly | 13:06 |
| hberaud[m] | tkajinam: I left a comment, I think there is an issue within `.github/workflows/test.yaml` | 13:09 |
| tkajinam | it seems I didn't ... | 13:11 |
| tkajinam | pushed the fixed version | 13:11 |
| hberaud[m] | LGTM now, thanks | 13:12 |
| hberaud[m] | and good news, I'm now able to merge it | 13:12 |
| hberaud[m] | \o/ | 13:12 |
| tkajinam | yay | 13:18 |
| damani[m] | hberaud, nice | 14:18 |
| hberaud[m] | damani, tkajinam stephenfin please could you review https://review.opendev.org/c/openstack/oslo.log/+/937729 when you have spare time. @Stephen: If I'm right, Itamar made changes over all your comments, or, at least, replied to them. | 15:15 |
| hberaud[m] | Thanks in advance | 15:15 |
| *** ralonsoh is now known as ralonsoh_out | 16:03 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!