| *** mhen_ is now known as mhen | 02:11 | |
| hberaud[m] | damani, tkajinam : o/ please do you mind having a look at https://review.opendev.org/c/openstack/oslo.db/+/922976? I think this patch is ready to go | 09:05 |
|---|---|---|
| damani[m] | ok | 11:31 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Migrate Eventlet components to the new backend system https://review.opendev.org/c/openstack/oslo.service/+/937010 | 13:02 |
| opendevreview | Stephen Finucane proposed openstack/oslo.utils master: imageutils: Add __main__ helper https://review.opendev.org/c/openstack/oslo.utils/+/937037 | 15:28 |
| opendevreview | Stephen Finucane proposed openstack/oslo.utils master: imageutils: Add __main__ helper https://review.opendev.org/c/openstack/oslo.utils/+/937037 | 15:30 |
| stephenfin | sean-k-mooney: Care to take a look at that ^^ at some point and tell me if I'm holding it right? | 15:37 |
| *** tosky_ is now known as tosky | 15:40 | |
| sean-k-mooney | hum i talked ot dansmith about being able to use it as a cli in the past i guess that one way to do it | 15:52 |
| sean-k-mooney | stephenfin: so there are 2 ways to do this have you considered creating an __main__.py instead | 15:54 |
| sean-k-mooney | that woudl allow you to avoid puttign the imports in the __main__ function | 15:55 |
| sean-k-mooney | you just put __main__.py beside __init__.py | 15:55 |
| sean-k-mooney | the other feedback is you have no test coverage of this | 15:55 |
| sean-k-mooney | so im suggesting you do https://docs.python.org/3/library/__main__.html#module-__main__ option 2 | 15:56 |
| sean-k-mooney | so https://docs.python.org/3/library/__main__.html#main-py-in-python-packages | 15:57 |
| sean-k-mooney | to me the __main__.py is slightly cleaner as you seperate the lib code form the cli code into diffent files | 15:58 |
| sean-k-mooney | stephenfin: i can leave a comment to that effect if you like | 15:59 |
| sean-k-mooney | ok, done i do support the idea its just not how i woudl do it | 16:04 |
| hberaud[m] | damani: there is no meeting today? | 16:05 |
| hberaud[m] | sorry, I'm early | 16:08 |
| hberaud[m] | meeting is at 5pm UTC | 16:08 |
| hberaud[m] | Sorry I cannot attends today | 16:09 |
| stephenfin | sean-k-mooney: the main issue with using a '__main__.py' file is I have to call it as 'oslo_utils.imageutils' instead of 'oslo_utils.imageutils.format_inspector'. At least unless I convert format_inspector to a module and place the file in there | 16:37 |
| sean-k-mooney | right but is that a problem | 16:42 |
| sean-k-mooney | im not suggesting you refactor it into a module | 16:42 |
| sean-k-mooney | well a freestandign one | 16:42 |
| sean-k-mooney | i can see why you want to have oslo_utils.imageutils.format_inspector | 16:43 |
| sean-k-mooney | as it is a little clearer what it doing | 16:43 |
| sean-k-mooney | but are we going to have more hten one cli for this module and even if we did wahy woudl you not register sub parsers | 16:44 |
| sean-k-mooney | you dont have to take the __main__.py suggestion | 16:44 |
| sean-k-mooney | but you proably should derfer the typing change | 16:45 |
| stephenfin | yeah, I don't think it makes sense in this instance. The only other thing in that file is a wrapper around 'qemu-img' that I obviously don't want a CLI for, so I think that a subparser wouldn't be helpful | 16:45 |
| damani[m] | gmann, meeting time are you around? | 17:05 |
| damani[m] | or other | 17:06 |
| damani[m] | #startmeeting oslo | 17:07 |
| opendevmeet | Meeting started Wed Dec 4 17:07:53 2024 UTC and is due to finish in 60 minutes. The chair is damani[m]. Information about MeetBot at http://wiki.debian.org/MeetBot. | 17:07 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 17:07 |
| opendevmeet | The meeting name has been set to 'oslo' | 17:07 |
| gmann | o/ | 17:09 |
| gmann | damani[m]: hi | 17:09 |
| damani[m] | gmann, hi | 17:10 |
| damani[m] | something you would like to discuss today about oslo? | 17:10 |
| gmann | damani[m]: nothing from me. for today | 17:11 |
| damani[m] | ok | 17:11 |
| damani[m] | it seems nobody else will join | 17:11 |
| damani[m] | so i think we can skip the meeting for today | 17:12 |
| gmann | yeah | 17:12 |
| damani[m] | gmann, thanks a lot for your time | 17:12 |
| damani[m] | and joining | 17:12 |
| damani[m] | by the way i continue to work on oslo.service and the backend system | 17:12 |
| damani[m] | i move the current implementation to an eventlet backend | 17:13 |
| damani[m] | nothing more on my side | 17:13 |
| damani[m] | #endmeeting | 17:14 |
| opendevmeet | Meeting ended Wed Dec 4 17:14:11 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:14 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/oslo/2024/oslo.2024-12-04-17.07.html | 17:14 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/oslo/2024/oslo.2024-12-04-17.07.txt | 17:14 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/oslo/2024/oslo.2024-12-04-17.07.log.html | 17:14 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Migrate Eventlet components to the new backend system https://review.opendev.org/c/openstack/oslo.service/+/937010 | 17:37 |
| sean-k-mooney | stephenfin: if you move the typeh ihintign to another commit or just drop them i think you conviced me that your current approch is fine | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/oslo.utils master: imageutils: Add __main__ helper https://review.opendev.org/c/openstack/oslo.utils/+/937037 | 18:06 |
| opendevreview | Ghanshyam proposed openstack/oslo.policy master: DNM: testing gate https://review.opendev.org/c/openstack/oslo.policy/+/937062 | 19:35 |
| *** elodilles is now known as elodilles_pto | 19:54 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!