| opendevreview | Dr. Jens Harbott proposed openstack/openstack-doc-tools master: Update sitemap generator with current series https://review.opendev.org/c/openstack/openstack-doc-tools/+/914614 | 08:29 |
|---|---|---|
| hberaud | tkajinam, damani: indeed, I think Sean's thinking is right ^. I think we have to follow the path proposed by Sean (removing heartbeat_in_pthread) to allow us to drop these "multiple readers" features calls who are blocking to go through the eventlet migration. | 08:36 |
| hberaud | Without toot digging, I think we would have to 1. deprecate heartbeat_in_pthread (HIP) 2. disabling HIP by default (I think it is already the case) 3. remove HIP 4. remove the oslo.log eventlet fix | 08:39 |
| hberaud | too | 08:39 |
| hberaud | However... the swift patch (https://opendev.org/openstack/swift/commit/69c715c505cf9e5df29dc1dff2fa1a4847471cb6) that inspired the oslo.log patch, was merged ~2 years before the introduction of HIP, so not sure removing HIP will really help to solve that point | 08:42 |
| hberaud | although, we surely have scenario without HIP involved where doing `eventlet.debug.hub_prevent_multiple_readers(False)` is a prerequisites. Previous call come from => https://review.opendev.org/c/openstack/oslo.log/+/852443 . Services handle threads at their convenience, so its hard to determine in which case oslo.log will be exposed to a context where multiple greenthreads | 08:49 |
| hberaud | are ran in multiple native threads... | 08:49 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.messaging stable/2024.1: Fix incorrect desc of rabbit_stream_fanout option https://review.opendev.org/c/openstack/oslo.messaging/+/914583 | 08:59 |
| hberaud | the discussion may concern you more sooner than you think => https://github.com/eventlet/eventlet/issues/874 | 09:25 |
| tkajinam | I have to digest the whole discussion further but at my first impression I think deprecating HIP makes sense, because the intention of HIP was "using something not eventlet" and we are introducing asyncio as its replacement | 09:27 |
| hberaud | yes, in all case asyncio would make HIP obsolete | 09:30 |
| opendevreview | Stephen Finucane proposed openstack/tooz master: Remove use of distutils https://review.opendev.org/c/openstack/tooz/+/914633 | 10:26 |
| opendevreview | Stephen Finucane proposed openstack/tooz master: Remove unnecessary dependencies https://review.opendev.org/c/openstack/tooz/+/914634 | 10:26 |
| opendevreview | Stephen Finucane proposed openstack/tooz master: pre-commit: Bump version, add doc8 https://review.opendev.org/c/openstack/tooz/+/914635 | 10:26 |
| opendevreview | Dr. Jens Harbott proposed openstack/openstack-doc-tools master: Update sitemap generator with current series https://review.opendev.org/c/openstack/openstack-doc-tools/+/914614 | 15:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!