Wednesday, 2024-02-14

opendevreviewTakashi Kajinami proposed openstack/tooz master: redis: support healthcheck interval  https://review.opendev.org/c/openstack/tooz/+/90896402:29
opendevreviewTakashi Kajinami proposed openstack/tooz master: redis: Fix wrong type used to parse socket_keepalive  https://review.opendev.org/c/openstack/tooz/+/90896502:47
opendevreviewTakashi Kajinami proposed openstack/oslo.cache stable/2023.2: Ensure requirements are capped by upper constraints  https://review.opendev.org/c/openstack/oslo.cache/+/90897508:07
opendevreviewTakashi Kajinami proposed openstack/oslo.cache stable/2023.1: Ensure requirements are capped by upper constraints  https://review.opendev.org/c/openstack/oslo.cache/+/90897608:13
opendevreviewMerged openstack/castellan master: Bump hacking  https://review.opendev.org/c/openstack/castellan/+/90697509:59
damanihi10:09
damanitkajinam, what do you think about https://review.opendev.org/c/openstack/oslo.cache/+/907681/2/oslo_cache/backends/dictionary.py?10:09
tkajinamo/10:24
tkajinamdamani, I've left a comment 10:24
tkajinamI don't think that specific change improves readability.10:25
damanino10:26
damaniactually for me it's the oposite 10:26
damaniit's harder to read 10:26
tkajinamyeah10:35
tkajinamit may be useful in a different situations (like when we check whether x is within [a, b] but does not work well for that specific logic10:36
damanitkajinam, i agree 11:40
damanihberaud, can you take a look please https://review.opendev.org/c/openstack/taskflow/+/90766611:40
opendevreviewTakashi Kajinami proposed openstack/oslo.utils master: wip: showing proposal  https://review.opendev.org/c/openstack/oslo.utils/+/90898711:45
opendevreviewMerged openstack/openstack-doc-tools master: Update python classifier in setup.cfg  https://review.opendev.org/c/openstack/openstack-doc-tools/+/90536612:00
hberaudboth versions (the older one and the proprosed one) are ok for me, but, IMO readability must prevail on technical barrel role. So if you guys both think that it is harder to read, then I'd argue that we must keep the current version12:48
hberauds/role/roll12:48
opendevreviewMerged openstack/oslo.cache master: config: Document backends supporting specific options  https://review.opendev.org/c/openstack/oslo.cache/+/90877013:19
opendevreviewMerged openstack/taskflow master: redis: Add username  https://review.opendev.org/c/openstack/taskflow/+/90766713:22
opendevreviewMerged openstack/oslo.cache master: redis: Add functional tests  https://review.opendev.org/c/openstack/oslo.cache/+/90765113:23
opendevreviewTakashi Kajinami proposed openstack/oslo.utils master: wip: showing proposal  https://review.opendev.org/c/openstack/oslo.utils/+/90898713:42
damanihberaud, i mean that link https://review.opendev.org/c/openstack/taskflow/+/90766614:15
hberauddone14:20
opendevreviewMerged openstack/taskflow master: redis: Enable SSL for sentinel  https://review.opendev.org/c/openstack/taskflow/+/90766615:39
opendevreviewMerged openstack/taskflow master: Use consistent credential for Redis and Redis Sentinel  https://review.opendev.org/c/openstack/taskflow/+/90767315:52
opendevreviewMerged openstack/taskflow master: redis: Support fallback servers  https://review.opendev.org/c/openstack/taskflow/+/90767415:52
*** jph4 is now known as jph18:32
opendevreviewmelanie witt proposed openstack/castellan master: Raise ManagedObjectNotFoundError in MockKeyManager  https://review.opendev.org/c/openstack/castellan/+/90905120:57
opendevreviewmelanie witt proposed openstack/castellan master: Raise ManagedObjectNotFoundError in MockKeyManager  https://review.opendev.org/c/openstack/castellan/+/90905120:58

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!