opendevreview | Takashi Kajinami proposed openstack/tooz master: Move driver tests to drivers directory https://review.opendev.org/c/openstack/tooz/+/907161 | 01:18 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: pre-commit: Bump versions https://review.opendev.org/c/openstack/oslo.cache/+/907168 | 04:39 |
opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: pre-commit: Integrate bandit https://review.opendev.org/c/openstack/oslo.cache/+/907169 | 04:42 |
ralonsoh | tkajinam, hello! if you have 1 min, please check my comment in https://review.opendev.org/c/openstack/oslo.policy/+/906624 | 06:34 |
ralonsoh | thanks in advance! | 06:34 |
opendevreview | Takashi Kajinami proposed openstack/oslo.service master: pre-commit: Bump versions https://review.opendev.org/c/openstack/oslo.service/+/907175 | 07:00 |
opendevreview | Takashi Kajinami proposed openstack/oslo.service master: pre-commit: Integrate doc8 and bandit https://review.opendev.org/c/openstack/oslo.service/+/907176 | 07:00 |
opendevreview | Philippe SÉRAPHIN proposed openstack/oslo.config master: Add option for generate shell completion script https://review.opendev.org/c/openstack/oslo.config/+/906478 | 07:03 |
opendevreview | Philippe SÉRAPHIN proposed openstack/oslo.config master: Add option for generate shell completion script https://review.opendev.org/c/openstack/oslo.config/+/906478 | 08:35 |
opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Fix minor typos in parameter help texts https://review.opendev.org/c/openstack/oslo.cache/+/907183 | 09:24 |
opendevreview | Merged openstack/etcd3gw master: Bump hacking https://review.opendev.org/c/openstack/etcd3gw/+/906623 | 09:52 |
opendevreview | Philippe SÉRAPHIN proposed openstack/oslo.config master: Add option for generate shell completion script https://review.opendev.org/c/openstack/oslo.config/+/906478 | 11:03 |
opendevreview | Takashi Kajinami proposed openstack/oslo.policy master: Suppress deprecation warnings in policy check tests https://review.opendev.org/c/openstack/oslo.policy/+/907195 | 11:51 |
opendevreview | Takashi Kajinami proposed openstack/oslo.policy master: Add flag to skip undefined rule check https://review.opendev.org/c/openstack/oslo.policy/+/907196 | 11:51 |
tkajinam | ralonsoh, sorry it was kicked out from my small memory by tons of notifications. I've replied to you | 12:01 |
tkajinam | I agree with the problem and the idea of implement the flag in oslo.policy. my comment is more about the implementation | 12:01 |
tkajinam | I hope the above patch can demonstrate what I'm trying to explain... if you agree that approach in 907195 works then I'll add the related-bug flag. | 12:02 |
tkajinam | (please see my comments in the review for details | 12:02 |
tkajinam | agree *with* that approach | 12:03 |
ralonsoh | tkajinam, that solution works for us. We'll set this flag after instantiating the enforcer | 12:06 |
ralonsoh | tkajinam, thanks! | 12:06 |
ralonsoh | I'll abandon my patches | 12:06 |
tkajinam | this would have less interface impact and you can just add one line (with min version of oslo-policy bumped) to address the problem | 12:06 |
tkajinam | I'm not yet sure how generic it would be to disable that check, so did not add a formal interface to override the flag, but setting it after creating an Enforcer should work. if we hear more use cases then we can add a new argument to __init__ | 12:08 |
tkajinam | ralonsoh, thanks for checking. then let me update the patch with the tag (and minor doc improvement) | 12:08 |
ralonsoh | perfect | 12:09 |
opendevreview | Takashi Kajinami proposed openstack/oslo.policy master: Add flag to skip undefined rule check https://review.opendev.org/c/openstack/oslo.policy/+/907196 | 12:10 |
tkajinam | done | 12:11 |
tkajinam | let's see what the other cores feel about this | 12:11 |
opendevreview | Takashi Kajinami proposed openstack/oslo.policy master: Suppress deprecation warnings in policy check tests https://review.opendev.org/c/openstack/oslo.policy/+/907195 | 12:13 |
opendevreview | Takashi Kajinami proposed openstack/oslo.policy master: Add flag to skip undefined rule check https://review.opendev.org/c/openstack/oslo.policy/+/907196 | 12:13 |
opendevreview | Merged openstack/pbr master: Use summary for the package summary https://review.opendev.org/c/openstack/pbr/+/906069 | 12:50 |
opendevreview | Philippe SÉRAPHIN proposed openstack/oslo.config master: Add option for generate shell completion script https://review.opendev.org/c/openstack/oslo.config/+/906478 | 13:16 |
opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Display the reply queue's name in timeout logs https://review.opendev.org/c/openstack/oslo.messaging/+/754049 | 13:54 |
opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Display the reply queue's name in timeout logs https://review.opendev.org/c/openstack/oslo.messaging/+/754049 | 14:00 |
opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Display the reply queue's name in timeout logs https://review.opendev.org/c/openstack/oslo.messaging/+/754049 | 14:07 |
opendevreview | Matúš Jenča proposed openstack/oslo.cache master: :Implement backend for Redis Sentinel https://review.opendev.org/c/openstack/oslo.cache/+/907211 | 14:22 |
opendevreview | Philippe SÉRAPHIN proposed openstack/oslo.config master: Add option for generate shell completion script https://review.opendev.org/c/openstack/oslo.config/+/906478 | 15:01 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!