| opendevreview | Thomas Goirand proposed openstack/tooz master: Add missing coma in diagnostic_lines.append call https://review.opendev.org/c/openstack/tooz/+/891192 | 09:39 |
|---|---|---|
| opendevreview | Thomas Goirand proposed openstack/tooz master: Add missing coma in diagnostic_lines.append call https://review.opendev.org/c/openstack/tooz/+/891192 | 09:43 |
| opendevreview | Merged openstack/tooz master: Change StrictRedis usage to Redis https://review.opendev.org/c/openstack/tooz/+/859544 | 11:10 |
| opendevreview | Jay Faulkner proposed openstack/oslo.messaging master: Only allow safe context fields in notifications https://review.opendev.org/c/openstack/oslo.messaging/+/891096 | 18:51 |
| opendevreview | Jay Faulkner proposed openstack/oslo.messaging master: Only allow safe context fields in notifications https://review.opendev.org/c/openstack/oslo.messaging/+/891096 | 18:52 |
| opendevreview | Jay Faulkner proposed openstack/oslo.messaging master: Only allow safe context fields in notifications https://review.opendev.org/c/openstack/oslo.messaging/+/891096 | 19:36 |
| opendevreview | Jay Faulkner proposed openstack/oslo.messaging master: Only allow safe context fields in notifications https://review.opendev.org/c/openstack/oslo.messaging/+/891096 | 20:07 |
| JayF | https://review.opendev.org/c/openstack/oslo.messaging/+/891096 has been tested working against Ironic in devstack; notification from Ironic is in comments there; unsafe context fields appear to be nulled \o/ | 21:24 |
| JayF | dansmith: Given the nature of the bug; I'm not sure a specific test of Nova notifications is required, but I've tested this working against Ironic. I can test against nova specifically if you think it's needed + it's a hardship for you to do the test. (I've been trying to get a working devstack w/ironic+nova for about a week, something local is screwing it up so testing in | 21:28 |
| JayF | nova would be from a fresh stack for me) | 21:28 |
| * JayF going to be around checking that PR for failed CI/feedback over the weekend, ping me if there's anything | 21:30 | |
| dansmith | JayF: just a DNM patch against nova should confirm it doesn't crash at least, but I can get that done sure | 22:41 |
| dansmith | typically not a huge deal to get something like this landed as long as it's proposed, so let's make sure we don't land, release, and discover we need to fix something | 22:41 |
| JayF | I thoguht https://e3487461d10f0d2cc5e1-c866b68a342a1b98ad74b0accf39cca4.ssl.cf1.rackcdn.com/891096/11/check/tempest-full-py3/ae6b7c2/testr_results.html would've covered it | 22:43 |
| JayF | but I guess you all probably run 4000 different matrix'ed out scenarios in your CI like we do | 22:43 |
| JayF | I'll do a dummy patch for nova, ironic, and neutron to be safe | 22:43 |
| JayF | that may not get up until later today or saturday though | 22:44 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!