| opendevreview | Merged openstack/oslo.utils master: Add netutils.get_my_ipv6() https://review.opendev.org/c/openstack/oslo.utils/+/878078 | 05:04 |
|---|---|---|
| stephenfin | rpittau: A few questions. 1) Are you passing it through in tox (via passenv), 2) Are you sure you're not overriding it in tox.ini (via setenv), 3) Does the test case you're deriving from support it (i.e. it should be derived from oslotest) | 13:43 |
| stephenfin | I also realise you asked over two days ago so you might have solved it by now :) | 13:44 |
| rpittau | stephenfin: no worries and thanks for your answer, here's mine 1) I'm using setenv, not passenv 2) see 1 :) 3) it is indeed all derived from oslotest | 13:47 |
| rpittau | this is my patch if you can spare a moment https://review.opendev.org/c/openstack/ironic/+/885372 help very much appreciated | 13:47 |
| stephenfin | Hmm, seems to work okay for me | 13:55 |
| stephenfin | OS_TEST_TIMEOUT=1 tox -e py38 -- ironic.tests.unit.common | 13:55 |
| stephenfin | 5 tests fail, all with a 'fixtures._fixtures.timeout.TimeoutException' exception | 13:55 |
| stephenfin | rpittau: ^ | 13:56 |
| rpittau | yep, locally is all rainbows and unicorns, but on CI it didn't work as expected, for example this is with a 15secs timeout value https://a7fcebe78a26f8561dd1-73e606dbd0efde3a717e3340853334ea.ssl.cf2.rackcdn.com/885372/4/check/openstack-tox-py39/a68e686/job-output.txt | 13:58 |
| rpittau | Failed: 0 | 13:58 |
| stephenfin | rpittau: https://github.com/openstack/ironic/blob/b4f8209b9/ironic/tests/unit/db/sqlalchemy/test_migrations.py#L191-L192 My guess is that's your culprit? | 14:05 |
| rpittau | fantastic | 14:06 |
| stephenfin | and https://github.com/openstack/ironic/blob/b4f8209b9/ironic/tests/unit/db/sqlalchemy/test_migrations.py#L1442-L1443 too, obviously | 14:06 |
| rpittau | yep, going to burn that code down | 14:06 |
| rpittau | thanks stephenfin | 14:06 |
| stephenfin | nw | 14:07 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!