*** JasonF is now known as JayF | 02:17 | |
opendevreview | Hervé Beraud proposed openstack/oslo.serialization master: Get ready for tox 4 https://review.opendev.org/c/openstack/oslo.serialization/+/869676 | 10:52 |
---|---|---|
opendevreview | Hervé Beraud proposed openstack/oslo.upgradecheck master: Get ready for tox 4 https://review.opendev.org/c/openstack/oslo.upgradecheck/+/869347 | 11:00 |
opendevreview | Hervé Beraud proposed openstack/oslo.reports master: Get ready for tox 4 https://review.opendev.org/c/openstack/oslo.reports/+/869682 | 11:17 |
opendevreview | Hervé Beraud proposed openstack/oslo.messaging master: Get ready for tox 4 https://review.opendev.org/c/openstack/oslo.messaging/+/869071 | 11:21 |
opendevreview | Mauricio Harley proposed openstack/castellan master: Add secret consumers https://review.opendev.org/c/openstack/castellan/+/858057 | 11:47 |
noonedeadpunk | Hey folks! Could you kindly review this patch - https://review.opendev.org/c/openstack/taskflow/+/867083 | 12:23 |
noonedeadpunk | As it's quite annoying... | 12:24 |
stephenfin | fungi: just fyi https://github.com/pypa/pip/issues/11718 | 13:14 |
fungi | stephenfin: interesting, didn't we previously use the edit-constraints tool in requirements to filter projects out of the constraints list in order to avoid that? did it become unnecessary at some point? | 13:19 |
stephenfin | I hadn't heard about that tool before so I can't say. This will affect every library we have though. None of them will be installable alongside constraints. | 13:22 |
stephenfin | (Libraries specifically since services aren't tracked via u-c) | 13:22 |
stephenfin | Hmm, actually this happens without '-e' or '--use-pep517'. How was tox (3) working before... | 13:24 |
andrewbogott_ | I was hoping to get some info from Hervé regarding his comments on https://review.opendev.org/c/openstack/oslo.messaging/+/866616 -- is he here in this channel but with a nick I don't recognize? | 14:27 |
frickler | hberaud: ^^ | 14:32 |
frickler | fungi: stephenfin: devstack does this, but likely not other tox jobs https://opendev.org/openstack/devstack/src/branch/master/inc/python#L376-L384 | 14:35 |
andrewbogott_ | hberaud: the milder fix for that issue is https://review.opendev.org/c/openstack/oslo.messaging/+/866617 -- my concern is that anyone who actually specifies a setting for kombu_reconnect_delay will still encounter the (very serious!) bug. That's why I was proposing an abrupt rip-out of the setting instead. | 14:44 |
andrewbogott_ | Do you think that we should document and deprecate, in spite of the risk? | 14:44 |
hberaud | andrewbogott_: good question, if keeping the logic lead inevitably to the bug, then I'm ok with the abrupt rip-out... | 14:47 |
andrewbogott_ | I think it does. If you read the attached bug, though, you can see that the packagers are taking a different approach, reverting an earlier patch that triggers the issue. | 15:02 |
andrewbogott_ | So that's also an OK fix although in my opinion the patch it's reverting is correct :) | 15:02 |
andrewbogott_ | well, correct but revealed this bug | 15:02 |
andrewbogott_ | Do you want me to explain more, or leave you in peace to read? | 15:03 |
andrewbogott_ | ah, I see your comment on the patch now, I will follow up there. thank you | 15:14 |
opendevreview | Andrew Bogott proposed openstack/oslo.messaging master: Deprecate kombu_reconnect_delay setting and remove associated code https://review.opendev.org/c/openstack/oslo.messaging/+/866616 | 20:18 |
-opendevstatus- NOTICE: One of our CI job log storage providers appears to be having trouble with log uploads and retrievals. We are in the process of removing that provider from the pool. | 22:45 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!