| zigo | I got some unit test failures in the bullseye backports when building oslo.config: | 08:26 |
|---|---|---|
| zigo | https://paste.opendev.org/show/bEl7otPN4YfYvVC6la4S/ | 08:26 |
| zigo | This looks like a unit test error only, with "Deprecated: " in front of the matching test ... | 08:26 |
| zigo | Does anyone know what's going on and how to fix?!? | 08:27 |
| lifeless | so that test is testing support for deprecation warnings. The failure is that the work Deprecated: is prepended to the output string | 08:35 |
| lifeless | sorry, that the work Deprecated: is *missing* | 08:36 |
| lifeless | the logs are being captured by a standard logging fixture | 08:37 |
| lifeless | so presumably either a logging filter is missing, or a version mismatch or some such is present | 08:37 |
| lifeless | ah so the format message is here - https://github.com/openstack/oslo.config/blob/7b838f5c31c3219d13661ec612d750e58683cbe6/oslo_config/tests/test_cfg.py#L1117 - its a test double for some reason - I'm not sure what value such a test brings, but there you are. | 08:38 |
| lifeless | perhaps mock.patch isn't patching it in? | 08:38 |
| lifeless | gl! | 08:38 |
| hberaud | zigo: The issue is related to cliff 4.0.0. See this related fix https://opendev.org/openstack/oslo.config/commit/78098e6b18026ff9ef03a948b57348f02d42e13b | 08:56 |
| hberaud | the same behavior is observable with cliff > 3.4.0 | 08:57 |
| hberaud | cliff 4.0.0 is pulled in your tests https://paste.opendev.org/show/bEl7otPN4YfYvVC6la4S/ | 08:58 |
| zigo | lifeless: hberaud: I did this as a temporary measure: https://salsa.debian.org/openstack-team/oslo/python-oslo.config/-/blob/debian/zed/debian/patches/fix-oslo.config-test-under-bullseye.patch | 09:03 |
| zigo | I'd of course prefer an upstream patch ... | 09:03 |
| zigo | This is just a "hide dust under the carpet" patch, though I'm ok with it as the feature doesn't seem broken (only tests...). | 09:04 |
| opendevreview | Andre Aranha proposed openstack/castellan master: [DNM] Add unit tests for secret consumers https://review.opendev.org/c/openstack/castellan/+/859112 | 12:55 |
| opendevreview | Merged openstack/pycadf master: Update zuul job templates https://review.opendev.org/c/openstack/pycadf/+/858198 | 16:12 |
| opendevreview | Merged openstack/pycadf master: remove unicode prefix from code https://review.opendev.org/c/openstack/pycadf/+/853462 | 16:12 |
| stephenfin | zzzeek: Yup, mostly seems to work with 1.4 as johnsom said | 16:45 |
| stephenfin | I'm not sure what the email you're referring to is | 16:46 |
| zzzeek | stephenfin: yes was secret red hat info I spilled | 16:48 |
| stephenfin | haha, okay cool :) | 16:48 |
| zzzeek | are you on RH irc, I dont see you anywhere | 16:49 |
| stephenfin | Use my old nick (sfinucan) there | 16:49 |
| zzzeek | ah | 16:50 |
| opendevreview | Merged openstack/openstackdocstheme master: Update included page footers to use current URLs https://review.opendev.org/c/openstack/openstackdocstheme/+/857164 | 17:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!