| opendevreview | Stephen Finucane proposed openstack/oslo-specs master: [oslo.messaging] add unix socket notifcation driver https://review.opendev.org/c/openstack/oslo-specs/+/839819 | 08:03 |
|---|---|---|
| opendevreview | Merged openstack/oslo-specs master: [oslo.messaging] add unix socket notifcation driver https://review.opendev.org/c/openstack/oslo-specs/+/839819 | 08:14 |
| opendevreview | sean mooney proposed openstack/oslo.messaging master: [WIP] add unix socket notifcation driver https://review.opendev.org/c/openstack/oslo.messaging/+/841892 | 11:32 |
| sean-k-mooney | stephenfin: if you are about can you tell me how im beign dumb ^ | 11:33 |
| sean-k-mooney | or is t hat really a bug that i should og fix | 11:33 |
| sean-k-mooney | it looks like everwhere else its doign self.config(driver=['test'], | 11:36 |
| sean-k-mooney | which i guess i can do but that feels liek a hack | 11:37 |
| stephenfin | sean-k-mooney: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/notifier.py#L32-L38 | 11:38 |
| stephenfin | It's because it's a MultiStrOpt | 11:38 |
| sean-k-mooney | oh ok | 11:38 |
| sean-k-mooney | then i would have expected a type error | 11:39 |
| sean-k-mooney | but that at least makes sense | 11:39 |
| stephenfin | Yeah, if you look for how we set e.g. 'passthrough_whitelist' in nova tests | 11:39 |
| stephenfin | You'll see that expects a list also | 11:39 |
| sean-k-mooney | i guess its not drivers for legacy reasons | 11:39 |
| stephenfin | I would say so. No reason we couldn't rename it | 11:40 |
| sean-k-mooney | for now ill just add a note in the code to call out why im passign a list | 11:40 |
| sean-k-mooney | i just was not expect a list based on the name | 11:40 |
| sean-k-mooney | thanks | 11:41 |
| sean-k-mooney | i knew it woudl be simple but i forgot to check the type | 11:41 |
| stephenfin | All good :) | 11:44 |
| sean-k-mooney | i can slowly feel my brianpower and sanity sliping away | 13:59 |
| opendevreview | sean mooney proposed openstack/oslo.messaging master: [WIP] add unix socket notifcation driver https://review.opendev.org/c/openstack/oslo.messaging/+/841892 | 14:02 |
| sean-k-mooney | ok i kind of found what the problem was | 14:37 |
| sean-k-mooney | it was in my code... | 14:37 |
| sean-k-mooney | does oslo messagaign have a way to get an executor/thread pool automaticlly | 17:46 |
| sean-k-mooney | i know it can run with our without eventlets | 17:48 |
| sean-k-mooney | utils.get_executor_with_context() | 17:49 |
| sean-k-mooney | that might be waht i want | 17:50 |
| opendevreview | sean mooney proposed openstack/oslo.messaging master: [WIP] add unix socket notifcation driver https://review.opendev.org/c/openstack/oslo.messaging/+/841892 | 20:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!