| stephenfin | hberaud: replied on https://review.opendev.org/c/openstack/oslo.cache/+/826569 sorry for the delay | 10:50 |
|---|---|---|
| hberaud | np | 10:51 |
| hberaud | stephenfin: I just replied to your comment | 11:45 |
| stephenfin | hberaud: okay, fair, you convinced me | 12:17 |
| hberaud | stephenfin: :) | 12:17 |
| rm_work | Plugging Still looking for another reviewer to merge | 12:24 |
| rm_work | https://review.opendev.org/c/openstack/oslo.messaging/+/807826 again… | 12:24 |
| rm_work | Who is a core besides Hervé? | 12:24 |
| stephenfin | me, but I don't understand that stuff well enough to review properly | 12:26 |
| stephenfin | rm_work: Have you tested this in a real deployment? | 12:27 |
| rm_work | We’re running it in QE and it seems to be ok, we want to push it to prod but were waiting to not have to manually port the patch into our build system 😅 | 12:28 |
| rm_work | I’ll check today with the engineer primarily focused on this and make sure he’s had no issues, but so far as he’s told us it is working | 12:30 |
| rm_work | I’ll ping you when I’ve verified we’re running it with no issues, that work for you? | 12:32 |
| stephenfin | Yup. I think we also want some docs for this. Ruby has left some great questions on the matter | 12:32 |
| stephenfin | I'll reply shortly | 12:32 |
| rm_work | Kk thanks 🙏 | 12:32 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/tooz master: Support etcd3gw api version https://review.opendev.org/c/openstack/tooz/+/827492 | 13:12 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/tooz master: Support etcd3gw api version https://review.opendev.org/c/openstack/tooz/+/827492 | 14:32 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/tooz master: Support etcd3gw api version https://review.opendev.org/c/openstack/tooz/+/827492 | 14:38 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/tooz master: Support etcd3gw api version https://review.opendev.org/c/openstack/tooz/+/827492 | 15:22 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/etcd3gw master: Add py38-etcd tox env https://review.opendev.org/c/openstack/etcd3gw/+/827520 | 15:37 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/etcd3gw master: Pass api_path thru etcd3gw.client https://review.opendev.org/c/openstack/etcd3gw/+/827521 | 15:37 |
| hberaud | stephenfin: just to be sure, I see you pressed the backport-candidate button here https://review.opendev.org/c/openstack/oslo.cache/+/826569/ 1) I wonder if it's voluntary and else if you wanted to put a review +2 2) I think we can go with a single core approval here (proposed by a core and backported by a core) | 15:49 |
| stephenfin | whoops, done | 15:55 |
| hberaud | thanks | 16:27 |
| hberaud | np | 16:27 |
| hberaud | stephenfin: sorry, can I ask you to W+ too? I have no other person to whom I can ask to review this patch anyway | 16:31 |
| stephenfin | sure | 16:31 |
| hberaud | s/this patch/these patches | 16:31 |
| hberaud | thanks | 16:32 |
| opendevreview | Merged openstack/oslo.cache stable/xena: Add socket keepalive options to oslo.cache https://review.opendev.org/c/openstack/oslo.cache/+/826569 | 18:16 |
| opendevreview | Merged openstack/oslo.cache stable/xena: Add retry mechanisms to oslo.cache https://review.opendev.org/c/openstack/oslo.cache/+/826593 | 18:16 |
| opendevreview | Merged openstack/oslo.cache stable/xena: Expose pymemcache's HashClient public params https://review.opendev.org/c/openstack/oslo.cache/+/826594 | 18:16 |
| *** dkehn_ is now known as dkehn | 20:47 | |
| opendevreview | Merged openstack/oslo.db master: Don't rely on implicit autocommit https://review.opendev.org/c/openstack/oslo.db/+/802587 | 21:00 |
| opendevreview | Merged openstack/oslo.db master: Remove use of Session.begin.subtransactions flag https://review.opendev.org/c/openstack/oslo.db/+/802588 | 21:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!