| *** mtreinish_ is now known as mtreinish | 05:13 | |
| Jorhson | stephenfin: Hi,stephenfin,can help to review the commit in your free time, thanks. https://review.opendev.org/c/openstack/oslo.cache/+/742060 | 06:17 |
|---|---|---|
| Jorhson | stephenfin: another commit is https://review.opendev.org/c/openstack/keystonemiddleware/+/743687 | 06:18 |
| damani | hberaud, stephenfin, can i have review please https://review.opendev.org/c/openstack/oslo.utils/+/825316 | 10:08 |
| hberaud | damani: done. See my comment on the patch ^ | 10:17 |
| damani | ok | 10:17 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.utils stable/victoria: Dropping lower constraints testing https://review.opendev.org/c/openstack/oslo.utils/+/825316 | 10:23 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.utils stable/victoria: Fix regex used to mask password https://review.opendev.org/c/openstack/oslo.utils/+/824912 | 10:23 |
| damani | hberaud, right sorry | 10:24 |
| damani | done :) | 10:24 |
| damani | hberaud, do you think we need to work on it https://review.opendev.org/c/openstack/pbr/+/662035 | 10:25 |
| damani | or close it ? | 10:25 |
| hberaud | damani: do you want to own this topic? | 10:37 |
| hberaud | ^ | 10:37 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.context master: Integrate mypy https://review.opendev.org/c/openstack/oslo.context/+/742487 | 10:39 |
| hberaud | I mean it depends mostly on you and if you volunteer to own this topic. I'm not against keeping it open but for now, personally I won't spend time on it. I can help by reviewing changes if needed | 10:39 |
| hberaud | damani: ^ | 10:39 |
| damani | hberaud, can you please review this patch https://review.opendev.org/c/openstack/oslo.context/+/742487 ? | 10:40 |
| damani | hberaud, my question is more do you think it's something we need to do | 10:41 |
| damani | if yes i can own the topic if no we can close it | 10:41 |
| hberaud | damani: yes I think this is an interesting change that will become more and more needed in a near future | 10:43 |
| damani | ok | 10:44 |
| damani | so i take it :) | 10:44 |
| hberaud | excellent | 10:44 |
| opendevreview | Merged openstack/oslo.service stable/wallaby: Make debug option of wsgi server configurable https://review.opendev.org/c/openstack/oslo.service/+/824915 | 11:24 |
| damani | hberaud, i think we can merge it https://review.opendev.org/c/openstack/oslo.utils/+/825316 | 13:37 |
| damani | and i will do the backport for ussuri and train | 13:37 |
| opendevreview | Gregory Thiemonge proposed openstack/taskflow master: Delete the job from backend if it cannot be consumed https://review.opendev.org/c/openstack/taskflow/+/816799 | 13:42 |
| hberaud | damani: I'm waiting for a 2nd +2 | 13:49 |
| elodilles | sorry for sticking my nose into it, but i also commented on the oslo.utils l-c job related patch o:) | 14:27 |
| elodilles | it's an easy to fix error, so i could imagine that fix instead of dropping the job because of it | 14:28 |
| elodilles | damani: ^^^ | 14:28 |
| damani | elodilles, i will check it | 14:32 |
| hberaud | elodilles: we already removed those LC on almost all oslo projects' stable branches | 14:39 |
| hberaud | elodilles: in other words this patch will uniformize LC management on oslo | 14:40 |
| elodilles | hmmm, i see, i just saw the l-c job on wallaby o:) | 14:48 |
| hberaud | on oslo.utils? | 14:51 |
| hberaud | elodilles: ^ | 14:52 |
| hberaud | indeed | 14:52 |
| hberaud | I see it | 14:52 |
| stephenfin | elodilles: Yeah, there shouldn't be any LC jobs in oslo anymore. Anything that's there is a mistake. We don't have the bandwidth to fix and/or maintain them | 14:53 |
| hberaud | damani: so, we need to remove LC on wallaby first, and then backport the patch | 14:53 |
| stephenfin | I say we but I really mean hberaud and damani since I'm mostly working elsewhere now | 14:53 |
| hberaud | my bad I was thinking it was already removed on W | 14:54 |
| elodilles | stephenfin: yepp, i see, thanks for the explanation. l-c fixes were time consuming to fix when the new pip resolver came out, that's true | 14:56 |
| elodilles | if i'm already here... o:) ... can i get a second stable core review for this patch? https://review.opendev.org/c/openstack/oslo.service/+/824916 | 15:00 |
| elodilles | hberaud: you have already reviewed the xena and wallaby version, so you might remember the context o:) | 15:03 |
| hberaud | elodilles: done | 15:04 |
| elodilles | hberaud: thx \o/ | 15:05 |
| damani | my bad too | 15:05 |
| damani | sorry | 15:05 |
| damani | i will do the patch for wallaby | 15:06 |
| elodilles | damani: add me as reviewer and I'll help with the review | 15:07 |
| damani | elodilles, sure :) | 15:08 |
| elodilles | :] | 15:08 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.utils stable/wallaby: Dropping lower constraints testing https://review.opendev.org/c/openstack/oslo.utils/+/825528 | 15:26 |
| damani | elodilles, hberaud, https://review.opendev.org/c/openstack/oslo.utils/+/825528 | 15:26 |
| damani | hberaud, seems we have a ci issue https://review.opendev.org/c/openstack/pbr/+/767972 | 15:33 |
| hberaud | damani: I see I left a comment this morning | 15:35 |
| hberaud | I can't reproduce it locally | 15:35 |
| damani | yes me either | 15:36 |
| damani | but a lot of patch failed | 15:36 |
| damani | neither | 15:36 |
| hberaud | which patches? | 15:36 |
| damani | i need to check again | 15:37 |
| damani | but i have seen other patches failed | 15:37 |
| hberaud | it start failing with py37 | 15:37 |
| damani | with the same issue | 15:37 |
| hberaud | I tested with py38 locally | 15:37 |
| opendevreview | Hervé Beraud proposed openstack/pbr master: [DNM] trying reproduce CI error https://review.opendev.org/c/openstack/pbr/+/825537 | 15:53 |
| hberaud | damani: let's try to reproduce it here ^ | 15:53 |
| damani | hberaud, ok | 15:53 |
| fungi | hberaud: i reproduced it with a similar change yesterday | 15:53 |
| hberaud | oh interesting | 15:54 |
| fungi | hberaud: https://review.opendev.org/825380 | 15:54 |
| fungi | in case you don't want to have to wait for results on yours | 15:54 |
| hberaud | fungi: excellent thank you | 15:54 |
| fungi | if the cause isn't obvious, i can probably set aside some time to dig into it as well | 15:55 |
| opendevreview | Gregory Thiemonge proposed openstack/taskflow master: WIP DNM Checking unit tests https://review.opendev.org/c/openstack/taskflow/+/825539 | 15:56 |
| fungi | hah | 15:56 |
| fungi | i wonder if taskflow's errors are related ^ | 15:56 |
| hberaud | indeed | 16:00 |
| hberaud | gthiemonge: FYI https://review.opendev.org/825380 we are not sure if your DNM patch is related | 16:01 |
| * hberaud AFK | 16:02 | |
| gthiemonge | hberaud: I'm checking a possible infinite loop in taskflow | 16:05 |
| opendevreview | Merged openstack/oslo.service stable/victoria: Make debug option of wsgi server configurable https://review.opendev.org/c/openstack/oslo.service/+/824916 | 16:31 |
| fungi | i'm able to reproduce locally with `tox -e py39` in pbr | 17:01 |
| fungi | up through py36 is passing and py37 up is failing, so it would probably help to compare pip freeze from a 3.6 and 3.7 run | 17:02 |
| fungi | i'll do that next | 17:02 |
| fungi | https://zuul.opendev.org/t/openstack/build/6f808229baea40f491c0e265de0aab9a/log/tox/py36-1.log vs https://zuul.opendev.org/t/openstack/build/a2651519587b42e48dfdef9c2f35052b/log/tox/py37-1.log | 17:10 |
| fungi | importlib-resources==5.2.3 is installed in the 3.6 env, 3.7 is using stdlib for that i guess | 17:11 |
| fungi | filelock goes from 3.4.1 to 3.4.2 | 17:13 |
| fungi | platformdirs 2.4.0 vs 2.4.1 | 17:13 |
| fungi | prettytable 2.5.0 to 3.0.0 | 17:13 |
| fungi | and zipp 3.6.0 to 3.7.0 | 17:14 |
| fungi | there are also almost certainly differences in setuptools versions (which pip freeze omits), as well as maybe wheel and pkg_resources | 17:14 |
| fungi | setuptools/pkg_resources/importlib changes are always likely to hit pbr hard | 17:19 |
| fungi | clarkb's comments in #opendev indicate newer setuptools is to blame | 17:52 |
| fungi | changed something about logging | 17:52 |
| hberaud | good catch | 18:08 |
| fungi | more in-depth analysis in #opendev | 18:13 |
| fungi | but in short, using pbr<60.2 seems to get tests passing. changelog for 60.2.0 says to switch from distutils.log to the python logging module, logging.getLogger(name) | 18:14 |
| fungi | though per clarkb it seems like continuing to use distutils.log is actually still expected to work, except that change seems to have broken setting the threshold | 18:17 |
| opendevreview | Merged openstack/oslo.utils stable/wallaby: Dropping lower constraints testing https://review.opendev.org/c/openstack/oslo.utils/+/825528 | 18:28 |
| opendevreview | Jeremy Stanley proposed openstack/pbr master: Don't test with setuptools local distutils https://review.opendev.org/c/openstack/pbr/+/825665 | 18:51 |
| fungi | we expect that ^ to pass, based on local testing | 18:56 |
| fungi | okay, close. not sure why the coverage job is failing, but looking into that now | 20:58 |
| opendevreview | Jeremy Stanley proposed openstack/pbr master: Don't test with setuptools local distutils https://review.opendev.org/c/openstack/pbr/+/825665 | 21:01 |
| fungi | apparently we setenv separately in [testenv:cover] | 21:02 |
| fungi | damani: hberaud: okay, so that's ^ passing now, if folks are okay with the workaround | 23:39 |
| fungi | then we'll be able to get back to merging other pbr fixes | 23:39 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!