| opendevreview | wdd proposed openstack/oslo.utils master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/oslo.utils/+/804187 | 03:04 |
|---|---|---|
| opendevreview | wdd proposed openstack/oslo.utils master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/oslo.utils/+/804188 | 03:06 |
| opendevreview | wdd proposed openstack/oslo.metrics master: hanged minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/oslo.metrics/+/804190 | 03:40 |
| opendevreview | wdd proposed openstack/oslo.metrics master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/oslo.metrics/+/804191 | 03:42 |
| opendevreview | wdd proposed openstack/oslo.metrics master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/oslo.metrics/+/804190 | 03:42 |
| *** rpittau|afk is now known as rpittau | 07:23 | |
| hberaud | stephenfin: o/ Please can you have a look to https://review.opendev.org/c/openstack/oslo.messaging/+/757242 | 07:49 |
| stephenfin | zzzeek: Yeah, so it's in upper-constraints and we don't have lower-constraints jobs in oslo any more /o\ I'm happy to bump things and make it clear in the release notes that we need SQLA 1.4.x now, if that works for you. Alternatively, I can separate out the SQLA 1.4.x stuff, but it doesn't sound like we've good reason to do so rn | 09:01 |
| stephenfin | hberaud: Seems there are open questions on it still? https://review.opendev.org/c/openstack/oslo.messaging/+/757242/1/oslo_messaging/exceptions.py | 09:03 |
| hberaud | stephenfin: yes more or less | 09:04 |
| hberaud | stephenfin: I'll decrease to +1 | 09:04 |
| stephenfin | Okay, I'm running it in a loop locally. Will let you know if/when it fails | 09:13 |
| stephenfin | hberaud: out of curiosity though, are you able to reproduce the failure on stable/train _without_ this patch? Perhaps there's something else wrong? | 09:14 |
| stephenfin | hberaud: I'm seeing the same failure on stable/train. I don't think it's specific to this patch | 09:43 |
| stephenfin | hberaud: I'm not sure what test is failing, but it locks up and starts emitting the following error messages repeatedly: | 09:44 |
| stephenfin | ERROR [oslo_messaging._drivers.amqp1_driver.controller] Socket failure: [Errno 111] Connection refused | 09:44 |
| hberaud | stephenfin: same thing here | 09:55 |
| hberaud | stephenfin: but that's not systematic | 09:55 |
| stephenfin | wfym? | 09:55 |
| stephenfin | *wdym | 09:55 |
| hberaud | stephenfin: by example with this patch ^ the tests pass around 70% of the time without errors | 09:56 |
| hberaud | it's more something flaky | 09:57 |
| stephenfin | I don't understand. Are you saying that the patch makes things worse, makes things better, or makes no difference? | 09:57 |
| hberaud | I mean I can reproduce the same error than you with stable/train | 09:57 |
| hberaud | and without any new patch | 09:58 |
| hberaud | the patch behave similarly than without it | 09:58 |
| hberaud | s/the patch/the tests with the patch/ | 09:58 |
| hberaud | in other words: no difference | 09:59 |
| stephenfin | gotcha, so are you saying we should ignore it or that the patch is useless? | 09:59 |
| hberaud | I'm saying that we should ignore it | 10:00 |
| stephenfin | okay | 10:00 |
| hberaud | the patch is useful when rabbitmq face performances issues | 10:00 |
| stephenfin | but I still have concerns around the "metadata" aspect of the patch. See my latest comments. I'd like the author to address those first so we can see the link between the various patches | 10:01 |
| stephenfin | I'm pretty sure they missed backporting to stable/ussuri also | 10:01 |
| stephenfin | I don't see a matching patch there | 10:01 |
| hberaud | no | 10:01 |
| hberaud | ussuri is already done | 10:01 |
| hberaud | https://review.opendev.org/c/openstack/oslo.messaging/+/743647 | 10:01 |
| stephenfin | oh, sweet. gtk - I missed that :) | 10:02 |
| hberaud | but as I said in my latest comments, this is a rewriting of this patch because the import of the exceptions doesn't work as expected | 10:02 |
| stephenfin | It's not a brand new patch though. Parts of it are the same. It's still built on the same foundation | 10:02 |
| hberaud | I already asked for an update on the commit message to keep a track of the history | 10:03 |
| hberaud | yes | 10:03 |
| stephenfin | We should use the same Change ID, include the "cherry picked from" line, and add a NOTE explaining what has changed | 10:03 |
| stephenfin | IMO | 10:03 |
| stephenfin | It's just easier if you're strict with this otherwise stuff gets missed | 10:03 |
| hberaud | At least I would appreciate the cherry-pick information and a note about the delta between ussuri and train to explain why | 10:03 |
| hberaud | yes | 10:03 |
| hberaud | I missed the change ID part | 10:04 |
| *** rpittau is now known as rpittau|afk | 11:28 | |
| opendevreview | Merged openstack/oslo.metrics master: Enable Test Coverage and Add New Test https://review.opendev.org/c/openstack/oslo.metrics/+/800271 | 13:22 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.middleware master: healthcheck: Limit source IP range https://review.opendev.org/c/openstack/oslo.middleware/+/800413 | 13:33 |
| opendevreview | Merged openstack/oslo.db master: Don't pass strings to Connection.execute() https://review.opendev.org/c/openstack/oslo.db/+/802571 | 14:44 |
| opendevreview | Merged openstack/oslo.db stable/victoria: Added handler for mysql 8.0.19 duplicate key error update https://review.opendev.org/c/openstack/oslo.db/+/798761 | 16:28 |
| opendevreview | Merged openstack/oslo.db master: Add missing bind argument to calls https://review.opendev.org/c/openstack/oslo.db/+/802572 | 18:18 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!