openstackgerrit | David Vallee Delisle proposed openstack/oslo.config master: Adding --check-defaults to validator https://review.opendev.org/759338 | 01:15 |
---|---|---|
openstackgerrit | David Vallee Delisle proposed openstack/oslo.config master: Adding --check-defaults to validator https://review.opendev.org/759338 | 01:30 |
*** brinzhang has joined #openstack-oslo | 02:09 | |
*** hamalq_ has quit IRC | 02:45 | |
*** rcernin has quit IRC | 02:51 | |
*** rcernin has joined #openstack-oslo | 03:19 | |
*** rcernin has quit IRC | 03:19 | |
*** rcernin has joined #openstack-oslo | 03:19 | |
*** rpittau|afk is now known as rpittau | 06:21 | |
*** ralonsoh has joined #openstack-oslo | 07:02 | |
*** hoonetorg has quit IRC | 07:07 | |
*** hoonetorg has joined #openstack-oslo | 07:19 | |
*** sboyron has joined #openstack-oslo | 07:20 | |
*** sboyron has quit IRC | 07:26 | |
*** tosky has joined #openstack-oslo | 07:36 | |
*** sboyron has joined #openstack-oslo | 07:49 | |
*** sboyron has quit IRC | 07:51 | |
*** sboyron has joined #openstack-oslo | 07:52 | |
*** sboyron has quit IRC | 09:04 | |
*** brinzhang has quit IRC | 09:53 | |
*** sboyron has joined #openstack-oslo | 10:18 | |
*** sboyron has quit IRC | 10:23 | |
*** dtantsur|afk is now known as dtantsur | 10:39 | |
*** takamatsu has quit IRC | 11:28 | |
*** takamatsu has joined #openstack-oslo | 11:32 | |
*** takamatsu has quit IRC | 11:34 | |
*** takamatsu has joined #openstack-oslo | 11:35 | |
*** sboyron has joined #openstack-oslo | 11:51 | |
openstackgerrit | Daniel Bengtsson proposed openstack/oslo.messaging stable/train: add min of 1 to rpc_conn_pool_size https://review.opendev.org/759410 | 12:11 |
openstackgerrit | Daniel Bengtsson proposed openstack/oslo.config stable/victoria: Add a new type HostDomain. https://review.opendev.org/759411 | 12:18 |
damani | hi | 12:22 |
*** kgiusti has joined #openstack-oslo | 12:22 | |
damani | bnemec, smcginnis, i have proposed a backport for victoria about https://review.opendev.org/759411 | 12:22 |
*** AJaeger has left #openstack-oslo | 12:23 | |
damani | it's a new feature, i add a new type, so i'm not sure if i can propose the cherry-pick or not | 12:23 |
smcginnis | damani: Was there a reason the existing HostAddress couldn't be updated to handle the _ character? | 13:06 |
smcginnis | Typically we don't allow backporting new things like that per stable policy. But since this addresses an issue and looks to be backwards compatible, maybe it could be OK in this instance. | 13:07 |
damani | smcginnis, initially i proposed that | 13:08 |
damani | smcginnis, but it was refused by bnemec because like he explained it's not a valid hostame | 13:10 |
damani | smcginni, so he proposed to add a new class to support the _ | 13:10 |
damani | https://review.opendev.org/#/c/746723/ | 13:11 |
smcginnis | Hmm. I think it should either be allowed or it shouldn't. Needing to configure a whole different class just to allow one character (that we've concrete examples of being used, valid or not) seems wrong to me. | 13:11 |
*** ianychoi_ has joined #openstack-oslo | 13:13 | |
*** ianychoi has quit IRC | 13:16 | |
*** rpittau is now known as rpittau|afk | 14:06 | |
*** sboyron has quit IRC | 14:22 | |
*** sboyron has joined #openstack-oslo | 14:37 | |
bnemec | The problem is it's an illegal character in hostnames. If we validate according to the RFC then we can't allow it in hostnames. | 14:38 |
bnemec | But apparently there are use cases where an _ is allowed in a hostname-like value. | 14:38 |
*** sboyron has quit IRC | 14:41 | |
*** takamatsu has quit IRC | 15:15 | |
*** ralonsoh has quit IRC | 15:20 | |
*** ralonsoh has joined #openstack-oslo | 15:20 | |
*** takamatsu has joined #openstack-oslo | 15:53 | |
*** ralonsoh has quit IRC | 16:36 | |
*** dtantsur is now known as dtantsur|afk | 17:12 | |
*** hamalq has joined #openstack-oslo | 17:17 | |
*** hamalq_ has joined #openstack-oslo | 17:20 | |
*** hamalq has quit IRC | 17:23 | |
openstackgerrit | David Vallee Delisle proposed openstack/oslo.config master: Adding --check-defaults to validator https://review.opendev.org/759338 | 17:33 |
openstackgerrit | David Vallee Delisle proposed openstack/oslo.config master: Adding --check-defaults to validator https://review.opendev.org/759338 | 17:37 |
openstackgerrit | David Vallee Delisle proposed openstack/oslo.config master: Adding --check-defaults to validator https://review.opendev.org/759338 | 17:51 |
openstackgerrit | David Vallee Delisle proposed openstack/oslo.config master: Adding --check-defaults to validator https://review.opendev.org/759338 | 18:11 |
*** lbragstad has quit IRC | 18:29 | |
openstackgerrit | David Vallee Delisle proposed openstack/oslo.config master: Adding --check-defaults to validator https://review.opendev.org/759338 | 19:37 |
*** rcernin has quit IRC | 19:55 | |
*** kgiusti has left #openstack-oslo | 21:19 | |
*** raildo has quit IRC | 21:53 | |
*** rcernin has joined #openstack-oslo | 22:01 | |
*** pmatulis has joined #openstack-oslo | 22:34 | |
*** pmatulis has left #openstack-oslo | 22:34 | |
*** rcernin has quit IRC | 22:59 | |
*** sean-k-mooney has quit IRC | 23:20 | |
*** sean-k-mooney has joined #openstack-oslo | 23:21 | |
openstackgerrit | David Vallee Delisle proposed openstack/oslo.config master: Adding --check-defaults to validator https://review.opendev.org/759338 | 23:22 |
*** hamalq_ has quit IRC | 23:43 | |
*** tosky has quit IRC | 23:46 | |
*** rcernin has joined #openstack-oslo | 23:50 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!