| *** brinzhang_ has joined #openstack-oslo | 00:32 | |
| *** brinzhang0 has quit IRC | 00:36 | |
| *** bnemec has quit IRC | 00:41 | |
| *** bnemec has joined #openstack-oslo | 00:46 | |
| *** brinzhang_ has quit IRC | 01:31 | |
| *** brinzhang_ has joined #openstack-oslo | 01:31 | |
| *** bnemec has quit IRC | 01:34 | |
| *** zzzeek has quit IRC | 01:36 | |
| *** zzzeek has joined #openstack-oslo | 01:38 | |
| *** bnemec has joined #openstack-oslo | 01:39 | |
| *** rcernin has quit IRC | 02:29 | |
| *** rcernin has joined #openstack-oslo | 02:51 | |
| *** rcernin has quit IRC | 02:56 | |
| *** rcernin has joined #openstack-oslo | 02:56 | |
| *** dave-mccowan has quit IRC | 03:00 | |
| *** zzzeek has quit IRC | 03:02 | |
| *** zzzeek has joined #openstack-oslo | 03:05 | |
| *** zzzeek has quit IRC | 05:37 | |
| *** zzzeek has joined #openstack-oslo | 05:37 | |
| *** ralonsoh has joined #openstack-oslo | 06:14 | |
| *** zzzeek has quit IRC | 06:16 | |
| *** zzzeek has joined #openstack-oslo | 06:17 | |
| *** zzzeek has quit IRC | 06:47 | |
| *** hoonetorg has quit IRC | 06:48 | |
| *** zzzeek has joined #openstack-oslo | 06:50 | |
| *** hoonetorg has joined #openstack-oslo | 07:01 | |
| *** rcernin has quit IRC | 07:28 | |
| *** brinzhang_ has quit IRC | 07:31 | |
| *** brinzhang_ has joined #openstack-oslo | 07:32 | |
| *** yoctozepto has quit IRC | 07:34 | |
| *** dtantsur|afk is now known as dtantsur | 07:40 | |
| *** tosky has joined #openstack-oslo | 07:47 | |
| *** moguimar has joined #openstack-oslo | 08:01 | |
| *** brinzhang_ has quit IRC | 08:10 | |
| *** brinzhang_ has joined #openstack-oslo | 08:11 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.privsep stable/train: Undo the eventlet monkey patch for the privileged daemon https://review.opendev.org/747907 | 08:32 |
|---|---|---|
| stephenfin | hberaud: What are your thoughts on eliminating the +2/-2 Backport-Candidate label value in favour of core-only +1/-1 ? | 08:46 |
| stephenfin | I ask because I'm considering doing that for nova and want to check if there's a reason we didn't do that in nova | 08:46 |
| stephenfin | I'm not sure how useful the +1/-1 is currently. I really only pay attention to the +2/-2. Maybe that's wrong of me? | 08:47 |
| hberaud | stephenfin: good question, I think "core-only +1/-1" is enough (even on oslo), on oslo I copied existing rules but now with more experience I think +2/-2 are not really useful and also I think that backport decisions should be only managed by core developers | 08:53 |
| *** yoctozepto has joined #openstack-oslo | 08:55 | |
| hberaud | so if is it possible to limit backport vote to core then no matter if we use +2 or +1 as long as a positive vote has been given | 08:57 |
| stephenfin | hberaud: Okay, I've proposed https://review.opendev.org/748384. Let's see what infra think of the idea | 09:14 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: [WIP] Adding pre-commit https://review.opendev.org/742137 | 09:33 |
| stephenfin | hberaud: If you can fix up the reno here I can fast approve https://review.opendev.org/#/c/747395/ | 09:41 |
| hberaud | stephenfin: ack, omw | 09:41 |
| hberaud | stephenfin: oh wait... kgiusti asked to wait for awhile with this patch | 09:42 |
| stephenfin | Oh, okay, np. Could you -W? | 09:42 |
| hberaud | stephenfin: done | 09:43 |
| stephenfin | And on another note, are you core on pbr? If so, care to look at https://review.opendev.org/#/c/735433/ ? | 09:43 |
| hberaud | stephenfin: anyway I'll update the reno | 09:43 |
| stephenfin | okay, thanks :) | 09:43 |
| hberaud | stephenfin: yep I'm core on pbr | 09:43 |
| hberaud | done | 09:44 |
| stephenfin | \o/ | 09:45 |
| stephenfin | There's also https://review.opendev.org/744720 and https://review.opendev.org/735443. I think the rest aren't crucial then | 09:45 |
| hberaud | stephenfin: also, any ideas to avoid to do all these "noqa"? => https://review.opendev.org/#/c/742137/3/tools/simulator.py | 09:45 |
| hberaud | flake8 warn about import order but we need eventlet first if I correctly understand this script | 09:46 |
| stephenfin | oh, yeah, eew | 09:47 |
| stephenfin | I was trying to figure out what was the issue | 09:47 |
| * hberaud wondering why I don't seen the PBR patches on is dashboard... | 09:47 | |
| hberaud | s/is/my | 09:48 |
| hberaud | especially since previously flake8 did not complain about the order of imports | 09:53 |
| stephenfin | hberaud: Okay, so you can surround the import with a try-except and resolve the issue | 09:53 |
| stephenfin | here's a related bug to point to https://github.com/PyCQA/pycodestyle/issues/472 | 09:54 |
| stephenfin | Also, bumping hacking to >=3.2.0,<3.3.0 in test-requirements.txt will allow you to separate fixing these style issues from the rest of the pre-commit stuff | 09:54 |
| stephenfin | i.e. this could be two patches | 09:55 |
| stephenfin | *you can surround the eventlet import and monkey_patch | 09:55 |
| openstackgerrit | Merged openstack/oslo-cookiecutter master: Update the tox minversion parameter. https://review.opendev.org/743972 | 09:56 |
| hberaud | awesome thanks | 09:56 |
| hberaud | I'll submit a new PS | 09:56 |
| *** zzzeek has quit IRC | 09:57 | |
| *** zzzeek has joined #openstack-oslo | 10:01 | |
| hberaud | fg | 10:05 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: [WIP] Adding pre-commit https://review.opendev.org/742137 | 10:08 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Adding pre-commit https://review.opendev.org/742137 | 10:10 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Adding pre-commit https://review.opendev.org/742137 | 10:13 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Run rabbitmq heartbeat in python thread by default https://review.opendev.org/747395 | 10:22 |
| openstackgerrit | Merged openstack/oslo.cache master: Adding functional tests for memcache_pool backend https://review.opendev.org/718176 | 10:45 |
| openstackgerrit | Merged openstack/oslo.log stable/ussuri: zuul: port the legacy grenade job https://review.opendev.org/745179 | 11:12 |
| openstackgerrit | Merged openstack/pbr master: Use easy_install.ScriptWriter.get_header() https://review.opendev.org/735433 | 11:29 |
| *** dave-mccowan has joined #openstack-oslo | 13:40 | |
| *** bnemec has quit IRC | 14:11 | |
| *** bnemec has joined #openstack-oslo | 14:12 | |
| *** dave-mccowan has quit IRC | 14:50 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/oslo.policy master: Log warning for redundant file rules https://review.opendev.org/748324 | 15:04 |
| *** moguimar has quit IRC | 15:19 | |
| gmann | stephenfin: hberaud I incorporated the review comments. can you please review the pending patches in this series - https://review.opendev.org/#/q/topic:bp/policy-json-to-yaml+(status:open+OR+status:merged) | 15:21 |
| gmann | to make it in before freeze | 15:22 |
| stephenfin | gmann: looking | 15:26 |
| gmann | stephenfin: thanks, i feel warning s helpful instead of info to move the things to policy-in-code way | 15:27 |
| stephenfin | yeah, I +2d that. Wanted to raise the point but if you're happy, so am I | 15:27 |
| gmann | thanks | 15:28 |
| gmann | stephenfin: can you check this again - https://review.opendev.org/#/c/748055/ | 15:30 |
| stephenfin | yup, have it open at the moment | 15:31 |
| gmann | ok, thanks again | 15:32 |
| hberaud | gmann: omw | 15:32 |
| gmann | hberaud: thanks | 15:39 |
| stephenfin | gmann: have a question on handling of duplicate policies on that review. Don't know if such a thing is possible | 15:56 |
| gmann | stephenfin: checking | 16:01 |
| gmann | stephenfin: replied, i am not removing the duplicate rule in file so that it would not break deployment and let policy.py load the file in same way it used to for json file | 16:07 |
| *** bnemec has quit IRC | 16:22 | |
| *** dtantsur is now known as dtantsur|afk | 16:23 | |
| *** bnemec has joined #openstack-oslo | 16:30 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/oslo.policy master: Add oslopolicy-convert-json-to-yaml tool https://review.opendev.org/748055 | 16:33 |
| *** tosky has quit IRC | 16:45 | |
| gmann | stephenfin: ^^ updated | 16:49 |
| stephenfin | cool, +2 | 16:50 |
| stephenfin | and with that, run time | 16:50 |
| stephenfin | o/ | 16:50 |
| gmann | thanks, | 16:55 |
| openstackgerrit | Merged openstack/pbr master: Add Release Notes to documentation https://review.opendev.org/744720 | 16:56 |
| openstackgerrit | Jeremy Stanley proposed openstack/pbr master: Remove bdist_wininst support https://review.opendev.org/735443 | 17:02 |
| fungi | stephenfin: hberaud: ^ fixed a minor merge conflict with that one, if you don't mind re-reviewing | 17:02 |
| *** ralonsoh has quit IRC | 17:12 | |
| *** raildo_ has quit IRC | 17:55 | |
| *** raildo_ has joined #openstack-oslo | 17:56 | |
| gmann | hberaud: can you check this again, addressed stephenfin comments after your +2 - https://review.opendev.org/#/c/748055/ | 18:03 |
| *** tosky has joined #openstack-oslo | 18:35 | |
| openstackgerrit | Merged openstack/oslo.policy master: Add oslopolicy-convert-json-to-yaml tool https://review.opendev.org/748055 | 20:11 |
| openstackgerrit | Merged openstack/pbr master: Remove bdist_wininst support https://review.opendev.org/735443 | 21:25 |
| *** raildo_ has quit IRC | 21:28 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/oslo.policy master: Deprecate the JSON support for policy_file https://review.opendev.org/748236 | 21:42 |
| openstackgerrit | Ghanshyam Mann proposed openstack/oslo.policy master: Log warning for redundant file rules https://review.opendev.org/748324 | 21:42 |
| gmann | hberaud: rebased these two which need re-approve https://review.opendev.org/#/c/748236/5 https://review.opendev.org/#/c/748324/3 | 21:42 |
| gmann | stephenfin: one more review for you once you are online - https://review.opendev.org/#/c/748056/ | 21:44 |
| *** bnemec has quit IRC | 22:07 | |
| *** bnemec has joined #openstack-oslo | 22:12 | |
| *** rcernin has joined #openstack-oslo | 22:45 | |
| *** cognifloyd has joined #openstack-oslo | 23:13 | |
| *** lbragstad has quit IRC | 23:27 | |
| *** lbragstad has joined #openstack-oslo | 23:28 | |
| *** bnemec has quit IRC | 23:37 | |
| *** bnemec has joined #openstack-oslo | 23:43 | |
| *** tosky has quit IRC | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!