*** Dmitrii-Sh has quit IRC | 00:25 | |
*** hamalq has quit IRC | 00:27 | |
*** Dmitrii-Sh has joined #openstack-oslo | 00:29 | |
openstackgerrit | Jorhson Deng proposed openstack/oslo.cache master: Support SASL protocol for memcached https://review.opendev.org/742060 | 00:53 |
---|---|---|
*** hamalq has joined #openstack-oslo | 01:30 | |
*** hamalq_ has joined #openstack-oslo | 01:31 | |
*** hamalq has quit IRC | 01:36 | |
*** hamalq_ has quit IRC | 01:38 | |
*** hamalq has joined #openstack-oslo | 02:04 | |
*** hamalq has quit IRC | 02:10 | |
*** dave-mccowan has quit IRC | 02:51 | |
*** cognifloyd has joined #openstack-oslo | 03:30 | |
*** redrobot has quit IRC | 03:42 | |
*** camelCaser has quit IRC | 04:23 | |
*** camelCaser has joined #openstack-oslo | 04:26 | |
*** cognifloyd has quit IRC | 04:33 | |
*** cognifloyd has joined #openstack-oslo | 04:34 | |
*** hamalq has joined #openstack-oslo | 04:43 | |
*** hamalq_ has joined #openstack-oslo | 04:44 | |
*** hamalq has quit IRC | 04:48 | |
*** hamalq_ has quit IRC | 04:55 | |
openstackgerrit | yatin proposed openstack/oslo.policy master: Fix unit tests to work with stevedore > 2.0.1 https://review.opendev.org/741869 | 06:17 |
*** iurygregory has joined #openstack-oslo | 06:25 | |
openstackgerrit | yatin proposed openstack/oslo.policy master: Fix unit tests to work with stevedore > 2.0.1 https://review.opendev.org/741869 | 06:44 |
*** ralonsoh has joined #openstack-oslo | 07:29 | |
*** rcernin has quit IRC | 07:32 | |
*** tosky has joined #openstack-oslo | 07:39 | |
openstackgerrit | Jorhson Deng proposed openstack/oslo.cache master: Support SASL protocol for memcached https://review.opendev.org/742060 | 07:53 |
*** tosky has quit IRC | 08:04 | |
*** tosky_ has joined #openstack-oslo | 08:04 | |
*** moguimar has joined #openstack-oslo | 08:08 | |
*** tosky_ is now known as tosky | 08:19 | |
*** hberaud has quit IRC | 08:49 | |
*** dtantsur|afk is now known as dtantsur | 08:52 | |
*** hberaud has joined #openstack-oslo | 09:06 | |
*** rcernin has joined #openstack-oslo | 09:11 | |
moguimar | hberaud, what do you think about the centralized repo for hooks dtantsur proposed? | 09:26 |
moguimar | I fancy either that or the commit hash in the version | 09:26 |
moguimar | s/version/rev:/ | 09:27 |
moguimar | I'm used to do `pre-commit autoupdate` and it goes and fetch the latest version for each repo | 09:28 |
moguimar | we could use it in the future for diff and then find out the newer commit hash | 09:29 |
hberaud | moguimar: it could be an elegant, way, I started to think about that yesterday by designing a new oslo-spec, but I wondering which more values we add by using that. I mean apart this one [1] other used repos are some sort of trusted repos. Introduce a centralized repo is useful to define our specific hooks (design hooks), and here we only use already existing hooks, so I'm not fully convinced on this | 09:33 |
hberaud | point especially when our security issue can be fix only by using commit hash rather than version number [1] https://github.com/Lucas-C/pre-commit-hooks | 09:33 |
hberaud | I mean if we only use already existing hooks then I don't see value to redefine our own hooks repository. | 09:35 |
moguimar | yeah | 09:35 |
moguimar | me too | 09:35 |
moguimar | so you wanna drop Lucas-C or hash it? | 09:35 |
*** rcernin has quit IRC | 09:35 | |
moguimar | and hash only Lucas-C or all 3 of them? | 09:36 |
hberaud | moguimar: IMO it could be the more straightforward path to follow | 09:36 |
moguimar | one of those, and we taylor a comment in the pre-commit file to let people aware of the decisions | 09:37 |
hberaud | as you want, I'm not against drop Lucas's hooks, or pin it to a specific commit, I quick took a look to it's code and it doesn't seems dangerous | 09:38 |
openstackgerrit | Jorhson Deng proposed openstack/oslo.cache master: Support SASL protocol for memcached https://review.opendev.org/742060 | 09:38 |
moguimar | ok, I'll work on that and bring something next Monday | 09:39 |
moguimar | for discussion | 09:39 |
hberaud | I mean we use a lot of requirements, who themself use their own requirements which we don't take care of, so I don't think this point is an horrible think to do, and possibly we already have lot of security hole by using dependencies of our dependencies | 09:40 |
hberaud | moguimar: ++ | 09:40 |
hberaud | moguimar: thanks to work on that :) | 09:41 |
hberaud | s/to work/to your work/ | 09:42 |
openstackgerrit | Jorhson Deng proposed openstack/oslo.cache master: Support SASL protocol for memcached https://review.opendev.org/742388 | 10:29 |
*** cognifloyd has quit IRC | 10:29 | |
stephenfin | morning hberaud, smcginnis: Any chance you folks could help me get these two remaining backports in? https://review.opendev.org/#/q/topic:bug/1845322+status:open You looked at the stable/train backport for me a while back | 10:32 |
*** moguimar has quit IRC | 10:41 | |
hberaud | stephenfin: sure | 10:41 |
*** tkajinam has quit IRC | 10:59 | |
jkulik | hi, can someone tell me why https://review.opendev.org/#/c/740909/ isn't moving even though there's a workflow +1? | 11:02 |
hberaud | jkulik: hmm, looks like to gate issue | 11:10 |
hberaud | jkulik: is parent commit looks right | 11:11 |
hberaud | s/is/its/ | 11:11 |
*** kevko has joined #openstack-oslo | 11:23 | |
*** kevko_ has joined #openstack-oslo | 11:25 | |
*** kevko has quit IRC | 11:25 | |
*** raildo has joined #openstack-oslo | 11:29 | |
*** rcernin has joined #openstack-oslo | 11:49 | |
*** moguimar has joined #openstack-oslo | 12:02 | |
*** kgiusti has joined #openstack-oslo | 12:35 | |
*** rm_work has quit IRC | 12:38 | |
*** rm_work has joined #openstack-oslo | 12:42 | |
*** moguimar has quit IRC | 12:52 | |
*** moguimar has joined #openstack-oslo | 13:09 | |
*** bnemec has joined #openstack-oslo | 13:30 | |
*** rcernin has quit IRC | 13:32 | |
openstackgerrit | Merged openstack/oslo.vmware master: Add backend-independent access to cookiejar https://review.opendev.org/740909 | 13:42 |
jkulik | thank you :) | 13:44 |
moguimar | hberaud, bnemec, dhellmann do you guys know why bandit is pinned to <1.6.0? | 13:45 |
hberaud | jkulik: definitivelly it looks like to a gate issue :) | 13:45 |
moguimar | it throws a lot of AttributeError: module '_ast' has no attribute 'Num' in py38 | 13:45 |
dhellmann | moguimar : we generally pin linters so that we can update the version and fix the issues with new rules at the same time | 13:45 |
hberaud | moguimar: no ideas | 13:46 |
moguimar | I see, so I could bump the version if it doesn't break or if I also provide the fixes? | 13:46 |
moguimar | something like from: bandit>=1.1.0,<1.6.0 # Apache-2.0 to bandit>=1.6.0,<1.7.0 # Apache-2.0 | 13:48 |
bnemec | moguimar: Right, that's the idea. | 13:50 |
moguimar | ok, thanks | 13:51 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Bump bandit version https://review.opendev.org/742436 | 13:56 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Removes pre-commit hooks from Lucas-C https://review.opendev.org/742438 | 13:58 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Uses commit hash instead of version tags in pre-commit https://review.opendev.org/742439 | 13:58 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Apply fixes for pre-commit compliace in all code https://review.opendev.org/742440 | 13:58 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add pre-commit to pep8 gate https://review.opendev.org/742441 | 13:58 |
openstackgerrit | Merged openstack/oslo.messaging master: Move legacy grenade jobs to Zuul v3 https://review.opendev.org/741947 | 13:58 |
*** moguimar has quit IRC | 14:38 | |
*** moguimar has joined #openstack-oslo | 14:43 | |
*** Guest23136 has joined #openstack-oslo | 14:47 | |
*** Guest23136 is now known as redrobot | 14:49 | |
openstackgerrit | Michal Arbet proposed openstack/oslo.cache master: Do not hardcode flush_on_reconnect, move to oslo.cache config https://review.opendev.org/742193 | 15:12 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Bump bandit version https://review.opendev.org/742436 | 15:22 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Removes pre-commit hooks from Lucas-C https://review.opendev.org/742438 | 15:26 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Uses commit hash instead of version tags in pre-commit https://review.opendev.org/742439 | 15:26 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Apply fixes for pre-commit compliace in all code https://review.opendev.org/742440 | 15:26 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add pre-commit to pep8 gate https://review.opendev.org/742441 | 15:26 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Apply fixes for pre-commit compliace in all code https://review.opendev.org/742440 | 15:31 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add pre-commit to pep8 gate https://review.opendev.org/742441 | 15:31 |
openstackgerrit | Michal Arbet proposed openstack/oslo.cache master: Do not hardcode flush_on_reconnect, move to oslo.cache config https://review.opendev.org/742193 | 15:31 |
openstackgerrit | Merged openstack/oslo.policy master: Fix unit tests to work with stevedore > 2.0.1 https://review.opendev.org/741869 | 15:36 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Removes pre-commit hooks from Lucas-C https://review.opendev.org/742438 | 15:36 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Uses commit hash instead of version tags in pre-commit https://review.opendev.org/742439 | 15:36 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Apply fixes for pre-commit compliace in all code https://review.opendev.org/742440 | 15:36 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add pre-commit to pep8 gate https://review.opendev.org/742441 | 15:36 |
*** moguimar has quit IRC | 15:54 | |
*** moguimar has joined #openstack-oslo | 16:03 | |
*** hamalq has joined #openstack-oslo | 16:22 | |
*** hamalq_ has joined #openstack-oslo | 16:23 | |
dansmith | bnemec: hey, I'm sorry. | 16:24 |
bnemec | ? | 16:24 |
*** hamalq has quit IRC | 16:27 | |
dansmith | bnemec: I'm sorry you have to be my oslo.* receptacle for questions :D | 16:30 |
bnemec | Ah. :-) | 16:30 |
dansmith | so, the glance team says something about config reload not working under uwsgi, which surprises me.. do you know anything about what might be preventing that? | 16:31 |
dansmith | I would have expected the oslo config object to just check the date on the file and re-read, which shouldn't be a wsgi problem | 16:31 |
bnemec | It's triggered by a signal, so if uwsgi is handling the signal itself that could be a problem. | 16:32 |
hberaud | dansmith, bnemec: not related to something like this? => https://review.opendev.org/#/c/733506/ | 16:32 |
dansmith | bnemec: oh, I see, well that's easy | 16:33 |
dansmith | hberaud: could well be.. I'm not really sure what their goal is.. won't that reload config if uwsgi just naturally cycles workers, which might reload before they're ready? | 16:33 |
dansmith | signal-based is very specific | 16:33 |
hberaud | dansmith: here is an example of the faced issue => https://bugs.launchpad.net/nova/+bug/1882094 | 16:35 |
openstack | Launchpad bug 1882094 in OpenStack Compute (nova) "[queens][OSP13] An overcloud reboot will sometimes leave nova_api broken" [Undecided,In progress] - Assigned to Herve Beraud (herveberaud) | 16:35 |
*** dtantsur is now known as dtantsur|afk | 16:35 | |
dansmith | hberaud: ahh, I see, that's a different thing I thnk | 16:35 |
hberaud | unfortunatelly by fixing this one I unearth another related to db sync | 16:35 |
dansmith | but legit | 16:35 |
* hberaud must disappear for today | 16:37 | |
*** lbragstad_ has joined #openstack-oslo | 16:54 | |
*** lbragstad has quit IRC | 16:57 | |
openstackgerrit | Michal Arbet proposed openstack/oslo.cache master: Do not hardcode flush_on_reconnect, move to oslo.cache config https://review.opendev.org/742193 | 16:57 |
openstackgerrit | Stephen Finucane proposed openstack/oslo.context master: Integrate mypy https://review.opendev.org/742487 | 16:59 |
*** moguimar has quit IRC | 17:17 | |
*** lbragstad_ has quit IRC | 17:37 | |
*** lbragstad_ has joined #openstack-oslo | 17:38 | |
*** lbragstad__ has joined #openstack-oslo | 17:45 | |
*** lbragstad_ has quit IRC | 17:47 | |
*** ralonsoh has quit IRC | 18:45 | |
*** bnemec has quit IRC | 19:03 | |
*** adrianc_ has joined #openstack-oslo | 19:44 | |
*** adrianc has quit IRC | 19:47 | |
*** kevko_ has quit IRC | 19:55 | |
*** kevko_ has joined #openstack-oslo | 20:21 | |
*** hemna has quit IRC | 20:32 | |
*** hemna has joined #openstack-oslo | 20:39 | |
*** hamalq_ has quit IRC | 20:57 | |
*** hamalq has joined #openstack-oslo | 20:58 | |
*** bnemec has joined #openstack-oslo | 21:04 | |
*** kgiusti has left #openstack-oslo | 21:05 | |
*** bnemec has quit IRC | 21:11 | |
*** bnemec has joined #openstack-oslo | 21:18 | |
*** raildo has quit IRC | 21:28 | |
*** kevko_ has quit IRC | 22:09 | |
*** rcernin has joined #openstack-oslo | 22:52 | |
*** rcernin has quit IRC | 22:58 | |
*** rcernin has joined #openstack-oslo | 23:01 | |
*** tosky has quit IRC | 23:03 | |
*** rcernin has quit IRC | 23:04 | |
*** rcernin has joined #openstack-oslo | 23:05 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!