| *** Dmitrii-Sh has quit IRC | 00:02 | |
| *** Dmitrii-Sh has joined #openstack-oslo | 00:07 | |
| *** hamalq has quit IRC | 00:09 | |
| *** gouthamr_ has quit IRC | 00:59 | |
| *** gouthamr_ has joined #openstack-oslo | 01:05 | |
| *** gouthamr_ has quit IRC | 01:25 | |
| *** gouthamr_ has joined #openstack-oslo | 01:37 | |
| *** gouthamr_ has quit IRC | 02:52 | |
| *** gouthamr_ has joined #openstack-oslo | 02:56 | |
| *** rcernin has quit IRC | 03:00 | |
| *** rcernin has joined #openstack-oslo | 03:03 | |
| *** HenryG has quit IRC | 03:06 | |
| *** HenryG has joined #openstack-oslo | 03:07 | |
| *** gouthamr_ has quit IRC | 03:26 | |
| *** gouthamr_ has joined #openstack-oslo | 03:32 | |
| *** gouthamr_ has quit IRC | 04:00 | |
| *** gouthamr_ has joined #openstack-oslo | 04:11 | |
| *** gouthamr_ has quit IRC | 04:29 | |
| *** gouthamr_ has joined #openstack-oslo | 04:30 | |
| *** gouthamr_ has quit IRC | 04:35 | |
| *** gouthamr_ has joined #openstack-oslo | 04:40 | |
| *** Luzi has joined #openstack-oslo | 05:12 | |
| *** Luzi has quit IRC | 05:19 | |
| *** zzzeek has quit IRC | 05:19 | |
| *** Luzi has joined #openstack-oslo | 05:19 | |
| *** zzzeek has joined #openstack-oslo | 05:23 | |
| *** moguimar has joined #openstack-oslo | 06:05 | |
| moguimar | hberaud, around? | 06:07 |
|---|---|---|
| *** ralonsoh has joined #openstack-oslo | 06:10 | |
| *** moguimar has quit IRC | 06:38 | |
| *** moguimar has joined #openstack-oslo | 06:39 | |
| *** gouthamr_ has quit IRC | 06:50 | |
| *** gouthamr_ has joined #openstack-oslo | 06:52 | |
| *** knikolla has quit IRC | 06:54 | |
| *** knikolla has joined #openstack-oslo | 06:56 | |
| *** csatari has quit IRC | 06:58 | |
| *** csatari has joined #openstack-oslo | 07:01 | |
| *** gouthamr_ has quit IRC | 07:04 | |
| *** gouthamr_ has joined #openstack-oslo | 07:05 | |
| *** gouthamr_ has quit IRC | 07:15 | |
| *** gouthamr_ has joined #openstack-oslo | 07:22 | |
| *** geguileo has joined #openstack-oslo | 07:32 | |
| *** geguileo is now known as Guest75265 | 07:42 | |
| *** gouthamr_ has quit IRC | 07:46 | |
| *** gouthamr_ has joined #openstack-oslo | 07:52 | |
| *** gouthamr_ has quit IRC | 07:57 | |
| hberaud | moguimar: yep | 08:02 |
| *** gmann has quit IRC | 08:03 | |
| *** andrewbogott has quit IRC | 08:03 | |
| *** andrewbogott has joined #openstack-oslo | 08:04 | |
| *** gmann has joined #openstack-oslo | 08:06 | |
| *** gouthamr_ has joined #openstack-oslo | 08:09 | |
| *** iurygregory has quit IRC | 08:10 | |
| moguimar | hberaud, I'm looking at the pre-commit patch | 08:13 |
| moguimar | how do you plan to integrate it? | 08:13 |
| hberaud | moguimar: you speak about this patch https://review.opendev.org/#/c/720771/ ? | 08:14 |
| *** moguimar has quit IRC | 08:15 | |
| *** moguimar has joined #openstack-oslo | 08:16 | |
| hberaud | moguimar: I seen you was disconnected so I'm not sure you seen my previous message: "you speak about this patch https://review.opendev.org/#/c/720771/ ?" | 08:17 |
| moguimar | yep | 08:17 |
| moguimar | cause I downloaded it for review | 08:18 |
| moguimar | and pre-commit doesn't work out of the box | 08:18 |
| moguimar | you need to manually put the hook in place | 08:18 |
| moguimar | but I've seen people also putting pre-commit in tox | 08:19 |
| hberaud | moguimar: so my plan is to copy this patch (submit a similar) on all the oslo's repo if everyone is ok with this original patch | 08:19 |
| hberaud | moguimar: for now I just plan to use pre-commit with 'pre-commit install' | 08:20 |
| moguimar | so lets review one thing | 08:20 |
| hberaud | but I agree in few months it could be interesting to try to call pre-commit from tox to centralize things | 08:21 |
| moguimar | what is the purpose (benefit) you want to achieve? | 08:21 |
| hberaud | personnaly I often forget to check pep before submit my patches | 08:22 |
| moguimar | https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/tox.ini#L36-L44 | 08:22 |
| hberaud | and I think I'm not the only one | 08:22 |
| hberaud | so the benefits here is to avoid to run the CI against patches who have pep8 errors | 08:23 |
| hberaud | and also save time | 08:23 |
| hberaud | but this patch is a starting point | 08:24 |
| hberaud | thanks for the links | 08:24 |
| *** iurygregory has joined #openstack-oslo | 08:24 | |
| moguimar | there is also another comment in the mailing list I'm trying to fetch | 08:28 |
| moguimar | this one from dtantsur|afk | 08:29 |
| moguimar | "That's what pep8 jobs are for. They cannot be replaced with a pre-commit hooks, because people who are mostly likely to screw up formatting are also most likely to not have it installed." | 08:29 |
| moguimar | in the python black discussion | 08:30 |
| moguimar | while pre-commit as a hook tests only what is staged or modified we would like to maybe test the last commit only | 08:32 |
| moguimar | in the tox | 08:33 |
| hberaud | so what's about a tox run on uncommited changes? | 08:33 |
| hberaud | they will be ignored? | 08:34 |
| hberaud | (if only committed changes are under consideration) | 08:35 |
| hberaud | on a git hook point of view I don't think this is an issue | 08:36 |
| hberaud | but on a tox call which will call pre-commit under the hood I'm not sure this will detect issues, isn't? | 08:37 |
| hberaud | I mean when I run tox I expect to analyze everything committed or not, unstagged changes, etc.... | 08:38 |
| moguimar | yep, I see | 08:38 |
| moguimar | maybe we can compound last commit and changes? | 08:38 |
| moguimar | I'm checking pre-commit run args | 08:39 |
| moguimar | --hook-stage {commit,merge-commit,prepare-commit-msg,commit-msg,post-commit,manual,post-checkout,push} | 08:39 |
| moguimar | I'm not sure if it will accept this option multiple times | 08:39 |
| moguimar | cause we wanna catch changes locally or last commit on CI | 08:40 |
| hberaud | "maybe we can compound last commit and changes?" I know we can call pre-commit run --all-files (https://pre-commit.com/#4-optional-run-against-all-the-files) | 08:40 |
| hberaud | maybe this one is the one we need in tox | 08:40 |
| moguimar | hberaud, sounds good | 08:41 |
| moguimar | will -a also catch changes? | 08:41 |
| moguimar | let me test it | 08:41 |
| hberaud | ack | 08:41 |
| *** benj_ has quit IRC | 08:41 | |
| moguimar | it catches staged stuff as well | 08:43 |
| moguimar | so `pre-commit run -a` seems fine usage in tox | 08:43 |
| hberaud | moguimar: anyway I personnaly think we need to create a binding between pre-commit and tox to centralize things, by example find a way to call tox's jobs from pre-commit to ensure to use centralized test-requirements and the venv given by tox | 08:44 |
| hberaud | nice! | 08:44 |
| moguimar | from pre-commit you mean the hook or the tool? | 08:44 |
| hberaud | I mean it could worth to call tox jobs from pre-commit when the git hook is triggered | 08:45 |
| hberaud | instead of redeclare testing requirements in pre-commit config | 08:46 |
| moguimar | from past experiences in other projects, that takes a long time for a commit | 08:46 |
| hberaud | I agree | 08:46 |
| moguimar | and sometimes you just want to "commit --amend --no-edit" | 08:47 |
| moguimar | to fix a typo or some minor changes | 08:47 |
| hberaud | yep | 08:47 |
| moguimar | the hook is nice, but we don't have a way to enforce it | 08:47 |
| moguimar | but as a tox job, we can gate that | 08:47 |
| hberaud | right | 08:47 |
| moguimar | and have some impact on reviews reducing the concern about code formating and such | 08:48 |
| hberaud | that's it, this is the goal :) | 08:48 |
| moguimar | so let's add the tox part on that patch and bring it up for discussion next moday? | 08:49 |
| hberaud | yes good idea | 08:49 |
| hberaud | do you want to submit the tox part and co-author this patch? | 08:50 |
| moguimar | ok | 08:50 |
| moguimar | can do | 08:50 |
| hberaud | nice | 08:50 |
| hberaud | moguimar: thanks for these words | 08:52 |
| moguimar | hberaud, I'm just trying to learn more as well =D | 08:52 |
| hberaud | good approach :) | 08:53 |
| hberaud | moguimar: else, here is another topic that I want to discuss a bit with you => SSL + eventlet | 08:53 |
| moguimar | do you have a patch? | 08:53 |
| hberaud | I know you're the security guy and SSL is your topic :) | 08:54 |
| hberaud | yep | 08:54 |
| hberaud | sec | 08:54 |
| hberaud | moguimar: take a look to these changes (and to the 4 others related patches) => https://review.opendev.org/#/c/735900/ , by discussing with you now I just want to highlight this problem | 08:56 |
| moguimar | ok | 08:57 |
| hberaud | moguimar: here is another example of possible impacts => https://github.com/celery/py-amqp/pull/327 | 08:57 |
| hberaud | I opened this previous patch mostly to highlight the situation | 08:57 |
| *** benj_ has joined #openstack-oslo | 08:58 | |
| hberaud | moguimar: moving away from eventlet is unlikely to happen because it's everywhere and we use it to green our world (stdlib and third parties modules) and we can't find a plug&play similar solution so we are stuck with eventlet for a long time | 09:00 |
| moguimar | what do you mean with "to green our world"? | 09:02 |
| hberaud | but in other hand our python supported runtimes continue increase... and so one day deprecated stuff in the stdlib will be removed | 09:02 |
| hberaud | green the world = async | 09:02 |
| hberaud | green thread = async thread | 09:02 |
| moguimar | so basically we use eventlet for non-blocking sockets, right? | 09:03 |
| hberaud | among others | 09:03 |
| moguimar | I see | 09:04 |
| hberaud | so the shortest path to fix the SSL issue is to fix eventlet ssl side | 09:04 |
| * moguimar remembers when we used to work with credit card machines with 200mhz processors and 2mb disk | 09:04 | |
| hberaud | lol | 09:05 |
| moguimar | you can't have thread issues if you can't have threads at all | 09:05 |
| hberaud | hahahaha | 09:05 |
| moguimar | ok, I'll take a look at the patches and the PR on github | 09:06 |
| hberaud | ack thanks, here a mostly want to make you aware about this possible issue with SSL in monkey patched env with eventlet. | 09:07 |
| hberaud | s/here a/here I/ | 09:07 |
| hberaud | that's all for me | 09:08 |
| moguimar | ok | 09:09 |
| moguimar | thanks herve | 09:09 |
| hberaud | thanks :) | 09:10 |
| *** tosky has joined #openstack-oslo | 09:10 | |
| openstackgerrit | Elod Illes proposed openstack/oslo.messaging stable/queens: Simplify tools/test-setup.sh https://review.opendev.org/739922 | 09:22 |
| *** rcernin has quit IRC | 09:23 | |
| *** dtantsur|afk is now known as dtantsur | 09:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.db master: requirements: Drop os-testr https://review.opendev.org/740236 | 10:38 |
| *** tkajinam has quit IRC | 11:02 | |
| *** dave-mccowan has joined #openstack-oslo | 11:18 | |
| openstackgerrit | Johannes Kulik proposed openstack/oslo.vmware master: Add moref helper functions https://review.opendev.org/739447 | 11:23 |
| *** jungleboyj_ is now known as jungleboyj | 11:46 | |
| *** raildo has joined #openstack-oslo | 12:23 | |
| *** raildo has quit IRC | 12:47 | |
| *** raildo has joined #openstack-oslo | 12:50 | |
| *** kgiusti has joined #openstack-oslo | 13:37 | |
| moguimar | hberaud, any special reason to create a local repo for flake8 in the pre-commit config? | 14:29 |
| *** lbragstad_ has joined #openstack-oslo | 14:29 | |
| *** lbragstad has quit IRC | 14:29 | |
| moguimar | other than using the one provided by flake8 | 14:29 |
| hberaud | IIRC it was related to nova's repo where I took the example => https://github.com/openstack/nova/blob/master/.pre-commit-config.yaml#L26 | 14:34 |
| hberaud | moguimar: ^^^^ | 14:34 |
| moguimar | ah I see | 14:35 |
| moguimar | they have their own now, it was a hook in https://github.com/pre-commit/pre-commit-hooks but now they recomend https://gitlab.com/pycqa/flake8 | 14:35 |
| moguimar | and we can still set additional_dependencies: [hacking>=3.0.1,<3.1.0] | 14:36 |
| moguimar | and ignore the rest of the config, as flake8 will still fetch config from tox.ini | 14:36 |
| hberaud | ah nice | 14:37 |
| *** Luzi has quit IRC | 14:56 | |
| moguimar | hberaud, I think I've found something interesting for the tox job | 14:57 |
| moguimar | pre-commit run --from-ref HEAD~ --to-ref HEAD | 14:57 |
| moguimar | I'm just not sure yet wether to use HEAD~ or HEAD^ | 14:57 |
| hberaud | they are not similar as with git? | 14:58 |
| moguimar | this way the tox job will blame only files in the change | 14:58 |
| moguimar | they are | 14:58 |
| moguimar | I have a call now | 14:58 |
| hberaud | ack | 14:58 |
| moguimar | will continue on this tomorrow | 14:58 |
| moguimar | o/ | 14:58 |
| hberaud | thanks | 14:58 |
| hberaud | good job | 14:58 |
| *** hamalq has joined #openstack-oslo | 16:18 | |
| *** hamalq_ has joined #openstack-oslo | 16:19 | |
| *** hamalq has quit IRC | 16:22 | |
| *** andreaf has quit IRC | 16:48 | |
| *** dasp_ has joined #openstack-oslo | 16:49 | |
| openstackgerrit | Stephen Finucane proposed openstack/pbr master: trivial: Improve logging of run commands https://review.opendev.org/740337 | 16:54 |
| *** coreycb has quit IRC | 16:55 | |
| *** rm_work has quit IRC | 16:55 | |
| *** dasp has quit IRC | 16:55 | |
| *** hberaud has quit IRC | 16:55 | |
| *** coreycb has joined #openstack-oslo | 16:58 | |
| *** rm_work has joined #openstack-oslo | 16:58 | |
| *** hberaud has joined #openstack-oslo | 16:58 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.policy master: Don't deepcopy objects before mask_dict_password https://review.opendev.org/740068 | 17:03 |
| *** lbragstad_ is now known as lbragstad | 17:21 | |
| *** dtantsur is now known as dtantsur|afk | 17:45 | |
| *** ralonsoh has quit IRC | 17:57 | |
| *** tosky has quit IRC | 19:26 | |
| *** moguimar has quit IRC | 19:50 | |
| *** kgiusti has left #openstack-oslo | 20:25 | |
| *** raildo has quit IRC | 21:22 | |
| *** tkajinam has joined #openstack-oslo | 23:00 | |
| *** dmellado has quit IRC | 23:39 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!