| *** threestrands has joined #openstack-oslo | 02:33 | |
| *** adrianc has quit IRC | 06:59 | |
| *** adrianc has joined #openstack-oslo | 07:12 | |
| *** tosky has joined #openstack-oslo | 07:24 | |
| *** rpittau|afk is now known as rpittau | 07:39 | |
| *** ralonsoh has joined #openstack-oslo | 07:44 | |
| *** threestrands has quit IRC | 08:33 | |
| *** tkajinam has quit IRC | 09:03 | |
| *** rcernin has quit IRC | 10:03 | |
| *** hberaud has quit IRC | 10:05 | |
| *** hberaud has joined #openstack-oslo | 10:08 | |
| *** rpittau is now known as rpittau|bbl | 10:21 | |
| openstackgerrit | Merged openstack/oslo.config stable/train: Use global upper constraints for docs targets https://review.opendev.org/722106 | 10:31 |
|---|---|---|
| openstackgerrit | Merged openstack/oslo.utils stable/train: tox: Use upper-constraints for docs jobs https://review.opendev.org/722093 | 10:34 |
| *** raildo has joined #openstack-oslo | 11:37 | |
| openstackgerrit | Elod Illes proposed openstack/oslo.utils stable/stein: tox: Use upper-constraints for docs jobs https://review.opendev.org/722281 | 11:55 |
| *** rpittau|bbl is now known as rpittau | 12:02 | |
| *** kgiusti has joined #openstack-oslo | 12:40 | |
| *** kgiusti has left #openstack-oslo | 12:57 | |
| *** kgiusti has joined #openstack-oslo | 13:00 | |
| *** moguimar has joined #openstack-oslo | 13:27 | |
| *** tkajinam has joined #openstack-oslo | 13:44 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.versionedobjects master: trivial: Mock warnings https://review.opendev.org/722330 | 14:25 |
| openstackgerrit | Merged openstack/oslo.concurrency master: Add release notes links to doc index https://review.opendev.org/720486 | 14:36 |
| *** tkajinam has quit IRC | 14:37 | |
| openstackgerrit | Merged openstack/oslo.messaging master: Add release notes links to doc index https://review.opendev.org/720478 | 14:38 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.versionedobjects master: Handle overriding of 'obj_class_from_primitive' https://review.opendev.org/718345 | 16:25 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.versionedobjects master: Handle overriding of 'obj_class_from_primitive' https://review.opendev.org/718345 | 16:27 |
| stephenfin | dansmith: You should probably take a look at this when you have a chance https://review.opendev.org/#/c/718345/ | 16:28 |
| *** hberaud has quit IRC | 16:36 | |
| *** hberaud has joined #openstack-oslo | 16:37 | |
| dansmith | stephenfin: I'm not sure I get this.. wouldn't your assertion imply that we can never send nested objects across RPC (which we definitely can do) | 16:46 |
| dansmith | ? | 16:46 |
| *** rpittau is now known as rpittau|afk | 16:49 | |
| stephenfin | no, I'm saying you can't override 'obj_from_primitive' on a child object | 16:57 |
| stephenfin | the parent 'obj_from_primitive' method is always called | 16:58 |
| stephenfin | The linked bug explains it more succinctly. I probably should have just used my explanation from that, but it took me a while to figure out how (de)serialization worked and I wanted to record it somewhere | 16:59 |
| openstackgerrit | Merged openstack/oslo.utils stable/stein: tox: Use upper-constraints for docs jobs https://review.opendev.org/722281 | 17:26 |
| *** kgiusti has quit IRC | 17:32 | |
| *** kgiusti has joined #openstack-oslo | 17:42 | |
| dansmith | stephenfin: I read the bug.. you're saying not that nested objects aren't deserialized, only that the nested deserialization routine, if overridden, isn't called? | 18:00 |
| dansmith | deserialization has always, AFAIK, been the job of the base class, with no reason to ever override it in a subclass | 18:00 |
| dansmith | so the tests that check it from the parent of two test classes isn't actually how it's done when deserialized by something like the RPC layer | 18:01 |
| dansmith | i.e. here: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L898 | 18:03 |
| *** stephenfin has quit IRC | 18:03 | |
| *** stephenfin has joined #openstack-oslo | 18:04 | |
| *** ralonsoh has quit IRC | 18:07 | |
| *** stephenfin has quit IRC | 18:19 | |
| *** stephenfin has joined #openstack-oslo | 18:19 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo-specs master: Remove devstack plugin branch creation https://review.opendev.org/722488 | 20:19 |
| *** raildo has quit IRC | 21:04 | |
| *** kgiusti has left #openstack-oslo | 21:05 | |
| *** moguimar has quit IRC | 21:35 | |
| *** moguimar has joined #openstack-oslo | 21:36 | |
| *** rcernin has joined #openstack-oslo | 22:10 | |
| *** rcernin has quit IRC | 22:15 | |
| *** rcernin has joined #openstack-oslo | 22:15 | |
| *** ansmith has quit IRC | 22:17 | |
| *** tosky has quit IRC | 22:58 | |
| *** tkajinam has joined #openstack-oslo | 22:58 | |
| *** rcernin has quit IRC | 23:09 | |
| *** rcernin has joined #openstack-oslo | 23:16 | |
| *** moguimar has quit IRC | 23:48 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!