| *** tosky has quit IRC | 00:54 | |
| *** dave-mccowan has quit IRC | 00:58 | |
| *** rcernin has quit IRC | 02:03 | |
| *** rcernin has joined #openstack-oslo | 02:03 | |
| *** SpamapS has quit IRC | 03:31 | |
| *** SpamapS has joined #openstack-oslo | 03:31 | |
| *** rcernin is now known as rcernin|brb | 05:30 | |
| *** rpittau|afk is now known as rpittau | 07:57 | |
| *** ralonsoh has joined #openstack-oslo | 08:46 | |
| *** tosky has joined #openstack-oslo | 08:51 | |
| *** raildo has joined #openstack-oslo | 11:33 | |
| *** rpittau is now known as rpittau|bbl | 11:37 | |
| *** kgiusti has joined #openstack-oslo | 12:39 | |
| smcginnis | Anyone seen this? http://paste.openstack.org/show/790937/ | 12:45 |
|---|---|---|
| smcginnis | "oslo_config.cfg.ArgsAlreadyParsedError: arguments already parsed: cannot register CLI option" | 12:45 |
| smcginnis | Sounds familiar. Someone just pointed it out in the Cinder channel. | 12:45 |
| *** kgiusti has left #openstack-oslo | 13:20 | |
| *** kgiusti has joined #openstack-oslo | 13:23 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo-cookiecutter master: trivial: refresh template with recent best practices https://review.opendev.org/707180 | 13:32 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo-cookiecutter master: trivial: refresh template with recent best practices https://review.opendev.org/707180 | 13:33 |
| -openstackstatus- NOTICE: Gerrit (review.opendev.org) will be down for maintenance starting at 14:00 (in less than 20 mins), probably until 15:00 UTC | 13:43 | |
| *** rpittau|bbl is now known as rpittau | 13:52 | |
| -openstackstatus- NOTICE: The Gerrit service on review.opendev.org is offline for maintenance until 15:00 UTC http://lists.opendev.org/pipermail/service-announce/2020-March/000001.html | 14:07 | |
| *** ChanServ changes topic to "The Gerrit service on review.opendev.org is offline for maintenance until 15:00 UTC http://lists.opendev.org/pipermail/service-announce/2020-March/000001.html" | 14:07 | |
| *** ChanServ changes topic to "OpenStack Common Libraries | https://wiki.openstack.org/wiki/Oslo" | 15:04 | |
| -openstackstatus- NOTICE: Gerrit maintenance is concluded at this time and requested renames have been performed | 15:04 | |
| hberaud | smcginnis: hum... I think ti's something already known... | 15:17 |
| hberaud | smcginnis: I don't remenber the associated bug but I think bnemec could help us to retrieve this one | 15:18 |
| smcginnis | Doesn't look like a change in cinder triggered this. But there also hasn't been an update to oslo.config for a few weeks, so some other dependency. | 15:20 |
| bnemec | Oh, this may be more fallout from that policy fix. :-/ | 15:22 |
| bnemec | Although I'm not sure why that would be happening on a doc build. That shouldn't have called the changed code in oslo.policy. | 15:24 |
| smcginnis | It could still do it by the autodoc functionality trying to load up the source code. | 15:28 |
| smcginnis | bnemec: Do you remember which version of oslo.policy didn't have this issue? I can try to force installing that version in my local venv and see if that does it. | 15:30 |
| *** toabctl has quit IRC | 15:31 | |
| bnemec | smcginnis: I believe 3.0.0 is where we started doing parsing on the global config object. | 15:32 |
| smcginnis | bnemec: Yep, that's it. I forced install of oslo.policy 2.4.1 in the docs venv and after that the job run successfully. | 15:36 |
| smcginnis | bnemec: Now the tricky part... do you know what the solution was to get around that. :) | 15:37 |
| bnemec | One of the generator entrypoints must be getting called. | 15:38 |
| bnemec | I wonder if it's something about the way the policy sample gets generated in the docs. | 15:39 |
| smcginnis | It's kinda odd. It happens loading a CLI cmd that only registers three of its own config opts: | 15:40 |
| smcginnis | https://opendev.org/openstack/cinder/src/branch/master/cinder/cmd/volume_usage_audit.py#L57 | 15:40 |
| bnemec | Yeah, but you can't register cli commands after args have been parsed once. | 15:41 |
| bnemec | Ah, it's because of this: https://github.com/openstack/oslo.policy/blob/master/oslo_policy/sphinxpolicygen.py#L80 | 15:45 |
| bnemec | I didn't realize we had other code calling the cli entrypoint. We probably shouldn't. :-/ | 15:46 |
| smcginnis | Yeah, I don't know how we should handle that on the cinder side. Maybe exclude our cmd code from autodocs? | 15:50 |
| bnemec | Maybe, but I'm wondering if we should just fix this on the oslo.policy side. | 15:53 |
| bnemec | It's conceivable that this broke other projects too. | 15:53 |
| bnemec | I feel like we shouldn't be running our cli parsing code when we aren't actually the cli entrypoint. | 15:53 |
| smcginnis | Yeah, that makes the most sense to me. | 15:54 |
| bnemec | Oh, in fact there's already functionality in place to make this work sanely. Should be a simple fix, give me a couple of minutes. | 15:54 |
| bnemec | smcginnis: Is there a bug open for this? | 16:04 |
| smcginnis | bnemec: No, I hasn't gotten that far. Someone just pointed it out in the channel this morning. | 16:04 |
| smcginnis | I'm not really here today. :) | 16:05 |
| bnemec | Ah. :-) | 16:05 |
| bnemec | Was just wondering if there was something I should reference in the commit message. | 16:05 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.policy master: Don't parse cli args on the global object in sphinxpolicygen https://review.opendev.org/714161 | 16:09 |
| bnemec | smcginnis: hberaud: ^Should fix the cinder docs build. | 16:10 |
| smcginnis | bnemec: Thanks, tested locally with that change and confirmed that does fix the issue. | 16:13 |
| hberaud | bnemec: omw to review | 16:13 |
| smcginnis | Thanks for the quick fix! | 16:13 |
| bnemec | smcginnis: Cool, thanks. I was just doing the same. :-) | 16:13 |
| hberaud | bnemec: thanks | 16:13 |
| bnemec | We'll probably want to blacklist 3.0.1 too then. | 16:14 |
| bnemec | Fixing this silly little cli bug has turned into quite the process. :-/ | 16:14 |
| smcginnis | Yeah, get the new fix out, blacklist the old rev. | 16:14 |
| smcginnis | Funny how the little things sometimes end up being like that. | 16:15 |
| hberaud | bnemec, smcginnis: just a side note to inform you, I'm a little bit busied by COVID19 stuffs currently so I don't think I'll be at 100% for the next few days/weeks due to the context... | 16:15 |
| hberaud | I mean 100% active | 16:16 |
| smcginnis | Yeah, understood. Stay safe hberaud. | 16:16 |
| bnemec | ^Yep, that. | 16:16 |
| smcginnis | A little crazy here too. Moved both my daugher and niece here from their dorm rooms this week. | 16:17 |
| smcginnis | Full house now. | 16:17 |
| bnemec | Fortunately my daily routine is pretty much social isolation anyway so not much has changed for me. ;-) | 16:17 |
| hberaud | I've 5 parents infected and 1 at the hospital in bad mode... | 16:17 |
| smcginnis | Work-wise, same for me. | 16:18 |
| smcginnis | hberaud: Oh now, sorry to hear that. I hope they are OK. | 16:18 |
| bnemec | hberaud: Ugh, sorry to hear that. :-( | 16:18 |
| smcginnis | *Oh no | 16:18 |
| hberaud | np thanks guys | 16:18 |
| *** iurygregory is now known as iurygregory}brb | 16:19 | |
| *** iurygregory}brb is now known as iurygregory|brb | 16:19 | |
| hberaud | take care of your families too and stay really vigilant | 16:19 |
| bnemec | +1 | 16:23 |
| *** openstack has joined #openstack-oslo | 16:58 | |
| *** ChanServ sets mode: +o openstack | 16:58 | |
| *** iurygregory|brb is now known as iurygregory | 17:14 | |
| *** toabctl has joined #openstack-oslo | 17:19 | |
| openstackgerrit | Merged openstack/oslo.policy master: Don't parse cli args on the global object in sphinxpolicygen https://review.opendev.org/714161 | 19:10 |
| smcginnis | bnemec: Still around? Should we get a release out for ^ | 19:13 |
| bnemec | smcginnis: Yep | 19:14 |
| bnemec | I'll propose it so you can +2. | 19:15 |
| bnemec | Done: https://review.opendev.org/714195 | 19:16 |
| *** ralonsoh has quit IRC | 19:17 | |
| smcginnis | bnemec: And done. | 19:36 |
| bnemec | Thanks! | 20:01 |
| *** kgiusti has left #openstack-oslo | 20:03 | |
| openstackgerrit | Andreas Jaeger proposed openstack/cookiecutter master: Update infra-manual location https://review.opendev.org/714226 | 20:54 |
| openstackgerrit | Andreas Jaeger proposed openstack/cookiecutter master: Update infra-manual location https://review.opendev.org/714226 | 20:58 |
| *** raildo_ has joined #openstack-oslo | 21:07 | |
| *** raildo has quit IRC | 21:10 | |
| *** raildo_ has quit IRC | 21:50 | |
| *** mmethot_ has joined #openstack-oslo | 22:33 | |
| *** mmethot has quit IRC | 22:35 | |
| *** mmethot has joined #openstack-oslo | 22:47 | |
| *** mmethot_ has quit IRC | 22:49 | |
| *** irclogbot_3 has quit IRC | 23:27 | |
| *** irclogbot_0 has joined #openstack-oslo | 23:28 | |
| *** hberaud has quit IRC | 23:37 | |
| *** hberaud has joined #openstack-oslo | 23:37 | |
| *** tosky has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!