*** d34dh0r53 has quit IRC | 00:16 | |
*** d34dh0r53 has joined #openstack-oslo | 00:25 | |
*** d34dh0r53 has quit IRC | 00:25 | |
*** d34dh0r53 has joined #openstack-oslo | 00:28 | |
*** d34dh0r53 has quit IRC | 00:30 | |
*** d34dh0r53 has joined #openstack-oslo | 00:35 | |
*** d34dh0r53 has quit IRC | 00:36 | |
*** d34dh0r53 has joined #openstack-oslo | 00:39 | |
*** d34dh0r53 has quit IRC | 00:39 | |
*** d34dh0r53 has joined #openstack-oslo | 00:43 | |
*** d34dh0r53 has quit IRC | 00:44 | |
*** hoonetorg has quit IRC | 00:45 | |
*** d34dh0r53 has joined #openstack-oslo | 00:52 | |
*** d34dh0r53 has quit IRC | 00:53 | |
*** hoonetorg has joined #openstack-oslo | 00:57 | |
*** d34dh0r53 has joined #openstack-oslo | 00:59 | |
*** d34dh0r53 has quit IRC | 00:59 | |
*** d34dh0r53 has joined #openstack-oslo | 01:01 | |
*** d34dh0r53 has quit IRC | 01:04 | |
*** d34dh0r53 has joined #openstack-oslo | 01:14 | |
*** d34dh0r53 has quit IRC | 01:14 | |
*** d34dh0r53 has joined #openstack-oslo | 01:28 | |
*** d34dh0r53 has quit IRC | 01:28 | |
*** d34dh0r53 has joined #openstack-oslo | 01:33 | |
*** d34dh0r53 has quit IRC | 01:34 | |
*** d34dh0r53 has joined #openstack-oslo | 01:37 | |
*** d34dh0r53 has quit IRC | 01:38 | |
*** d34dh0r53 has joined #openstack-oslo | 01:41 | |
*** d34dh0r53 has quit IRC | 01:42 | |
*** d34dh0r53 has joined #openstack-oslo | 01:52 | |
*** d34dh0r53 has quit IRC | 01:52 | |
*** d34dh0r53 has joined #openstack-oslo | 01:56 | |
*** d34dh0r53 has quit IRC | 01:57 | |
*** d34dh0r53 has joined #openstack-oslo | 02:02 | |
*** d34dh0r53 has quit IRC | 02:03 | |
*** d34dh0r53 has joined #openstack-oslo | 02:05 | |
*** d34dh0r53 has quit IRC | 02:05 | |
*** d34dh0r53 has joined #openstack-oslo | 02:09 | |
*** d34dh0r53 has quit IRC | 02:10 | |
*** d34dh0r53 has joined #openstack-oslo | 02:19 | |
*** d34dh0r53 has quit IRC | 02:19 | |
*** d34dh0r53 has joined #openstack-oslo | 02:21 | |
*** d34dh0r53 has quit IRC | 02:22 | |
*** d34dh0r53 has joined #openstack-oslo | 02:38 | |
*** d34dh0r53 has quit IRC | 02:39 | |
*** mmethot has quit IRC | 02:43 | |
*** d34dh0r53 has joined #openstack-oslo | 02:45 | |
*** d34dh0r53 has quit IRC | 02:45 | |
*** d34dh0r53 has joined #openstack-oslo | 02:47 | |
*** d34dh0r53 has quit IRC | 02:47 | |
*** d34dh0r53 has joined #openstack-oslo | 02:54 | |
*** d34dh0r53 has quit IRC | 02:55 | |
*** d34dh0r53 has joined #openstack-oslo | 03:09 | |
*** d34dh0r53 has quit IRC | 03:09 | |
*** d34dh0r53 has joined #openstack-oslo | 03:19 | |
*** d34dh0r53 has quit IRC | 03:19 | |
*** d34dh0r53 has joined #openstack-oslo | 03:28 | |
*** d34dh0r53 has quit IRC | 03:28 | |
*** mmethot has joined #openstack-oslo | 03:34 | |
*** d34dh0r53 has joined #openstack-oslo | 03:41 | |
*** d34dh0r53 has quit IRC | 03:41 | |
*** d34dh0r53 has joined #openstack-oslo | 03:48 | |
*** d34dh0r53 has quit IRC | 04:40 | |
*** d34dh0r53 has joined #openstack-oslo | 04:45 | |
*** d34dh0r53 has quit IRC | 04:45 | |
*** d34dh0r53 has joined #openstack-oslo | 04:53 | |
*** d34dh0r53 has joined #openstack-oslo | 04:54 | |
*** d34dh0r53 has quit IRC | 04:56 | |
*** dave-mccowan has quit IRC | 05:36 | |
*** pcaruana has joined #openstack-oslo | 07:38 | |
*** tosky has joined #openstack-oslo | 08:05 | |
*** tesseract has joined #openstack-oslo | 08:06 | |
*** starborn has joined #openstack-oslo | 08:13 | |
*** lbragstad has quit IRC | 08:28 | |
*** hberaud|gone is now known as hberaud | 08:29 | |
*** tosky_ has joined #openstack-oslo | 08:33 | |
*** tosky has quit IRC | 08:34 | |
*** tosky_ is now known as tosky | 08:39 | |
*** lbragstad has joined #openstack-oslo | 08:40 | |
*** iurygregory has quit IRC | 08:42 | |
*** ralonsoh has joined #openstack-oslo | 08:52 | |
*** iurygregory has joined #openstack-oslo | 09:08 | |
*** geguileo has joined #openstack-oslo | 10:28 | |
*** hberaud is now known as hberaud|lunch | 12:25 | |
*** hberaud|lunch is now known as hberaud | 13:04 | |
*** goldyfruit_ has quit IRC | 13:08 | |
*** kgiusti has joined #openstack-oslo | 14:24 | |
*** ansmith has joined #openstack-oslo | 14:57 | |
*** rcernin has quit IRC | 15:01 | |
*** dave-mccowan has joined #openstack-oslo | 15:06 | |
*** smcginnis has joined #openstack-oslo | 15:06 | |
smcginnis | bnemec or others: Any idea why the new oslo.config release would cause a problem from this: | 15:07 |
---|---|---|
smcginnis | https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/v2/test_registry_client.py#L48 | 15:07 |
smcginnis | Failure in here near the bottom - https://de0765cc74f1c1de732f-60e7154167fad33e01f6d4d5448fd7d1.ssl.cf5.rackcdn.com/701104/4/check/cross-glance-py36/e1b4c8e/job-output.txt | 15:08 |
smcginnis | Looks like it's causing stestr to blow up. | 15:16 |
bnemec | Yeah, that was a change in behavior. I actually wonder if this should have been a major release. | 15:17 |
bnemec | I'm guessing it has to do with https://github.com/openstack/oslo.config/commit/543daf4f7ae0c1be6cb66345218beca20669cfc9 | 15:17 |
smcginnis | To be fair, it was a major version bump. | 15:18 |
smcginnis | Just not clear what changed to cause this. | 15:18 |
bnemec | Oh, ha :-) | 15:18 |
smcginnis | ;) | 15:18 |
bnemec | stephenfin: hberaud: See discussion above about oslo.config. | 15:19 |
smcginnis | I've pinged Trienish. Seems to impact glance, but not others. | 15:20 |
hberaud | bnemec: ack | 15:20 |
smcginnis | So maybe I just need to see how glance is calling stestr that causes it to hit this that others are doing differently. | 15:20 |
bnemec | I would guess it's because of the parse_args in the glance unit tests. | 15:20 |
smcginnis | Using codesearch, it looks like others are doing the same as that line I referenced. | 15:21 |
smcginnis | Any idea how that needs to change to pass now? | 15:21 |
bnemec | Based on the release note, I suspect it would require changes in the consuming projects. | 15:22 |
stephenfin | That doesn't look like the output of stestr | 15:22 |
stephenfin | usage: run [-h] [--chunksize CHUNKSIZE] [--config-dir DIR] | 15:23 |
stephenfin | [--config-file PATH] [--debug] [--dontreplicate DONTREPLICATE] | 15:23 |
stephenfin | ... | 15:23 |
stephenfin | https://github.com/mtreinish/stestr/blob/master/stestr/commands/run.py#L66-L170 | 15:23 |
bnemec | I'm guessing stestr uses oslo.config so it's conflicting with the glance call to parse_args. | 15:23 |
smcginnis | Yeah, that's "stestr run" | 15:23 |
smcginnis | Oh, not that one. SOrry. | 15:24 |
bnemec | stestr registered a positional arg, and glance is parsing with no arguments which is no longer allowed. | 15:24 |
stephenfin | usage: stestr run [-h] [--failing] [--serial] [--concurrency CONCURRENCY] | 15:24 |
stephenfin | [--load-list LOAD_LIST] [--partial] [--subunit] | 15:24 |
smcginnis | I tried adding "positional=True, required=False" to https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/v2/test_registry_client.py#L48, but same error. | 15:25 |
hberaud | smcginnis: can you try to put "positional=True, required=False" to options available here => https://github.com/openstack/glance/blob/master/glance/common/config.py | 15:39 |
smcginnis | hberaud: Is that in each positional config opt? | 15:40 |
hberaud | Yes I think. not 100% sure but I don't think we need to put them to https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/v2/test_registry_client.py#L48 | 15:41 |
bnemec | I don't see any positional opts in that file. | 15:41 |
hberaud | bnemec: you are right | 15:42 |
bnemec | My fear is that the problem here is that both oslo.config and stestr are registering things with argparse and it's getting confused. | 15:44 |
bnemec | Before we got away with it because everything was optional. | 15:44 |
smcginnis | The stestr thing may have been wrong. It doesn't use oslo.config, so I think that was just a side effect of the test discovery failing. | 15:44 |
* smcginnis follows on -dev | 15:45 | |
bnemec | Yeah, but I'm guessing cliff uses argparse under the covers. | 15:45 |
hberaud | bnemec: ok you may have right, but I don't seen oslo usage in stestr or maybe I misunderstood something | 15:46 |
hberaud | bnemec: a right | 15:46 |
hberaud | s/a/ah/ | 15:47 |
*** hoonetorg has quit IRC | 16:07 | |
*** starborn has quit IRC | 16:17 | |
*** hoonetorg has joined #openstack-oslo | 16:20 | |
*** openstackgerrit has quit IRC | 16:30 | |
*** iurygregory has quit IRC | 17:13 | |
stephenfin | bnemec, smcginnis: https://review.opendev.org/701580 | 17:49 |
stephenfin | Not a resolution but does point to something odd alright | 17:49 |
stephenfin | and I'm off for the next few days, so it'll be next week before I can look into it more :( | 17:50 |
smcginnis | Thanks stephenfin | 17:50 |
*** tosky has quit IRC | 17:54 | |
*** tesseract has quit IRC | 18:15 | |
*** pcaruana has quit IRC | 18:27 | |
*** openstackgerrit has joined #openstack-oslo | 18:33 | |
openstackgerrit | Hervé Beraud proposed openstack/oslo.log master: tox: Trivial cleanup https://review.opendev.org/700138 | 18:33 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.log master: tox: Trivial cleanup https://review.opendev.org/700138 | 18:34 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.i18n master: tox: Trivial cleanup https://review.opendev.org/700137 | 18:38 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: tox: Trivial cleanup https://review.opendev.org/700132 | 18:47 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.utils master: tox: Trivial cleanup https://review.opendev.org/700149 | 18:51 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.privsep master: tox: Trivial cleanup https://review.opendev.org/700141 | 18:55 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: tox: Trivial cleanup https://review.opendev.org/700128 | 18:59 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.config master: tox: Trivial cleanup https://review.opendev.org/700130 | 19:01 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.middleware master: tox: Trivial cleanup https://review.opendev.org/700139 | 19:02 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.policy master: tox: Trivial cleanup https://review.opendev.org/700140 | 19:04 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.service master: tox: Trivial cleanup https://review.opendev.org/700144 | 19:11 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.upgradecheck master: tox: Trivial cleanup https://review.opendev.org/700146 | 19:13 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.context master: tox: Trivial cleanup https://review.opendev.org/700131 | 19:14 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.concurrency master: tox: Trivial cleanup https://review.opendev.org/700133 | 19:16 |
openstackgerrit | Hervé Beraud proposed openstack/oslo-specs master: tox: Trivial cleanup https://review.opendev.org/700145 | 19:21 |
hberaud | bnemec: what's about the status of the py27 support dropping for the oslo world? (for this kind of patch => https://review.opendev.org/#/c/700689/), I think it's too early to drop support, please can you confirm? | 19:33 |
smcginnis | The community goal does say it should be OK for oslo to drop support between milestones 1 and 2. | 19:35 |
smcginnis | https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html#schedule | 19:35 |
bnemec | hberaud: We're actually into phase 2, so it's okay for Oslo libs to start dropping support. | 19:35 |
smcginnis | But that said, it's kind of going to be a big impact, so probably better to wait until close to milestone 2. | 19:35 |
smcginnis | Or at least maybe we should send out an announcement to the ML letting everyone know when oslo plans on releasing new versions that include that. | 19:35 |
bnemec | Yeah, but it's going to take us a while. I'd rather catch issues early and have plenty of time to fix them. | 19:36 |
hberaud | make sense | 19:36 |
bnemec | Maybe this should get raised in the meeting next week so at least the liaisons have some forewarning. | 19:36 |
hberaud | thanks for the heads up | 19:36 |
bnemec | And then we can send something to the list as well. | 19:36 |
hberaud | yep good idea | 19:36 |
hberaud | can be worth to discuss about | 19:37 |
smcginnis | ++ | 19:37 |
bnemec | Okay, it's on the agenda. | 19:37 |
hberaud | I need to dash for today see you tomorrow o/ | 19:38 |
bnemec | Have a good night | 19:38 |
hberaud | thx | 19:38 |
*** hberaud is now known as hberaud|gone | 19:38 | |
*** bnemec has quit IRC | 19:47 | |
*** bnemec has joined #openstack-oslo | 19:52 | |
openstackgerrit | Merged openstack/oslo.vmware master: tox: Trivial cleanup https://review.opendev.org/700346 | 20:20 |
openstackgerrit | Merged openstack/oslo.db master: tox: Trivial cleanup https://review.opendev.org/700337 | 20:23 |
*** openstackgerrit has quit IRC | 20:31 | |
*** ralonsoh has quit IRC | 21:30 | |
*** ansmith has quit IRC | 21:42 | |
*** kgiusti has left #openstack-oslo | 21:54 | |
*** ansmith has joined #openstack-oslo | 22:23 | |
*** tkajinam has joined #openstack-oslo | 22:56 | |
*** tkajinam has quit IRC | 22:58 | |
*** tkajinam has joined #openstack-oslo | 23:00 | |
*** rcernin has joined #openstack-oslo | 23:13 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!